Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2194229/?format=api
{ "id": 2194229, "url": "http://patchwork.ozlabs.org/api/patches/2194229/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260207134728.1495932-9-lulu@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260207134728.1495932-9-lulu@redhat.com>", "list_archive_url": null, "date": "2026-02-07T13:47:25", "name": "[09/12] net/filter-mirror: treat redirector injections as raw frames", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "bb20cd9a027c3573dcdfebb38fc6f4f61fe6252a", "submitter": { "id": 78960, "url": "http://patchwork.ozlabs.org/api/people/78960/?format=api", "name": "Cindy Lu", "email": "lulu@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260207134728.1495932-9-lulu@redhat.com/mbox/", "series": [ { "id": 491379, "url": "http://patchwork.ozlabs.org/api/series/491379/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=491379", "date": "2026-02-07T13:47:17", "name": "[01/12] net: introduce read_poll/write_poll", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/491379/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2194229/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2194229/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=Kb+YoDnv;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4f7XPr3Mgjz1yB8\n\tfor <incoming@patchwork.ozlabs.org>; Sun, 08 Feb 2026 00:49:36 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1voigi-00042s-Ns; Sat, 07 Feb 2026 08:49:30 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <lulu@redhat.com>) id 1voigT-0003mK-63\n for qemu-devel@nongnu.org; Sat, 07 Feb 2026 08:49:17 -0500", "from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <lulu@redhat.com>) id 1voigP-0003Hv-7K\n for qemu-devel@nongnu.org; Sat, 07 Feb 2026 08:49:12 -0500", "from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-299-oTZFbYC7Pn2iSCEScRZhbA-1; Sat,\n 07 Feb 2026 08:49:04 -0500", "from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 107451956088; Sat, 7 Feb 2026 13:49:03 +0000 (UTC)", "from S2.redhat.com (unknown [10.72.112.15])\n by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id B822318004AD; Sat, 7 Feb 2026 13:48:59 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1770472147;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=sp9aBnO3KajDA7xQyQybSz68hMVXM/FTvW8kMmAJ+XA=;\n b=Kb+YoDnv003Dks2jh2kuZH3GrGc7QYfX+9WNCwcMyoNozZUT0g7eoUW/4XJ1Aga2QssaX5\n x/2EAozlwXvy/REaQIlfpPqcHQqAqFHrZRbEmu1eKTC7lePQyr64WMvFTQoQ1ycGLrXduC\n Et/SbutBy9lrV8Ap6dwNKK+DiQNXafA=", "X-MC-Unique": "oTZFbYC7Pn2iSCEScRZhbA-1", "X-Mimecast-MFC-AGG-ID": "oTZFbYC7Pn2iSCEScRZhbA_1770472143", "From": "Cindy Lu <lulu@redhat.com>", "To": "lulu@redhat.com, mst@redhat.com, jasowang@redhat.com, zhangckid@gmail.com,\n lizhijian@fujitsu.com, qemu-devel@nongnu.org", "Subject": "[PATCH 09/12] net/filter-mirror: treat redirector injections as raw\n frames", "Date": "Sat, 7 Feb 2026 21:47:25 +0800", "Message-ID": "<20260207134728.1495932-9-lulu@redhat.com>", "In-Reply-To": "<20260207134728.1495932-1-lulu@redhat.com>", "References": "<20260207134728.1495932-1-lulu@redhat.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.93", "Received-SPF": "pass client-ip=170.10.129.124; envelope-from=lulu@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Packets injected from the redirector chardev are raw Ethernet frames without a\nvnet_hdr prefix. Mark them as RAW so downstream filters (e.g. dump) do not skip\nvnet_hdr_len bytes, and strip the vnet_hdr prefix only when vnet_hdr_support is\nenabled and a valid prefix is present.\n\nSigned-off-by: Cindy Lu <lulu@redhat.com>\n---\n net/filter-mirror.c | 30 +++++++++++++++++++++++++-----\n 1 file changed, 25 insertions(+), 5 deletions(-)", "diff": "diff --git a/net/filter-mirror.c b/net/filter-mirror.c\nindex c1b9dabacd..de32028246 100644\n--- a/net/filter-mirror.c\n+++ b/net/filter-mirror.c\n@@ -146,6 +146,7 @@ static int filter_send(MirrorState *s,\n }\n \n static void redirector_to_filter(NetFilterState *nf,\n+ unsigned flags,\n const uint8_t *buf,\n int len)\n {\n@@ -156,13 +157,13 @@ static void redirector_to_filter(NetFilterState *nf,\n \n if (nf->direction == NET_FILTER_DIRECTION_ALL ||\n nf->direction == NET_FILTER_DIRECTION_TX) {\n- qemu_netfilter_pass_to_next(nf->netdev, 0, &iov, 1, nf);\n+ qemu_netfilter_pass_to_next(nf->netdev, flags, &iov, 1, nf);\n }\n \n if (nf->direction == NET_FILTER_DIRECTION_ALL ||\n nf->direction == NET_FILTER_DIRECTION_RX) {\n- qemu_netfilter_pass_to_next(nf->netdev->peer, 0, &iov, 1, nf);\n- }\n+ qemu_netfilter_pass_to_next(nf->netdev->peer, flags, &iov, 1, nf);\n+ }\n }\n \n static int redirector_chr_can_read(void *opaque)\n@@ -294,12 +295,31 @@ static void redirector_rs_finalize(SocketReadState *rs)\n {\n MirrorState *s = container_of(rs, MirrorState, rs);\n NetFilterState *nf = NETFILTER(s);\n+ const uint8_t *buf = rs->buf;\n+ int len = rs->packet_len;\n \n /* Update indev statistics */\n s->indev_packets++;\n- s->indev_bytes += rs->packet_len;\n+ s->indev_bytes += len;\n+\n+ /*\n+ * If the sender enables vnet_hdr_support, received data includes a\n+ * vnet_hdr prefix. Skip vnet_hdr_len bytes and pass the Ethernet frame.\n+ */\n+ if (s->vnet_hdr) {\n+ if (rs->vnet_hdr_len <= 0 || rs->vnet_hdr_len >= len) {\n+ return;\n+ }\n+ buf += rs->vnet_hdr_len;\n+ len -= rs->vnet_hdr_len;\n+ }\n \n- redirector_to_filter(nf, rs->buf, rs->packet_len);\n+ /*\n+ * Packets injected from the chardev are raw Ethernet frames without a\n+ * vnet_hdr prefix. Mark them as RAW so downstream filters (e.g. dump)\n+ * won't try to skip a vnet_hdr_len.\n+ */\n+ redirector_to_filter(nf, QEMU_NET_PACKET_FLAG_RAW, buf, len);\n }\n \n static void filter_redirector_vm_state_change(void *opaque, bool running,\n", "prefixes": [ "09/12" ] }