Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2194224/?format=api
{ "id": 2194224, "url": "http://patchwork.ozlabs.org/api/patches/2194224/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260207134728.1495932-7-lulu@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260207134728.1495932-7-lulu@redhat.com>", "list_archive_url": null, "date": "2026-02-07T13:47:23", "name": "[07/12] netfilter: enable read_poll when redirector created while stopped", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "bd11ca4036c4edb75bdebeb8e55ee57a68c86334", "submitter": { "id": 78960, "url": "http://patchwork.ozlabs.org/api/people/78960/?format=api", "name": "Cindy Lu", "email": "lulu@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260207134728.1495932-7-lulu@redhat.com/mbox/", "series": [ { "id": 491379, "url": "http://patchwork.ozlabs.org/api/series/491379/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=491379", "date": "2026-02-07T13:47:17", "name": "[01/12] net: introduce read_poll/write_poll", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/491379/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2194224/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2194224/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=UIA8o0x/;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4f7XPf04bVz1xtV\n\tfor <incoming@patchwork.ozlabs.org>; Sun, 08 Feb 2026 00:49:25 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1voigG-0003bj-9G; Sat, 07 Feb 2026 08:49:02 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <lulu@redhat.com>) id 1voift-0003Jq-1s\n for qemu-devel@nongnu.org; Sat, 07 Feb 2026 08:48:41 -0500", "from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <lulu@redhat.com>) id 1voifr-0003FO-Dm\n for qemu-devel@nongnu.org; Sat, 07 Feb 2026 08:48:36 -0500", "from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-678-QTq1-qbPMIG37Atb1gEjiw-1; Sat,\n 07 Feb 2026 08:48:33 -0500", "from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 860F018003F6; Sat, 7 Feb 2026 13:48:32 +0000 (UTC)", "from S2.redhat.com (unknown [10.72.112.15])\n by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 61D9B30001A8; Sat, 7 Feb 2026 13:48:28 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1770472114;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=/h197Ye4vwe/RDsUiCKSabQ/LWbJNm/iv8nehvs3ca8=;\n b=UIA8o0x/ZUjt4NIiQTSV8NVQhYQR5jv17NM0zRmlCPaHBFhej5dQXyoQPOmlKhqFo1VxqR\n pfJa5HGfKfc0afy+2Twwhko5FpUvvHgdj9kCxEx2i/YAc7zFl6cDveu91POolRHshDCbZ7\n x/V/DsO1/UQjwUjN28x7J75iruNHciI=", "X-MC-Unique": "QTq1-qbPMIG37Atb1gEjiw-1", "X-Mimecast-MFC-AGG-ID": "QTq1-qbPMIG37Atb1gEjiw_1770472112", "From": "Cindy Lu <lulu@redhat.com>", "To": "lulu@redhat.com, mst@redhat.com, jasowang@redhat.com, zhangckid@gmail.com,\n lizhijian@fujitsu.com, qemu-devel@nongnu.org", "Subject": "[PATCH 07/12] netfilter: enable read_poll when redirector created\n while stopped", "Date": "Sat, 7 Feb 2026 21:47:23 +0800", "Message-ID": "<20260207134728.1495932-7-lulu@redhat.com>", "In-Reply-To": "<20260207134728.1495932-1-lulu@redhat.com>", "References": "<20260207134728.1495932-1-lulu@redhat.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.4", "Received-SPF": "pass client-ip=170.10.133.124; envelope-from=lulu@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "From: Jason Wang <jasowang@redhat.com>\n\nfilter-redirector uses a vm change state handler to enable netdev read_poll()\nwhen enable_when_stopped=true and the VM stops, so that host traffic can be\nstill drained into the netfilter chain while vCPUs are not running.\n\nHowever, qemu_add_vm_change_state_handler() does not invoke the callback for\nthe current VM state at registration time. If a redirector is created after\nthe VM is already stopped (or if enable_when_stopped is toggled on while\nstopped), read_poll() may remain disabled and packets will not be drained.\n\nAdd a helper that checks the current runstate and proactively enables\nread_poll() when enable_when_stopped is set and the VM is already stopped.\nCall it from redirector setup and from the enable_when_stopped property setter.\n\nSigned-off-by: Jason Wang <jasowang@redhat.com>\nSigned-off-by: Cindy Lu <lulu@redhat.com>\n---\n net/filter-mirror.c | 32 ++++++++++++++++++++++++++++++++\n 1 file changed, 32 insertions(+)", "diff": "diff --git a/net/filter-mirror.c b/net/filter-mirror.c\nindex eb703b7dee..c1b9dabacd 100644\n--- a/net/filter-mirror.c\n+++ b/net/filter-mirror.c\n@@ -314,6 +314,27 @@ static void filter_redirector_vm_state_change(void *opaque, bool running,\n }\n }\n \n+static void filter_redirector_maybe_enable_read_poll(NetFilterState *nf)\n+{\n+ MirrorState *s = FILTER_REDIRECTOR(nf);\n+ NetClientState *nc = nf->netdev;\n+\n+ if (!nc || !nc->info || !nc->info->read_poll) {\n+ return;\n+ }\n+\n+ /*\n+ * When a redirector is created while the VM is already stopped,\n+ * qemu_add_vm_change_state_handler() will not immediately invoke the\n+ * callback for the current state. If enable_when_stopped is set, we\n+ * must proactively enable read_poll so that tap packets can be drained\n+ * into the netfilter chain (e.g. redirector+buffer) during stop.\n+ */\n+ if (!runstate_is_running() && s->enable_when_stopped) {\n+ nc->info->read_poll(nc, true);\n+ }\n+}\n+\n static void filter_redirector_setup(NetFilterState *nf, Error **errp)\n {\n MirrorState *s = FILTER_REDIRECTOR(nf);\n@@ -366,6 +387,8 @@ static void filter_redirector_setup(NetFilterState *nf, Error **errp)\n \n s->vmsentry = qemu_add_vm_change_state_handler(\n filter_redirector_vm_state_change, nf);\n+\n+ filter_redirector_maybe_enable_read_poll(nf);\n }\n \n static void filter_redirector_status_changed(NetFilterState *nf, Error **errp)\n@@ -484,8 +507,17 @@ static void filter_redirector_set_enable_when_stopped(Object *obj,\n Error **errp)\n {\n MirrorState *s = FILTER_REDIRECTOR(obj);\n+ NetFilterState *nf = NETFILTER(obj);\n \n s->enable_when_stopped = value;\n+\n+ /*\n+ * If toggled on while the VM is already stopped, ensure we enable read_poll\n+ * immediately (vm_state_change callback only runs on transitions).\n+ */\n+ if (value) {\n+ filter_redirector_maybe_enable_read_poll(nf);\n+ }\n }\n \n static void filter_mirror_class_init(ObjectClass *oc, const void *data)\n", "prefixes": [ "07/12" ] }