Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2194222/?format=api
{ "id": 2194222, "url": "http://patchwork.ozlabs.org/api/patches/2194222/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260207134728.1495932-5-lulu@redhat.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260207134728.1495932-5-lulu@redhat.com>", "list_archive_url": null, "date": "2026-02-07T13:47:21", "name": "[05/12] tests/qtest: add tests for filter-redirector indev/outdev statistics", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "822b64258e80db92866277d595c8585b7959c35a", "submitter": { "id": 78960, "url": "http://patchwork.ozlabs.org/api/people/78960/?format=api", "name": "Cindy Lu", "email": "lulu@redhat.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260207134728.1495932-5-lulu@redhat.com/mbox/", "series": [ { "id": 491379, "url": "http://patchwork.ozlabs.org/api/series/491379/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=491379", "date": "2026-02-07T13:47:17", "name": "[01/12] net: introduce read_poll/write_poll", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/491379/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2194222/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2194222/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=gcjm/jw3;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4f7XPG1MtGz1xtV\n\tfor <incoming@patchwork.ozlabs.org>; Sun, 08 Feb 2026 00:49:06 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1voigB-0003YV-QQ; Sat, 07 Feb 2026 08:48:56 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <lulu@redhat.com>) id 1voifr-0003Je-CH\n for qemu-devel@nongnu.org; Sat, 07 Feb 2026 08:48:39 -0500", "from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <lulu@redhat.com>) id 1voifk-0003Ew-Dy\n for qemu-devel@nongnu.org; Sat, 07 Feb 2026 08:48:33 -0500", "from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-102-TIz5Xx2FOyGC-SSLUfkciw-1; Sat,\n 07 Feb 2026 08:48:25 -0500", "from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 98ED31955F12; Sat, 7 Feb 2026 13:48:24 +0000 (UTC)", "from S2.redhat.com (unknown [10.72.112.15])\n by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id AD08D3000218; Sat, 7 Feb 2026 13:48:20 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1770472106;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=V4ehdhIooVsJXMe4M0Z1v1Zz4s/zK/9guJ7vD04/nOg=;\n b=gcjm/jw3yK8Vu0jOBqUl3XSUGF2j24/wPaX/LBjCpjvVbNsD9fyqbJRUaFb3vViWovfGSj\n 1PKt1Jcc10dJw0Tj8vWrfvDux9rgvzAIp2VhIhWLS9D5M+0tHag744Af2YFgxAuHVk6xRY\n oT33SZ+sUmBPOayMAYm5/Ho6aOkQIUc=", "X-MC-Unique": "TIz5Xx2FOyGC-SSLUfkciw-1", "X-Mimecast-MFC-AGG-ID": "TIz5Xx2FOyGC-SSLUfkciw_1770472104", "From": "Cindy Lu <lulu@redhat.com>", "To": "lulu@redhat.com, mst@redhat.com, jasowang@redhat.com, zhangckid@gmail.com,\n lizhijian@fujitsu.com, qemu-devel@nongnu.org", "Subject": "[PATCH 05/12] tests/qtest: add tests for filter-redirector\n indev/outdev statistics", "Date": "Sat, 7 Feb 2026 21:47:21 +0800", "Message-ID": "<20260207134728.1495932-5-lulu@redhat.com>", "In-Reply-To": "<20260207134728.1495932-1-lulu@redhat.com>", "References": "<20260207134728.1495932-1-lulu@redhat.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.4", "Received-SPF": "pass client-ip=170.10.133.124; envelope-from=lulu@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "From: Jason Wang <jasowang@redhat.com>\n\nAdd test cases to verify the indev/outdev counters for filter-redirector:\n\ntest_query_netfilter_stats_rx():\n- Extended to verify indev counter in the counters array\n- Uses filter-redirector with indev to inject packets\n- Verifies indev packets/bytes are updated\n\ntest_query_netfilter_stats_redirector_outdev():\n- New test for outdev statistics\n- Uses filter-redirector with outdev configured\n- Verifies initial outdev counters are zero\n- Sends packet and verifies outdev packets/bytes are updated\n\nThese tests verify the new flexible counters array design where\nfilter-specific statistics are returned via the get_stats callback.\n\nSigned-off-by: Jason Wang <jasowang@redhat.com>\nSigned-off-by: Cindy Lu <lulu@redhat.com>\n---\n tests/qtest/test-netfilter.c | 371 +++++++++++++++++++++++++++++++++++\n 1 file changed, 371 insertions(+)", "diff": "diff --git a/tests/qtest/test-netfilter.c b/tests/qtest/test-netfilter.c\nindex 326d4bd85f..20b0373cf7 100644\n--- a/tests/qtest/test-netfilter.c\n+++ b/tests/qtest/test-netfilter.c\n@@ -9,6 +9,7 @@\n */\n \n #include \"qemu/osdep.h\"\n+#include \"qemu/iov.h\"\n #include \"libqtest-single.h\"\n #include \"qobject/qdict.h\"\n \n@@ -124,6 +125,371 @@ static void add_multi_netfilter(void)\n qobject_unref(response);\n }\n \n+/*\n+ * Test query-netfilter-stats for TX direction using filter-mirror.\n+ *\n+ * Traffic flow:\n+ * test_sock -> socket backend (bn0) -> filter-mirror (TX stats++) -> chardev\n+ */\n+static void test_query_netfilter_stats_tx(void)\n+{\n+ QTestState *qts;\n+ QDict *response;\n+ QList *stats_list;\n+ const QListEntry *entry;\n+ int send_sock[2], recv_sock[2];\n+ int ret;\n+ char send_buf[] = \"Hello TX stats!\";\n+ uint32_t size = sizeof(send_buf);\n+ uint32_t net_size;\n+ bool found_filter = false;\n+\n+ net_size = htonl(size);\n+\n+ ret = socketpair(PF_UNIX, SOCK_STREAM, 0, send_sock);\n+ g_assert_cmpint(ret, !=, -1);\n+\n+ ret = socketpair(PF_UNIX, SOCK_STREAM, 0, recv_sock);\n+ g_assert_cmpint(ret, !=, -1);\n+\n+ qts = qtest_initf(\n+ \"-nic socket,id=bn0,fd=%d \"\n+ \"-chardev socket,id=mirror0,fd=%d \"\n+ \"-object filter-mirror,id=f0,netdev=bn0,queue=tx,outdev=mirror0\",\n+ send_sock[1], recv_sock[1]);\n+\n+ qtest_qmp_assert_success(qts, \"{ 'execute' : 'query-status'}\");\n+\n+ /* Query initial stats */\n+ response = qtest_qmp(qts, \"{'execute': 'query-netfilter-stats'}\");\n+ g_assert(response);\n+ g_assert(!qdict_haskey(response, \"error\"));\n+ stats_list = qdict_get_qlist(response, \"return\");\n+ g_assert(stats_list);\n+\n+ for (entry = qlist_first(stats_list); entry; entry = qlist_next(entry)) {\n+ QDict *stats = qobject_to(QDict, qlist_entry_obj(entry));\n+ const char *name = qdict_get_str(stats, \"name\");\n+ if (g_strcmp0(name, \"f0\") == 0) {\n+ found_filter = true;\n+ g_assert_cmpint(qdict_get_int(stats, \"packets-tx\"), ==, 0);\n+ g_assert_cmpint(qdict_get_int(stats, \"bytes-tx\"), ==, 0);\n+ g_assert_cmpstr(qdict_get_str(stats, \"type\"), ==, \"filter-mirror\");\n+ }\n+ }\n+ g_assert(found_filter);\n+ qobject_unref(response);\n+\n+ /* Send packet - triggers TX direction */\n+ struct iovec iov[] = {\n+ { .iov_base = &net_size, .iov_len = sizeof(net_size) },\n+ { .iov_base = send_buf, .iov_len = sizeof(send_buf) },\n+ };\n+ ret = iov_send(send_sock[0], iov, 2, 0,\n+ sizeof(net_size) + sizeof(send_buf));\n+ g_assert_cmpint(ret, ==, sizeof(send_buf) + sizeof(net_size));\n+\n+ g_usleep(100000);\n+\n+ /* Verify TX stats updated */\n+ response = qtest_qmp(qts, \"{'execute': 'query-netfilter-stats'}\");\n+ g_assert(response);\n+ stats_list = qdict_get_qlist(response, \"return\");\n+\n+ found_filter = false;\n+ for (entry = qlist_first(stats_list); entry; entry = qlist_next(entry)) {\n+ QDict *stats = qobject_to(QDict, qlist_entry_obj(entry));\n+ const char *name = qdict_get_str(stats, \"name\");\n+ if (g_strcmp0(name, \"f0\") == 0) {\n+ found_filter = true;\n+ g_assert_cmpint(qdict_get_int(stats, \"packets-tx\"), >=, 1);\n+ g_assert_cmpint(qdict_get_int(stats, \"bytes-tx\"), >=,\n+ sizeof(send_buf));\n+ }\n+ }\n+ g_assert(found_filter);\n+ qobject_unref(response);\n+\n+ close(send_sock[0]);\n+ close(send_sock[1]);\n+ close(recv_sock[0]);\n+ close(recv_sock[1]);\n+ qtest_quit(qts);\n+}\n+\n+/*\n+ * Test query-netfilter-stats for RX direction using filter-redirector.\n+ *\n+ * Traffic flow:\n+ * indev_sock -> chardev (indev) -> filter-redirector -> netdev (RX path)\n+ *\n+ * When filter-redirector reads from indev and calls redirector_to_filter(),\n+ * it passes the packet to the next filter in the chain via\n+ * qemu_netfilter_pass_to_next(). We add a second filter (filter-buffer)\n+ * that will receive the packet and update its RX stats.\n+ */\n+static void test_query_netfilter_stats_rx(void)\n+{\n+ QTestState *qts;\n+ QDict *response;\n+ QList *stats_list;\n+ const QListEntry *entry;\n+ int backend_sock[2], indev_sock[2];\n+ int ret;\n+ char send_buf[] = \"Hello RX stats!\";\n+ uint32_t size = sizeof(send_buf);\n+ uint32_t net_size;\n+ bool found_buffer = false;\n+\n+ net_size = htonl(size);\n+\n+ ret = socketpair(PF_UNIX, SOCK_STREAM, 0, backend_sock);\n+ g_assert_cmpint(ret, !=, -1);\n+\n+ ret = socketpair(PF_UNIX, SOCK_STREAM, 0, indev_sock);\n+ g_assert_cmpint(ret, !=, -1);\n+\n+ /*\n+ * Setup:\n+ * - filter-redirector (rd0, queue=rx, indev) at tail - injects data\n+ * - filter-buffer (fb0, queue=rx) at head - receives and counts\n+ *\n+ * RX direction traverses from tail to head, so:\n+ * indev -> rd0 (reads, calls pass_to_next) -> fb0 (receive_iov, RX stats++)\n+ */\n+ qts = qtest_initf(\n+ \"-nic socket,id=bn0,fd=%d \"\n+ \"-chardev socket,id=indev0,fd=%d \"\n+ \"-object filter-buffer,id=fb0,netdev=bn0,queue=rx,interval=1000000,position=head \"\n+ \"-object filter-redirector,id=rd0,netdev=bn0,queue=rx,indev=indev0,position=tail\",\n+ backend_sock[1], indev_sock[1]);\n+\n+ qtest_qmp_assert_success(qts, \"{ 'execute' : 'query-status'}\");\n+\n+ /* Query initial stats - fb0 should have zero RX */\n+ response = qtest_qmp(qts, \"{'execute': 'query-netfilter-stats'}\");\n+ g_assert(response);\n+ g_assert(!qdict_haskey(response, \"error\"));\n+ stats_list = qdict_get_qlist(response, \"return\");\n+ g_assert(stats_list);\n+\n+ for (entry = qlist_first(stats_list); entry; entry = qlist_next(entry)) {\n+ QDict *stats = qobject_to(QDict, qlist_entry_obj(entry));\n+ const char *name = qdict_get_str(stats, \"name\");\n+ if (g_strcmp0(name, \"fb0\") == 0) {\n+ found_buffer = true;\n+ g_assert_cmpint(qdict_get_int(stats, \"packets-rx\"), ==, 0);\n+ g_assert_cmpint(qdict_get_int(stats, \"bytes-rx\"), ==, 0);\n+ g_assert_cmpstr(qdict_get_str(stats, \"type\"), ==, \"filter-buffer\");\n+ }\n+ }\n+ g_assert(found_buffer);\n+ qobject_unref(response);\n+\n+ /* Inject packet via indev - triggers RX direction */\n+ struct iovec iov[] = {\n+ { .iov_base = &net_size, .iov_len = sizeof(net_size) },\n+ { .iov_base = send_buf, .iov_len = sizeof(send_buf) },\n+ };\n+ ret = iov_send(indev_sock[0], iov, 2, 0,\n+ sizeof(net_size) + sizeof(send_buf));\n+ g_assert_cmpint(ret, ==, sizeof(send_buf) + sizeof(net_size));\n+\n+ g_usleep(100000);\n+\n+ /* Verify fb0's RX stats and rd0's indev stats updated */\n+ response = qtest_qmp(qts, \"{'execute': 'query-netfilter-stats'}\");\n+ g_assert(response);\n+ stats_list = qdict_get_qlist(response, \"return\");\n+\n+ found_buffer = false;\n+ bool found_redirector = false;\n+ for (entry = qlist_first(stats_list); entry; entry = qlist_next(entry)) {\n+ QDict *stats = qobject_to(QDict, qlist_entry_obj(entry));\n+ const char *name = qdict_get_str(stats, \"name\");\n+ if (g_strcmp0(name, \"fb0\") == 0) {\n+ found_buffer = true;\n+ g_assert_cmpint(qdict_get_int(stats, \"packets-rx\"), >=, 1);\n+ g_assert_cmpint(qdict_get_int(stats, \"bytes-rx\"), >=,\n+ sizeof(send_buf));\n+ }\n+ if (g_strcmp0(name, \"rd0\") == 0) {\n+ QList *counters;\n+ const QListEntry *centry;\n+ bool found_indev = false;\n+\n+ found_redirector = true;\n+ /* Verify indev counter in counters array */\n+ g_assert(qdict_haskey(stats, \"counters\"));\n+ counters = qdict_get_qlist(stats, \"counters\");\n+ for (centry = qlist_first(counters); centry;\n+ centry = qlist_next(centry)) {\n+ QDict *counter = qobject_to(QDict, qlist_entry_obj(centry));\n+ const char *cname = qdict_get_str(counter, \"name\");\n+ if (g_strcmp0(cname, \"indev\") == 0) {\n+ found_indev = true;\n+ g_assert_cmpint(qdict_get_int(counter, \"packets\"), >=, 1);\n+ g_assert_cmpint(qdict_get_int(counter, \"bytes\"),\n+ >=, sizeof(send_buf));\n+ }\n+ }\n+ g_assert(found_indev);\n+ }\n+ }\n+ g_assert(found_buffer);\n+ g_assert(found_redirector);\n+ qobject_unref(response);\n+\n+ /* Test query by name */\n+ response = qtest_qmp(qts,\n+ \"{'execute': 'query-netfilter-stats',\"\n+ \" 'arguments': { 'name': 'fb0' }}\");\n+ g_assert(response);\n+ g_assert(!qdict_haskey(response, \"error\"));\n+ stats_list = qdict_get_qlist(response, \"return\");\n+ g_assert_cmpint(qlist_size(stats_list), ==, 1);\n+ qobject_unref(response);\n+\n+ /* Test error for non-existent filter */\n+ response = qtest_qmp(qts,\n+ \"{'execute': 'query-netfilter-stats',\"\n+ \" 'arguments': { 'name': 'nonexistent' }}\");\n+ g_assert(response);\n+ g_assert(qdict_haskey(response, \"error\"));\n+ qobject_unref(response);\n+\n+ close(backend_sock[0]);\n+ close(backend_sock[1]);\n+ close(indev_sock[0]);\n+ close(indev_sock[1]);\n+ qtest_quit(qts);\n+}\n+\n+/*\n+ * Test filter-redirector outdev statistics.\n+ *\n+ * Traffic flow:\n+ * test_sock -> socket backend -> filter-redirector (outdev) -> chardev\n+ *\n+ * When data passes through filter-redirector with outdev configured,\n+ * it sends the data to outdev and updates outdev statistics.\n+ */\n+static void test_query_netfilter_stats_redirector_outdev(void)\n+{\n+ QTestState *qts;\n+ QDict *response;\n+ QList *stats_list;\n+ const QListEntry *entry;\n+ int send_sock[2], recv_sock[2];\n+ int ret;\n+ char send_buf[] = \"Hello outdev stats!\";\n+ uint32_t size = sizeof(send_buf);\n+ uint32_t net_size;\n+ bool found_redirector = false;\n+\n+ net_size = htonl(size);\n+\n+ ret = socketpair(PF_UNIX, SOCK_STREAM, 0, send_sock);\n+ g_assert_cmpint(ret, !=, -1);\n+\n+ ret = socketpair(PF_UNIX, SOCK_STREAM, 0, recv_sock);\n+ g_assert_cmpint(ret, !=, -1);\n+\n+ qts = qtest_initf(\n+ \"-nic socket,id=bn0,fd=%d \"\n+ \"-chardev socket,id=outdev0,fd=%d \"\n+ \"-object filter-redirector,id=rd0,netdev=bn0,queue=tx,outdev=outdev0\",\n+ send_sock[1], recv_sock[1]);\n+\n+ qtest_qmp_assert_success(qts, \"{ 'execute' : 'query-status'}\");\n+\n+ /* Query initial stats */\n+ response = qtest_qmp(qts, \"{'execute': 'query-netfilter-stats'}\");\n+ g_assert(response);\n+ stats_list = qdict_get_qlist(response, \"return\");\n+\n+ for (entry = qlist_first(stats_list); entry; entry = qlist_next(entry)) {\n+ QDict *stats = qobject_to(QDict, qlist_entry_obj(entry));\n+ const char *name = qdict_get_str(stats, \"name\");\n+ if (g_strcmp0(name, \"rd0\") == 0) {\n+ QList *counters;\n+ const QListEntry *centry;\n+ bool found_outdev = false;\n+\n+ found_redirector = true;\n+ g_assert(qdict_haskey(stats, \"counters\"));\n+ counters = qdict_get_qlist(stats, \"counters\");\n+ for (centry = qlist_first(counters); centry;\n+ centry = qlist_next(centry)) {\n+ QDict *counter = qobject_to(QDict, qlist_entry_obj(centry));\n+ const char *cname = qdict_get_str(counter, \"name\");\n+ if (g_strcmp0(cname, \"outdev\") == 0) {\n+ found_outdev = true;\n+ g_assert_cmpint(qdict_get_int(counter, \"packets\"), ==, 0);\n+ g_assert_cmpint(qdict_get_int(counter, \"bytes\"), ==, 0);\n+ }\n+ }\n+ g_assert(found_outdev);\n+ }\n+ }\n+ g_assert(found_redirector);\n+ qobject_unref(response);\n+\n+ /* Send packet - triggers TX direction and outdev */\n+ struct iovec iov[] = {\n+ { .iov_base = &net_size, .iov_len = sizeof(net_size) },\n+ { .iov_base = send_buf, .iov_len = sizeof(send_buf) },\n+ };\n+ ret = iov_send(send_sock[0], iov, 2, 0,\n+ sizeof(net_size) + sizeof(send_buf));\n+ g_assert_cmpint(ret, ==, sizeof(send_buf) + sizeof(net_size));\n+\n+ g_usleep(100000);\n+\n+ /* Verify outdev stats updated */\n+ response = qtest_qmp(qts, \"{'execute': 'query-netfilter-stats'}\");\n+ g_assert(response);\n+ stats_list = qdict_get_qlist(response, \"return\");\n+\n+ found_redirector = false;\n+ for (entry = qlist_first(stats_list); entry; entry = qlist_next(entry)) {\n+ QDict *stats = qobject_to(QDict, qlist_entry_obj(entry));\n+ const char *name = qdict_get_str(stats, \"name\");\n+ if (g_strcmp0(name, \"rd0\") == 0) {\n+ QList *counters;\n+ const QListEntry *centry;\n+ bool found_outdev = false;\n+\n+ found_redirector = true;\n+ /* TX stats should also be updated */\n+ g_assert_cmpint(qdict_get_int(stats, \"packets-tx\"), >=, 1);\n+\n+ /* Verify outdev counter */\n+ counters = qdict_get_qlist(stats, \"counters\");\n+ for (centry = qlist_first(counters); centry;\n+ centry = qlist_next(centry)) {\n+ QDict *counter = qobject_to(QDict, qlist_entry_obj(centry));\n+ const char *cname = qdict_get_str(counter, \"name\");\n+ if (g_strcmp0(cname, \"outdev\") == 0) {\n+ found_outdev = true;\n+ g_assert_cmpint(qdict_get_int(counter, \"packets\"), >=, 1);\n+ g_assert_cmpint(qdict_get_int(counter, \"bytes\"),\n+ >=, sizeof(send_buf));\n+ }\n+ }\n+ g_assert(found_outdev);\n+ }\n+ }\n+ g_assert(found_redirector);\n+ qobject_unref(response);\n+\n+ close(send_sock[0]);\n+ close(send_sock[1]);\n+ close(recv_sock[0]);\n+ close(recv_sock[1]);\n+ qtest_quit(qts);\n+}\n+\n /* add multi(2) netfilters to a netdev and then remove the netdev */\n static void remove_netdev_with_multi_netfilter(void)\n {\n@@ -187,6 +553,11 @@ int main(int argc, char **argv)\n qtest_add_func(\"/netfilter/remove_netdev_multi\",\n remove_netdev_with_multi_netfilter);\n \n+ qtest_add_func(\"/netfilter/query_stats_tx\", test_query_netfilter_stats_tx);\n+ qtest_add_func(\"/netfilter/query_stats_rx\", test_query_netfilter_stats_rx);\n+ qtest_add_func(\"/netfilter/query_stats_redirector_outdev\",\n+ test_query_netfilter_stats_redirector_outdev);\n+\n args = g_strdup_printf(\"-nic user,id=qtest-bn0\");\n qtest_start(args);\n ret = g_test_run();\n", "prefixes": [ "05/12" ] }