Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2194181/?format=api
{ "id": 2194181, "url": "http://patchwork.ozlabs.org/api/patches/2194181/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-ext4/patch/20260207010617.216675-1-nikic.milos@gmail.com/", "project": { "id": 8, "url": "http://patchwork.ozlabs.org/api/projects/8/?format=api", "name": "Linux ext4 filesystem development", "link_name": "linux-ext4", "list_id": "linux-ext4.vger.kernel.org", "list_email": "linux-ext4@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260207010617.216675-1-nikic.milos@gmail.com>", "list_archive_url": null, "date": "2026-02-07T01:06:17", "name": "ext2: replace BUG_ON with WARN_ON_ONCE in ext2_get_blocks", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "f3d1b39ae993a6d81cfdbf157494f0c65e38b217", "submitter": { "id": 92599, "url": "http://patchwork.ozlabs.org/api/people/92599/?format=api", "name": "Milos Nikic", "email": "nikic.milos@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-ext4/patch/20260207010617.216675-1-nikic.milos@gmail.com/mbox/", "series": [ { "id": 491356, "url": "http://patchwork.ozlabs.org/api/series/491356/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-ext4/list/?series=491356", "date": "2026-02-07T01:06:17", "name": "ext2: replace BUG_ON with WARN_ON_ONCE in ext2_get_blocks", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/491356/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2194181/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2194181/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <SRS0=NFMo=AL=vger.kernel.org=linux-ext4+bounces-13612-patchwork-incoming=ozlabs.org@ozlabs.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linux-ext4@vger.kernel.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "patchwork-incoming@ozlabs.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20230601 header.b=ddc4Isqa;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=ozlabs.org\n (client-ip=150.107.74.76; helo=mail.ozlabs.org;\n envelope-from=srs0=nfmo=al=vger.kernel.org=linux-ext4+bounces-13612-patchwork-incoming=ozlabs.org@ozlabs.org;\n receiver=patchwork.ozlabs.org)", "gandalf.ozlabs.org;\n arc=pass smtp.remote-ip=\"2600:3c0a:e001:db::12fc:5321\"\n arc.chain=subspace.kernel.org", "gandalf.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com", "gandalf.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20230601 header.b=ddc4Isqa;\n\tdkim-atps=neutral", "gandalf.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-ext4+bounces-13612-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"ddc4Isqa\"", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=74.125.82.45", "smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com", "smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com" ], "Received": [ "from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1 raw public key)\n server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4f7CVV4cbVz1xvD\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 07 Feb 2026 12:07:29 +1100 (AEDT)", "from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3])\n\tby gandalf.ozlabs.org (Postfix) with ESMTP id 4f7CVS6vlWz4w1g\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 07 Feb 2026 12:07:28 +1100 (AEDT)", "by gandalf.ozlabs.org (Postfix)\n\tid 4f7CVS6r73z4wBJ; Sat, 07 Feb 2026 12:07:28 +1100 (AEDT)", "from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby gandalf.ozlabs.org (Postfix) with ESMTPS id 4f7CVP41Yqz4w1g\n\tfor <patchwork-incoming@ozlabs.org>; Sat, 07 Feb 2026 12:07:25 +1100 (AEDT)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 70FFA3014C25\n\tfor <patchwork-incoming@ozlabs.org>; Sat, 7 Feb 2026 01:06:23 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id D9CB223EAB3;\n\tSat, 7 Feb 2026 01:06:21 +0000 (UTC)", "from mail-dl1-f45.google.com (mail-dl1-f45.google.com\n [74.125.82.45])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C45522B8C5\n\tfor <linux-ext4@vger.kernel.org>; Sat, 7 Feb 2026 01:06:21 +0000 (UTC)", "by mail-dl1-f45.google.com with SMTP id\n a92af1059eb24-1249b9f5703so1761097c88.0\n for <linux-ext4@vger.kernel.org>;\n Fri, 06 Feb 2026 17:06:21 -0800 (PST)", "from arch.lan (c-98-51-119-100.hsd1.ca.comcast.net. [98.51.119.100])\n by smtp.gmail.com with ESMTPSA id\n a92af1059eb24-127041d9c91sm3690236c88.2.2026.02.06.17.06.19\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 06 Feb 2026 17:06:20 -0800 (PST)" ], "ARC-Seal": [ "i=2; a=rsa-sha256; d=ozlabs.org; s=201707; t=1770426448; cv=pass;\n\tb=TIQ0Ku2WV6ZPHtJ9QjsvJ7MXh8H08ElL9qNW5NTVV3l50DNcj/XOpncH6gGDj//DaCWF+Vb2t3PhwQCl3hcYPjWaYvDZ3dzDjXF/G3q/zrxPN7IW9O96EHEPA50D2O7WGBIjaMZ3yjprDgE0ozCzRIPOZ1kJ1tRVGICgQuCzzMkcKJoXMrSaDYpLKTXiRHE79a+ZHYoFSXQRQOhAnH5kPfiBbh6JSOJv0P1FrgzjFbD6Hw6Srew7U7k+UjgmCsY51wkVC1Q4UP/NZHnuTdIQMDOA49yWPtJ3mO1gwDqGohOChlp4PVEqkkM69aqw7kZ6v749iyGJAIcrn4/LKA7rvA==", "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1770426381; cv=none;\n b=VsU7PF2XlCbOCfEIZy+jcHKtj1GYhWaLPWyACM5fViMvWNWFhX9c2xQZOEEcQv5KEZezACSI37ySqFiqDE6JTEdshg9nCIx0dl4LytDaVdm4dny8XkDjqMgw91z5qks5q6B1woMMFbCJe6zAHMyUkcnj0JCoRq66bDXNsj41oVg=" ], "ARC-Message-Signature": [ "i=2; a=rsa-sha256; d=ozlabs.org; s=201707;\n\tt=1770426448; c=relaxed/relaxed;\n\tbh=dawYaSkjSeeyfXPo6xA5YUh2ssPoeMLLOdZBaaBhvAU=;\n\th=From:To:Cc:Subject:Date:Message-ID:MIME-Version;\n b=WaxxYHr+nZjv4PH8uWZNmhAQ1X4lZ8oYJmopz+9FTtojgv6Q+6xxWgdcB3dPpbeHxBYXRpGtYFEgr/06ccfMMjaCO6MAVdZvoj6k1nVyELpwfVmP5Lhb8COHP3vB1Ygq2DkX1urWF4RiY1o6+wC0Dwo8rdS4Ns2yll1mfqAOJefBErX59U6oKVcq19d9+B9kjXdbjCYpqJ16NrG9hYYfuUa4pvmWV638C1K5hYEVThJZXMjJi/WoQb44O0fsbqYN+0PQmWRnS36eTI3ehllsKcM/jKP3N+KURWFOYQRe8dPjB9RPkTpWiV+jXFzsumMI0pN+DZPfU8u8ftBKzeb4Aw==", "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1770426381; c=relaxed/simple;\n\tbh=CjoRwzUH4R8x/n/7y1CkznKIRCyKpv3yTyXgli5U4wM=;\n\th=From:To:Cc:Subject:Date:Message-ID:MIME-Version;\n b=NiOws1Fws+yWwayDbW3z4Y1vdASUs216ytKsI0Bpn4bls5WTSrGaCl0IciM5QU2snFpmMFYz6jZCJ9bvII7+gYqtlH8jrI2SkzMJM4LZNjDY5J9pS5b/FRn1W/TzoFb8jgBzA7RMgDzS2Q4UKctqqRYXZImAxK+h3lCr/GRI9hk=" ], "ARC-Authentication-Results": [ "i=2; gandalf.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com; dkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20230601 header.b=ddc4Isqa; dkim-atps=neutral;\n spf=pass (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-ext4+bounces-13612-patchwork-incoming=ozlabs.org@vger.kernel.org;\n receiver=ozlabs.org) smtp.mailfrom=vger.kernel.org", "i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=ddc4Isqa; arc=none smtp.client-ip=74.125.82.45" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20230601; t=1770426381; x=1771031181;\n darn=vger.kernel.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=dawYaSkjSeeyfXPo6xA5YUh2ssPoeMLLOdZBaaBhvAU=;\n b=ddc4IsqasYXu2GabntQJdkV9EtvgP6+CXHue9xCRuYA3AsBv8qqnn2m2qxGJp/zrfU\n IkFDsHS5pkPJ3Po9het5zE2Cl7dcAwYUhJETtoo8juQuVJcUDGt0WeVaQ5y1imaaYkRp\n XUaaWDz7LY3ltDiqVyr3ZA2TM+Hz47jpoMkB1Tobij+gI7h4dETDrBTDdPtqpPO6H3/G\n LVBU5NGqUPYzuXf8HsUWl/AOlqoh719co1nTZmx210z/Lqm6oJDi5P/ynlhfYn4I4aVI\n FPOZZ4x0dzpeBldUqRGSouztRcpl9DIafxb8LR8S5yTzCjIMuCJew79iUIsDOingNA27\n BCvg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1770426381; x=1771031181;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=dawYaSkjSeeyfXPo6xA5YUh2ssPoeMLLOdZBaaBhvAU=;\n b=Vz7M78EVmjx+vkLfsr9o+V8sTf/NuUYaXh6R8ucJ8LNPIwpoXx/dmUJ8ztWlQubca9\n mkQBW9nJHu/OEpAfS03U0p3LGcO897Unzzngr7HU+XLTVa8+8hSxZBGpEU92TIjDc2mf\n +jIDvjlrzDzAFbgx3SA/3oOFkpn1A/5XkPwA5i9cYFOc14XJqUtqZjZrSMqA+0JPm6UW\n OinPT3UKRwoiujYpT/h8K/qCXkFU2uxsTbyROTuSUaKbAk0QSMfMFrhBiSxrSgFJ2UhZ\n Cm0X93I8gtAhfp+SELSMe2SJa8ggEES+kSiKXpgEwTHYCxczPvC3S8cZ0h6aop3/dZ0N\n IYww==", "X-Gm-Message-State": "AOJu0YzNgm3xdVT7GBxlJHQZFRNWA6WNxVjKlccs8OuZoydbTVNA8tkv\n\tC6/P7k9dLTF8A3XiqvliMlLlgpbGT6wcfN/dNAt9SYuWTrLaO4bVO0YZ", "X-Gm-Gg": "AZuq6aIVYMcZ4FaTHM7fhqgyv/KrxSUifb74I4HroHdAu+iA2N1wyKKy/fs1Kd5U5Kn\n\tLzFfxrg2dkI7fgSSc0W4UEomahLOwAThP3Bzk/8/tjwpTq7v93kjd7meDD1vzKPaju2HxpOpsdW\n\tXckIpFqr+mGc2WHxfh+Zi57qtBPRwrT5CCve1k5la7ctuxQhcN6oISbQnX54QM7AcQUiOKsJrCR\n\tF/1vgzVbNade23nBIiEpCk09iz/pgC8MA8jHebDP/uFVHENzP45VSvqSTZN5lb8Fs+KFsTGTbrZ\n\t9EYmh3C+rGgXVCO6eWIscNnE8V1KZY41GgflSdx5U0lpTMIFwaZ9LyPetxGttFodGKpc4H9zUvt\n\t9QCOMePXF3JdX0Xvlp+ClhEPJIncUpos1rklH5mXq5bIcrEZjIaoGw7WjrGXfeRgzNiooul75pc\n\tIw5Z13ZQnaKqYCMXMevtSh73jYAYdVeBzJKBsd2RHn0K3zMJ8SErmiMV9r1chB5q43TT5ve2jYb\n\tGomTQ+/RP22wwF6FkRTUiG1rQJbeRiBFfyF", "X-Received": "by 2002:a05:7022:250e:b0:11a:2f10:fa46 with SMTP id\n a92af1059eb24-12703e569femr2185435c88.0.1770426380622;\n Fri, 06 Feb 2026 17:06:20 -0800 (PST)", "From": "Milos Nikic <nikic.milos@gmail.com>", "To": "jack@suse.com", "Cc": "linux-ext4@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org,\n\tMilos Nikic <nikic.milos@gmail.com>", "Subject": "[PATCH] ext2: replace BUG_ON with WARN_ON_ONCE in ext2_get_blocks", "Date": "Fri, 6 Feb 2026 17:06:17 -0800", "Message-ID": "<20260207010617.216675-1-nikic.milos@gmail.com>", "X-Mailer": "git-send-email 2.52.0", "Precedence": "bulk", "X-Mailing-List": "linux-ext4@vger.kernel.org", "List-Id": "<linux-ext4.vger.kernel.org>", "List-Subscribe": "<mailto:linux-ext4+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:linux-ext4+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Spam-Status": "No, score=-1.2 required=5.0 tests=ARC_SIGNED,ARC_VALID,\n\tDKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DMARC_PASS,\n\tFREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,\n\tMAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=disabled\n\tversion=4.0.1", "X-Spam-Checker-Version": "SpamAssassin 4.0.1 (2024-03-25) on gandalf.ozlabs.org" }, "content": "If ext2_get_blocks() is called with maxblocks == 0, it currently triggers\na BUG_ON(), causing a kernel panic.\n\nWhile this condition implies a logic error in the caller, a filesystem\nshould not crash the system due to invalid arguments.\n\nReplace the BUG_ON() with a WARN_ON_ONCE() to provide a stack trace for\ndebugging, and return -EINVAL to handle the error gracefully.\n\nSigned-off-by: Milos Nikic <nikic.milos@gmail.com>\n---\n fs/ext2/inode.c | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/fs/ext2/inode.c b/fs/ext2/inode.c\nindex dbfe9098a124..18bf1a91dbc2 100644\n--- a/fs/ext2/inode.c\n+++ b/fs/ext2/inode.c\n@@ -638,7 +638,8 @@ static int ext2_get_blocks(struct inode *inode,\n \tint count = 0;\n \text2_fsblk_t first_block = 0;\n \n-\tBUG_ON(maxblocks == 0);\n+\tif (WARN_ON_ONCE(maxblocks == 0))\n+\t\treturn -EINVAL;\n \n \tdepth = ext2_block_to_path(inode,iblock,offsets,&blocks_to_boundary);\n \n", "prefixes": [] }