Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2194176/?format=api
{ "id": 2194176, "url": "http://patchwork.ozlabs.org/api/patches/2194176/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-pci/patch/20260207-rust_leds-v12-1-fdb518417b75@posteo.de/", "project": { "id": 28, "url": "http://patchwork.ozlabs.org/api/projects/28/?format=api", "name": "Linux PCI development", "link_name": "linux-pci", "list_id": "linux-pci.vger.kernel.org", "list_email": "linux-pci@vger.kernel.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260207-rust_leds-v12-1-fdb518417b75@posteo.de>", "list_archive_url": null, "date": "2026-02-07T00:12:42", "name": "[v12,1/3] rust: leds: add basic led classdev abstractions", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "338daafedcc767c516722f89f5ac84fca1174f64", "submitter": { "id": 91819, "url": "http://patchwork.ozlabs.org/api/people/91819/?format=api", "name": "Markus Probst", "email": "markus.probst@posteo.de" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linux-pci/patch/20260207-rust_leds-v12-1-fdb518417b75@posteo.de/mbox/", "series": [ { "id": 491353, "url": "http://patchwork.ozlabs.org/api/series/491353/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linux-pci/list/?series=491353", "date": "2026-02-07T00:12:41", "name": "rust: leds: add led classdev abstractions", "version": 12, "mbox": "http://patchwork.ozlabs.org/series/491353/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2194176/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2194176/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linux-pci+bounces-46920-incoming=patchwork.ozlabs.org@vger.kernel.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linux-pci@vger.kernel.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=posteo.de header.i=@posteo.de header.a=rsa-sha256\n header.s=2017 header.b=pwgCkyAk;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c15:e001:75::12fc:5321; helo=sin.lore.kernel.org;\n envelope-from=linux-pci+bounces-46920-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)", "smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=posteo.de header.i=@posteo.de\n header.b=\"pwgCkyAk\"", "smtp.subspace.kernel.org;\n arc=none smtp.client-ip=185.67.36.65", "smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=posteo.de", "smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=posteo.de" ], "Received": [ "from sin.lore.kernel.org (sin.lore.kernel.org\n [IPv6:2600:3c15:e001:75::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4f7BHb03m8z1xvh\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 07 Feb 2026 11:12:59 +1100 (AEDT)", "from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sin.lore.kernel.org (Postfix) with ESMTP id 666CE301406E\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 7 Feb 2026 00:12:51 +0000 (UTC)", "from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 853B615746E;\n\tSat, 7 Feb 2026 00:12:45 +0000 (UTC)", "from mout01.posteo.de (mout01.posteo.de [185.67.36.65])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 1023A139579\n\tfor <linux-pci@vger.kernel.org>; Sat, 7 Feb 2026 00:12:44 +0000 (UTC)", "from submission (posteo.de [185.67.36.169])\n\tby mout01.posteo.de (Postfix) with ESMTPS id 91E7124002B\n\tfor <linux-pci@vger.kernel.org>; Sat, 7 Feb 2026 01:12:43 +0100 (CET)", "from customer (localhost [127.0.0.1])\n\tby submission (posteo.de) with ESMTPSA id 4f7BHF0dC5z6tsf;\n\tSat, 7 Feb 2026 01:12:41 +0100 (CET)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1770423165; cv=none;\n b=W0LK/BTl7vO0BoJHg4LYxQcZ6l/A/NXNfr2gs5mS8saM333g/8KNGimJbr7npRcnIPJnnQ25nIzVJQV3fsCQAHuSpZcYL+wpMpkDP88wM917mr0lAQOsgmGcmvM8hyUJNHdYZRoHzeYyOnorI9d9JXa3oFihKBa9fN7JeQ7WidI=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1770423165; c=relaxed/simple;\n\tbh=JDTZ/DKXCT5IqfBt6mf6TxRiTpdhp8kCyDCumLKo81M=;\n\th=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References:\n\t In-Reply-To:To:Cc;\n b=WHiobToOjpTsjZpRiEDvSdhM19QvADSRgbabO/abPDo36+D4g+O+ct9SCZV7duU6IEvPHf7fwB6De/wsziHFOPcSH1X3A9XIpvhpPHVR/e/r9VWi0f7/p2jz8/vijp6pLcIFAuKkR+pHXnXVIjVrtSK1lo/bOss0djR2LeXB/jc=", "ARC-Authentication-Results": "i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=posteo.de;\n spf=pass smtp.mailfrom=posteo.de;\n dkim=pass (2048-bit key) header.d=posteo.de header.i=@posteo.de\n header.b=pwgCkyAk; arc=none smtp.client-ip=185.67.36.65", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=posteo.de; s=2017;\n\tt=1770423163; bh=AkmMpmqu94Yavhw2vaIs+kHQopWIrgX+KHcocuIkxrw=;\n\th=From:Date:Subject:MIME-Version:Content-Type:\n\t Content-Transfer-Encoding:Message-Id:To:Cc:Autocrypt:OpenPGP:From;\n\tb=pwgCkyAkdJPIQn22Hrt4PZjmr8GJ3Msr3Vq1MB3WyqFZtLWk6N0mQFmrRb9eYYJIM\n\t ogevQJ6dYRXEEOih/epffOWbhcxXpmwVaIaaj1dqty7ewOrwWhiw37btFq//m+eVTg\n\t L+FN4Y4r0j3GCQ1mOePzNPjE99dBZQuI6UcDfYUOQEhbajn4q+FGjvsp8qYYBj5uVN\n\t mTKcDAwph7cUBFAJ3H/wI5g3bdEimXkLPs+8f/VBD2tybADXd6hasohmpg+K1eYysV\n\t 0VvPyoEmA7ZsDN29OWjOpYl14bq1KmxQA76VdDW0ySD09N9SMNDnBJmJBsHrbZSQ4K\n\t 7AK6Z5OSsUAhA==", "From": "Markus Probst <markus.probst@posteo.de>", "Date": "Sat, 07 Feb 2026 00:12:42 +0000", "Subject": "[PATCH v12 1/3] rust: leds: add basic led classdev abstractions", "Precedence": "bulk", "X-Mailing-List": "linux-pci@vger.kernel.org", "List-Id": "<linux-pci.vger.kernel.org>", "List-Subscribe": "<mailto:linux-pci+subscribe@vger.kernel.org>", "List-Unsubscribe": "<mailto:linux-pci+unsubscribe@vger.kernel.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "<20260207-rust_leds-v12-1-fdb518417b75@posteo.de>", "References": "<20260207-rust_leds-v12-0-fdb518417b75@posteo.de>", "In-Reply-To": "<20260207-rust_leds-v12-0-fdb518417b75@posteo.de>", "To": "Lee Jones <lee@kernel.org>, Pavel Machek <pavel@kernel.org>,\n Greg Kroah-Hartman <gregkh@linuxfoundation.org>,\n Dave Ertman <david.m.ertman@intel.com>, Ira Weiny <ira.weiny@intel.com>,\n Leon Romanovsky <leon@kernel.org>, Miguel Ojeda <ojeda@kernel.org>,\n Alex Gaynor <alex.gaynor@gmail.com>, Boqun Feng <boqun.feng@gmail.com>,\n Gary Guo <gary@garyguo.net>,\n =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= <bjorn3_gh@protonmail.com>,\n Benno Lossin <lossin@kernel.org>, Andreas Hindborg <a.hindborg@kernel.org>,\n Alice Ryhl <aliceryhl@google.com>, Trevor Gross <tmgross@umich.edu>,\n Danilo Krummrich <dakr@kernel.org>, \"Rafael J. Wysocki\" <rafael@kernel.org>,\n Bjorn Helgaas <bhelgaas@google.com>,\n =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= <kwilczynski@kernel.org>", "Cc": "rust-for-linux@vger.kernel.org, linux-leds@vger.kernel.org,\n linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,\n Markus Probst <markus.probst@posteo.de>", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=18740;\n i=markus.probst@posteo.de; h=from:subject:message-id;\n bh=JDTZ/DKXCT5IqfBt6mf6TxRiTpdhp8kCyDCumLKo81M=;\n b=owEBiQJ2/ZANAwAIATR2H/jnrUPSAcsmYgBphoNvFVmnuJNgXdN5sMFsziN8xClLaYlqMLvuk\n TujVAGtP1+JAk8EAAEIADkWIQSCdBjE9KxY53IwxHM0dh/4561D0gUCaYaDbxsUgAAAAAAEAA5t\n YW51MiwyLjUrMS4xMSwyLDIACgkQNHYf+OetQ9LYFhAAkD5k9jrl6H96/wRNQhNt68AOJ4YopSu\n 9i6dFN6s2oW8aPr8fvxzLvVKvbOXIxH57IkXr2ugrdFbz4j8dqF7q5/lAr18qPI/hphSNWEoH3p\n CWroSiEOMzGxfrleuG3cN+RLB0onwiVQ75Px0NXDv7vF/R0tpSIkRxzKlnNnjWDLV/EWJIS4P2J\n 26ZU7NwQDajoJEpXUqIHmiXqbdCizSi67Qyt9o9dFWm6NW943zmuDmT0AIQu+DmjUthPqGVQXuu\n KLPKpQG/V9k8vII/plmf3irULqRJkbSfF8NDxPo8b5ibhdh7GXr7sb7FeTOB9Zb61rK34sGYz+e\n IsiO7T1tHjrVHf9mdZIQDfKnOw72bybh8/ENLBVk3vAyccDfNn+ONm/tuuOz83SRKLfx9cTKB5U\n KERRv5lzXvvyYjLIa9fi9tjzIyUgS71xZ81ZC7BL4SY7n9PBbSjkWNV8xxOtQAFMfv4lJfDy+xH\n Zvep0bDgThSen2K+WswaQVLym3b+qfpROI1UGsE/AoKQcE7q2CpVIbU0IPGmDYU7AGm3FTyQT/a\n fmNQoZtvUuDFb4YSepN1NCUvyQDAb7UochM+MXI5d0pogeMUK6eEjils29iymlSU3W2Q+5knn9I\n ZKECVbz7bYMuucab+r9r6f4JeeBd/MGUNppIKQ7g6iyMYaT1qV00=", "X-Developer-Key": "i=markus.probst@posteo.de; a=openpgp;\n fpr=827418C4F4AC58E77230C47334761FF8E7AD43D2", "Autocrypt": "addr=markus.probst@posteo.de; prefer-encrypt=mutual;\n keydata=xsFNBGiDvXgBEADAXUceKafpl46S35UmDh2wRvvx+UfZbcTjeQOlSwKP7YVJ4JOZrVs93qReNLkO\n WguIqPBxR9blQ4nyYrqSCV+MMw/3ifyXIm6Pw2YRUDg+WTEOjTixRCoWDgUj1nOsvJ9tVAm76Ww+\n /pAnepVRafMID0rqEfD9oGv1YrfpeFJhyE2zUw3SyyNLIKWD6QeLRhKQRbSnsXhGLFBXCqt9k5JA\n RhgQof9zvztcCVlT5KVvuyfC4H+HzeGmu9201BVyihJwKdcKPq+n/aY5FUVxNTgtI9f8wIbmfAja\n oT1pjXSp+dszakA98fhONM98pOq723o/1ZGMZukyXFfsDGtA3BB79HoopHKujLGWAGskzClwTjRQ\n xBqxh/U/lL1pc+0xPWikTNCmtziCOvv0KA0arDOMQlyFvImzX6oGVgE4ksKQYbMZ3Ikw6L1Rv1J+\n FvN0aNwOKgL2ztBRYscUGcQvA0Zo1fGCAn/BLEJvQYShWKeKqjyncVGoXFsz2AcuFKe1pwETSsN6\n OZncjy32e4ktgs07cWBfx0v62b8md36jau+B6RVnnodaA8++oXl3FRwiEW8XfXWIjy4umIv93tb8\n 8ekYsfOfWkTSewZYXGoqe4RtK80ulMHb/dh2FZQIFyRdN4HOmB4FYO5sEYFr9YjHLmDkrUgNodJC\n XCeMe4BO4iaxUQARAQABzRdtYXJrdXMucHJvYnN0QHBvc3Rlby5kZcLBkQQTAQgAOxYhBIJ0GMT0\n rFjncjDEczR2H/jnrUPSBQJog714AhsDBQsJCAcCAiICBhUKCQgLAgQWAgMBAh4HAheAAAoJEDR2\n H/jnrUPSgdkQAISaTk2D345ehXEkn5z2yUEjaVjHIE7ziqRaOgn/QanCgeTUinIv6L6QXUFvvIfH\n 1OLPwQ1hfvEg9NnNLyFezWSy6jvoVBTIPqicD/r3FkithnQ1IDkdSjrarPMxJkvuh3l7XZHo49GV\n HQ8i5zh5w4YISrcEtE99lJisvni2Jqx7we5tey9voQFDyM8jxlSWv3pmoUTCtBkX/eKHJXosgsuS\n B4TGDCVPOjla/emI5c9MhMG7O4WEEmoSdPbmraPw66YZD6uLyhV4DPHbiDWRzXWnClHSyjB9rky9\n lausFxogvu4l9H+KDsXIadNDWdLdu1/enS/wDd9zh5S78rY2jeXaG4mnf4seEKamZ7KQ6FIHrcyP\n ezdDzssPQcTQcGRMQzCn6wP3tlGk7rsfmyHMlFqdRoNNv+ZER/OkmZFPW655zRfbMi0vtrqK2Awm\n 9ggobb1oktfd9PPNXMUY+DNVlgR2G7jLnenSoQausLUm0pHoNE8TWFv851Y6SOYnvn488sP1Tki5\n F3rKwclawQFHUXTCQw+QSh9ay8xgnNZfH+u9NY7w3gPoeKBOAFcBc2BtzcgekeWS8qgEmm2/oNFV\n G0ivPQbRx8FjRKbuF7g3YhgNZZ0ac8FneuUtJ2PkSIFTZhaAiC0utvxk0ndmWFiW4acEkMZGrLaM\n L2zWNjrqwsD2zsFNBGiDvXgBEADCXQy1n7wjRxG12DOVADawjghKcG+5LtEf31WftHKLFbp/HArj\n BhkT6mj+CCI1ClqY+FYU5CK/s0ScMfLxRGLZ0Ktzawb78vOgBVFT3yB1yWBTewsAXdqNqRooaUNo\n 8cG/NNJLjhccH/7PO/FWX5qftOVUJ/AIsAhKQJ18Tc8Ik73v427EDxuKb9mTAnYQFA3Ev3hAiVbO\n 6Rv39amVOfJ8sqwiSUGidj2Fctg2aB5JbeMln0KCUbTD1LhEFepeKypfofAXQbGwaCjAhmkWy/q3\n IT1mUrPxOngbxdRoOx1tGUC0HCMUW1sFaJgQPMmDcR0JGPOpgsKnitsSnN7ShcCr1buel7vLnUMD\n +TAZ5opdoF6HjAvAnBQaijtK6minkrM0seNXnCg0KkV8xhMNa6zCs1rq4GgjNLJue2EmuyHooHA4\n 7JMoLVHcxVeuNTp6K2+XRx0Pk4e2Lj8IVy9yEYyrywEOC5XRW37KJjsiOAsumi1rkvM7QREWgUDe\n Xs0+RpxI3QrrANh71fLMRo7LKRF3Gvw13NVCCC9ea20P4PwhgWKStkwO2NO+YJsAoS1QycMi/vKu\n 0EHhknYXamaSV50oZzHKmX56vEeJHTcngrM8R1SwJCYopCx9gkz90bTVYlitJa5hloWTYeMD7FNj\n Y6jfVSzgM/K4gMgUNDW/PPGeMwARAQABwsF2BBgBCAAgFiEEgnQYxPSsWOdyMMRzNHYf+OetQ9IF\n AmiDvXgCGwwACgkQNHYf+OetQ9LHDBAAhk+ab8+WrbS/b1/gYW3q1KDiXU719nCtfkUVXKidW5Ec\n Idlr5HGt8ilLoxSWT2Zi368iHCXS0WenGgPwlv8ifvB7TOZiiTDZROZkXjEBmU4nYjJ7GymawpWv\n oQwjMsPuq6ysbzWtOZ7eILx7cI0FjQeJ/Q2baRJub0uAZNwBOxCkAS6lpk5Fntd2u8CWmDQo4SYp\n xeuQ+pwkp0yEP30RhN2BO2DXiBEGSZSYh+ioGbCHQPIV3iVj0h6lcCPOqopZqyeCfigeacBI0nvN\n jHWz/spzF3+4OS+3RJvoHtAQmProxyGib8iVsTxgZO3UUi4TSODeEt0i0kHSPY4sCciOyXfAyYoD\n DFqhRjOEwBBxhr+scU4C1T2AflozvDwq3VSONjrKJUkhd8+WsdXxMdPFgBQuiKKwUy11mz6KQfcR\n wmDehF3UaUoxa+YIhWPbKmycxuX/D8SvnqavzAeAL1OcRbEI/HsoroVlEFbBRNBZLJUlnTPs8ZcU\n 4+8rq5YX1GUrJL3jf6SAfSgO7UdkEET3PdcKFYtS+ruV1Cp5V0q4kCfI5jk25iiz8grM2wOzVSsc\n l1mEkhiEPH87HP0whhb544iioSnumd3HJKL7dzhRegsMizatupp8D65A2JziW0WKopa1iw9fti3A\n aBeNN4ijKZchBXHPgVx+YtWRHfcm4l8=", "OpenPGP": "url=https://posteo.de/keys/markus.probst@posteo.de.asc;\n preference=encrypt" }, "content": "Implement the core abstractions needed for led class devices, including:\n\n* `led::LedOps` - the trait for handling leds, including\n `brightness_set`, `brightness_get` and `blink_set`\n\n* `led::DeviceBuilder` - the builder for the led class device\n\n* `led::Device` - a safe wrapper around `led_classdev`\n\nSigned-off-by: Markus Probst <markus.probst@posteo.de>\n---\n MAINTAINERS | 8 ++\n rust/kernel/led.rs | 252 ++++++++++++++++++++++++++++++++++++++++++++++\n rust/kernel/led/normal.rs | 218 +++++++++++++++++++++++++++++++++++++++\n rust/kernel/lib.rs | 1 +\n 4 files changed, 479 insertions(+)", "diff": "diff --git a/MAINTAINERS b/MAINTAINERS\nindex 0efa8cc6775b..5f8b59678785 100644\n--- a/MAINTAINERS\n+++ b/MAINTAINERS\n@@ -14279,6 +14279,14 @@ F:\tdrivers/leds/\n F:\tinclude/dt-bindings/leds/\n F:\tinclude/linux/leds.h\n \n+LED SUBSYSTEM [RUST]\n+M:\tMarkus Probst <markus.probst@posteo.de>\n+L:\tlinux-leds@vger.kernel.org\n+L:\trust-for-linux@vger.kernel.org\n+S:\tMaintained\n+F:\trust/kernel/led.rs\n+F:\trust/kernel/led/\n+\n LEGO MINDSTORMS EV3\n R:\tDavid Lechner <david@lechnology.com>\n S:\tMaintained\ndiff --git a/rust/kernel/led.rs b/rust/kernel/led.rs\nnew file mode 100644\nindex 000000000000..646846c56a01\n--- /dev/null\n+++ b/rust/kernel/led.rs\n@@ -0,0 +1,252 @@\n+// SPDX-License-Identifier: GPL-2.0\n+\n+//! Abstractions for the leds driver model.\n+//!\n+//! C header: [`include/linux/leds.h`](srctree/include/linux/leds.h)\n+\n+use core::{\n+ marker::PhantomData,\n+ mem::transmute,\n+ ptr::NonNull, //\n+};\n+\n+use crate::{\n+ container_of,\n+ device::{\n+ self,\n+ property::FwNode,\n+ AsBusDevice,\n+ Bound, //\n+ },\n+ devres::Devres,\n+ error::{\n+ from_result,\n+ to_result,\n+ VTABLE_DEFAULT_ERROR, //\n+ },\n+ macros::vtable,\n+ prelude::*,\n+ str::CStrExt,\n+ types::{\n+ ARef,\n+ Opaque, //\n+ }, //\n+};\n+\n+mod normal;\n+\n+pub use normal::Device;\n+\n+/// The builder to register a led class device.\n+///\n+/// See [`LedOps`].\n+#[derive(Default)]\n+pub struct DeviceBuilder<'a> {\n+ fwnode: Option<ARef<FwNode>>,\n+ devicename: Option<&'a CStr>,\n+ devname_mandatory: bool,\n+ initial_brightness: u32,\n+ default_trigger: Option<&'a CStr>,\n+ color: Color,\n+}\n+\n+impl DeviceBuilder<'static> {\n+ /// Creates a new [`DeviceBuilder`].\n+ #[inline]\n+ pub fn new() -> Self {\n+ Self::default()\n+ }\n+}\n+\n+impl<'a> DeviceBuilder<'a> {\n+ /// Sets the firmware node.\n+ #[inline]\n+ pub fn fwnode(self, fwnode: Option<ARef<FwNode>>) -> Self {\n+ Self { fwnode, ..self }\n+ }\n+\n+ /// Sets the device name.\n+ #[inline]\n+ pub fn devicename(self, devicename: &'a CStr) -> Self {\n+ Self {\n+ devicename: Some(devicename),\n+ ..self\n+ }\n+ }\n+\n+ /// Sets if a device name is mandatory.\n+ #[inline]\n+ pub fn devicename_mandatory(self, mandatory: bool) -> Self {\n+ Self {\n+ devname_mandatory: mandatory,\n+ ..self\n+ }\n+ }\n+\n+ /// Sets the initial brightness value for the led.\n+ ///\n+ /// The default brightness is 0.\n+ /// If [`LedOps::brightness_get`] is implemented, this value will be ignored.\n+ #[inline]\n+ pub fn initial_brightness(self, brightness: u32) -> Self {\n+ Self {\n+ initial_brightness: brightness,\n+ ..self\n+ }\n+ }\n+\n+ /// Set the default led trigger.\n+ ///\n+ /// This value can be overwritten by the \"linux,default-trigger\" fwnode property.\n+ #[inline]\n+ pub fn default_trigger(self, trigger: &'a CStr) -> Self {\n+ Self {\n+ default_trigger: Some(trigger),\n+ ..self\n+ }\n+ }\n+\n+ /// Sets the color of the led.\n+ ///\n+ /// This value can be overwritten by the \"color\" fwnode property.\n+ #[inline]\n+ pub fn color(self, color: Color) -> Self {\n+ Self { color, ..self }\n+ }\n+}\n+\n+/// Trait defining the operations for a LED driver.\n+///\n+/// # Examples\n+/// ```\n+/// use kernel::{\n+/// device,\n+/// devres::Devres,\n+/// led,\n+/// macros::vtable,\n+/// platform,\n+/// prelude::*, //\n+/// };\n+///\n+/// struct MyLedOps;\n+///\n+///\n+/// #[vtable]\n+/// impl led::LedOps for MyLedOps {\n+/// type Bus = platform::Device<device::Bound>;\n+/// const BLOCKING: bool = false;\n+/// const MAX_BRIGHTNESS: u32 = 255;\n+///\n+/// fn brightness_set(\n+/// &self,\n+/// _dev: &platform::Device<device::Bound>,\n+/// _classdev: &led::Device<Self>,\n+/// _brightness: u32\n+/// ) -> Result<()> {\n+/// // Set the brightness for the led here\n+/// Ok(())\n+/// }\n+/// }\n+///\n+/// fn register_my_led(\n+/// parent: &platform::Device<device::Bound>,\n+/// ) -> Result<Pin<KBox<Devres<led::Device<MyLedOps>>>>> {\n+/// KBox::pin_init(led::DeviceBuilder::new()\n+/// .build(\n+/// parent,\n+/// Ok(MyLedOps),\n+/// ), GFP_KERNEL)\n+/// }\n+/// ```\n+/// Led drivers must implement this trait in order to register and handle a [`Device`].\n+#[vtable]\n+pub trait LedOps: Send + 'static + Sized {\n+ /// The bus device required by the implementation.\n+ #[allow(private_bounds)]\n+ type Bus: AsBusDevice<Bound>;\n+\n+ /// If set true, [`LedOps::brightness_set`] and [`LedOps::blink_set`] must perform the\n+ /// operation immediately. If set false, they must not sleep.\n+ const BLOCKING: bool;\n+ /// The max brightness level.\n+ const MAX_BRIGHTNESS: u32;\n+\n+ /// Sets the brightness level.\n+ ///\n+ /// See also [`LedOps::BLOCKING`].\n+ fn brightness_set(\n+ &self,\n+ dev: &Self::Bus,\n+ classdev: &Device<Self>,\n+ brightness: u32,\n+ ) -> Result<()>;\n+\n+ /// Gets the current brightness level.\n+ fn brightness_get(&self, dev: &Self::Bus, classdev: &Device<Self>) -> u32 {\n+ let _ = (dev, classdev);\n+ build_error!(VTABLE_DEFAULT_ERROR)\n+ }\n+\n+ /// Activates hardware accelerated blinking.\n+ ///\n+ /// delays are in milliseconds. If both are zero, a sensible default should be chosen.\n+ /// The caller should adjust the timings in that case and if it can't match the values\n+ /// specified exactly. Setting the brightness to 0 will disable the hardware accelerated\n+ /// blinking.\n+ ///\n+ /// See also [`LedOps::BLOCKING`].\n+ fn blink_set(\n+ &self,\n+ dev: &Self::Bus,\n+ classdev: &Device<Self>,\n+ delay_on: &mut usize,\n+ delay_off: &mut usize,\n+ ) -> Result<()> {\n+ let _ = (dev, classdev, delay_on, delay_off);\n+ build_error!(VTABLE_DEFAULT_ERROR)\n+ }\n+}\n+\n+/// Led colors.\n+#[derive(Copy, Clone, Debug, Default)]\n+#[repr(u32)]\n+#[non_exhaustive]\n+#[expect(\n+ missing_docs,\n+ reason = \"it shouldn't be necessary to document each color\"\n+)]\n+pub enum Color {\n+ #[default]\n+ White = bindings::LED_COLOR_ID_WHITE,\n+ Red = bindings::LED_COLOR_ID_RED,\n+ Green = bindings::LED_COLOR_ID_GREEN,\n+ Blue = bindings::LED_COLOR_ID_BLUE,\n+ Amber = bindings::LED_COLOR_ID_AMBER,\n+ Violet = bindings::LED_COLOR_ID_VIOLET,\n+ Yellow = bindings::LED_COLOR_ID_YELLOW,\n+ Ir = bindings::LED_COLOR_ID_IR,\n+ Multi = bindings::LED_COLOR_ID_MULTI,\n+ Rgb = bindings::LED_COLOR_ID_RGB,\n+ Purple = bindings::LED_COLOR_ID_PURPLE,\n+ Orange = bindings::LED_COLOR_ID_ORANGE,\n+ Pink = bindings::LED_COLOR_ID_PINK,\n+ Cyan = bindings::LED_COLOR_ID_CYAN,\n+ Lime = bindings::LED_COLOR_ID_LIME,\n+}\n+static_assert!(bindings::LED_COLOR_ID_MAX == 15);\n+\n+impl TryFrom<u32> for Color {\n+ type Error = Error;\n+\n+ fn try_from(value: u32) -> core::result::Result<Self, Self::Error> {\n+ if value < bindings::LED_COLOR_ID_MAX {\n+ // SAFETY:\n+ // - `Color` is represented as `u32`\n+ // - the static_assert above guarantees that no additional color has been added\n+ // - `value` is guaranteed to be in the color id range\n+ Ok(unsafe { transmute::<u32, Color>(value) })\n+ } else {\n+ Err(EINVAL)\n+ }\n+ }\n+}\ndiff --git a/rust/kernel/led/normal.rs b/rust/kernel/led/normal.rs\nnew file mode 100644\nindex 000000000000..efce886b5c04\n--- /dev/null\n+++ b/rust/kernel/led/normal.rs\n@@ -0,0 +1,218 @@\n+// SPDX-License-Identifier: GPL-2.0\n+\n+//! Led mode for the `struct led_classdev`.\n+//!\n+//! C header: [`include/linux/leds.h`](srctree/include/linux/leds.h)\n+\n+use super::*;\n+\n+/// The led class device representation.\n+///\n+/// This structure represents the Rust abstraction for a led class device.\n+#[pin_data(PinnedDrop)]\n+pub struct Device<T: LedOps> {\n+ #[pin]\n+ ops: T,\n+ #[pin]\n+ classdev: Opaque<bindings::led_classdev>,\n+}\n+\n+impl<'a> DeviceBuilder<'a> {\n+ /// Registers a new [`Device`].\n+ pub fn build<T: LedOps>(\n+ self,\n+ parent: &'a T::Bus,\n+ ops: impl PinInit<T, Error> + 'a,\n+ ) -> impl PinInit<Devres<Device<T>>, Error> + 'a {\n+ Devres::new(\n+ parent.as_ref(),\n+ try_pin_init!(Device {\n+ ops <- ops,\n+ classdev <- Opaque::try_ffi_init(|ptr: *mut bindings::led_classdev| {\n+ // SAFETY: `try_ffi_init` guarantees that `ptr` is valid for write.\n+ // `led_classdev` gets fully initialized in-place by\n+ // `led_classdev_register_ext` including `mutex` and `list_head`.\n+ unsafe {\n+ ptr.write(bindings::led_classdev {\n+ brightness_set: (!T::BLOCKING)\n+ .then_some(Adapter::<T>::brightness_set_callback),\n+ brightness_set_blocking: T::BLOCKING\n+ .then_some(Adapter::<T>::brightness_set_blocking_callback),\n+ brightness_get: T::HAS_BRIGHTNESS_GET\n+ .then_some(Adapter::<T>::brightness_get_callback),\n+ blink_set: T::HAS_BLINK_SET.then_some(Adapter::<T>::blink_set_callback),\n+ max_brightness: T::MAX_BRIGHTNESS,\n+ brightness: self.initial_brightness,\n+ default_trigger: self\n+ .default_trigger\n+ .map_or(core::ptr::null(), CStrExt::as_char_ptr),\n+ color: self.color as u32,\n+ ..bindings::led_classdev::default()\n+ })\n+ };\n+\n+ let mut init_data = bindings::led_init_data {\n+ fwnode: self\n+ .fwnode\n+ .as_ref()\n+ .map_or(core::ptr::null_mut(), |fwnode| fwnode.as_raw()),\n+ default_label: core::ptr::null(),\n+ devicename: self\n+ .devicename\n+ .map_or(core::ptr::null(), CStrExt::as_char_ptr),\n+ devname_mandatory: self.devname_mandatory,\n+ };\n+\n+ // SAFETY:\n+ // - `parent.as_ref().as_raw()` is guaranteed to be a pointer to a valid\n+ // `device`.\n+ // - `ptr` is guaranteed to be a pointer to an initialized `led_classdev`.\n+ to_result(unsafe {\n+ bindings::led_classdev_register_ext(\n+ parent.as_ref().as_raw(),\n+ ptr,\n+ &raw mut init_data,\n+ )\n+ })?;\n+\n+ core::mem::forget(self.fwnode); // keep the reference count incremented\n+\n+ Ok::<_, Error>(())\n+ }),\n+ }),\n+ )\n+ }\n+}\n+\n+impl<T: LedOps> Device<T> {\n+ /// # Safety\n+ /// `led_cdev` must be a valid pointer to a `led_classdev` embedded within a\n+ /// `led::Device`.\n+ unsafe fn from_raw<'a>(led_cdev: *mut bindings::led_classdev) -> &'a Self {\n+ // SAFETY: The function's contract guarantees that `led_cdev` points to a `led_classdev`\n+ // field embedded within a valid `led::Device`. `container_of!` can therefore\n+ // safely calculate the address of the containing struct.\n+ unsafe { &*container_of!(Opaque::cast_from(led_cdev), Self, classdev) }\n+ }\n+\n+ fn parent(&self) -> &device::Device<Bound> {\n+ // SAFETY: `self.classdev.get()` is guaranteed to be a valid pointer to `led_classdev`.\n+ unsafe { device::Device::from_raw((*(*self.classdev.get()).dev).parent) }\n+ }\n+}\n+\n+// SAFETY: A `led::Device` can be unregistered from any thread.\n+unsafe impl<T: LedOps + Send> Send for Device<T> {}\n+\n+// SAFETY: `led::Device` can be shared among threads because all methods of `led::Device`\n+// are thread safe.\n+unsafe impl<T: LedOps + Sync> Sync for Device<T> {}\n+\n+struct Adapter<T: LedOps> {\n+ _p: PhantomData<T>,\n+}\n+\n+impl<T: LedOps> Adapter<T> {\n+ /// # Safety\n+ /// `led_cdev` must be a valid pointer to a `led_classdev` embedded within a\n+ /// `led::Device`.\n+ /// This function is called on setting the brightness of a led.\n+ unsafe extern \"C\" fn brightness_set_callback(\n+ led_cdev: *mut bindings::led_classdev,\n+ brightness: u32,\n+ ) {\n+ // SAFETY: The function's contract guarantees that `led_cdev` is a valid pointer to a\n+ // `led_classdev` embedded within a `led::Device`.\n+ let classdev = unsafe { Device::<T>::from_raw(led_cdev) };\n+ // SAFETY: `classdev.parent()` is guaranteed to be contained in `T::Bus`.\n+ let parent = unsafe { T::Bus::from_device(classdev.parent()) };\n+\n+ let _ = classdev.ops.brightness_set(parent, classdev, brightness);\n+ }\n+\n+ /// # Safety\n+ /// `led_cdev` must be a valid pointer to a `led_classdev` embedded within a\n+ /// `led::Device`.\n+ /// This function is called on setting the brightness of a led immediately.\n+ unsafe extern \"C\" fn brightness_set_blocking_callback(\n+ led_cdev: *mut bindings::led_classdev,\n+ brightness: u32,\n+ ) -> i32 {\n+ from_result(|| {\n+ // SAFETY: The function's contract guarantees that `led_cdev` is a valid pointer to a\n+ // `led_classdev` embedded within a `led::Device`.\n+ let classdev = unsafe { Device::<T>::from_raw(led_cdev) };\n+ // SAFETY: `classdev.parent()` is guaranteed to be contained in `T::Bus`.\n+ let parent = unsafe { T::Bus::from_device(classdev.parent()) };\n+\n+ classdev.ops.brightness_set(parent, classdev, brightness)?;\n+ Ok(0)\n+ })\n+ }\n+\n+ /// # Safety\n+ /// `led_cdev` must be a valid pointer to a `led_classdev` embedded within a\n+ /// `led::Device`.\n+ /// This function is called on getting the brightness of a led.\n+ unsafe extern \"C\" fn brightness_get_callback(led_cdev: *mut bindings::led_classdev) -> u32 {\n+ // SAFETY: The function's contract guarantees that `led_cdev` is a valid pointer to a\n+ // `led_classdev` embedded within a `led::Device`.\n+ let classdev = unsafe { Device::<T>::from_raw(led_cdev) };\n+ // SAFETY: `classdev.parent()` is guaranteed to be contained in `T::Bus`.\n+ let parent = unsafe { T::Bus::from_device(classdev.parent()) };\n+\n+ classdev.ops.brightness_get(parent, classdev)\n+ }\n+\n+ /// # Safety\n+ /// `led_cdev` must be a valid pointer to a `led_classdev` embedded within a\n+ /// `led::Device`.\n+ /// `delay_on` and `delay_off` must be valid pointers to `usize` and have\n+ /// exclusive access for the period of this function.\n+ /// This function is called on enabling hardware accelerated blinking.\n+ unsafe extern \"C\" fn blink_set_callback(\n+ led_cdev: *mut bindings::led_classdev,\n+ delay_on: *mut usize,\n+ delay_off: *mut usize,\n+ ) -> i32 {\n+ from_result(|| {\n+ // SAFETY: The function's contract guarantees that `led_cdev` is a valid pointer to a\n+ // `led_classdev` embedded within a `led::Device`.\n+ let classdev = unsafe { Device::<T>::from_raw(led_cdev) };\n+ // SAFETY: `classdev.parent()` is guaranteed to be contained in `T::Bus`.\n+ let parent = unsafe { T::Bus::from_device(classdev.parent()) };\n+\n+ classdev.ops.blink_set(\n+ parent,\n+ classdev,\n+ // SAFETY: The function's contract guarantees that `delay_on` points to a `usize`\n+ // and is exclusive for the period of this function.\n+ unsafe { &mut *delay_on },\n+ // SAFETY: The function's contract guarantees that `delay_off` points to a `usize`\n+ // and is exclusive for the period of this function.\n+ unsafe { &mut *delay_off },\n+ )?;\n+ Ok(0)\n+ })\n+ }\n+}\n+\n+#[pinned_drop]\n+impl<T: LedOps> PinnedDrop for Device<T> {\n+ fn drop(self: Pin<&mut Self>) {\n+ let raw = self.classdev.get();\n+ // SAFETY: The existence of `self` guarantees that `self.classdev.get()` is a pointer to a\n+ // valid `led_classdev`.\n+ let dev: &device::Device = unsafe { device::Device::from_raw((*raw).dev) };\n+\n+ let _fwnode = dev\n+ .fwnode()\n+ // SAFETY: the reference count of `fwnode` has previously been\n+ // incremented in `led::Device::new`.\n+ .map(|fwnode| unsafe { ARef::from_raw(NonNull::from(fwnode)) });\n+\n+ // SAFETY: The existence of `self` guarantees that `self.classdev` has previously been\n+ // successfully registered with `led_classdev_register_ext`.\n+ unsafe { bindings::led_classdev_unregister(raw) };\n+ }\n+}\ndiff --git a/rust/kernel/lib.rs b/rust/kernel/lib.rs\nindex f812cf120042..231818e0614b 100644\n--- a/rust/kernel/lib.rs\n+++ b/rust/kernel/lib.rs\n@@ -108,6 +108,7 @@\n pub mod jump_label;\n #[cfg(CONFIG_KUNIT)]\n pub mod kunit;\n+pub mod led;\n pub mod list;\n pub mod maple_tree;\n pub mod miscdevice;\n", "prefixes": [ "v12", "1/3" ] }