Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2194147/?format=api
{ "id": 2194147, "url": "http://patchwork.ozlabs.org/api/patches/2194147/?format=api", "web_url": "http://patchwork.ozlabs.org/project/gcc/patch/ri6zf5lplje.fsf@virgil.suse.cz/", "project": { "id": 17, "url": "http://patchwork.ozlabs.org/api/projects/17/?format=api", "name": "GNU Compiler Collection", "link_name": "gcc", "list_id": "gcc-patches.gcc.gnu.org", "list_email": "gcc-patches@gcc.gnu.org", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<ri6zf5lplje.fsf@virgil.suse.cz>", "list_archive_url": null, "date": "2026-02-06T22:14:13", "name": "ipa-cp: Also look at self-recursive ancestor jump functions (PR122856)", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "5b513bf614d0bd7ea0d03cb381482f746c1ab718", "submitter": { "id": 4351, "url": "http://patchwork.ozlabs.org/api/people/4351/?format=api", "name": "Martin Jambor", "email": "mjambor@suse.cz" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/gcc/patch/ri6zf5lplje.fsf@virgil.suse.cz/mbox/", "series": [ { "id": 491343, "url": "http://patchwork.ozlabs.org/api/series/491343/?format=api", "web_url": "http://patchwork.ozlabs.org/project/gcc/list/?series=491343", "date": "2026-02-06T22:14:13", "name": "ipa-cp: Also look at self-recursive ancestor jump functions (PR122856)", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/491343/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2194147/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2194147/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "gcc-patches@gcc.gnu.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "gcc-patches@gcc.gnu.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=suse.cz header.i=@suse.cz header.a=rsa-sha256\n header.s=susede2_rsa header.b=oFmswNQp;\n\tdkim=pass header.d=suse.cz header.i=@suse.cz header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=JfDkPx8/;\n\tdkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz\n header.a=rsa-sha256 header.s=susede2_rsa header.b=xp94sqHo;\n\tdkim=neutral header.d=suse.cz header.i=@suse.cz header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=4Tmd8oZH;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)", "sourceware.org;\n\tdkim=pass (1024-bit key,\n unprotected) header.d=suse.cz header.i=@suse.cz header.a=rsa-sha256\n header.s=susede2_rsa header.b=oFmswNQp;\n\tdkim=pass header.d=suse.cz header.i=@suse.cz header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=JfDkPx8/;\n\tdkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz\n header.a=rsa-sha256 header.s=susede2_rsa header.b=xp94sqHo;\n\tdkim=neutral header.d=suse.cz header.i=@suse.cz header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=4Tmd8oZH", "sourceware.org;\n dmarc=none (p=none dis=none) header.from=suse.cz", "sourceware.org; spf=pass smtp.mailfrom=suse.cz", "server2.sourceware.org;\n arc=none smtp.remote-ip=195.135.223.131", "smtp-out2.suse.de;\n\tnone" ], "Received": [ "from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4f77gN55z7z1xvh\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 07 Feb 2026 09:14:55 +1100 (AEDT)", "from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id 37E9F4BAD153\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 6 Feb 2026 22:14:53 +0000 (GMT)", "from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131])\n by sourceware.org (Postfix) with ESMTPS id 3DD7D4B9DB48\n for <gcc-patches@gcc.gnu.org>; Fri, 6 Feb 2026 22:14:16 +0000 (GMT)", "from imap1.dmz-prg2.suse.org (unknown [10.150.64.97])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-out2.suse.de (Postfix) with ESMTPS id 48FB55BCCE;\n Fri, 6 Feb 2026 22:14:14 +0000 (UTC)", "from imap1.dmz-prg2.suse.org (localhost [127.0.0.1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 311193EA63;\n Fri, 6 Feb 2026 22:14:14 +0000 (UTC)", "from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167])\n by imap1.dmz-prg2.suse.org with ESMTPSA id uAWKC7ZnhmmNaAAAD6G6ig\n (envelope-from <mjambor@suse.cz>); Fri, 06 Feb 2026 22:14:14 +0000" ], "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 sourceware.org 37E9F4BAD153", "OpenDKIM Filter v2.11.0 sourceware.org 3DD7D4B9DB48" ], "DMARC-Filter": "OpenDMARC Filter v1.4.2 sourceware.org 3DD7D4B9DB48", "ARC-Filter": "OpenARC Filter v1.0.0 sourceware.org 3DD7D4B9DB48", "ARC-Seal": "i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1770416056; cv=none;\n b=GhSHlrmrbd7nOuZQZvMINHEeA9nC/M9zTXuHTUmeiCu1U8hCv4+ufFfdiXhk/Yc20/WuM+uiMibl1tclqKKm4r38lLBR7LBlO/R+6R2++AA2G/q5mDX0zEZaEda8QpmOW72c5YZCDHzbJNnjuY7jypRW6PrWfOqmbMXamDOFRgI=", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1770416056; c=relaxed/simple;\n bh=LaDxvRL5KIGsroT8FvpLLran1uUfyKzzCSklVPpncgs=;\n h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From:\n To:Subject:Date:Message-ID:MIME-Version;\n b=R1c0aZji/+ExUgtK4WmN924jRKO6UFtTCZUV8/SIc+JS1BHghaDD+IawRxGgWR7fB81K3ES2WCqa1pLuAULQy0iK22TeCnEowNvOja8R3QodoQtW2rRj0+fMzYsPq9jwu/+pBfPO96QeR8MgLZLB1yDUPaKKZ8YNg0J4yzTvzig=", "ARC-Authentication-Results": "i=1; server2.sourceware.org", "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_rsa;\n t=1770416055;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:content-type:content-type;\n bh=HhIh2T2qpVgs044jzhhsinA0+SLzN/ibEpct2jBMvT8=;\n b=oFmswNQprwvXLsIL9ZzOHMZxkQi3m852p+zVgKSPBHv31QMJ2cLWsIT5Wo/650/CLvF+36\n +wifP0y40rUvdwa4cdcQ3bvvkWEi/l6vkSbvQI3YbzXydxcKfJvrYmULLZYA0IjgynjOw7\n 1OdAK9643dP16oEoU4Mx0obQN1F1J8o=", "v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_ed25519; t=1770416055;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:content-type:content-type;\n bh=HhIh2T2qpVgs044jzhhsinA0+SLzN/ibEpct2jBMvT8=;\n b=JfDkPx8/jJ5TtWazMHquwQhJ5QCcrhg0mz2jnhUXE8AFdtSMyBT76E+V36b15e/4441qeW\n mymB0O2GY2ZhEeCg==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_rsa;\n t=1770416054;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:content-type:content-type;\n bh=HhIh2T2qpVgs044jzhhsinA0+SLzN/ibEpct2jBMvT8=;\n b=xp94sqHoqA7SMqN/v7eg1FwGofUobPPPv55+ttD9aAK3s7Njmo6/bXdIrXZfTdJOcgsls3\n mZZ33sMr5fuikKDjodbSK8++8t/tSV/cDG5UXhoI2GUgTa83r7yrTWeU4CBfirPVicI3H3\n KsvON++1WNOGrywMAQshm1ygZrikuP8=", "v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_ed25519; t=1770416054;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:content-type:content-type;\n bh=HhIh2T2qpVgs044jzhhsinA0+SLzN/ibEpct2jBMvT8=;\n b=4Tmd8oZHsxavlMHQznWGuJ/pHayMtR3uQhEirKVVvXYT7ke/pk1pVYIycPcLIwrg/oD2hi\n 1gi1kal3boOVSnCA==" ], "From": "Martin Jambor <mjambor@suse.cz>", "To": "GCC Patches <gcc-patches@gcc.gnu.org>", "Cc": "Jan Hubicka <hubicka@ucw.cz>", "Subject": "[PATCH] ipa-cp: Also look at self-recursive ancestor jump functions\n (PR122856)", "User-Agent": "Notmuch/0.38.3 (https://notmuchmail.org) Emacs/30.2\n (x86_64-suse-linux-gnu)", "Date": "Fri, 06 Feb 2026 23:14:13 +0100", "Message-ID": "<ri6zf5lplje.fsf@virgil.suse.cz>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Spamd-Result": "default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[100.00%];\n NEURAL_HAM_LONG(-1.00)[-1.000];\n NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain];\n RCPT_COUNT_TWO(0.00)[2]; MID_RHS_MATCH_FROMTLD(0.00)[];\n FUZZY_RATELIMITED(0.00)[rspamd.com]; ARC_NA(0.00)[];\n RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_TLS_ALL(0.00)[];\n DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519];\n TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_HAS_DN(0.00)[];\n TO_DN_ALL(0.00)[]; FROM_EQ_ENVFROM(0.00)[];\n RCVD_COUNT_TWO(0.00)[2]; MIME_TRACE(0.00)[0:+]", "X-BeenThere": "gcc-patches@gcc.gnu.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Gcc-patches mailing list <gcc-patches.gcc.gnu.org>", "List-Unsubscribe": "<https://gcc.gnu.org/mailman/options/gcc-patches>,\n <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>", "List-Archive": "<https://gcc.gnu.org/pipermail/gcc-patches/>", "List-Post": "<mailto:gcc-patches@gcc.gnu.org>", "List-Help": "<mailto:gcc-patches-request@gcc.gnu.org?subject=help>", "List-Subscribe": "<https://gcc.gnu.org/mailman/listinfo/gcc-patches>,\n <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>", "Errors-To": "gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org" }, "content": "Hi,\n\nPR 122856 shows that when looking at self recursive calls with\nself-feeding jump functions, we did consider pass-through functions\nbut not ancestor functions with zero offsets. This then leads to the\nfact that constants which were collected from IPA-CP lattices were not\namong those collected from available edges, triggering a verification\nassert.\n\nThis patch fixes that by also detecting self-feeding ancestor jump\nfunctions.\n\nBootstrapped and tested on x86_64-linux. OK for master and affected\nrelease branches?\n\nThanks,\n\nMartin\n\n\ngcc/ChangeLog:\n\n2026-02-06 Martin Jambor <mjambor@suse.cz>\n\n\tPR ipa/122856\n\t* ipa-cp.cc (self_recursive_pass_through_p): Test jump function type first.\n\t(self_recursive_ancestor_p): New function.\n\t(find_scalar_values_for_callers_subset): Test also for self-recursive\n\tancestor jump functions.\n\t(push_agg_values_for_index_from_edge): Likewise.\n\ngcc/testsuite/ChangeLog:\n\n2026-02-06 Martin Jambor <mjambor@suse.cz>\n\n\tPR ipa/122856\n\t* g++.dg/ipa/pr122856.C: New test.\n---\n gcc/ipa-cp.cc | 28 +++++++++++++++++++++++++---\n gcc/testsuite/g++.dg/ipa/pr122856.C | 26 ++++++++++++++++++++++++++\n 2 files changed, 51 insertions(+), 3 deletions(-)\n create mode 100644 gcc/testsuite/g++.dg/ipa/pr122856.C", "diff": "diff --git a/gcc/ipa-cp.cc b/gcc/ipa-cp.cc\nindex 339d306251c..5b7cb3cdb43 100644\n--- a/gcc/ipa-cp.cc\n+++ b/gcc/ipa-cp.cc\n@@ -5259,9 +5259,9 @@ self_recursive_pass_through_p (cgraph_edge *cs, ipa_jump_func *jfunc, int i,\n \t\t\t bool simple = true)\n {\n enum availability availability;\n- if (cs->caller == cs->callee->function_symbol (&availability)\n+ if (jfunc->type == IPA_JF_PASS_THROUGH\n+ && cs->caller == cs->callee->function_symbol (&availability)\n && availability > AVAIL_INTERPOSABLE\n- && jfunc->type == IPA_JF_PASS_THROUGH\n && (!simple || ipa_get_jf_pass_through_operation (jfunc) == NOP_EXPR)\n && ipa_get_jf_pass_through_formal_id (jfunc) == i\n && ipa_node_params_sum->get (cs->caller)\n@@ -5270,6 +5270,25 @@ self_recursive_pass_through_p (cgraph_edge *cs, ipa_jump_func *jfunc, int i,\n return false;\n }\n \n+/* Return true if JFUNC, which describes the i-th parameter of call CS, is an\n+ ancestor function with zero offset to itself when the cgraph_node involved\n+ is not an IPA-CP clone. */\n+\n+static bool\n+self_recursive_ancestor_p (cgraph_edge *cs, ipa_jump_func *jfunc, int i)\n+{\n+ enum availability availability;\n+ if (jfunc->type == IPA_JF_ANCESTOR\n+ && cs->caller == cs->callee->function_symbol (&availability)\n+ && availability > AVAIL_INTERPOSABLE\n+ && ipa_get_jf_ancestor_offset (jfunc) == 0\n+ && ipa_get_jf_ancestor_formal_id (jfunc) == i\n+ && ipa_node_params_sum->get (cs->caller)\n+ && !ipa_node_params_sum->get (cs->caller)->ipcp_orig_node)\n+ return true;\n+ return false;\n+}\n+\n /* Return true if JFUNC, which describes a part of an aggregate represented or\n pointed to by the i-th parameter of call CS, is a pass-through function to\n itself when the cgraph_node involved is not an IPA-CP clone.. When\n@@ -5361,6 +5380,8 @@ find_scalar_values_for_callers_subset (vec<tree> &known_csts,\n \t\t\t\top_type);\n \t t = ipacp_value_safe_for_type (type, t);\n \t }\n+\t else if (self_recursive_ancestor_p (cs, jump_func, i))\n+\t continue;\n \t else\n \t t = ipa_value_from_jfunc (ipa_node_params_sum->get (cs->caller),\n \t\t\t\t jump_func, type);\n@@ -5515,7 +5536,8 @@ push_agg_values_for_index_from_edge (struct cgraph_edge *cs, int index,\n \t && !src_plats->aggs_bottom\n \t && (agg_jf_preserved || !src_plats->aggs_by_ref))\n \t {\n-\t if (interim && self_recursive_pass_through_p (cs, jfunc, index))\n+\t if (interim && (self_recursive_pass_through_p (cs, jfunc, index)\n+\t\t\t || self_recursive_ancestor_p (cs, jfunc, index)))\n \t\t{\n \t\t interim->push_adjusted_values (src_idx, index, unit_delta,\n \t\t\t\t\t\t res);\ndiff --git a/gcc/testsuite/g++.dg/ipa/pr122856.C b/gcc/testsuite/g++.dg/ipa/pr122856.C\nnew file mode 100644\nindex 00000000000..b634e628009\n--- /dev/null\n+++ b/gcc/testsuite/g++.dg/ipa/pr122856.C\n@@ -0,0 +1,26 @@\n+/* { dg-do compile } */\n+/* { dg-options \"-O3 -std=gnu++11\" } */\n+\n+template <typename T>\n+class Base {\n+public:\n+ virtual int get();\n+ virtual ~Base() = default;\n+};\n+\n+template <typename T>\n+class Derived : public Base<T> {\n+public:\n+ int get() override { return Base<T>::get(); }\n+};\n+\n+template <typename T>\n+int Base<T>::get() {\n+\n+ return static_cast<Derived<int>*>(this)->get();\n+}\n+\n+int main() {\n+ Derived<int> d;\n+ return d.get();\n+}\n", "prefixes": [] }