Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2194126/?format=api
{ "id": 2194126, "url": "http://patchwork.ozlabs.org/api/patches/2194126/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260206214448.22008-14-philmd@linaro.org/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260206214448.22008-14-philmd@linaro.org>", "list_archive_url": null, "date": "2026-02-06T21:44:31", "name": "[PULL,13/30] target/sparc: Remove dubious swapping in LD_code() helper", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "46014cdf221acb46594d21f2e2216be521668f54", "submitter": { "id": 85046, "url": "http://patchwork.ozlabs.org/api/people/85046/?format=api", "name": "Philippe Mathieu-Daudé", "email": "philmd@linaro.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260206214448.22008-14-philmd@linaro.org/mbox/", "series": [ { "id": 491339, "url": "http://patchwork.ozlabs.org/api/series/491339/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=491339", "date": "2026-02-06T21:44:19", "name": "[PULL,01/30] riscv64/test_boston.py: fix intermitent test timeout", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/491339/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2194126/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2194126/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=quyxR58d;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4f774P4CfYz1xvW\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 07 Feb 2026 08:48:05 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1voTgB-0008Ju-8J; Fri, 06 Feb 2026 16:47:56 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1voTen-0005xE-PD\n for qemu-devel@nongnu.org; Fri, 06 Feb 2026 16:46:30 -0500", "from mail-wm1-x332.google.com ([2a00:1450:4864:20::332])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1voTec-0002g1-4P\n for qemu-devel@nongnu.org; Fri, 06 Feb 2026 16:46:20 -0500", "by mail-wm1-x332.google.com with SMTP id\n 5b1f17b1804b1-4806ce0f97bso23184045e9.0\n for <qemu-devel@nongnu.org>; Fri, 06 Feb 2026 13:46:17 -0800 (PST)", "from localhost.localdomain (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-483179dbdcfsm192157375e9.0.2026.02.06.13.46.15\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Fri, 06 Feb 2026 13:46:15 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1770414376; x=1771019176; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=j+b6+TDlKntW7zTY/b8CtNdbrq47FTBf8R9jWQuRs0E=;\n b=quyxR58d7JaWlmvdRjrp5M2IbrlfMrXJyr+m+x7ZE7itueX2Mpf7pN1p266jaTRfNi\n jGpeFOpN3x2qUZxrfK5LGmdZi8nSMacF85lFQC+EhFS9CcnZHnsrv0u8zecUdPZuoUqI\n 9ps5KsqjGPeNf9z81tHkbMzfdeYYhKWtrFcpO1Lv3pEP1LmvK0JfENqqDgNm92G5c2uW\n jc40wIF0zn2aEahBqupeh1p8R6V+pvp/x1Lum5sal8e1ZqqjISlYhOCQgnxOm5NOdhzH\n aeFRSOhaynpG0BwMTKHgDOe9YS5iCFcULYavQGbaQahXBkLCHhBrQCAYoJRMu7UxgDaK\n imag==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1770414376; x=1771019176;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=j+b6+TDlKntW7zTY/b8CtNdbrq47FTBf8R9jWQuRs0E=;\n b=bKEreRn8k+tor7ZW118Bt0/9foy72vfuhEP+4dj9zNNzc6uZ3llZHGAmbxzG7QEpMT\n ec/vWVQGZ28Pz79I/oDCVlJwbeoO7edgFlisCLrCSyQuvlAdW/NBSJoPpqVCeryET8+C\n PCoBOMt6FBQ3gNurGGH9s4wVFTDcY3nM7LbyvCxZRvt7xWZk8N/vpwO1i+LfvjQfkKKl\n 4RWUfT0g5pjwzUG/QFoYi3gCuWXeGreNEqF6gmLhjniEpsnJPBMd7oGKLeWmgeRKt9HR\n 5Ukm3VBH82xCDicyqFYXaoTN/JyHKzsKdcsfEzqLuGGNOCmoaaB+LvaXuNHz9U/Pm9MB\n B7rg==", "X-Gm-Message-State": "AOJu0Yy/sMFPvC5wkhlX9gbW2WyZ7bCYoXqBbdJQKe8S0+x4SWp/oBmA\n tJkXAzqxWnmjM+T8vYk/bKTHMY6PXalp9tZ9XBDnbquggLGPDxd47kNjd6bF+PYNNKDW03QlgwV\n nxYzUhTw=", "X-Gm-Gg": "AZuq6aKa1h03xCNOYYstPBnjH3mGmxTMSXMRSwypO6tRI+ai5Xq8UMQysNQppPont1I\n gMa4XDLzQZI019ra0bpK1SC5creLx2Et5KA/OsATcEdZjwh4XSl/4hRfr7KcU9JeP7TY3wZCc9r\n kLvFfGIYXLcMbTpx5SkIajDE6FZmCamK7Svthx5WunHaR6Jd3KiWAgoh5+06mwJXh8BJnn4L7Qm\n k4blwYiHEmDLN3GfCjWHiBRGrNzp3Y4+0Df0lUdcjLnsYz3JJbJBD3oZxPDUzBUFWK7M5olBoQx\n OYofVD8dLMpgTkXf3BmVOB5zJbyiKVexwu1UWEZekY0cVuQZOy84zkjX71iN5R2l/QPLLnRnbQR\n SVRFN3uCCXb+b+SwQFujVmI1/uv/PgyYDTqz4S2OMeO4wVTuqrXIWHGL8elvmipLo0qn5TWdGYx\n 0Jt/lyVpfgZCdsrFQcfSF/1ZX6zUIsIF5PuR5N+ShslQZSicWACW46TGbiNhjs", "X-Received": "by 2002:a05:600c:6209:b0:480:690e:f14a with SMTP id\n 5b1f17b1804b1-483201ee840mr56401525e9.14.1770414376418;\n Fri, 06 Feb 2026 13:46:16 -0800 (PST)", "From": "=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>", "To": "qemu-devel@nongnu.org", "Cc": "qemu-s390x@nongnu.org", "Subject": "[PULL 13/30] target/sparc: Remove dubious swapping in LD_code()\n helper", "Date": "Fri, 6 Feb 2026 22:44:31 +0100", "Message-ID": "<20260206214448.22008-14-philmd@linaro.org>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20260206214448.22008-1-philmd@linaro.org>", "References": "<20260206214448.22008-1-philmd@linaro.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Received-SPF": "pass client-ip=2a00:1450:4864:20::332;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x332.google.com", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Since the endianness is contained in %oi, cpu_ld*_code_mmu() has\nalready honored it. Swapping again makes no sense. Remove the\nbswap() calls.\n\nFixes: 2786a3f8d3a (\"Use GET_ASI_CODE for ASI_KERNELTXT / ASI_USERTXT\")\nReported-by: Richard Henderson <richard.henderson@linaro.org>\nSigned-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>\nReviewed-by: Richard Henderson <richard.henderson@linaro.org>\nMessage-Id: <20260203230054.23667-4-philmd@linaro.org>\n---\n target/sparc/ldst_helper.c | 9 ---------\n 1 file changed, 9 deletions(-)", "diff": "diff --git a/target/sparc/ldst_helper.c b/target/sparc/ldst_helper.c\nindex 3bc6a6827a4..4ec8799d1f7 100644\n--- a/target/sparc/ldst_helper.c\n+++ b/target/sparc/ldst_helper.c\n@@ -1169,27 +1169,18 @@ uint64_t helper_ld_code(CPUSPARCState *env, target_ulong addr, uint32_t oi)\n break;\n case MO_16:\n ret = cpu_ldw_code_mmu(env, addr, oi, ra);\n- if ((mop & MO_BSWAP) != MO_TE) {\n- ret = bswap16(ret);\n- }\n if (mop & MO_SIGN) {\n ret = (int16_t)ret;\n }\n break;\n case MO_32:\n ret = cpu_ldl_code_mmu(env, addr, oi, ra);\n- if ((mop & MO_BSWAP) != MO_TE) {\n- ret = bswap32(ret);\n- }\n if (mop & MO_SIGN) {\n ret = (int32_t)ret;\n }\n break;\n case MO_64:\n ret = cpu_ldq_code_mmu(env, addr, oi, ra);\n- if ((mop & MO_BSWAP) != MO_TE) {\n- ret = bswap64(ret);\n- }\n break;\n default:\n g_assert_not_reached();\n", "prefixes": [ "PULL", "13/30" ] }