Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2194072/?format=api
{ "id": 2194072, "url": "http://patchwork.ozlabs.org/api/patches/2194072/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260206183813.2573541-2-brian.cain@oss.qualcomm.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260206183813.2573541-2-brian.cain@oss.qualcomm.com>", "list_archive_url": null, "date": "2026-02-06T18:38:11", "name": "[1/3] target/hexagon: Fix invalid duplex decoding", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "9546c7436c69a15edbda8c347fdacb6ed7046e47", "submitter": { "id": 89839, "url": "http://patchwork.ozlabs.org/api/people/89839/?format=api", "name": "Brian Cain", "email": "brian.cain@oss.qualcomm.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260206183813.2573541-2-brian.cain@oss.qualcomm.com/mbox/", "series": [ { "id": 491324, "url": "http://patchwork.ozlabs.org/api/series/491324/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=491324", "date": "2026-02-06T18:38:10", "name": "Handle some invalid encodings", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/491324/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2194072/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2194072/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256\n header.s=qcppdkim1 header.b=H9gI++f1;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.a=rsa-sha256 header.s=google header.b=XsZML12U;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4f72tM6Rs6z1xvm\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 07 Feb 2026 05:39:07 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1voQiv-0001A3-LV; Fri, 06 Feb 2026 13:38:33 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <brian.cain@oss.qualcomm.com>)\n id 1voQio-00018g-AV\n for qemu-devel@nongnu.org; Fri, 06 Feb 2026 13:38:27 -0500", "from mx0a-0031df01.pphosted.com ([205.220.168.131])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <brian.cain@oss.qualcomm.com>)\n id 1voQik-0008Cq-QZ\n for qemu-devel@nongnu.org; Fri, 06 Feb 2026 13:38:26 -0500", "from pps.filterd (m0279862.ppops.net [127.0.0.1])\n by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 616Glx9h2313831\n for <qemu-devel@nongnu.org>; Fri, 6 Feb 2026 18:38:19 GMT", "from mail-dy1-f197.google.com (mail-dy1-f197.google.com\n [74.125.82.197])\n by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c52mrkx3p-1\n (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT)\n for <qemu-devel@nongnu.org>; Fri, 06 Feb 2026 18:38:18 +0000 (GMT)", "by mail-dy1-f197.google.com with SMTP id\n 5a478bee46e88-2b7eddde359so1339450eec.0\n for <qemu-devel@nongnu.org>; Fri, 06 Feb 2026 10:38:18 -0800 (PST)", "from hu-bcain-lv.qualcomm.com (Global_NAT1.qualcomm.com.\n [129.46.96.20]) by smtp.gmail.com with ESMTPSA id\n 5a478bee46e88-2b855c3c846sm2270605eec.16.2026.02.06.10.38.16\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 06 Feb 2026 10:38:16 -0800 (PST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h=\n cc:content-transfer-encoding:content-type:date:from:in-reply-to\n :message-id:mime-version:references:subject:to; s=qcppdkim1; bh=\n i2JHn+EgmNjdP4REanm9c3H86iyltIkYUZFkiRNficU=; b=H9gI++f1XDDVIw9d\n NpB8tHL6F6KgCxG3nKt3WqkHMKt9svFAtvaBrHJOE6XdIidRr/IBLLdKw94ra+KQ\n Ni+WbrFdnlZRInV9rHvCsbQgdoU5241aebWwbVcZYGH7FYmTTr6q/+CvGv3R7ek7\n hBBXno9QerOa7Oh3dG/4r5ZMUQS0T9hijfSdvDaBoF0c0raupMjQULhT3ki8Fq8n\n Uh0VC06j2rifcndvluhqXa+xZ6I0aMDkey7yJ1ouiXFgCG1Mo5Exmf7aobhv35uV\n prp8BlN3jYSvXosPJe5tbg1AEq/3LNC+t5z8BxxElDi68j595l9q+sZOiDffgpP1\n QdP9UA==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=oss.qualcomm.com; s=google; t=1770403098; x=1771007898; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=i2JHn+EgmNjdP4REanm9c3H86iyltIkYUZFkiRNficU=;\n b=XsZML12U/xsVAu22dr3OKmpShuzV8rURkoD8b0F3VvO5G4v48rDXiGO9Q3ocA0gAr6\n x61KvHGlver4ubSqm8nzrvdmLimsw/rL2KWs1x37t7AhSECzrvnFrfC5NniZhKm79wYE\n soQbgv4ISshNBhqOqwuVXkD5KJE2Dukc+BhUkQ8rvJjuWP6SZdwPqzdostqBq2ku1vie\n Ibcg2DVWCnkqc67beC8fDdQgkiIwefcGsIz8BU+E3NgSMck9SEHAjrVYF5xmc0+r05cY\n cDph2nV7sFmhlslSpp69pH60h3k3zQkDI1JFffPc1CD2W8Oit/x+GaqZmkvJRYnGVCvu\n 2/nw==" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1770403098; x=1771007898;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=i2JHn+EgmNjdP4REanm9c3H86iyltIkYUZFkiRNficU=;\n b=ff77znmEX7sMCJQg3ucJARtUqnCBmLnCwFilKsK99U7Vm6J2XZvDK61FDa8YMwIDa/\n LBWKs5QGyxjqBHdvLWqdLAwQ7t9UfYGiYeiYnkUwWZkCbMnt0a9o5Ey+7XbnXd8ISq2I\n sTejNDP+58G9v7+Xe/mZc0+WcWvQfdubYL8H2R2EjE/SJDi0+YVhdfQFtlo1M4caaZt+\n zrSWYLZZiFdLH2OMMM/yG8HMGELZkzpsss6A/mE+yS851/JN/eDuhe2R/+nZvdpzkgEU\n 4g614dIJ+V8jyaA39+BJUjZkq03OT0qwiIJ0jNqkPhGCUU4cbWiFccqlklpinrkk4XKl\n jYtg==", "X-Gm-Message-State": "AOJu0YweyrrJzI/4tKo2tHMElNwbxxNvnyu2A7z60FIcehwsxVRxBW0i\n q8Eg0bNRxqaQNctmntTprUYxRgFZbKnYGYOfyGTt0Yu6+5xoBdtsgVkb7HUgyJiGW3s7zmgmU4g\n E6Hbmk+fcdM1ndoIC9znlj6L0mpakQIgl1sLSD6rkOJZy++98FD3i9rf2ItpyvPb+OQ==", "X-Gm-Gg": "AZuq6aJB35Lh38Z4mu34TUq+yyyPF6oiTHj1tF+8f7Lt/MNXopQ0hWstV4ZC8pXDzGB\n nnxJA6uW2mATp9dkBprIv4rW2lznqKiKxIMLlbFj2TMzMjuSPBgSYfb60xaqS9q6x413xBFgsER\n 5rxCq9iX4FAdPZQYS5mI8OWKk39OWT1E4rcx0oMFzNEdVycjnW6VdF+WzIROKKlzPNFjPozGKUb\n 5Ri5C2uAoC26aSHbdJKspI4qPmU+X6FPYi1Rg4zsq+O5L641uCfC84/Xev9F2QtLcCzVVkGCog7\n 8mcWRqOsldzAjuR5GNiMBIIuVKuyRRvYF+GtNISgllh+o2V0yIxOtWA+I5+eyBVNoLObo+nfXjG\n JC826SyEHwG7rPy12JKTSIoUdpf81JYd5q14hpnZQOaAMRpaYvvUwu8VqNQ==", "X-Received": [ "by 2002:a05:7300:641f:b0:2b7:2bbd:95c0 with SMTP id\n 5a478bee46e88-2b85683463amr1454039eec.35.1770403097817;\n Fri, 06 Feb 2026 10:38:17 -0800 (PST)", "by 2002:a05:7300:641f:b0:2b7:2bbd:95c0 with SMTP id\n 5a478bee46e88-2b85683463amr1454023eec.35.1770403097143;\n Fri, 06 Feb 2026 10:38:17 -0800 (PST)" ], "From": "Brian Cain <brian.cain@oss.qualcomm.com>", "To": "qemu-devel@nongnu.org", "Cc": "brian.cain@oss.qualcomm.com, ltaylorsimpson@gmail.com, alex@alexrp.com,\n Brian Cain <bcain@quicinc.com>, Laurent Vivier <laurent@vivier.eu>,\n Pierrick Bouvier <pierrick.bouvier@linaro.org>", "Subject": "[PATCH 1/3] target/hexagon: Fix invalid duplex decoding", "Date": "Fri, 6 Feb 2026 10:38:11 -0800", "Message-Id": "<20260206183813.2573541-2-brian.cain@oss.qualcomm.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20260206183813.2573541-1-brian.cain@oss.qualcomm.com>", "References": "<20260206183813.2573541-1-brian.cain@oss.qualcomm.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "X-Proofpoint-Spam-Details-Enc": "AW1haW4tMjYwMjA2MDEzNyBTYWx0ZWRfX+Yy119dDYbcF\n yahO2bnvT9Agrv9SsQoXgdDvR1alTwGW4A2tDfYLxmuXRu0lwmTQHlhOeM8Cqnb9qrB2yqQzm0Q\n mYcvj3maL7GX42yk/A2oT3x7yE0VY06C+YXdKHTyf4Rgn5dJU3zgYxkoVM0NvrM9Xm/M/xLRVaI\n QDpWaGG1ZwvuVT9eADZURDfLtjQF3dUSnTHJ+rdaCZVsg8wPdCeer8YjX07XxdLeDSxYGMey/Wz\n ma6X39J+edqvX8BNLoULrKCKNuwg3aZQW91AvEGiMcwAMU9Ur+nvxtLdKxg51whWS37oinbOgCY\n iatJGJlaZcfkIjUe6LO58U5hOnd+/8fXKifRoL26K6dA9tcBZT1Aj3aRPGBYYwQwrrf6SjLNuYG\n HItBrDNiZ77FCgFNd0UIrotS+gOkDlwf1viWLIQ1/YMVnh1rc2dVaiaqXh/arwcT5xhOjmzUin4\n ttu/cdV9tFTjEbHiPag==", "X-Proofpoint-GUID": "3k38DMx9oue2r_Z_6aDchk1T4BMKtYqL", "X-Authority-Analysis": "v=2.4 cv=e4kLiKp/ c=1 sm=1 tr=0 ts=6986351a cx=c_pps\n a=Uww141gWH0fZj/3QKPojxA==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17\n a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10\n a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22\n a=p0WdMEafAAAA:8 a=COk6AnOGAAAA:8 a=OCWrEZw6VeUBrM89gJgA:9 a=QEXdDO2ut3YA:10\n a=PxkB5W3o20Ba91AHUih5:22 a=TjNXssC_j7lpFel5tvFf:22", "X-Proofpoint-ORIG-GUID": "3k38DMx9oue2r_Z_6aDchk1T4BMKtYqL", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-02-06_05,2026-02-05_03,2025-10-01_01", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n impostorscore=0 phishscore=0 clxscore=1015 adultscore=0 malwarescore=0\n bulkscore=0 spamscore=0 lowpriorityscore=0 suspectscore=0 priorityscore=1501\n classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0\n reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602060137", "Received-SPF": "pass client-ip=205.220.168.131;\n envelope-from=brian.cain@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com", "X-Spam_score_int": "-27", "X-Spam_score": "-2.8", "X-Spam_bar": "--", "X-Spam_report": "(-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "When decoding a duplex instruction, if the slot0 sub-instruction fails\nto decode after slot1 succeeds, QEMU was leaving the packet in a\npartially-decoded state. This allowed invalid duplex encodings (where\none sub-instruction doesn't match any valid pattern) to be executed\nincorrectly.\n\nFix by resetting the decoder state when slot0 fails, returning an empty\ninstruction that triggers an exception.\n\nAdd gen_exception_decode_fail() for raising exceptions when decode fails\nbefore ctx->next_PC is initialized. This keeps gen_exception_end_tb()\nsemantics unchanged (it continues to use ctx->next_PC for the exception\nPC after successful decode).\n\nUpdate the invalid-slots test to expect SIGILL (exit code 132) instead\nof the old exit(1) behavior now that the exception is properly handled.\nAdd invalid-duplex test for the specific case of invalid duplex encoding\nafter immext.\n\nResolves: https://gitlab.com/qemu-project/qemu/-/issues/3291\nSigned-off-by: Brian Cain <bcain@quicinc.com>\n---\n linux-user/hexagon/cpu_loop.c | 4 ++++\n target/hexagon/decode.c | 13 +++++++++++--\n target/hexagon/translate.c | 18 ++++++++++++++++--\n tests/tcg/hexagon/invalid-duplex.c | 28 ++++++++++++++++++++++++++++\n tests/tcg/hexagon/Makefile.target | 11 ++++++++++-\n 5 files changed, 69 insertions(+), 5 deletions(-)\n create mode 100644 tests/tcg/hexagon/invalid-duplex.c", "diff": "diff --git a/linux-user/hexagon/cpu_loop.c b/linux-user/hexagon/cpu_loop.c\nindex 1941f4c9c1..c0e1098e3f 100644\n--- a/linux-user/hexagon/cpu_loop.c\n+++ b/linux-user/hexagon/cpu_loop.c\n@@ -64,6 +64,10 @@ void cpu_loop(CPUHexagonState *env)\n force_sig_fault(TARGET_SIGBUS, TARGET_BUS_ADRALN,\n env->gpr[HEX_REG_R31]);\n break;\n+ case HEX_CAUSE_INVALID_PACKET:\n+ force_sig_fault(TARGET_SIGILL, TARGET_ILL_ILLOPC,\n+ env->gpr[HEX_REG_PC]);\n+ break;\n case EXCP_ATOMIC:\n cpu_exec_step_atomic(cs);\n break;\ndiff --git a/target/hexagon/decode.c b/target/hexagon/decode.c\nindex b5ece60450..69ba1ec96c 100644\n--- a/target/hexagon/decode.c\n+++ b/target/hexagon/decode.c\n@@ -509,8 +509,14 @@ decode_insns(DisasContext *ctx, Insn *insn, uint32_t encoding)\n insn->iclass = iclass_bits(encoding);\n return 2;\n }\n+ /*\n+ * Slot0 decode failed after slot1 succeeded. This is an invalid\n+ * duplex encoding (both sub-instructions must be valid).\n+ */\n+ ctx->insn = --insn;\n }\n- g_assert_not_reached();\n+ /* Invalid duplex encoding - return 0 to signal failure */\n+ return 0;\n }\n }\n \n@@ -674,7 +680,10 @@ int decode_packet(DisasContext *ctx, int max_words, const uint32_t *words,\n encoding32 = words[words_read];\n end_of_packet = is_packet_end(encoding32);\n new_insns = decode_insns(ctx, insn, encoding32);\n- g_assert(new_insns > 0);\n+ if (new_insns == 0) {\n+ /* Invalid instruction encoding */\n+ return 0;\n+ }\n /*\n * If we saw an extender, mark next word extended so immediate\n * decode works\ndiff --git a/target/hexagon/translate.c b/target/hexagon/translate.c\nindex e88e19cc1a..7fe8b35351 100644\n--- a/target/hexagon/translate.c\n+++ b/target/hexagon/translate.c\n@@ -195,7 +195,21 @@ static void gen_exception_end_tb(DisasContext *ctx, int excp)\n tcg_gen_movi_tl(hex_gpr[HEX_REG_PC], ctx->next_PC);\n gen_exception_raw(excp);\n ctx->base.is_jmp = DISAS_NORETURN;\n+}\n \n+/*\n+ * Generate exception for decode failures. Unlike gen_exception_end_tb,\n+ * this is used when decode fails before ctx->next_PC is initialized.\n+ */\n+static void gen_exception_decode_fail(DisasContext *ctx, int nwords, int excp)\n+{\n+ target_ulong fail_pc = ctx->base.pc_next + nwords * sizeof(uint32_t);\n+\n+ gen_exec_counters(ctx);\n+ tcg_gen_movi_tl(hex_gpr[HEX_REG_PC], fail_pc);\n+ gen_exception_raw(excp);\n+ ctx->base.is_jmp = DISAS_NORETURN;\n+ ctx->base.pc_next = fail_pc;\n }\n \n static int read_packet_words(CPUHexagonState *env, DisasContext *ctx,\n@@ -935,7 +949,7 @@ static void decode_and_translate_packet(CPUHexagonState *env, DisasContext *ctx)\n \n nwords = read_packet_words(env, ctx, words);\n if (!nwords) {\n- gen_exception_end_tb(ctx, HEX_CAUSE_INVALID_PACKET);\n+ gen_exception_decode_fail(ctx, 0, HEX_CAUSE_INVALID_PACKET);\n return;\n }\n \n@@ -950,7 +964,7 @@ static void decode_and_translate_packet(CPUHexagonState *env, DisasContext *ctx)\n gen_commit_packet(ctx);\n ctx->base.pc_next += pkt.encod_pkt_size_in_bytes;\n } else {\n- gen_exception_end_tb(ctx, HEX_CAUSE_INVALID_PACKET);\n+ gen_exception_decode_fail(ctx, nwords, HEX_CAUSE_INVALID_PACKET);\n }\n }\n \ndiff --git a/tests/tcg/hexagon/invalid-duplex.c b/tests/tcg/hexagon/invalid-duplex.c\nnew file mode 100644\nindex 0000000000..88ad5024e9\n--- /dev/null\n+++ b/tests/tcg/hexagon/invalid-duplex.c\n@@ -0,0 +1,28 @@\n+/*\n+ * Test that invalid duplex encodings are properly rejected.\n+ *\n+ * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.\n+ * SPDX-License-Identifier: GPL-2.0-or-later\n+ */\n+\n+/*\n+ * This test uses an invalid packet encoding where:\n+ * - Word 0: 0x0fff6fff = immext(#0xfffbffc0), parse bits = 01\n+ * - Word 1: 0x600237b0 = duplex with:\n+ * - slot0 = 0x17b0 (invalid S2 subinstruction encoding)\n+ * - slot1 = 0x0002 (valid SA1_addi)\n+ * - duplex iclass = 7 (S2 for slot0, A for slot1)\n+ *\n+ * Since slot0 doesn't decode to any valid S2 subinstruction, this packet\n+ * should be rejected and raise SIGILL.\n+ */\n+\n+int main()\n+{\n+ asm volatile(\n+ /* Invalid packet: immext followed by duplex with invalid slot0 */\n+ \".word 0x0fff6fff\\n\" /* immext(#0xfffbffc0), parse=01 */\n+ \".word 0x600237b0\\n\" /* duplex: slot0=0x17b0 (invalid), slot1=0x0002 */\n+ : : : \"memory\");\n+ return 0;\n+}\ndiff --git a/tests/tcg/hexagon/Makefile.target b/tests/tcg/hexagon/Makefile.target\nindex e5182c01d8..b0e20139c2 100644\n--- a/tests/tcg/hexagon/Makefile.target\n+++ b/tests/tcg/hexagon/Makefile.target\n@@ -51,13 +51,22 @@ HEX_TESTS += scatter_gather\n HEX_TESTS += hvx_misc\n HEX_TESTS += hvx_histogram\n HEX_TESTS += invalid-slots\n+HEX_TESTS += invalid-duplex\n HEX_TESTS += unaligned_pc\n \n run-and-check-exception = $(call run-test,$2,$3 2>$2.stderr; \\\n \ttest $$? -eq 1 && grep -q \"exception $(strip $1)\" $2.stderr)\n \n+# Check that command dies from SIGILL (exit code = 128 + 4 = 132)\n run-invalid-slots: invalid-slots\n-\t$(call run-and-check-exception, 0x15, $@, $(QEMU) $(QEMU_OPTS) $<)\n+\t$(call quiet-command, \\\n+\t\t$(QEMU) $(QEMU_OPTS) $< ; test $$? -eq 132, \\\n+\t\tTEST, invalid-slots on $(TARGET_NAME))\n+\n+run-invalid-duplex: invalid-duplex\n+\t$(call quiet-command, \\\n+\t\t$(QEMU) $(QEMU_OPTS) $< ; test $$? -eq 132, \\\n+\t\tTEST, invalid-duplex on $(TARGET_NAME))\n \n HEX_TESTS += test_abs\n HEX_TESTS += test_bitcnt\n", "prefixes": [ "1/3" ] }