Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2194071/?format=api
{ "id": 2194071, "url": "http://patchwork.ozlabs.org/api/patches/2194071/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260206183813.2573541-4-brian.cain@oss.qualcomm.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260206183813.2573541-4-brian.cain@oss.qualcomm.com>", "list_archive_url": null, "date": "2026-02-06T18:38:13", "name": "[3/3] target/hexagon: Return decode failure for invalid non-duplex encodings", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "35f6058554cb0a47fb94c55af63386171890e7ac", "submitter": { "id": 89839, "url": "http://patchwork.ozlabs.org/api/people/89839/?format=api", "name": "Brian Cain", "email": "brian.cain@oss.qualcomm.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260206183813.2573541-4-brian.cain@oss.qualcomm.com/mbox/", "series": [ { "id": 491324, "url": "http://patchwork.ozlabs.org/api/series/491324/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=491324", "date": "2026-02-06T18:38:10", "name": "Handle some invalid encodings", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/491324/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2194071/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2194071/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256\n header.s=qcppdkim1 header.b=jYRSDYZP;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.a=rsa-sha256 header.s=google header.b=ZVqmQZEX;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4f72tM4B5hz1xvh\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 07 Feb 2026 05:39:07 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1voQiv-0001A2-KM; Fri, 06 Feb 2026 13:38:33 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <brian.cain@oss.qualcomm.com>)\n id 1voQin-00018c-RE\n for qemu-devel@nongnu.org; Fri, 06 Feb 2026 13:38:26 -0500", "from mx0a-0031df01.pphosted.com ([205.220.168.131])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <brian.cain@oss.qualcomm.com>)\n id 1voQik-0008D4-QZ\n for qemu-devel@nongnu.org; Fri, 06 Feb 2026 13:38:25 -0500", "from pps.filterd (m0279867.ppops.net [127.0.0.1])\n by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 616EqpGn2483302\n for <qemu-devel@nongnu.org>; Fri, 6 Feb 2026 18:38:20 GMT", "from mail-dy1-f200.google.com (mail-dy1-f200.google.com\n [74.125.82.200])\n by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c5c1722t4-1\n (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT)\n for <qemu-devel@nongnu.org>; Fri, 06 Feb 2026 18:38:20 +0000 (GMT)", "by mail-dy1-f200.google.com with SMTP id\n 5a478bee46e88-2b83787af4cso18451658eec.1\n for <qemu-devel@nongnu.org>; Fri, 06 Feb 2026 10:38:20 -0800 (PST)", "from hu-bcain-lv.qualcomm.com (Global_NAT1.qualcomm.com.\n [129.46.96.20]) by smtp.gmail.com with ESMTPSA id\n 5a478bee46e88-2b855c3c846sm2270605eec.16.2026.02.06.10.38.18\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 06 Feb 2026 10:38:18 -0800 (PST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h=\n cc:content-transfer-encoding:content-type:date:from:in-reply-to\n :message-id:mime-version:references:subject:to; s=qcppdkim1; bh=\n LeWn/rnkeIdof3Uh+foZY8TtCF2GD38j3/bVb9HIVR0=; b=jYRSDYZPXg9OvXXA\n DEWPObVU1TeZOvIZWnuM41+PST5DHKRxIDIIbCI3sZTXXt7S6ytBg04ubydacrMs\n wgfIudNVCWolxIO+fERpIR8vUl/ZK4iVZ/AG63lhIhsIBSRNkC0GEn74t0KCtMC8\n K8aDoJXVfaPhcYzfx8jv55MIbc1CL053xs2PW69/Vdfy/o+F31BJk3d9rcOvE1EM\n dvy6g4EAJXXmVTqVhgLR1QxHZ9XhIKrqLzey33YIDenblYP/cLQOTBzg+DmSgHzu\n Y1JlX0d1UwOp3oIwH0Jj0KuWwXmDQepdSllfnDx/b4lks44vEgTEPw//JwhgGDjv\n ziq8Fw==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=oss.qualcomm.com; s=google; t=1770403100; x=1771007900; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=LeWn/rnkeIdof3Uh+foZY8TtCF2GD38j3/bVb9HIVR0=;\n b=ZVqmQZEX+MzKJrorfxe7NI+o2Ofqkc+u5wSKiCVbcvlRiJ1vTHlb3z25ASS3PUy4UH\n eMz/ZTfx7FNf+6BTk7Bg0KYSv5Ujs3UBRmj7HuRBJ4CxA36sH7VYA//IHb1elLbg63a8\n kVBtT6GpsKfH5Syy7e8wRovIJOvBfCZOppLYHP8QZ9dL701SiA2MAO/rRKdlU80Qf7Lx\n yHQHqKoW7O0tb2G6C1WvrOyMPv0uK9fVxBcstxdffeG7cHq/d97aB2OHKK1YK8/WVw1j\n zCJFRXOBdqyj4l8Z5dMNSkZxxZqmLPFQOBSQHEwKgOxqh7lTFkNrtbZmR1uXayiErPLf\n 8VLg==" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1770403100; x=1771007900;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=LeWn/rnkeIdof3Uh+foZY8TtCF2GD38j3/bVb9HIVR0=;\n b=ldZ7E8vEPZf18yCL31pPX45BYKJyyM+UZBtUrJ73oAFpw0+DVjcDtL4vXdraYx9nl4\n gJrlMVi61VQl1BVRo1abXYq8nldZeWL75yp1v02edlWYNyAeYOBKUK5E7kNN2J0JnslX\n raONUeqh7C2m9vkoyCpEkuWvzDXkAHN7uudwFybAcjCKzxw2MrUzFoe6dHqRfiBFHs68\n TfGb5RsCvGwY5FRPEFJSYnl0tOGFa6xQHm871UUGz9XAkgkmLcbNHCt0cdac9rEuHEsZ\n p8p/x79oY8/lfG9Wbuho4GUkCh1Y0ry9jsvJQSwNwCbNCcaArlhYei7CPvIRjLTTxNsw\n Ok1w==", "X-Gm-Message-State": "AOJu0YyctbXzB36iBke96FyebIK6bT+EKP7YNFnqo31TaM0rw5HO1fzG\n NVPhI0qGzDcvP1N0z+W5dN8rEyS5W7l83OtaY5PvoiwJR6fw8AUrL0FL/5DHv0Kgu34QbjFRuq5\n JvK0J/FDlgKLRIAMOig7cbwmLUZP/zI7/Dl5kdyVl3RgaR4bl2RJ5sFf0ue/IxDdyHQ==", "X-Gm-Gg": "AZuq6aLyiBv+cEmpORRWmdgDPwWUKQ9Po1pqOWKFLobmnFm0zgHUa7PmAZihEFR5OLY\n wsfiIkNNuUm0P9wKiKDnBQiuQZjqkon/5SNy7GkGER7drMBPcLrwznqKViF5naWGDOy5c87T1F7\n 3GbqEsBqwTu6HQE74R2+xR/zZE4Be/35yMaIejZ4z81+01p3Ai1yBtZgwUEGBcGum109Uc8f/lf\n gfGnjiwYOCSCbedBeA9zlEodGNqrgtKScCY4AnEEOjvZ5Qsoz1oFbvM6bQhxOOlrAo6hmq91IhP\n U1bRHvqP/Rai83ScDqOSQjYG9Jiem5hKN8e170oE+lWiq/U7a+xqpJUfyCfkE1b7NyVFRHABRvE\n UDwZjSTOnIPYQ/PPCPCDdSgB0I6UQAPBt9DigZFDRC+cM0mNgNvEyyZuxJQ==", "X-Received": [ "by 2002:a05:7301:3f18:b0:2ae:5b54:523e with SMTP id\n 5a478bee46e88-2b856a456b1mr1389008eec.40.1770403099558;\n Fri, 06 Feb 2026 10:38:19 -0800 (PST)", "by 2002:a05:7301:3f18:b0:2ae:5b54:523e with SMTP id\n 5a478bee46e88-2b856a456b1mr1388996eec.40.1770403099037;\n Fri, 06 Feb 2026 10:38:19 -0800 (PST)" ], "From": "Brian Cain <brian.cain@oss.qualcomm.com>", "To": "qemu-devel@nongnu.org", "Cc": "brian.cain@oss.qualcomm.com, ltaylorsimpson@gmail.com, alex@alexrp.com", "Subject": "[PATCH 3/3] target/hexagon: Return decode failure for invalid\n non-duplex encodings", "Date": "Fri, 6 Feb 2026 10:38:13 -0800", "Message-Id": "<20260206183813.2573541-4-brian.cain@oss.qualcomm.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20260206183813.2573541-1-brian.cain@oss.qualcomm.com>", "References": "<20260206183813.2573541-1-brian.cain@oss.qualcomm.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "X-Proofpoint-GUID": "sa-K_pRTalGw6htUUTbOUsrraS3oAzlJ", "X-Proofpoint-Spam-Details-Enc": "AW1haW4tMjYwMjA2MDEzNyBTYWx0ZWRfX/rv+nIsclXeZ\n o1nqtlcB/jJetVo3sURjmCJUOHnxe/wwAzTyW2b/cUginmsHi2Wm4b2cgUQO/emh+OaL2ERigK/\n GlC+kntO16gN39VaELlo83jkfYPI+EWTsTZr0THpH700zzT0X90Cw4W4I+ZFvHQAskkK4Kjtmm0\n mVsK7Kjt0sECaM0Ur+UTeWWNCm02hO5w8yTfF5yl2Nh5G3ayzhAgs2nElfcajVPBAd8cfCh7l9C\n pp952L2C77E1Kcc295LgWPHvuwlUIqHkiJNcGz5QE0OOFAtxF3U8cbk0HpEPHWMV9rXKhErs3OB\n mRNZgmk8AEYOJHt9ssPrw9z4zJRVVlw1w2P3BtkDlR5NVqG+kHkddogaGhZq/+pU0CeXDlG9GWv\n 6a+Xpvod1bqeoULxOFKs3X+MBy1de4AOKy3+4W7s3aFpmnqBx12Ntgn6q0ybcBwkowAbBUqAJAj\n SDb15pyBhQImUlCy98A==", "X-Proofpoint-ORIG-GUID": "sa-K_pRTalGw6htUUTbOUsrraS3oAzlJ", "X-Authority-Analysis": "v=2.4 cv=E7TAZKdl c=1 sm=1 tr=0 ts=6986351c cx=c_pps\n a=PfFC4Oe2JQzmKTvty2cRDw==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17\n a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10\n a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22\n a=EUspDBNiAAAA:8 a=JVcbmikgOCOOM7YXfUEA:9 a=QEXdDO2ut3YA:10\n a=6Ab_bkdmUrQuMsNx7PHu:22", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-02-06_05,2026-02-05_03,2025-10-01_01", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n malwarescore=0 adultscore=0 spamscore=0 clxscore=1015 bulkscore=0\n phishscore=0 priorityscore=1501 suspectscore=0 impostorscore=0\n lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc=\n route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000\n definitions=main-2602060137", "Received-SPF": "pass client-ip=205.220.168.131;\n envelope-from=brian.cain@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com", "X-Spam_score_int": "-27", "X-Spam_score": "-2.8", "X-Spam_bar": "--", "X-Spam_report": "(-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "When a non-duplex encoding (parse_bits != 0) fails both decode_normal()\nand decode_hvx(), the decoder hit an unreachable. Instead, handle\nthe decode failure and raise an exception.\n\nSigned-off-by: Brian Cain <brian.cain@oss.qualcomm.com>\n---\n target/hexagon/decode.c | 3 ++-\n tests/tcg/hexagon/invalid-encoding.c | 20 ++++++++++++++++++++\n tests/tcg/hexagon/Makefile.target | 6 ++++++\n 3 files changed, 28 insertions(+), 1 deletion(-)\n create mode 100644 tests/tcg/hexagon/invalid-encoding.c", "diff": "diff --git a/target/hexagon/decode.c b/target/hexagon/decode.c\nindex 90499fc320..ebb4e02a17 100644\n--- a/target/hexagon/decode.c\n+++ b/target/hexagon/decode.c\n@@ -489,7 +489,8 @@ decode_insns(DisasContext *ctx, Insn *insn, uint32_t encoding)\n insn->iclass = iclass_bits(encoding);\n return 1;\n }\n- g_assert_not_reached();\n+ /* Invalid non-duplex encoding */\n+ return 0;\n } else {\n uint32_t iclass = get_duplex_iclass(encoding);\n unsigned int slot0_subinsn = get_slot0_subinsn(encoding);\ndiff --git a/tests/tcg/hexagon/invalid-encoding.c b/tests/tcg/hexagon/invalid-encoding.c\nnew file mode 100644\nindex 0000000000..efe914b4e4\n--- /dev/null\n+++ b/tests/tcg/hexagon/invalid-encoding.c\n@@ -0,0 +1,20 @@\n+/*\n+ * Test that invalid non-duplex encodings are properly rejected.\n+ *\n+ * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.\n+ * SPDX-License-Identifier: GPL-2.0-or-later\n+ */\n+\n+/*\n+ * The encoding 0xffffc000 has parse bits [15:14] = 0b11, making it a\n+ * non-duplex instruction and packet end. The remaining bits do not match\n+ * any valid normal or HVX instruction encoding, so this should raise SIGILL.\n+ */\n+\n+int main()\n+{\n+ asm volatile(\n+ \".word 0xffffc000\\n\"\n+ : : : \"memory\");\n+ return 0;\n+}\ndiff --git a/tests/tcg/hexagon/Makefile.target b/tests/tcg/hexagon/Makefile.target\nindex 7199e29a30..79ebfd56ce 100644\n--- a/tests/tcg/hexagon/Makefile.target\n+++ b/tests/tcg/hexagon/Makefile.target\n@@ -53,6 +53,7 @@ HEX_TESTS += hvx_histogram\n HEX_TESTS += invalid-slots\n HEX_TESTS += invalid-duplex\n HEX_TESTS += invalid-dups\n+HEX_TESTS += invalid-encoding\n HEX_TESTS += unaligned_pc\n \n run-and-check-exception = $(call run-test,$2,$3 2>$2.stderr; \\\n@@ -74,6 +75,11 @@ run-invalid-dups: invalid-dups\n \t\t$(QEMU) $(QEMU_OPTS) $< ; test $$? -eq 132, \\\n \t\tTEST, invalid-dups on $(TARGET_NAME))\n \n+run-invalid-encoding: invalid-encoding\n+\t$(call quiet-command, \\\n+\t\t$(QEMU) $(QEMU_OPTS) $< ; test $$? -eq 132, \\\n+\t\tTEST, invalid-encoding on $(TARGET_NAME))\n+\n HEX_TESTS += test_abs\n HEX_TESTS += test_bitcnt\n HEX_TESTS += test_bitsplit\n", "prefixes": [ "3/3" ] }