Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2194070/?format=api
{ "id": 2194070, "url": "http://patchwork.ozlabs.org/api/patches/2194070/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260206183813.2573541-3-brian.cain@oss.qualcomm.com/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260206183813.2573541-3-brian.cain@oss.qualcomm.com>", "list_archive_url": null, "date": "2026-02-06T18:38:12", "name": "[2/3] target/hexagon: Reject duplex encodings with duplicate dest registers", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "cbba2d2a2aae2b80417668c28d8e99973731e69b", "submitter": { "id": 89839, "url": "http://patchwork.ozlabs.org/api/people/89839/?format=api", "name": "Brian Cain", "email": "brian.cain@oss.qualcomm.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20260206183813.2573541-3-brian.cain@oss.qualcomm.com/mbox/", "series": [ { "id": 491324, "url": "http://patchwork.ozlabs.org/api/series/491324/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=491324", "date": "2026-02-06T18:38:10", "name": "Handle some invalid encodings", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/491324/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2194070/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2194070/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256\n header.s=qcppdkim1 header.b=RXsa9jRG;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.a=rsa-sha256 header.s=google header.b=KY12B6PD;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4f72st5zzqz1xvh\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 07 Feb 2026 05:38:42 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1voQiw-0001AT-Fw; Fri, 06 Feb 2026 13:38:34 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <brian.cain@oss.qualcomm.com>)\n id 1voQim-000186-OE\n for qemu-devel@nongnu.org; Fri, 06 Feb 2026 13:38:24 -0500", "from mx0b-0031df01.pphosted.com ([205.220.180.131])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <brian.cain@oss.qualcomm.com>)\n id 1voQik-0008Cy-QW\n for qemu-devel@nongnu.org; Fri, 06 Feb 2026 13:38:24 -0500", "from pps.filterd (m0279873.ppops.net [127.0.0.1])\n by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 616GxA6j694761\n for <qemu-devel@nongnu.org>; Fri, 6 Feb 2026 18:38:20 GMT", "from mail-dy1-f198.google.com (mail-dy1-f198.google.com\n [74.125.82.198])\n by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c53qvbjbw-1\n (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT)\n for <qemu-devel@nongnu.org>; Fri, 06 Feb 2026 18:38:19 +0000 (GMT)", "by mail-dy1-f198.google.com with SMTP id\n 5a478bee46e88-2b71c5826fbso2512934eec.1\n for <qemu-devel@nongnu.org>; Fri, 06 Feb 2026 10:38:19 -0800 (PST)", "from hu-bcain-lv.qualcomm.com (Global_NAT1.qualcomm.com.\n [129.46.96.20]) by smtp.gmail.com with ESMTPSA id\n 5a478bee46e88-2b855c3c846sm2270605eec.16.2026.02.06.10.38.17\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 06 Feb 2026 10:38:17 -0800 (PST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h=\n cc:content-transfer-encoding:content-type:date:from:in-reply-to\n :message-id:mime-version:references:subject:to; s=qcppdkim1; bh=\n Z1WeDq8iLYhbAxqSSPx1kZ21cBW0C5MfaYx4W488Dm8=; b=RXsa9jRGZEQWqKQ2\n PlAtPp3sa/3TrggOgJvIOCHv2fINDVfPswAblKax4TcTII1sL+6Cc0lflIbhIqg3\n MtjQqKEu90QPAly/9arTOaz7P55QYMz+LWj26XDEYZB17MpjrvI4nO5+53Wg7Uq/\n oEANDI5kiv5G4gMppKe9YdQu3Y2Xw+2T9YO6LjmpmOE3xcTv7cKfdzL1asf5tcuD\n nFdOy7Eno4xOCdTy7fZQ/BALDnVRV1eVZP4pp48ZEwu0Ms0IQ8yXUnTRntekTmAg\n 9hoPRturQsPpsbCU6mh2NB7K7hEW7i2RpHa6WaG73djDLSXTov4C9cn0eidDjNiz\n RdV3TQ==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=oss.qualcomm.com; s=google; t=1770403099; x=1771007899; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=Z1WeDq8iLYhbAxqSSPx1kZ21cBW0C5MfaYx4W488Dm8=;\n b=KY12B6PDWm8oxz0ZL2yvR4aNV4ysMDOGm6Oq57YrxbUtKgIb6ZCYaJbs08JraKP02r\n zD92Jz0a+K6nf5naKqrlLUpYPBiH4zI2ztf5iRIXiUB6eJINChTGr9PA26ET+n6+RFeR\n HZxXRLt2HK5xGb8bHdmuQckUQ+J/JcdJpOgMer/kVCr8EBoEV8PS0AkXxbDakN/MyFO/\n ih9R50BYa+Enb6OXO+Q7Hc62gc0DWAKbHq9KpahoDZRKoOn6x7xsYZFDEBW0AP4u/u3e\n OUS9ryP4eTbFtNnOyqrIvpSEcw9s+Qtn/H0tJ2AUpbho5clml9FwTOo2ennqW0e0uC0U\n 06Ag==" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1770403099; x=1771007899;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=Z1WeDq8iLYhbAxqSSPx1kZ21cBW0C5MfaYx4W488Dm8=;\n b=mYrRNaxRlcsMVTnuqAdXrQP0mx505pe/U+1+Eh1v/frQDYzA29/uMAsg/p+CzIoScL\n Nb+118dBCR/fbFvu2mKkGjBK1+p9p+JP79fBtCBraRU+ZqgTF+PqH/nGItGfIx692nbD\n Ps4rDy1pJI4gtLuiYFKJVVOCTqZ8TAbtLz8qe7WD+gZFo10vxEbjC68yqGjRx166x+pm\n uFFn+0IPO63Cplu2oraUPfwIx00c4EJBu8VinmRFsmctdSnQapMBg/Z2wNtT5QReHdLd\n AEHs5/raS6sKjIAwe6nT4LTtRHQl8XqPSa+EWUtjKwHEXX0KSHM5wDXnVQ98lhZ37RnN\n aQ4w==", "X-Gm-Message-State": "AOJu0YzlN/NAq+/KjUPFHUNueA0grhxR91lh80T1HbyUa2CTRm1guzbF\n rdoOpAaUStxdKAjwnIeFSVdwtjlja6ny4kd3luUx1FBlQY7wF9vFovIESTNcchIHrOSiQU3DuwK\n 301v0MWJ2lvOeDj03IXTNIFfm9GLu2mlZ50Ibgg/IkvlsBuwTd1VJhDk+cal3wpzspg==", "X-Gm-Gg": "AZuq6aIKZqufCjuKoIMHMSu2gSi6GqS0IYz4ebrTz2iS1uvbNbSfuljFL4rijd8fUet\n R9M+Qk//QPYiZfjRxnzc59E9awlUMctDOKJK2GwXELhxSG4PDf+Cvo6eYM6c8zGF0GdqnMKfvL+\n s2XulJ/pwgjncxBJqG408pNASda0UX9VoUJP7KFWPEcse75Wz/gwIA2ij+knx013G27K6i3Y8Ib\n DH262BfNv6aQCFqtKOcblgbJDW10r58tCIWffBqjmTqrAseuBh09TEcnmaCmyDmSmu1YjOkaZtt\n J1Ba8Rn3OFfrWJNnPuug1JdqE8mfX6xgJyqDISJeg71sOdd8YnLWJM47ENlJGeHD4nz1mHqWK9N\n 9OI5rUlpLt3YC7dBkZBlUfmrr+CK5Ij1Wm84olCntEDv5+SzPr6qh0r7vcw==", "X-Received": [ "by 2002:a05:693c:3007:b0:2b8:30b8:58c0 with SMTP id\n 5a478bee46e88-2b8563d810cmr1782344eec.6.1770403098764;\n Fri, 06 Feb 2026 10:38:18 -0800 (PST)", "by 2002:a05:693c:3007:b0:2b8:30b8:58c0 with SMTP id\n 5a478bee46e88-2b8563d810cmr1782325eec.6.1770403098178;\n Fri, 06 Feb 2026 10:38:18 -0800 (PST)" ], "From": "Brian Cain <brian.cain@oss.qualcomm.com>", "To": "qemu-devel@nongnu.org", "Cc": "brian.cain@oss.qualcomm.com, ltaylorsimpson@gmail.com, alex@alexrp.com", "Subject": "[PATCH 2/3] target/hexagon: Reject duplex encodings with duplicate\n dest registers", "Date": "Fri, 6 Feb 2026 10:38:12 -0800", "Message-Id": "<20260206183813.2573541-3-brian.cain@oss.qualcomm.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20260206183813.2573541-1-brian.cain@oss.qualcomm.com>", "References": "<20260206183813.2573541-1-brian.cain@oss.qualcomm.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "X-Authority-Analysis": "v=2.4 cv=TsPrRTXh c=1 sm=1 tr=0 ts=6986351c cx=c_pps\n a=wEP8DlPgTf/vqF+yE6f9lg==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17\n a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10\n a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22\n a=p0WdMEafAAAA:8 a=EUspDBNiAAAA:8 a=ceJ5jWYMHQCwmun8QzEA:9 a=QEXdDO2ut3YA:10\n a=bBxd6f-gb0O0v-kibOvt:22", "X-Proofpoint-ORIG-GUID": "kjI-jDiziXXwngjzJObDydtBAvMtJH9e", "X-Proofpoint-GUID": "kjI-jDiziXXwngjzJObDydtBAvMtJH9e", "X-Proofpoint-Spam-Details-Enc": "AW1haW4tMjYwMjA2MDEzNyBTYWx0ZWRfX3xTdz+Qacqpd\n UfZ/Kf+OKtZuwymT9dmdyuoyDmCQJRoRVyDCRMqKCOP/zP3254Z64U+PBHxOvxPwr2XgLpk/zol\n zS48Avssf7MXjL8liBnnLwyVUlE7LbNr7erncAmEfYiBMcRrWmvoh53ey3fSDSAsaKrNA9oIfFK\n lH3U7ARXXX4DuLK/YYqAqNeoQcR3/9OrFvCY/7H5BP/OsvvD84pruE1biFw5RfDHUuLQxWmFrfQ\n /jVJtMcHIYj3eGp7OzaKZ6ogfMyRG39Kg5W9o8JhejDSASjTgJHn8Kv6mTlJPGqDimI8qJL3Hd0\n U9EetAR3WllFv8DQr3XNUEaunBEE1xxXT+mGHd080yhLzQJoq4VLplkUl9CkaJOg5gfFhoO3C6d\n R3Pm4OOk1jIVGRLnOtwDKm0coLYQXgruqFlq/uSbKrUbY+qrW8hs3Pu8LOgSQ9d8Oyfu+AcMPI1\n /LdY6K8rBjjH86AL+ow==", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-02-06_05,2026-02-05_03,2025-10-01_01", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n adultscore=0 lowpriorityscore=0 phishscore=0 priorityscore=1501\n suspectscore=0 malwarescore=0 bulkscore=0 spamscore=0 clxscore=1015\n impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc=\n route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000\n definitions=main-2602060137", "Received-SPF": "pass client-ip=205.220.180.131;\n envelope-from=brian.cain@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com", "X-Spam_score_int": "-27", "X-Spam_score": "-2.8", "X-Spam_bar": "--", "X-Spam_report": "(-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "qemu development <qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "A duplex encoding like 0x00000000 decodes as two loads that both write r0.\n\nAdd a check in decode_insns() after both sub-instructions decode\nsuccessfully to verify they don't write the same destination register.\n\nResolves: https://gitlab.com/qemu-project/qemu/-/issues/2696\nSigned-off-by: Brian Cain <brian.cain@oss.qualcomm.com>\n---\n target/hexagon/decode.c | 12 ++++++++++++\n tests/tcg/hexagon/invalid-dups.c | 23 +++++++++++++++++++++++\n tests/tcg/hexagon/Makefile.target | 6 ++++++\n 3 files changed, 41 insertions(+)\n create mode 100644 tests/tcg/hexagon/invalid-dups.c", "diff": "diff --git a/target/hexagon/decode.c b/target/hexagon/decode.c\nindex 69ba1ec96c..90499fc320 100644\n--- a/target/hexagon/decode.c\n+++ b/target/hexagon/decode.c\n@@ -501,12 +501,24 @@ decode_insns(DisasContext *ctx, Insn *insn, uint32_t encoding)\n \n /* The slot1 subinsn needs to be in the packet first */\n if (decode_slot1_subinsn(ctx, slot1_subinsn)) {\n+ Insn *slot1_insn = insn;\n insn->generate = opcode_genptr[insn->opcode];\n insn->iclass = iclass_bits(encoding);\n ctx->insn = ++insn;\n if (decode_slot0_subinsn(ctx, slot0_subinsn)) {\n insn->generate = opcode_genptr[insn->opcode];\n insn->iclass = iclass_bits(encoding);\n+ /*\n+ * Check that the two sub-instructions don't write the same\n+ * destination register (e.g., encoding 0x0 decodes as two\n+ * loads both writing R0, which is an invalid packet).\n+ */\n+ if (insn->dest_idx >= 0 && slot1_insn->dest_idx >= 0 &&\n+ insn->regno[insn->dest_idx] ==\n+ slot1_insn->regno[slot1_insn->dest_idx]) {\n+ ctx->insn = --insn;\n+ return 0;\n+ }\n return 2;\n }\n /*\ndiff --git a/tests/tcg/hexagon/invalid-dups.c b/tests/tcg/hexagon/invalid-dups.c\nnew file mode 100644\nindex 0000000000..cb37ef7066\n--- /dev/null\n+++ b/tests/tcg/hexagon/invalid-dups.c\n@@ -0,0 +1,23 @@\n+/*\n+ * Test that duplex encodings with duplicate destination registers are rejected.\n+ *\n+ * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.\n+ * SPDX-License-Identifier: GPL-2.0-or-later\n+ */\n+\n+/*\n+ * The encoding 0x00000000 decodes as a duplex with parse bits [15:14] = 0b00:\n+ * slot1: SL1_loadri_io R0 = memw(R0+#0x0)\n+ * slot0: SL1_loadri_io R0 = memw(R0+#0x0)\n+ *\n+ * Both sub-instructions write R0, which is an invalid packet (duplicate\n+ * destination register). This should raise SIGILL.\n+ */\n+\n+int main()\n+{\n+ asm volatile(\n+ \".word 0x00000000\\n\"\n+ : : : \"r0\", \"memory\");\n+ return 0;\n+}\ndiff --git a/tests/tcg/hexagon/Makefile.target b/tests/tcg/hexagon/Makefile.target\nindex b0e20139c2..7199e29a30 100644\n--- a/tests/tcg/hexagon/Makefile.target\n+++ b/tests/tcg/hexagon/Makefile.target\n@@ -52,6 +52,7 @@ HEX_TESTS += hvx_misc\n HEX_TESTS += hvx_histogram\n HEX_TESTS += invalid-slots\n HEX_TESTS += invalid-duplex\n+HEX_TESTS += invalid-dups\n HEX_TESTS += unaligned_pc\n \n run-and-check-exception = $(call run-test,$2,$3 2>$2.stderr; \\\n@@ -68,6 +69,11 @@ run-invalid-duplex: invalid-duplex\n \t\t$(QEMU) $(QEMU_OPTS) $< ; test $$? -eq 132, \\\n \t\tTEST, invalid-duplex on $(TARGET_NAME))\n \n+run-invalid-dups: invalid-dups\n+\t$(call quiet-command, \\\n+\t\t$(QEMU) $(QEMU_OPTS) $< ; test $$? -eq 132, \\\n+\t\tTEST, invalid-dups on $(TARGET_NAME))\n+\n HEX_TESTS += test_abs\n HEX_TESTS += test_bitcnt\n HEX_TESTS += test_bitsplit\n", "prefixes": [ "2/3" ] }