Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2192316/?format=api
{ "id": 2192316, "url": "http://patchwork.ozlabs.org/api/patches/2192316/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260203125417.37285-8-takkozu@amazon.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260203125417.37285-8-takkozu@amazon.com>", "list_archive_url": null, "date": "2026-02-03T12:54:13", "name": "[iwl-next,v6,3/3] igb: allow configuring RSS key via ethtool set_rxfh", "commit_ref": null, "pull_url": null, "state": "under-review", "archived": false, "hash": "01084c197379226f71a7136440ad885f52d0a682", "submitter": { "id": 92211, "url": "http://patchwork.ozlabs.org/api/people/92211/?format=api", "name": "Takashi Kozu", "email": "takkozu@amazon.com" }, "delegate": { "id": 109701, "url": "http://patchwork.ozlabs.org/api/users/109701/?format=api", "username": "anguy11", "first_name": "Anthony", "last_name": "Nguyen", "email": "anthony.l.nguyen@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260203125417.37285-8-takkozu@amazon.com/mbox/", "series": [ { "id": 490796, "url": "http://patchwork.ozlabs.org/api/series/490796/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=490796", "date": "2026-02-03T12:54:10", "name": "igb: add RSS key get/set support", "version": 6, "mbox": "http://patchwork.ozlabs.org/series/490796/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2192316/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2192316/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=mRF4aJdg;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::136; helo=smtp3.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4f53Pj02xWz1xqf\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 03 Feb 2026 23:55:53 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 9818260896;\n\tTue, 3 Feb 2026 12:55:51 +0000 (UTC)", "from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id iVswsnF0xqKL; Tue, 3 Feb 2026 12:55:51 +0000 (UTC)", "from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id D4F1D60893;\n\tTue, 3 Feb 2026 12:55:50 +0000 (UTC)", "from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136])\n by lists1.osuosl.org (Postfix) with ESMTP id E9D73F5\n for <intel-wired-lan@lists.osuosl.org>; Tue, 3 Feb 2026 12:55:49 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp3.osuosl.org (Postfix) with ESMTP id D797160873\n for <intel-wired-lan@lists.osuosl.org>; Tue, 3 Feb 2026 12:55:49 +0000 (UTC)", "from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id Y-pIm2KgIXWa for <intel-wired-lan@lists.osuosl.org>;\n Tue, 3 Feb 2026 12:55:49 +0000 (UTC)", "from pdx-out-003.esa.us-west-2.outbound.mail-perimeter.amazon.com\n (pdx-out-003.esa.us-west-2.outbound.mail-perimeter.amazon.com\n [44.246.68.102])\n by smtp3.osuosl.org (Postfix) with ESMTPS id E12E66086D\n for <intel-wired-lan@lists.osuosl.org>; Tue, 3 Feb 2026 12:55:48 +0000 (UTC)", "from ip-10-5-12-219.us-west-2.compute.internal (HELO\n smtpout.naws.us-west-2.prod.farcaster.email.amazon.dev) ([10.5.12.219])\n by internal-pdx-out-003.esa.us-west-2.outbound.mail-perimeter.amazon.com with\n ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Feb 2026 12:55:46 +0000", "from EX19MTAUWB001.ant.amazon.com [205.251.233.104:29351]\n by smtpin.naws.us-west-2.prod.farcaster.email.amazon.dev [10.0.17.158:2525]\n with esmtp (Farcaster)\n id bea7ed2c-7832-42d6-9b20-8c0bec80b03f; Tue, 3 Feb 2026 12:55:45 +0000 (UTC)", "from EX19D001UWA001.ant.amazon.com (10.13.138.214) by\n EX19MTAUWB001.ant.amazon.com (10.250.64.248) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.2562.35;\n Tue, 3 Feb 2026 12:55:45 +0000", "from 603e5f7bc1fe.amazon.com (10.37.245.7) by\n EX19D001UWA001.ant.amazon.com (10.13.138.214) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.2562.35;\n Tue, 3 Feb 2026 12:55:43 +0000" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp3.osuosl.org D4F1D60893", "OpenDKIM Filter v2.11.0 smtp3.osuosl.org E12E66086D" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1770123350;\n\tbh=W1p9ZU1anq8c3tA5/K3cU5JbzW1imGiGjezF2dcMG5o=;\n\th=From:To:CC:Date:In-Reply-To:References:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=mRF4aJdgMqrk+FkuFJn0pS6C42PiRpSe1ok9b4gCkyokElYrd234wUCOU8kVcF0K6\n\t o+lkvSi1O5GnL4/aTuhCqk+FlcgxBYc6HHzLSs3+Z04Lvakj1gS68Qsm+nji8/wMAT\n\t BiUKvB5yjJhoteJVTCulgB5bvg9YK/z1RfY3bqueW0PSY7uq1RHHEWaeGB14/lZeJK\n\t 6/nrypDOSbszMy5l+whly4FcnGauLTmbySx+sTGtA8W+bUYIDff9UjoHntD6dqg9pg\n\t 0ach20PAhWpiGFszckPNjqMrtxCQE/aTQUkNvmP89kLYYeBpxzY2ocRWIR8PwGk1x8\n\t yuVcAGodxFDAw==", "Received-SPF": "Pass (mailfrom) identity=mailfrom; client-ip=44.246.68.102;\n helo=pdx-out-003.esa.us-west-2.outbound.mail-perimeter.amazon.com;\n envelope-from=prvs=487b0b5b4=takkozu@amazon.co.jp; receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp3.osuosl.org E12E66086D", "X-CSE-ConnectionGUID": "BA2TFj8aRWKimPNqD0okYg==", "X-CSE-MsgGUID": "yiaUqkMeT0i3/+jqQdUuRQ==", "X-IronPort-AV": "E=Sophos;i=\"6.21,270,1763424000\"; d=\"scan'208\";a=\"12190615\"", "X-Farcaster-Flow-ID": "bea7ed2c-7832-42d6-9b20-8c0bec80b03f", "From": "Takashi Kozu <takkozu@amazon.com>", "To": "<horms@kernel.org>", "CC": "<anthony.l.nguyen@intel.com>, <przemyslaw.kitszel@intel.com>,\n <andrew+netdev@lunn.ch>, <davem@davemloft.net>, <edumazet@google.com>,\n <kuba@kernel.org>, <pabeni@redhat.com>, <intel-wired-lan@lists.osuosl.org>,\n <netdev@vger.kernel.org>, <aleksandr.loktionov@intel.com>,\n <pmenzel@molgen.mpg.de>, <piotr.kwapulinski@intel.com>, <enjuk@amazon.com>,\n Takashi Kozu <takkozu@amazon.com>", "Date": "Tue, 3 Feb 2026 21:54:13 +0900", "Message-ID": "<20260203125417.37285-8-takkozu@amazon.com>", "X-Mailer": "git-send-email 2.47.0", "In-Reply-To": "<20260203125417.37285-5-takkozu@amazon.com>", "References": "<20260203125417.37285-5-takkozu@amazon.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.37.245.7]", "X-ClientProxiedBy": "EX19D044UWB003.ant.amazon.com (10.13.139.168) To\n EX19D001UWA001.ant.amazon.com (10.13.138.214)", "X-Mailman-Original-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=amazon.com; i=@amazon.com; q=dns/txt; s=amazoncorp2;\n t=1770123348; x=1801659348;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=W1p9ZU1anq8c3tA5/K3cU5JbzW1imGiGjezF2dcMG5o=;\n b=GfCt9Q1ec16i/HMExvGa8Q1esMz6M+SxKwPvyHyPmGBQC+Cc1z04lrKB\n oiZ1Vz0qSH80P5Y2818cANIGGsf7J+GLyug+GAm4QeyxpIzJ2D468FjC8\n tSbX7GgZCZZO0isOsuD4JmSFQn4+mGtri6l/KOCbeyO2k6E9i3DhHv+Qt\n qGHZ6GB8PXkw9nD6Wfv28m4dIT4wVfWepzi1ogDyyyg8QqU1lYfG5/ynt\n E+0+zaEwCAe48932Y0zv68fXqPgUQlHVRIC0smPq+5kixjeDWTWDHJ2W4\n jPoOSp7eFy2OQqiEjk5Kr4U8+RilF0ozuNj0Aw34pObAxwGqLYLlBgPbJ\n Q==;", "X-Mailman-Original-Authentication-Results": [ "smtp3.osuosl.org;\n dmarc=pass (p=quarantine dis=none)\n header.from=amazon.com", "smtp3.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=amazon.com header.i=@amazon.com header.a=rsa-sha256\n header.s=amazoncorp2 header.b=GfCt9Q1e" ], "Subject": "[Intel-wired-lan] [PATCH iwl-next v6 3/3] igb: allow configuring\n RSS key via ethtool set_rxfh", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Change igb_set_rxfh() to accept and save a userspace-provided\nRSS key. When a key is provided, store it in the adapter and write the\nE1000 registers accordingly.\n\nThis can be tested using `ethtool -X <dev> hkey <key>`.\n\nReviewed-by: Simon Horman <horms@kernel.org>\nSigned-off-by: Takashi Kozu <takkozu@amazon.com>\n---\n drivers/net/ethernet/intel/igb/igb_ethtool.c | 48 +++++++++++---------\n 1 file changed, 26 insertions(+), 22 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/igb/igb_ethtool.c b/drivers/net/ethernet/intel/igb/igb_ethtool.c\nindex b387121f0ea7..b4eef14c09d5 100644\n--- a/drivers/net/ethernet/intel/igb/igb_ethtool.c\n+++ b/drivers/net/ethernet/intel/igb/igb_ethtool.c\n@@ -3357,35 +3357,39 @@ static int igb_set_rxfh(struct net_device *netdev,\n \tu32 num_queues;\n \n \t/* We do not allow change in unsupported parameters */\n-\tif (rxfh->key ||\n-\t (rxfh->hfunc != ETH_RSS_HASH_NO_CHANGE &&\n-\t rxfh->hfunc != ETH_RSS_HASH_TOP))\n+\tif (rxfh->hfunc != ETH_RSS_HASH_NO_CHANGE &&\n+\t rxfh->hfunc != ETH_RSS_HASH_TOP)\n \t\treturn -EOPNOTSUPP;\n-\tif (!rxfh->indir)\n-\t\treturn 0;\n \n-\tnum_queues = adapter->rss_queues;\n+\tif (rxfh->indir) {\n+\t\tnum_queues = adapter->rss_queues;\n \n-\tswitch (hw->mac.type) {\n-\tcase e1000_82576:\n-\t\t/* 82576 supports 2 RSS queues for SR-IOV */\n-\t\tif (adapter->vfs_allocated_count)\n-\t\t\tnum_queues = 2;\n-\t\tbreak;\n-\tdefault:\n-\t\tbreak;\n-\t}\n+\t\tswitch (hw->mac.type) {\n+\t\tcase e1000_82576:\n+\t\t\t/* 82576 supports 2 RSS queues for SR-IOV */\n+\t\t\tif (adapter->vfs_allocated_count)\n+\t\t\t\tnum_queues = 2;\n+\t\t\tbreak;\n+\t\tdefault:\n+\t\t\tbreak;\n+\t\t}\n \n-\t/* Verify user input. */\n-\tfor (i = 0; i < IGB_RETA_SIZE; i++)\n-\t\tif (rxfh->indir[i] >= num_queues)\n-\t\t\treturn -EINVAL;\n+\t\t/* Verify user input. */\n+\t\tfor (i = 0; i < IGB_RETA_SIZE; i++)\n+\t\t\tif (rxfh->indir[i] >= num_queues)\n+\t\t\t\treturn -EINVAL;\n \n \n-\tfor (i = 0; i < IGB_RETA_SIZE; i++)\n-\t\tadapter->rss_indir_tbl[i] = rxfh->indir[i];\n+\t\tfor (i = 0; i < IGB_RETA_SIZE; i++)\n+\t\t\tadapter->rss_indir_tbl[i] = rxfh->indir[i];\n+\n+\t\tigb_write_rss_indir_tbl(adapter);\n+\t}\n \n-\tigb_write_rss_indir_tbl(adapter);\n+\tif (rxfh->key) {\n+\t\tmemcpy(adapter->rss_key, rxfh->key, sizeof(adapter->rss_key));\n+\t\tigb_write_rss_key(adapter);\n+\t}\n \n \treturn 0;\n }\n", "prefixes": [ "iwl-next", "v6", "3/3" ] }