Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2191457/?format=api
{ "id": 2191457, "url": "http://patchwork.ozlabs.org/api/patches/2191457/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260202101755.315528-1-mschmidt@redhat.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260202101755.315528-1-mschmidt@redhat.com>", "list_archive_url": null, "date": "2026-02-02T10:17:54", "name": "[net] ice: fix crash in ethtool offline loopback test", "commit_ref": null, "pull_url": null, "state": "under-review", "archived": false, "hash": "3b9e94aa51e4677919a90b6880aa1f225aab532e", "submitter": { "id": 1162, "url": "http://patchwork.ozlabs.org/api/people/1162/?format=api", "name": "Michal Schmidt", "email": "mschmidt@redhat.com" }, "delegate": { "id": 109701, "url": "http://patchwork.ozlabs.org/api/users/109701/?format=api", "username": "anguy11", "first_name": "Anthony", "last_name": "Nguyen", "email": "anthony.l.nguyen@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260202101755.315528-1-mschmidt@redhat.com/mbox/", "series": [ { "id": 490602, "url": "http://patchwork.ozlabs.org/api/series/490602/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=490602", "date": "2026-02-02T10:17:54", "name": "[net] ice: fix crash in ethtool offline loopback test", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/490602/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2191457/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2191457/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=t8PK6+Gq;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::137; helo=smtp4.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4f4Myb6kpZz1xtl\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 02 Feb 2026 21:18:31 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 1470740A45;\n\tMon, 2 Feb 2026 10:18:30 +0000 (UTC)", "from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id ky4GrTnVaRkq; Mon, 2 Feb 2026 10:18:28 +0000 (UTC)", "from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 7439140A44;\n\tMon, 2 Feb 2026 10:18:28 +0000 (UTC)", "from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n by lists1.osuosl.org (Postfix) with ESMTP id 1CEB21E0\n for <intel-wired-lan@lists.osuosl.org>; Mon, 2 Feb 2026 10:18:27 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp1.osuosl.org (Postfix) with ESMTP id 0B57582FF9\n for <intel-wired-lan@lists.osuosl.org>; Mon, 2 Feb 2026 10:18:27 +0000 (UTC)", "from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id Ut8vPp9dMj6K for <intel-wired-lan@lists.osuosl.org>;\n Mon, 2 Feb 2026 10:18:26 +0000 (UTC)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n by smtp1.osuosl.org (Postfix) with ESMTPS id E1EB782F98\n for <intel-wired-lan@lists.osuosl.org>; Mon, 2 Feb 2026 10:18:24 +0000 (UTC)", "from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-261-EV51GaeONfiBLUq-hmGr9A-1; Mon,\n 02 Feb 2026 05:18:22 -0500", "from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 77DC2195606F; Mon, 2 Feb 2026 10:18:19 +0000 (UTC)", "from rhel-developer-toolbox-latest (unknown [10.43.3.143])\n by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 37F9D19560A2; Mon, 2 Feb 2026 10:18:16 +0000 (UTC)" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp4.osuosl.org 7439140A44", "OpenDKIM Filter v2.11.0 smtp1.osuosl.org E1EB782F98" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1770027508;\n\tbh=QwkSiX1Hp8rIk3qxgAOsnlMj5FGX8DKdzbss4//3U/M=;\n\th=From:To:Cc:Date:Subject:List-Id:List-Unsubscribe:List-Archive:\n\t List-Post:List-Help:List-Subscribe:From;\n\tb=t8PK6+GqwJkLgXV2pO6DoHV3NKSDeLdnJaERmXapGF3BpaT+H9iCTwAdbIU8ecdrR\n\t 9TG2gfA++xui3mKrPHjuQnAxQRMvHNpgvSAajhjB5ckKI20o2qJ89Fs4yseN43Cr7l\n\t B9M91R/ZBtU1cD9jlbNmE71xmk8lDWhC5uDZrTODCIQNDTPul1xBVjXzMPyBEQqp9D\n\t rxFf5tqQeUil0jpL7S6m5lFjNT7GIlFs4F8g9XaHbkB3AYpz1xVHM1y6g73GraUVge\n\t YvU5gT4DsLcBuw7CrN6yUGAm+ABv0dZx/ZPwgTPpBlKW/NUg6oPYpCzDFhuapz2jOh\n\t M1Tyr3k5htVHA==", "Received-SPF": "Pass (mailfrom) identity=mailfrom; client-ip=170.10.129.124;\n helo=us-smtp-delivery-124.mimecast.com; envelope-from=mschmidt@redhat.com;\n receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp1.osuosl.org E1EB782F98", "X-MC-Unique": "EV51GaeONfiBLUq-hmGr9A-1", "X-Mimecast-MFC-AGG-ID": "EV51GaeONfiBLUq-hmGr9A_1770027499", "From": "Michal Schmidt <mschmidt@redhat.com>", "To": "Tony Nguyen <anthony.l.nguyen@intel.com>,\n Przemek Kitszel <przemyslaw.kitszel@intel.com>,\n Andrew Lunn <andrew+netdev@lunn.ch>,\n \"David S. Miller\" <davem@davemloft.net>,\n Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>,\n Paolo Abeni <pabeni@redhat.com>,\n Alexander Lobakin <aleksander.lobakin@intel.com>,\n Jacob Keller <jacob.e.keller@intel.com>,\n Michal Kubiak <michal.kubiak@intel.com>", "Cc": "intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,\n linux-kernel@vger.kernel.org", "Date": "Mon, 2 Feb 2026 11:17:54 +0100", "Message-ID": "<20260202101755.315528-1-mschmidt@redhat.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.12", "X-Mailman-Original-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com;\n s=mimecast20190719; t=1770027504;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding;\n bh=QwkSiX1Hp8rIk3qxgAOsnlMj5FGX8DKdzbss4//3U/M=;\n b=Vj/0PrfIQDl2mesD2IDxUy3zRl00k5fqlbqCZ0KCP572hdFJsV0Smquam9531mQiSfqYIK\n PDdDfzD8HcBvsYg1rOCQ1+Fl1fPNkyJ1UNQpFNkps0NCFyC3fky0Rs6kP90tSTLgTUE2+4\n /dBHAO8+BQhxYwNFHeBQiQ5rvtIDR00=", "X-Mailman-Original-Authentication-Results": [ "smtp1.osuosl.org;\n dmarc=pass (p=quarantine dis=none)\n header.from=redhat.com", "smtp1.osuosl.org;\n dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com\n header.a=rsa-sha256 header.s=mimecast20190719 header.b=Vj/0PrfI" ], "Subject": "[Intel-wired-lan] [PATCH net] ice: fix crash in ethtool offline\n loopback test", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Since the conversion of ice to page pool, the ethtool loopback test\ncrashes:\n\n BUG: kernel NULL pointer dereference, address: 000000000000000c\n #PF: supervisor write access in kernel mode\n #PF: error_code(0x0002) - not-present page\n PGD 1100f1067 P4D 0\n Oops: Oops: 0002 [#1] SMP NOPTI\n CPU: 23 UID: 0 PID: 5904 Comm: ethtool Kdump: loaded Not tainted 6.19.0-0.rc7.260128g1f97d9dcf5364.49.eln154.x86_64 #1 PREEMPT(lazy)\n Hardware name: [...]\n RIP: 0010:ice_alloc_rx_bufs+0x1cd/0x310 [ice]\n Code: 83 6c 24 30 01 66 41 89 47 08 0f 84 c0 00 00 00 41 0f b7 dc 48 8b 44 24 18 48 c1 e3 04 41 bb 00 10 00 00 48 8d 2c 18 8b 04 24 <89> 45 0c 41 8b 4d 00 49 d3 e3 44 3b 5c 24 24 0f 83 ac fe ff ff 44\n RSP: 0018:ff7894738aa1f768 EFLAGS: 00010246\n RAX: 0000000000000000 RBX: 0000000000000000 RCX: 0000000000000000\n RDX: 0000000000000000 RSI: 0000000000000700 RDI: 0000000000000000\n RBP: 0000000000000000 R08: ff16dcae79880200 R09: 0000000000000019\n R10: 0000000000000001 R11: 0000000000001000 R12: 0000000000000000\n R13: 0000000000000000 R14: 0000000000000000 R15: ff16dcae6c670000\n FS: 00007fcf428850c0(0000) GS:ff16dcb149710000(0000) knlGS:0000000000000000\n CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033\n CR2: 000000000000000c CR3: 0000000121227005 CR4: 0000000000773ef0\n PKRU: 55555554\n Call Trace:\n <TASK>\n ice_vsi_cfg_rxq+0xca/0x460 [ice]\n ice_vsi_cfg_rxqs+0x54/0x70 [ice]\n ice_loopback_test+0xa9/0x520 [ice]\n ice_self_test+0x1b9/0x280 [ice]\n ethtool_self_test+0xe5/0x200\n __dev_ethtool+0x1106/0x1a90\n dev_ethtool+0xbe/0x1a0\n dev_ioctl+0x258/0x4c0\n sock_do_ioctl+0xe3/0x130\n __x64_sys_ioctl+0xb9/0x100\n do_syscall_64+0x7c/0x700\n entry_SYSCALL_64_after_hwframe+0x76/0x7e\n [...]\n\nIt crashes because we have not initialized libeth for the rx ring.\n\nFix it by treating ICE_VSI_LB VSIs slightly more like normal PF VSIs and\nletting them have a q_vector. It's just a dummy, because the loopback\ntest does not use interrupts, but it contains a napi struct that can be\npassed to libeth_rx_fq_create() called from ice_vsi_cfg_rxq() ->\nice_rxq_pp_create().\n\nFixes: 93f53db9f9dc (\"ice: switch to Page Pool\")\nSigned-off-by: Michal Schmidt <mschmidt@redhat.com>\n---\n drivers/net/ethernet/intel/ice/ice_base.c | 5 ++++-\n drivers/net/ethernet/intel/ice/ice_ethtool.c | 4 ++++\n drivers/net/ethernet/intel/ice/ice_lib.c | 15 ++++++++++-----\n 3 files changed, 18 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice_base.c b/drivers/net/ethernet/intel/ice/ice_base.c\nindex eadb1e3d12b3..f0da50df6791 100644\n--- a/drivers/net/ethernet/intel/ice/ice_base.c\n+++ b/drivers/net/ethernet/intel/ice/ice_base.c\n@@ -124,6 +124,8 @@ static int ice_vsi_alloc_q_vector(struct ice_vsi *vsi, u16 v_idx)\n \tif (vsi->type == ICE_VSI_VF) {\n \t\tice_calc_vf_reg_idx(vsi->vf, q_vector);\n \t\tgoto out;\n+\t} else if (vsi->type == ICE_VSI_LB) {\n+\t\tgoto skip_alloc;\n \t} else if (vsi->type == ICE_VSI_CTRL && vsi->vf) {\n \t\tstruct ice_vsi *ctrl_vsi = ice_get_vf_ctrl_vsi(pf, vsi);\n \n@@ -662,7 +664,8 @@ static int ice_vsi_cfg_rxq(struct ice_rx_ring *ring)\n \tu32 rx_buf_len;\n \tint err;\n \n-\tif (ring->vsi->type == ICE_VSI_PF || ring->vsi->type == ICE_VSI_SF) {\n+\tif (ring->vsi->type == ICE_VSI_PF || ring->vsi->type == ICE_VSI_SF ||\n+\t ring->vsi->type == ICE_VSI_LB) {\n \t\tif (!xdp_rxq_info_is_reg(&ring->xdp_rxq)) {\n \t\t\terr = __xdp_rxq_info_reg(&ring->xdp_rxq, ring->netdev,\n \t\t\t\t\t\t ring->q_index,\ndiff --git a/drivers/net/ethernet/intel/ice/ice_ethtool.c b/drivers/net/ethernet/intel/ice/ice_ethtool.c\nindex 3565a5d96c6d..e9f2618950c8 100644\n--- a/drivers/net/ethernet/intel/ice/ice_ethtool.c\n+++ b/drivers/net/ethernet/intel/ice/ice_ethtool.c\n@@ -1289,6 +1289,10 @@ static u64 ice_loopback_test(struct net_device *netdev)\n \ttest_vsi->netdev = netdev;\n \ttx_ring = test_vsi->tx_rings[0];\n \trx_ring = test_vsi->rx_rings[0];\n+\t/* Dummy q_vector and napi. Fill the minimum required for\n+\t * ice_rxq_pp_create().\n+\t */\n+\trx_ring->q_vector->napi.dev = netdev;\n \n \tif (ice_lbtest_prepare_rings(test_vsi)) {\n \t\tret = 2;\ndiff --git a/drivers/net/ethernet/intel/ice/ice_lib.c b/drivers/net/ethernet/intel/ice/ice_lib.c\nindex d47af94f31a9..bad67e4dc044 100644\n--- a/drivers/net/ethernet/intel/ice/ice_lib.c\n+++ b/drivers/net/ethernet/intel/ice/ice_lib.c\n@@ -107,10 +107,6 @@ static int ice_vsi_alloc_arrays(struct ice_vsi *vsi)\n \tif (!vsi->rxq_map)\n \t\tgoto err_rxq_map;\n \n-\t/* There is no need to allocate q_vectors for a loopback VSI. */\n-\tif (vsi->type == ICE_VSI_LB)\n-\t\treturn 0;\n-\n \t/* allocate memory for q_vector pointers */\n \tvsi->q_vectors = devm_kcalloc(dev, vsi->num_q_vectors,\n \t\t\t\t sizeof(*vsi->q_vectors), GFP_KERNEL);\n@@ -239,6 +235,8 @@ static void ice_vsi_set_num_qs(struct ice_vsi *vsi)\n \tcase ICE_VSI_LB:\n \t\tvsi->alloc_txq = 1;\n \t\tvsi->alloc_rxq = 1;\n+\t\t/* A dummy q_vector, no actual IRQ. */\n+\t\tvsi->num_q_vectors = 1;\n \t\tbreak;\n \tdefault:\n \t\tdev_warn(ice_pf_to_dev(pf), \"Unknown VSI type %d\\n\", vsi_type);\n@@ -2424,14 +2422,21 @@ static int ice_vsi_cfg_def(struct ice_vsi *vsi)\n \t\t}\n \t\tbreak;\n \tcase ICE_VSI_LB:\n-\t\tret = ice_vsi_alloc_rings(vsi);\n+\t\tret = ice_vsi_alloc_q_vectors(vsi);\n \t\tif (ret)\n \t\t\tgoto unroll_vsi_init;\n \n+\t\tret = ice_vsi_alloc_rings(vsi);\n+\t\tif (ret)\n+\t\t\tgoto unroll_alloc_q_vector;\n+\n \t\tret = ice_vsi_alloc_ring_stats(vsi);\n \t\tif (ret)\n \t\t\tgoto unroll_vector_base;\n \n+\t\t/* Simply map the dummy q_vector to the only rx_ring */\n+\t\tvsi->rx_rings[0]->q_vector = vsi->q_vectors[0];\n+\n \t\tbreak;\n \tdefault:\n \t\t/* clean up the resources and exit */\n", "prefixes": [ "net" ] }