Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2191177/?format=api
{ "id": 2191177, "url": "http://patchwork.ozlabs.org/api/patches/2191177/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260131163037.88108-4-kohei@enjuk.jp/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260131163037.88108-4-kohei@enjuk.jp>", "list_archive_url": null, "date": "2026-01-31T16:29:38", "name": "[v2,iwl-next,3/3] igc: allow configuring RSS key via ethtool set_rxfh", "commit_ref": null, "pull_url": null, "state": "under-review", "archived": false, "hash": "09bd1e777e80507a1146478fe66d10391db809d7", "submitter": { "id": 92459, "url": "http://patchwork.ozlabs.org/api/people/92459/?format=api", "name": "Kohei Enju", "email": "kohei@enjuk.jp" }, "delegate": { "id": 109701, "url": "http://patchwork.ozlabs.org/api/users/109701/?format=api", "username": "anguy11", "first_name": "Anthony", "last_name": "Nguyen", "email": "anthony.l.nguyen@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260131163037.88108-4-kohei@enjuk.jp/mbox/", "series": [ { "id": 490492, "url": "http://patchwork.ozlabs.org/api/series/490492/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=490492", "date": "2026-01-31T16:29:35", "name": "igc: add RSS key get/set support", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/490492/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2191177/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2191177/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=mjEVkX+I;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::136; helo=smtp3.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4f3JLB6cStz1xtd\n\tfor <incoming@patchwork.ozlabs.org>; Sun, 01 Feb 2026 03:31:46 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 2CF0760B66;\n\tSat, 31 Jan 2026 16:31:45 +0000 (UTC)", "from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id f1RY-7kBOnPN; Sat, 31 Jan 2026 16:31:44 +0000 (UTC)", "from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 611AF60B64;\n\tSat, 31 Jan 2026 16:31:44 +0000 (UTC)", "from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n by lists1.osuosl.org (Postfix) with ESMTP id C13031E0\n for <intel-wired-lan@lists.osuosl.org>; Sat, 31 Jan 2026 16:31:43 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp1.osuosl.org (Postfix) with ESMTP id AFABC8349A\n for <intel-wired-lan@lists.osuosl.org>; Sat, 31 Jan 2026 16:31:43 +0000 (UTC)", "from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id aupp0WilhTjH for <intel-wired-lan@lists.osuosl.org>;\n Sat, 31 Jan 2026 16:31:42 +0000 (UTC)", "from www2881.sakura.ne.jp (www2881.sakura.ne.jp [49.212.198.91])\n by smtp1.osuosl.org (Postfix) with ESMTPS id 7501083443\n for <intel-wired-lan@lists.osuosl.org>; Sat, 31 Jan 2026 16:31:42 +0000 (UTC)", "from ms-a2 (248.212.13.160.dy.iij4u.or.jp [160.13.212.248])\n (authenticated bits=0)\n by www2881.sakura.ne.jp (8.16.1/8.16.1) with ESMTPSA id 60VGVPea039683\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);\n Sun, 1 Feb 2026 01:31:25 +0900 (JST) (envelope-from kohei@enjuk.jp)" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp3.osuosl.org 611AF60B64", "OpenDKIM Filter v2.11.0 smtp1.osuosl.org 7501083443" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1769877104;\n\tbh=XkB0UJdSADANAbmF+JgfoF3mhihZYqHI6IAIOSB6NXo=;\n\th=From:To:Cc:Date:In-Reply-To:References:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=mjEVkX+InkGSwWYaX4X+SHBTpe5hds9bE7l8VfHwisxDuI01ItByW/g1uGPfNTEfW\n\t U+8Uf4KJM9WnvUNtfqZ/l/vnUVdNvAAwXWskaujlFdSUH5ru1lMiU5PrmVzRNwYBzh\n\t w7TikJpIz21/H55J7Dt2V49P5OXPciabh+WBfmPdO/4zsSLWWhokN4NzgL4+D8liDS\n\t SZIJptIeZDJIo5zWJSJXDF+mo9qVG5i9HSOeoFU7I98uCKEyHPP3vPIUW/8J99xHWm\n\t GgTS3al7mHRS4rcFtFUT5+qlLoF4KuAG3xRTJcBN+Zg+HNuIXqQOAnc+4zwzln+I7A\n\t PJyCv5pUjV7jQ==", "Received-SPF": "Pass (mailfrom) identity=mailfrom; client-ip=49.212.198.91;\n helo=www2881.sakura.ne.jp; envelope-from=kohei@enjuk.jp; receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp1.osuosl.org 7501083443", "From": "Kohei Enju <kohei@enjuk.jp>", "To": "intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org", "Cc": "Tony Nguyen <anthony.l.nguyen@intel.com>,\n Przemek Kitszel <przemyslaw.kitszel@intel.com>,\n Andrew Lunn <andrew+netdev@lunn.ch>,\n \"David S. Miller\" <davem@davemloft.net>,\n Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>,\n Paolo Abeni <pabeni@redhat.com>,\n Vitaly Lifshits <vitaly.lifshits@intel.com>,\n Simon Horman <horms@kernel.org>,\n Aleksandr Loktionov <aleksandr.loktionov@intel.com>,\n kohei.enju@gmail.com, Kohei Enju <kohei@enjuk.jp>", "Date": "Sat, 31 Jan 2026 16:29:38 +0000", "Message-ID": "<20260131163037.88108-4-kohei@enjuk.jp>", "X-Mailer": "git-send-email 2.51.0", "In-Reply-To": "<20260131163037.88108-1-kohei@enjuk.jp>", "References": "<20260131163037.88108-1-kohei@enjuk.jp>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Original-DKIM-Signature": "a=rsa-sha256;\n bh=XkB0UJdSADANAbmF+JgfoF3mhihZYqHI6IAIOSB6NXo=;\n c=relaxed/relaxed; d=enjuk.jp;\n h=From:To:Subject:Date:Message-ID;\n s=rs20251215; t=1769877085; v=1;\n b=R0gNYgPwNDX86udfeD4kz63cQh1NW/Bf0EwiikmwKatkqDpH0mWANdGGduDG4I3h\n RskNGMdY3m6EvldWEiTDjOMJAkq1zNpkPB+obVQIYn8cMkXjw8fws3F7JuoKJyWb\n G1mvULGGIg0iGbfJuXKeP/2XviLmlwGcYUeCIsOcpMygsQrDundLGcQ5WzO/M0dF\n FKy7y4cQEylE5Mmi0FqXlZ0g+u815aYW9hMJ36WKriHEZktqmhH4JVFyqUUcA6rA\n +CQQLiL5KqzPVVJgUrbDKF2OgKQWH9rawpf6/Hw2BJPuIwZV7qlqihLS7RAK3lG/\n LNkYIYscEgo66BtahAj8rA==", "X-Mailman-Original-Authentication-Results": [ "smtp1.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=enjuk.jp", "smtp1.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=enjuk.jp header.i=@enjuk.jp header.a=rsa-sha256\n header.s=rs20251215 header.b=R0gNYgPw" ], "Subject": "[Intel-wired-lan] [PATCH v2 iwl-next 3/3] igc: allow configuring\n RSS key via ethtool set_rxfh", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Change igc_ethtool_set_rxfh() to accept and save a userspace-provided\nRSS key. When a key is provided, store it in the adapter and write the\nRSSRK registers accordingly.\n\nThis can be tested using `ethtool -X <dev> hkey <key>`.\n\nSigned-off-by: Kohei Enju <kohei@enjuk.jp>\n---\n drivers/net/ethernet/intel/igc/igc_ethtool.c | 30 +++++++++++---------\n 1 file changed, 17 insertions(+), 13 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/igc/igc_ethtool.c b/drivers/net/ethernet/intel/igc/igc_ethtool.c\nindex 661b044073ca..eb5b146f6f10 100644\n--- a/drivers/net/ethernet/intel/igc/igc_ethtool.c\n+++ b/drivers/net/ethernet/intel/igc/igc_ethtool.c\n@@ -1539,24 +1539,28 @@ static int igc_ethtool_set_rxfh(struct net_device *netdev,\n \tint i;\n \n \t/* We do not allow change in unsupported parameters */\n-\tif (rxfh->key ||\n-\t (rxfh->hfunc != ETH_RSS_HASH_NO_CHANGE &&\n-\t rxfh->hfunc != ETH_RSS_HASH_TOP))\n+\tif (rxfh->hfunc != ETH_RSS_HASH_NO_CHANGE &&\n+\t rxfh->hfunc != ETH_RSS_HASH_TOP)\n \t\treturn -EOPNOTSUPP;\n-\tif (!rxfh->indir)\n-\t\treturn 0;\n \n-\tnum_queues = adapter->rss_queues;\n+\tif (rxfh->indir) {\n+\t\tnum_queues = adapter->rss_queues;\n \n-\t/* Verify user input. */\n-\tfor (i = 0; i < IGC_RETA_SIZE; i++)\n-\t\tif (rxfh->indir[i] >= num_queues)\n-\t\t\treturn -EINVAL;\n+\t\t/* Verify user input. */\n+\t\tfor (i = 0; i < IGC_RETA_SIZE; i++)\n+\t\t\tif (rxfh->indir[i] >= num_queues)\n+\t\t\t\treturn -EINVAL;\n \n-\tfor (i = 0; i < IGC_RETA_SIZE; i++)\n-\t\tadapter->rss_indir_tbl[i] = rxfh->indir[i];\n+\t\tfor (i = 0; i < IGC_RETA_SIZE; i++)\n+\t\t\tadapter->rss_indir_tbl[i] = rxfh->indir[i];\n \n-\tigc_write_rss_indir_tbl(adapter);\n+\t\tigc_write_rss_indir_tbl(adapter);\n+\t}\n+\n+\tif (rxfh->key) {\n+\t\tmemcpy(adapter->rss_key, rxfh->key, sizeof(adapter->rss_key));\n+\t\tigc_write_rss_key(adapter);\n+\t}\n \n \treturn 0;\n }\n", "prefixes": [ "v2", "iwl-next", "3/3" ] }