Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2189502/?format=api
{ "id": 2189502, "url": "http://patchwork.ozlabs.org/api/patches/2189502/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260127123711.595435-1-piotr.kwapulinski@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260127123711.595435-1-piotr.kwapulinski@intel.com>", "list_archive_url": null, "date": "2026-01-27T12:37:11", "name": "[iwl-next,v3] ixgbe: e610: add ACI dynamic debug", "commit_ref": null, "pull_url": null, "state": "under-review", "archived": false, "hash": "844026646afce720b50f46494d8c3ca608236efa", "submitter": { "id": 76726, "url": "http://patchwork.ozlabs.org/api/people/76726/?format=api", "name": "Kwapulinski, Piotr", "email": "piotr.kwapulinski@intel.com" }, "delegate": { "id": 109701, "url": "http://patchwork.ozlabs.org/api/users/109701/?format=api", "username": "anguy11", "first_name": "Anthony", "last_name": "Nguyen", "email": "anthony.l.nguyen@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260127123711.595435-1-piotr.kwapulinski@intel.com/mbox/", "series": [ { "id": 489897, "url": "http://patchwork.ozlabs.org/api/series/489897/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=489897", "date": "2026-01-27T12:37:11", "name": "[iwl-next,v3] ixgbe: e610: add ACI dynamic debug", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/489897/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2189502/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2189502/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=gCIOHAI9;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.137; helo=smtp4.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4f0l1Z2RTdz1xsp\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 27 Jan 2026 23:23:28 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 0A2744082F;\n\tTue, 27 Jan 2026 12:23:26 +0000 (UTC)", "from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id NJidkikwuW5D; Tue, 27 Jan 2026 12:23:25 +0000 (UTC)", "from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 355684074D;\n\tTue, 27 Jan 2026 12:23:25 +0000 (UTC)", "from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n by lists1.osuosl.org (Postfix) with ESMTP id 8958E2F4\n for <intel-wired-lan@lists.osuosl.org>; Tue, 27 Jan 2026 12:23:23 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp3.osuosl.org (Postfix) with ESMTP id 84B5260F92\n for <intel-wired-lan@lists.osuosl.org>; Tue, 27 Jan 2026 12:23:23 +0000 (UTC)", "from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id C09RmHfcv-mw for <intel-wired-lan@lists.osuosl.org>;\n Tue, 27 Jan 2026 12:23:22 +0000 (UTC)", "from mgamail.intel.com (mgamail.intel.com [198.175.65.11])\n by smtp3.osuosl.org (Postfix) with ESMTPS id 94AEE60F57\n for <intel-wired-lan@lists.osuosl.org>; Tue, 27 Jan 2026 12:23:22 +0000 (UTC)", "from fmviesa003.fm.intel.com ([10.60.135.143])\n by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 27 Jan 2026 04:16:14 -0800", "from amlin-018-252.igk.intel.com ([10.102.18.252])\n by fmviesa003.fm.intel.com with ESMTP; 27 Jan 2026 04:16:12 -0800" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp4.osuosl.org 355684074D", "OpenDKIM Filter v2.11.0 smtp3.osuosl.org 94AEE60F57" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1769516605;\n\tbh=Uk0mG7pDyvMyJb5OL5KY+u68BZdbkEuTp71eNbt2UXc=;\n\th=From:To:Cc:Date:Subject:List-Id:List-Unsubscribe:List-Archive:\n\t List-Post:List-Help:List-Subscribe:From;\n\tb=gCIOHAI9/+FVT1zG66ffhUK8mi2GVi0UI/IB7yLLKEGRGJV2Fcd9h4Y5D/v1W4JHx\n\t lSuvx/NDBGkXLucXECZM8OkFORSWy45ot81oJNGJOkLpEG9Yz84zLWTGuKuPCQOxcp\n\t angXtTI6OqAM/1m9cvBPGlJJXOoyuDREWYWiJ1fk9U+bwnL9bLwzktjOgyGXU7wRDY\n\t uqjaQcx623p94iN3+mhsDQgfb37otQuhw/G6vgGq3wzUwtSWiYCUlMKCU/Iqf8Xbtw\n\t pvNnGuGPGDzYXDPYRcndhuTGf0o7nj9+I8KwEHtUwtn4kev1RWQnJvql0cs5Xg1bCV\n\t TdF6hTP78mG4g==", "X-Greylist": "delayed 428 seconds by postgrey-1.37 at util1.osuosl.org;\n Tue, 27 Jan 2026 12:23:22 UTC", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp3.osuosl.org 94AEE60F57", "Received-SPF": "Pass (mailfrom) identity=mailfrom; client-ip=198.175.65.11;\n helo=mgamail.intel.com; envelope-from=piotr.kwapulinski@intel.com;\n receiver=<UNKNOWN>", "X-CSE-ConnectionGUID": [ "wiEvki5FQAas+TY/GqZykA==", "Ay4bs5BvScGuClns8IJHCw==" ], "X-CSE-MsgGUID": [ "3DkRTOf4RK6g/yZaRa38ow==", "frcpyRkuTbmj8aqOK3uuLA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6800,10657,11683\"; a=\"81013526\"", "E=Sophos;i=\"6.21,257,1763452800\"; d=\"scan'208\";a=\"81013526\"" ], "X-ExtLoop1": "1", "From": "Piotr Kwapulinski <piotr.kwapulinski@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Cc": "netdev@vger.kernel.org, Piotr Kwapulinski <piotr.kwapulinski@intel.com>,\n Stefan Wegrzyn <stefan.wegrzyn@intel.com>,\n Aleksandr Loktionov <aleksandr.loktionov@intel.com>", "Date": "Tue, 27 Jan 2026 13:37:11 +0100", "Message-ID": "<20260127123711.595435-1-piotr.kwapulinski@intel.com>", "X-Mailer": "git-send-email 2.47.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Original-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1769516603; x=1801052603;\n h=from:to:cc:subject:date:message-id:mime-version:\n content-transfer-encoding;\n bh=msmU2MyrqSWPyAAe2Zo1KaeZzDHoeq3eZ3UxRhiaGDA=;\n b=lqdg+G9fKCg24sQerRFPc4cmW0eeDP7p6ygvj//zKy5aGqxZgDX9Tuwu\n erho7+9ioreVCUwRNhzkXGu9HpBepIJ+8qA1+A2FD1rjBCy8HIgNA5Q3Y\n EFjUH4uyZfG5rxgjDdrs1mnqc1cgAsqCTPibR5eW9K7AewnS4XFOe+FA8\n BjFxYnLKdd2TEvPnvJsGIyoU36a2bgUw99R14nJXN+ZZIZlh7vul4siz0\n X99ql2uEBnQKzs0Cyfy8vOtrCrbSHi5sQ9o89Iw2U+obsav296Df4ZGAI\n 8N/Q6W5IDTajTTHKfahZH3fSrGMbTgzzSMcnwTTD7v/IDYe/T+gxEnXPr\n w==;", "X-Mailman-Original-Authentication-Results": [ "smtp3.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com", "smtp3.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=lqdg+G9f" ], "Subject": "[Intel-wired-lan] [PATCH iwl-next v3] ixgbe: e610: add ACI dynamic\n debug", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Enable dynamic debug (dyndbg) of Admin Command Interface (ACI) for e610\nadapter. Utilizes the standard dynamic debug interface. For example to\nenable dyndbg at driver load:\n\ninsmod ixgbe.ko dyndbg='+p'\n\nACI debug output for e610 adapter is immediately printed into a kernel\nlog (dmesg). Example output:\n\nixgbe 0000:01:00.0 eth0: CQ CMD: opcode 0x0701, flags 0x3003, datalen 0x0060, retval 0x0000\nixgbe 0000:01:00.0 eth0: cookie (h,l) 0x00000000 0x00000000\nixgbe 0000:01:00.0 eth0: param (0,1) 0x8194E044 0x00600000\nixgbe 0000:01:00.0 eth0: addr (h,l) 0x00000000 0x00000000\nixgbe 0000:01:00.0 eth0: Buffer:\nixgbe 0000:01:00.0 eth0: 00000000: 01 00 17 00 00 00 00 00 00 00 00 00 00 00 00 00\nixgbe 0000:01:00.0 eth0: 00000010: 1d 00 00 00 0b d5 1e 15 5e 4b 90 63 aa 0b 21 31\nixgbe 0000:01:00.0 eth0: 00000020: 69 eb cd ab dc f8 8a fd f4 53 e2 dc 54 e0 81 fa\nixgbe 0000:01:00.0 eth0: 00000030: 12 dc 41 82 01 00 00 00 24 20 08 26 53 08 00 00\nixgbe 0000:01:00.0 eth0: 00000040: 08 00 14 00 00 00 00 00 00 00 00 00 00 00 00 00\nixgbe 0000:01:00.0 eth0: 00000050: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00\nixgbe 0000:01:00.0 eth0: CQ CMD: opcode 0x0009, flags 0x2003, datalen 0x0000, retval 0x0000\nixgbe 0000:01:00.0 eth0: cookie (h,l) 0x00000000 0x00000000\nixgbe 0000:01:00.0 eth0: param (0,1) 0x00000001 0x00000000\nixgbe 0000:01:00.0 eth0: addr (h,l) 0x00000000 0x00000000\n\nCo-developed-by: Stefan Wegrzyn <stefan.wegrzyn@intel.com>\nSigned-off-by: Stefan Wegrzyn <stefan.wegrzyn@intel.com>\nReviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>\nSigned-off-by: Piotr Kwapulinski <piotr.kwapulinski@intel.com>\n---\nv1 -> v2\n Commit message updated\nv2 -> v3\n Remove unnecessary commit:\n e610: Convert ACI descriptor buffer to little endian\n---\n drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c | 112 ++++++++++++++++--\n 1 file changed, 105 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c\nindex c2f8189..ad58e11 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c\n@@ -9,6 +9,78 @@\n #include \"ixgbe_mbx.h\"\n #include \"ixgbe_phy.h\"\n \n+#define IXGBE_ACI_DEBUG_ROW_SIZE\t16\n+#define IXGBE_ACI_DEBUG_GROUP_SIZE\t1\n+#define IXGBE_NETDEV_PREFIX_BUF_SIZE\t64\n+\n+/**\n+ * ixgbe_hex_debug_dump - dump a blob of data in \"hex ASCII\" format\n+ * @hw: hardware structure address\n+ * @buf: data blob to dump\n+ * @buf_size: number of bytes in the @buf\n+ *\n+ * Dump a blob of data into a kernel log. The blob is printed in lines\n+ * consisting of 16 or 32 bytes decorated with PCI device string. Each byte is\n+ * printed in a \"hex ASCII\" format.\n+ * Example output:\n+ * ixgbe 0000:01:00.1 eth14: 00000000: 01 00 17 00 00 00 00 00 00 00 00 00 00 00 00 00\n+ * ixgbe 0000:01:00.1 eth14: 00000010: 1d 00 00 00 0b d5 1e 15 5e 4b 90 63 aa 0b 21 31\n+ * ixgbe 0000:01:00.1 eth14: 00000020: 69 eb cd ab dc f8 8a fd f4 53 e2 dc 54 e0 81 fa\n+ */\n+static void ixgbe_hex_debug_dump(struct ixgbe_hw *hw, void *buf,\n+\t\t\t\t size_t buf_size)\n+{\n+\tchar netdev_info[IXGBE_NETDEV_PREFIX_BUF_SIZE];\n+\tstruct ixgbe_adapter *adapter = hw->back;\n+\tstruct pci_dev *pdev = adapter->pdev;\n+\n+\tsnprintf(netdev_info, IXGBE_NETDEV_PREFIX_BUF_SIZE,\n+\t\t \"%s %s %s: \", ixgbe_driver_name, pci_name(pdev),\n+\t\t netdev_name(adapter->netdev));\n+\tprint_hex_dump_debug(netdev_info, DUMP_PREFIX_OFFSET,\n+\t\t\t IXGBE_ACI_DEBUG_ROW_SIZE,\n+\t\t\t IXGBE_ACI_DEBUG_GROUP_SIZE,\n+\t\t\t buf, buf_size, false);\n+}\n+\n+/**\n+ * ixgbe_aci_debug - dump the ACI content\n+ * @hw: pointer to the hardware structure\n+ * @desc: pointer to control queue descriptor\n+ * @buf: pointer to command buffer\n+ * @buf_len: max length of buf\n+ *\n+ * Dump individual ACI commands and its descriptor details.\n+ */\n+static void ixgbe_aci_debug(struct ixgbe_hw *hw, void *desc, void *buf,\n+\t\t\t u16 buf_len)\n+{\n+\tstruct libie_aq_desc *aq_desc = desc;\n+\tu16 datalen, flags;\n+\n+\tdatalen = le16_to_cpu(aq_desc->datalen);\n+\tflags = le16_to_cpu(aq_desc->flags);\n+\n+\thw_dbg(hw, \"CQ CMD: opcode 0x%04X, flags 0x%04X, datalen 0x%04X, retval 0x%04X\\n\",\n+\t le16_to_cpu(aq_desc->opcode), flags, datalen,\n+\t le16_to_cpu(aq_desc->retval));\n+\thw_dbg(hw, \"\\tcookie (h,l) 0x%08X 0x%08X\\n\",\n+\t le32_to_cpu(aq_desc->cookie_high),\n+\t le32_to_cpu(aq_desc->cookie_low));\n+\thw_dbg(hw, \"\\tparam (0,1) 0x%08X 0x%08X\\n\",\n+\t le32_to_cpu(aq_desc->params.generic.param0),\n+\t le32_to_cpu(aq_desc->params.generic.param1));\n+\thw_dbg(hw, \"\\taddr (h,l) 0x%08X 0x%08X\\n\",\n+\t le32_to_cpu(aq_desc->params.generic.addr_high),\n+\t le32_to_cpu(aq_desc->params.generic.addr_low));\n+\n+\tif (buf && datalen && (flags & (LIBIE_AQ_FLAG_DD | LIBIE_AQ_FLAG_CMP |\n+\t LIBIE_AQ_FLAG_RD))) {\n+\t\thw_dbg(hw, \"Buffer:\\n\");\n+\t\tixgbe_hex_debug_dump(hw, buf, min(buf_len, datalen));\n+\t}\n+}\n+\n /**\n * ixgbe_should_retry_aci_send_cmd_execute - decide if ACI command should\n * be resent\n@@ -69,26 +141,33 @@ static int ixgbe_aci_send_cmd_execute(struct ixgbe_hw *hw,\n \t/* It's necessary to check if mechanism is enabled */\n \thicr = IXGBE_READ_REG(hw, IXGBE_PF_HICR);\n \n-\tif (!(hicr & IXGBE_PF_HICR_EN))\n+\tif (!(hicr & IXGBE_PF_HICR_EN)) {\n+\t\thw_dbg(hw, \"CSR mechanism is not enabled\\n\");\n \t\treturn -EIO;\n+\t}\n \n \tif (hicr & IXGBE_PF_HICR_C) {\n \t\thw->aci.last_status = LIBIE_AQ_RC_EBUSY;\n+\t\thw_dbg(hw, \"CSR mechanism is busy\\n\");\n \t\treturn -EBUSY;\n \t}\n \n \topcode = le16_to_cpu(desc->opcode);\n \n-\tif (buf_size > IXGBE_ACI_MAX_BUFFER_SIZE)\n+\tif (buf_size > IXGBE_ACI_MAX_BUFFER_SIZE) {\n+\t\thw_dbg(hw, \"buf_size is too big\\n\");\n \t\treturn -EINVAL;\n+\t}\n \n \tif (buf)\n \t\tdesc->flags |= cpu_to_le16(LIBIE_AQ_FLAG_BUF);\n \n \tif (desc->flags & cpu_to_le16(LIBIE_AQ_FLAG_BUF)) {\n \t\tif ((buf && !buf_size) ||\n-\t\t (!buf && buf_size))\n+\t\t (!buf && buf_size)) {\n+\t\t\thw_dbg(hw, \"error: invalid argument buf or buf_size\\n\");\n \t\t\treturn -EINVAL;\n+\t\t}\n \t\tif (buf && buf_size)\n \t\t\tvalid_buf = true;\n \t}\n@@ -106,8 +185,12 @@ static int ixgbe_aci_send_cmd_execute(struct ixgbe_hw *hw,\n \t\tif (desc->flags & cpu_to_le16(LIBIE_AQ_FLAG_RD)) {\n \t\t\tfor (i = 0; i < buf_size / 4; i++)\n \t\t\t\tIXGBE_WRITE_REG(hw, IXGBE_PF_HIBA(i), ((u32 *)buf)[i]);\n-\t\t\tif (buf_tail_size)\n+\t\t\tixgbe_aci_debug(hw, desc, buf, buf_size);\n+\t\t\tif (buf_tail_size) {\n \t\t\t\tIXGBE_WRITE_REG(hw, IXGBE_PF_HIBA(i), buf_tail);\n+\t\t\t\tixgbe_aci_debug(hw, desc, &buf_tail,\n+\t\t\t\t\t\tbuf_tail_size);\n+\t\t\t}\n \t\t}\n \t}\n \n@@ -147,6 +230,7 @@ static int ixgbe_aci_send_cmd_execute(struct ixgbe_hw *hw,\n \t\t\traw_desc[i] = IXGBE_READ_REG(hw, IXGBE_PF_HIDA(i));\n \t\t\traw_desc[i] = raw_desc[i];\n \t\t}\n+\t\tixgbe_aci_debug(hw, raw_desc, NULL, 0);\n \t}\n \n \t/* Read async Admin Command response */\n@@ -155,14 +239,21 @@ static int ixgbe_aci_send_cmd_execute(struct ixgbe_hw *hw,\n \t\t\traw_desc[i] = IXGBE_READ_REG(hw, IXGBE_PF_HIDA_2(i));\n \t\t\traw_desc[i] = raw_desc[i];\n \t\t}\n+\t\tixgbe_aci_debug(hw, raw_desc, NULL, 0);\n \t}\n \n \t/* Handle timeout and invalid state of HICR register */\n-\tif (hicr & IXGBE_PF_HICR_C)\n+\tif (hicr & IXGBE_PF_HICR_C) {\n+\t\thw_dbg(hw, \"error: Admin Command 0x%X command timeout\\n\",\n+\t\t le16_to_cpu(desc->opcode));\n \t\treturn -ETIME;\n+\t}\n \n-\tif (!(hicr & IXGBE_PF_HICR_SV) && !(hicr & IXGBE_PF_HICR_EV))\n+\tif (!(hicr & IXGBE_PF_HICR_SV) && !(hicr & IXGBE_PF_HICR_EV)) {\n+\t\thw_dbg(hw, \"error: Admin Command 0x%X invalid state of HICR register\\n\",\n+\t\t le16_to_cpu(desc->opcode));\n \t\treturn -EIO;\n+\t}\n \n \t/* For every command other than 0x0014 treat opcode mismatch\n \t * as an error. Response to 0x0014 command read from HIDA_2\n@@ -170,12 +261,16 @@ static int ixgbe_aci_send_cmd_execute(struct ixgbe_hw *hw,\n \t * different opcode than the command.\n \t */\n \tif (desc->opcode != cpu_to_le16(opcode) &&\n-\t opcode != ixgbe_aci_opc_get_fw_event)\n+\t opcode != ixgbe_aci_opc_get_fw_event) {\n+\t\thw_dbg(hw, \"error: Admin Command failed, bad opcode returned\\n\");\n \t\treturn -EIO;\n+\t}\n \n \tif (desc->retval) {\n \t\thw->aci.last_status = (enum libie_aq_err)\n \t\t\tle16_to_cpu(desc->retval);\n+\t\thw_dbg(hw, \"error: Admin Command failed with error %x\\n\",\n+\t\t le16_to_cpu(desc->retval));\n \t\treturn -EIO;\n \t}\n \n@@ -183,10 +278,13 @@ static int ixgbe_aci_send_cmd_execute(struct ixgbe_hw *hw,\n \tif (valid_buf) {\n \t\tfor (i = 0; i < buf_size / 4; i++)\n \t\t\t((u32 *)buf)[i] = IXGBE_READ_REG(hw, IXGBE_PF_HIBA(i));\n+\t\tixgbe_aci_debug(hw, raw_desc, buf, buf_size);\n \t\tif (buf_tail_size) {\n \t\t\tbuf_tail = IXGBE_READ_REG(hw, IXGBE_PF_HIBA(i));\n \t\t\tmemcpy(buf + buf_size - buf_tail_size, &buf_tail,\n \t\t\t buf_tail_size);\n+\t\t\tixgbe_aci_debug(hw, raw_desc, &buf_tail,\n+\t\t\t\t\tbuf_tail_size);\n \t\t}\n \t}\n \n", "prefixes": [ "iwl-next", "v3" ] }