Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2189388/?format=api
{ "id": 2189388, "url": "http://patchwork.ozlabs.org/api/patches/2189388/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260127085410.79645-6-takkozu@amazon.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260127085410.79645-6-takkozu@amazon.com>", "list_archive_url": null, "date": "2026-01-27T08:54:08", "name": "[iwl-next,v5,1/3] igb: prepare for RSS key get/set support", "commit_ref": null, "pull_url": null, "state": "under-review", "archived": false, "hash": "3bcb382f2637845801dc29bab39d673417f84888", "submitter": { "id": 92211, "url": "http://patchwork.ozlabs.org/api/people/92211/?format=api", "name": "Takashi Kozu", "email": "takkozu@amazon.com" }, "delegate": { "id": 109701, "url": "http://patchwork.ozlabs.org/api/users/109701/?format=api", "username": "anguy11", "first_name": "Anthony", "last_name": "Nguyen", "email": "anthony.l.nguyen@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260127085410.79645-6-takkozu@amazon.com/mbox/", "series": [ { "id": 489868, "url": "http://patchwork.ozlabs.org/api/series/489868/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=489868", "date": "2026-01-27T08:54:07", "name": "igb: add RSS key get/set support", "version": 5, "mbox": "http://patchwork.ozlabs.org/series/489868/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2189388/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2189388/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=wPD6Pw63;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::137; helo=smtp4.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4f0fQ53fJdz1xqf\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 27 Jan 2026 19:55:57 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 572BD40B84;\n\tTue, 27 Jan 2026 08:55:55 +0000 (UTC)", "from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id vdhRw68mypik; Tue, 27 Jan 2026 08:55:54 +0000 (UTC)", "from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 1202640B81;\n\tTue, 27 Jan 2026 08:55:54 +0000 (UTC)", "from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136])\n by lists1.osuosl.org (Postfix) with ESMTP id 1ECD72F4\n for <intel-wired-lan@lists.osuosl.org>; Tue, 27 Jan 2026 08:55:53 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp3.osuosl.org (Postfix) with ESMTP id 0EA8460F2D\n for <intel-wired-lan@lists.osuosl.org>; Tue, 27 Jan 2026 08:55:53 +0000 (UTC)", "from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id 66XctEd8xsb9 for <intel-wired-lan@lists.osuosl.org>;\n Tue, 27 Jan 2026 08:55:52 +0000 (UTC)", "from pdx-out-002.esa.us-west-2.outbound.mail-perimeter.amazon.com\n (pdx-out-002.esa.us-west-2.outbound.mail-perimeter.amazon.com [44.246.1.125])\n by smtp3.osuosl.org (Postfix) with ESMTPS id 07B8D60F29\n for <intel-wired-lan@lists.osuosl.org>; Tue, 27 Jan 2026 08:55:51 +0000 (UTC)", "from ip-10-5-9-48.us-west-2.compute.internal (HELO\n smtpout.naws.us-west-2.prod.farcaster.email.amazon.dev) ([10.5.9.48])\n by internal-pdx-out-002.esa.us-west-2.outbound.mail-perimeter.amazon.com with\n ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jan 2026 08:55:49 +0000", "from EX19MTAUWA001.ant.amazon.com [205.251.233.236:25481]\n by smtpin.naws.us-west-2.prod.farcaster.email.amazon.dev [10.0.21.97:2525]\n with esmtp (Farcaster)\n id 58bd2a5e-5ca5-4efb-ae3e-72a03727abff;\n Tue, 27 Jan 2026 08:55:48 +0000 (UTC)", "from EX19D001UWA001.ant.amazon.com (10.13.138.214) by\n EX19MTAUWA001.ant.amazon.com (10.250.64.218) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.2562.35;\n Tue, 27 Jan 2026 08:55:48 +0000", "from 603e5f7bc1fe.amazon.com (10.37.245.7) by\n EX19D001UWA001.ant.amazon.com (10.13.138.214) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.2562.35;\n Tue, 27 Jan 2026 08:55:46 +0000" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp4.osuosl.org 1202640B81", "OpenDKIM Filter v2.11.0 smtp3.osuosl.org 07B8D60F29" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1769504154;\n\tbh=QfY1g9C2h8elKkHTNNBWGB62LHLqZF4532Rj48fTap8=;\n\th=From:To:CC:Date:In-Reply-To:References:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=wPD6Pw63hVG+aHwzsbGHVwV+am94kWzDAmy3QfOVo1D3ZAK16tJBTt10GNSLhPcil\n\t sagblko4N7pavN0IaCl46eDc+qEAkFk0TVECS8AiV69Ceu5nhNBVesXxAAq9NPflmP\n\t W+UI3hqXii1VtVgV63s2LYvxQQInkcrMpqbnbT9wbtJr5LuetP5onGhnUEzZmXnU6x\n\t TP4rOFs435e991WluriUeDa3JwqvLm+2InUT35RYAnxF0PpGuDyBl1LHVSw4Si9uoL\n\t qsT3aMd2zHEzTCj28bLzak7TcC4Z/U7WSqxcet3uVSoK9G4tjWxQhwXYz8qz0IZj9M\n\t MJPdVGWHLcu5A==", "Received-SPF": "Pass (mailfrom) identity=mailfrom; client-ip=44.246.1.125;\n helo=pdx-out-002.esa.us-west-2.outbound.mail-perimeter.amazon.com;\n envelope-from=prvs=4803e00d0=takkozu@amazon.co.jp; receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp3.osuosl.org 07B8D60F29", "X-CSE-ConnectionGUID": "h6rt98Y2S+ytNYHQ1vJRDQ==", "X-CSE-MsgGUID": "ohHjiut/QPKWiA28xw+EWw==", "X-IronPort-AV": "E=Sophos;i=\"6.21,256,1763424000\"; d=\"scan'208\";a=\"11668567\"", "X-Farcaster-Flow-ID": "58bd2a5e-5ca5-4efb-ae3e-72a03727abff", "From": "Takashi Kozu <takkozu@amazon.com>", "To": "<anthony.l.nguyen@intel.com>", "CC": "<przemyslaw.kitszel@intel.com>, <andrew+netdev@lunn.ch>,\n <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,\n <pabeni@redhat.com>, <intel-wired-lan@lists.osuosl.org>,\n <netdev@vger.kernel.org>, <aleksandr.loktionov@intel.com>,\n <pmenzel@molgen.mpg.de>, <piotr.kwapulinski@intel.com>, <enjuk@amazon.com>,\n Takashi Kozu <takkozu@amazon.com>", "Date": "Tue, 27 Jan 2026 17:54:08 +0900", "Message-ID": "<20260127085410.79645-6-takkozu@amazon.com>", "X-Mailer": "git-send-email 2.47.0", "In-Reply-To": "<20260127085410.79645-5-takkozu@amazon.com>", "References": "<20260127085410.79645-5-takkozu@amazon.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.37.245.7]", "X-ClientProxiedBy": "EX19D045UWC004.ant.amazon.com (10.13.139.203) To\n EX19D001UWA001.ant.amazon.com (10.13.138.214)", "X-Mailman-Original-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=amazon.com; i=@amazon.com; q=dns/txt; s=amazoncorp2;\n t=1769504152; x=1801040152;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=QfY1g9C2h8elKkHTNNBWGB62LHLqZF4532Rj48fTap8=;\n b=kFoICwVoN/wKI0SDsfAH5IIgl9FCoiWHRqeX76/s2NDLyYLSxSO3HvgL\n U4F6Vu0pQO/nCzQTMJ85cOQOgeUDiUhFN2Uj7WyFvYmsrU44gyCBcu4vu\n HNQO6s3UnAOTq8RdlLZrOqaoBFnAfCgzIvhUnWpzUQUL0+hoBp8z/GuC9\n 43DuRvLTyG3B7SM3pp3oHXg1ZD1NwOAE7+zHs9W6ueBMuzmvyCpD68pRy\n Y1zRIKMTtAIiXwm4nGk+biVleaW0IIvQaRehJiJKCbBr3J0ywy0AN1Er0\n iFoMJpyIajnC4qC7rJCdQ1z7BLpRdR23KQNTGa0FXh+I1Cr5N55JzTK59\n Q==;", "X-Mailman-Original-Authentication-Results": [ "smtp3.osuosl.org;\n dmarc=pass (p=quarantine dis=none)\n header.from=amazon.com", "smtp3.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=amazon.com header.i=@amazon.com header.a=rsa-sha256\n header.s=amazoncorp2 header.b=kFoICwVo" ], "Subject": "[Intel-wired-lan] [PATCH iwl-next v5 1/3] igb: prepare for RSS key\n get/set support", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Store the RSS key inside struct igb_adapter and introduce the\nigb_write_rss_key() helper function. This allows the driver to program\nthe E1000 registers using a persistent RSS key, instead of using a\nstack-local buffer in igb_setup_mrqc().\n\nReviewed-by: Piotr Kwapulinski <piotr.kwapulinski@intel.com>\nReviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>\nSigned-off-by: Takashi Kozu <takkozu@amazon.com>\n---\n drivers/net/ethernet/intel/igb/igb.h | 3 +++\n drivers/net/ethernet/intel/igb/igb_ethtool.c | 21 ++++++++++++++++++++\n drivers/net/ethernet/intel/igb/igb_main.c | 8 ++++----\n 3 files changed, 28 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/igb/igb.h b/drivers/net/ethernet/intel/igb/igb.h\nindex 0fff1df81b7b..8c9b02058cec 100644\n--- a/drivers/net/ethernet/intel/igb/igb.h\n+++ b/drivers/net/ethernet/intel/igb/igb.h\n@@ -495,6 +495,7 @@ struct hwmon_buff {\n #define IGB_N_PEROUT\t2\n #define IGB_N_SDP\t4\n #define IGB_RETA_SIZE\t128\n+#define IGB_RSS_KEY_SIZE\t40\n \n enum igb_filter_match_flags {\n \tIGB_FILTER_FLAG_ETHER_TYPE = 0x1,\n@@ -655,6 +656,7 @@ struct igb_adapter {\n \tstruct i2c_client *i2c_client;\n \tu32 rss_indir_tbl_init;\n \tu8 rss_indir_tbl[IGB_RETA_SIZE];\n+\tu8 rss_key[IGB_RSS_KEY_SIZE];\n \n \tunsigned long link_check_timeout;\n \tint copper_tries;\n@@ -735,6 +737,7 @@ void igb_down(struct igb_adapter *);\n void igb_reinit_locked(struct igb_adapter *);\n void igb_reset(struct igb_adapter *);\n int igb_reinit_queues(struct igb_adapter *);\n+void igb_write_rss_key(struct igb_adapter *adapter);\n void igb_write_rss_indir_tbl(struct igb_adapter *);\n int igb_set_spd_dplx(struct igb_adapter *, u32, u8);\n int igb_setup_tx_resources(struct igb_ring *);\ndiff --git a/drivers/net/ethernet/intel/igb/igb_ethtool.c b/drivers/net/ethernet/intel/igb/igb_ethtool.c\nindex b507576b28b2..a93069b761a6 100644\n--- a/drivers/net/ethernet/intel/igb/igb_ethtool.c\n+++ b/drivers/net/ethernet/intel/igb/igb_ethtool.c\n@@ -3019,6 +3019,27 @@ static int igb_set_rxnfc(struct net_device *dev, struct ethtool_rxnfc *cmd)\n \treturn ret;\n }\n \n+/**\n+ * igb_write_rss_key - Program the RSS key into device registers\n+ * @adapter: board private structure\n+ *\n+ * Write the RSS key stored in adapter->rss_key to the E1000 hardware registers.\n+ * Each 32-bit chunk of the key is read using get_unaligned_le32() and written\n+ * to the appropriate register.\n+ */\n+void igb_write_rss_key(struct igb_adapter *adapter)\n+{\n+\tstruct e1000_hw *hw = &adapter->hw;\n+\n+\tASSERT_RTNL();\n+\n+\tfor (int i = 0; i < IGB_RSS_KEY_SIZE / 4; i++) {\n+\t\tu32 val = get_unaligned_le32(&adapter->rss_key[i * 4]);\n+\n+\t\twr32(E1000_RSSRK(i), val);\n+\t}\n+}\n+\n static int igb_get_eee(struct net_device *netdev, struct ethtool_keee *edata)\n {\n \tstruct igb_adapter *adapter = netdev_priv(netdev);\ndiff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c\nindex dbea37269d2c..c703011b19ec 100644\n--- a/drivers/net/ethernet/intel/igb/igb_main.c\n+++ b/drivers/net/ethernet/intel/igb/igb_main.c\n@@ -4050,6 +4050,9 @@ static int igb_sw_init(struct igb_adapter *adapter)\n \n \tpci_read_config_word(pdev, PCI_COMMAND, &hw->bus.pci_cmd_word);\n \n+\t/* init RSS key */\n+\tnetdev_rss_key_fill(adapter->rss_key, sizeof(adapter->rss_key));\n+\n \t/* set default ring sizes */\n \tadapter->tx_ring_count = IGB_DEFAULT_TXD;\n \tadapter->rx_ring_count = IGB_DEFAULT_RXD;\n@@ -4525,11 +4528,8 @@ static void igb_setup_mrqc(struct igb_adapter *adapter)\n \tstruct e1000_hw *hw = &adapter->hw;\n \tu32 mrqc, rxcsum;\n \tu32 j, num_rx_queues;\n-\tu32 rss_key[10];\n \n-\tnetdev_rss_key_fill(rss_key, sizeof(rss_key));\n-\tfor (j = 0; j < 10; j++)\n-\t\twr32(E1000_RSSRK(j), rss_key[j]);\n+\tigb_write_rss_key(adapter);\n \n \tnum_rx_queues = adapter->rss_queues;\n \n", "prefixes": [ "iwl-next", "v5", "1/3" ] }