Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2187663/?format=api
{ "id": 2187663, "url": "http://patchwork.ozlabs.org/api/patches/2187663/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260122134809.7765-1-kohei@enjuk.jp/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260122134809.7765-1-kohei@enjuk.jp>", "list_archive_url": null, "date": "2026-01-22T13:47:46", "name": "[v2,iwl-next] igb: set skb hash type from RSS_TYPE", "commit_ref": null, "pull_url": null, "state": "under-review", "archived": false, "hash": "74f3624765e30f73504e4afc6831228b6797702d", "submitter": { "id": 92459, "url": "http://patchwork.ozlabs.org/api/people/92459/?format=api", "name": "Kohei Enju", "email": "kohei@enjuk.jp" }, "delegate": { "id": 109701, "url": "http://patchwork.ozlabs.org/api/users/109701/?format=api", "username": "anguy11", "first_name": "Anthony", "last_name": "Nguyen", "email": "anthony.l.nguyen@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260122134809.7765-1-kohei@enjuk.jp/mbox/", "series": [ { "id": 489382, "url": "http://patchwork.ozlabs.org/api/series/489382/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=489382", "date": "2026-01-22T13:47:46", "name": "[v2,iwl-next] igb: set skb hash type from RSS_TYPE", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/489382/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2187663/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2187663/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=JYxVrS/f;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.137; helo=smtp4.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4dxj87039bz1xrD\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 23 Jan 2026 00:48:38 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id B6B1446B64;\n\tThu, 22 Jan 2026 13:48:36 +0000 (UTC)", "from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id O8q57GPjSTAI; Thu, 22 Jan 2026 13:48:35 +0000 (UTC)", "from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id F081B4694C;\n\tThu, 22 Jan 2026 13:48:34 +0000 (UTC)", "from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n by lists1.osuosl.org (Postfix) with ESMTP id 6839924D\n for <intel-wired-lan@lists.osuosl.org>; Thu, 22 Jan 2026 13:48:33 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp2.osuosl.org (Postfix) with ESMTP id 57B9240C64\n for <intel-wired-lan@lists.osuosl.org>; Thu, 22 Jan 2026 13:48:33 +0000 (UTC)", "from smtp2.osuosl.org ([127.0.0.1])\n by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id 1hnXFemwmIVA for <intel-wired-lan@lists.osuosl.org>;\n Thu, 22 Jan 2026 13:48:32 +0000 (UTC)", "from www2881.sakura.ne.jp (www2881.sakura.ne.jp [49.212.198.91])\n by smtp2.osuosl.org (Postfix) with ESMTPS id 2A6A9424EA\n for <intel-wired-lan@lists.osuosl.org>; Thu, 22 Jan 2026 13:48:31 +0000 (UTC)", "from ms-a2 (79.192.13.160.dy.iij4u.or.jp [160.13.192.79])\n (authenticated bits=0)\n by www2881.sakura.ne.jp (8.16.1/8.16.1) with ESMTPSA id 60MDmAkd061527\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);\n Thu, 22 Jan 2026 22:48:11 +0900 (JST) (envelope-from kohei@enjuk.jp)" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp4.osuosl.org F081B4694C", "OpenDKIM Filter v2.11.0 smtp2.osuosl.org 2A6A9424EA" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1769089715;\n\tbh=PPx7lBvZdRocqs9Ic7hyxz4MceYROtyFu1Q8VoDJ5rc=;\n\th=From:To:Cc:Date:Subject:List-Id:List-Unsubscribe:List-Archive:\n\t List-Post:List-Help:List-Subscribe:From;\n\tb=JYxVrS/fvbWqC6MA4mjrMbcqPNUeADa06mtBaUjAq1ydI5L2uGj11W/6g+6qKRAbG\n\t AnLJ2RqxmnzeRiNISLVoXpe3G/W/eRKcMukfLwdX9WY9hD72VImizkbwjKcyPbTZiT\n\t 1dhqc6BB4XVEKBufTTfafj5Dg4L5ReMX2m2nKRv+AIZirSFfmFEL+6wS4aZyiS2tWz\n\t swOu9887lfg2lrW9OSuL5I636xI+pCOJgsJ+H2cVJdFFzfqaP5JymfE626Iq3lxFOi\n\t FJSZN2X9j2hhRL4AsefKZRno+/67wG39uEhxP7QafOPKJI0GVriA6NOk00lnfuucWm\n\t 3ar2Bh9TsZoeA==", "Received-SPF": "Pass (mailfrom) identity=mailfrom; client-ip=49.212.198.91;\n helo=www2881.sakura.ne.jp; envelope-from=kohei@enjuk.jp; receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp2.osuosl.org 2A6A9424EA", "From": "Kohei Enju <kohei@enjuk.jp>", "To": "intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org", "Cc": "Tony Nguyen <anthony.l.nguyen@intel.com>,\n Przemek Kitszel <przemyslaw.kitszel@intel.com>,\n Andrew Lunn <andrew+netdev@lunn.ch>,\n \"David S. Miller\" <davem@davemloft.net>,\n Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>,\n Paolo Abeni <pabeni@redhat.com>, kohei.enju@gmail.com,\n Kohei Enju <kohei@enjuk.jp>,\n Aleksandr Loktionov <aleksandr.loktionov@intel.com>", "Date": "Thu, 22 Jan 2026 13:47:46 +0000", "Message-ID": "<20260122134809.7765-1-kohei@enjuk.jp>", "X-Mailer": "git-send-email 2.51.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Original-DKIM-Signature": "a=rsa-sha256;\n bh=PPx7lBvZdRocqs9Ic7hyxz4MceYROtyFu1Q8VoDJ5rc=;\n c=relaxed/relaxed; d=enjuk.jp;\n h=From:To:Subject:Date:Message-ID;\n s=rs20251215; t=1769089692; v=1;\n b=Yoavn74erfL56Hc73SWC+KaIwCdQtTUPmXZdvsuA+4jlffmNcncKDT2wPpgnvwJt\n 5K7UieVXf1Bd9vnZt7t69lsAFiX6q17vsPRLYEqkjFVDVNs5m4IRnbyInGzY85K6\n p5mq38smUAhzkyQ7vHGjb8d8jUfhP0UZNr7cmwYrbkQ0RZF7A3mBe7Cs1Kxp0wP/\n k7wL60/KsW15YVoYL3GQAEzeUh04X6dbZ84dKrYAHE0tWDvg2PJFUzXhh9DlTRjn\n Kre8E0gz1mICF3Hhr2f22qgoU9rtXsJ4fQ4ZVj1T2ivLJlhklYiBrkw8en7nXSOv\n m8fwXhQuBy9Q3GuBV6vR1Q==", "X-Mailman-Original-Authentication-Results": [ "smtp2.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=enjuk.jp", "smtp2.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=enjuk.jp header.i=@enjuk.jp header.a=rsa-sha256\n header.s=rs20251215 header.b=Yoavn74e" ], "Subject": "[Intel-wired-lan] [PATCH v2 iwl-next] igb: set skb hash type from\n RSS_TYPE", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "igb always marks the RX hash as L3 regardless of RSS_TYPE in the\nadvanced descriptor, which may indicate L4 (TCP/UDP) hash. This can\ntrigger unnecessary SW hash recalculation and breaks toeplitz selftests.\n\nUse RSS_TYPE from pkt_info to set the correct PKT_HASH_TYPE_*\n\nTested by toeplitz.py with the igb RSS key get/set patches applied as\nthey are required for toeplitz.py (see Link below).\n # ethtool -N $DEV rx-flow-hash udp4 sdfn\n # ethtool -N $DEV rx-flow-hash udp6 sdfn\n # python toeplitz.py | grep -E \"^# Totals\"\n\nWithout patch:\n # Totals: pass:0 fail:12 xfail:0 xpass:0 skip:0 error:0\n\nWith patch:\n # Totals: pass:12 fail:0 xfail:0 xpass:0 skip:0 error:0\n\nLink: https://lore.kernel.org/intel-wired-lan/20260119084511.95287-5-takkozu@amazon.com/\nSigned-off-by: Kohei Enju <kohei@enjuk.jp>\nReviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>\n---\nChangelog:\n v2:\n - Fix max-line-length by removing unnecessary comment\n v1: https://lore.kernel.org/intel-wired-lan/20260119175922.199950-1-kohei@enjuk.jp/\n---\n drivers/net/ethernet/intel/igb/e1000_82575.h | 21 ++++++++++++++++++++\n drivers/net/ethernet/intel/igb/igb_main.c | 18 +++++++++++++----\n 2 files changed, 35 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/igb/e1000_82575.h b/drivers/net/ethernet/intel/igb/e1000_82575.h\nindex 63ec253ac788..9e696d55e512 100644\n--- a/drivers/net/ethernet/intel/igb/e1000_82575.h\n+++ b/drivers/net/ethernet/intel/igb/e1000_82575.h\n@@ -87,6 +87,27 @@ union e1000_adv_rx_desc {\n \t} wb; /* writeback */\n };\n \n+#define E1000_RSS_TYPE_NO_HASH\t\t 0\n+#define E1000_RSS_TYPE_HASH_TCP_IPV4\t 1\n+#define E1000_RSS_TYPE_HASH_IPV4\t 2\n+#define E1000_RSS_TYPE_HASH_TCP_IPV6\t 3\n+#define E1000_RSS_TYPE_HASH_IPV6_EX\t 4\n+#define E1000_RSS_TYPE_HASH_IPV6\t 5\n+#define E1000_RSS_TYPE_HASH_TCP_IPV6_EX\t 6\n+#define E1000_RSS_TYPE_HASH_UDP_IPV4\t 7\n+#define E1000_RSS_TYPE_HASH_UDP_IPV6\t 8\n+#define E1000_RSS_TYPE_HASH_UDP_IPV6_EX\t 9\n+\n+#define E1000_RSS_TYPE_MASK\t\tGENMASK(3, 0)\n+\n+#define E1000_RSS_L4_TYPES_MASK\t\\\n+\t(BIT(E1000_RSS_TYPE_HASH_TCP_IPV4)\t| \\\n+\t BIT(E1000_RSS_TYPE_HASH_TCP_IPV6)\t| \\\n+\t BIT(E1000_RSS_TYPE_HASH_TCP_IPV6_EX)\t| \\\n+\t BIT(E1000_RSS_TYPE_HASH_UDP_IPV4)\t| \\\n+\t BIT(E1000_RSS_TYPE_HASH_UDP_IPV6)\t| \\\n+\t BIT(E1000_RSS_TYPE_HASH_UDP_IPV6_EX))\n+\n #define E1000_RXDADV_HDRBUFLEN_MASK 0x7FE0\n #define E1000_RXDADV_HDRBUFLEN_SHIFT 5\n #define E1000_RXDADV_STAT_TS 0x10000 /* Pkt was time stamped */\ndiff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c\nindex 8dab133296ca..ef0cbf532716 100644\n--- a/drivers/net/ethernet/intel/igb/igb_main.c\n+++ b/drivers/net/ethernet/intel/igb/igb_main.c\n@@ -8824,10 +8824,20 @@ static inline void igb_rx_hash(struct igb_ring *ring,\n \t\t\t union e1000_adv_rx_desc *rx_desc,\n \t\t\t struct sk_buff *skb)\n {\n-\tif (ring->netdev->features & NETIF_F_RXHASH)\n-\t\tskb_set_hash(skb,\n-\t\t\t le32_to_cpu(rx_desc->wb.lower.hi_dword.rss),\n-\t\t\t PKT_HASH_TYPE_L3);\n+\tu16 rss_type;\n+\n+\tif (!(ring->netdev->features & NETIF_F_RXHASH))\n+\t\treturn;\n+\n+\trss_type = le16_to_cpu(rx_desc->wb.lower.lo_dword.pkt_info) &\n+\t\t E1000_RSS_TYPE_MASK;\n+\n+\tif (!rss_type)\n+\t\treturn;\n+\n+\tskb_set_hash(skb, le32_to_cpu(rx_desc->wb.lower.hi_dword.rss),\n+\t\t (E1000_RSS_L4_TYPES_MASK & BIT(rss_type)) ?\n+\t\t PKT_HASH_TYPE_L4 : PKT_HASH_TYPE_L3);\n }\n \n /**\n", "prefixes": [ "v2", "iwl-next" ] }