Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2187484/?format=api
{ "id": 2187484, "url": "http://patchwork.ozlabs.org/api/patches/2187484/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260122032644.183754-1-zilin@seu.edu.cn/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260122032644.183754-1-zilin@seu.edu.cn>", "list_archive_url": null, "date": "2026-01-22T03:26:44", "name": "[net] ice: Fix memory leak in ice_set_ringparam()", "commit_ref": null, "pull_url": null, "state": "under-review", "archived": false, "hash": "72803a2cb782b22fdbcda4ca59bafbfc61bfdca2", "submitter": { "id": 92091, "url": "http://patchwork.ozlabs.org/api/people/92091/?format=api", "name": "Zilin Guan", "email": "zilin@seu.edu.cn" }, "delegate": { "id": 109701, "url": "http://patchwork.ozlabs.org/api/users/109701/?format=api", "username": "anguy11", "first_name": "Anthony", "last_name": "Nguyen", "email": "anthony.l.nguyen@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260122032644.183754-1-zilin@seu.edu.cn/mbox/", "series": [ { "id": 489316, "url": "http://patchwork.ozlabs.org/api/series/489316/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=489316", "date": "2026-01-22T03:26:44", "name": "[net] ice: Fix memory leak in ice_set_ringparam()", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/489316/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2187484/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2187484/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=ug6ulRix;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::137; helo=smtp4.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4dxRSv4c5dz1xsN\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 22 Jan 2026 14:32:14 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 2FC9042B38;\n\tThu, 22 Jan 2026 03:32:08 +0000 (UTC)", "from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id qNP8K_GD6QuE; Thu, 22 Jan 2026 03:32:07 +0000 (UTC)", "from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 47BC641E26;\n\tThu, 22 Jan 2026 03:32:07 +0000 (UTC)", "from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n by lists1.osuosl.org (Postfix) with ESMTP id 6ACC5122\n for <intel-wired-lan@lists.osuosl.org>; Thu, 22 Jan 2026 03:32:05 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp4.osuosl.org (Postfix) with ESMTP id 457A841E26\n for <intel-wired-lan@lists.osuosl.org>; Thu, 22 Jan 2026 03:32:05 +0000 (UTC)", "from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id MWkt_X5Hg25U for <intel-wired-lan@lists.osuosl.org>;\n Thu, 22 Jan 2026 03:32:04 +0000 (UTC)", "from mail-m81205.xmail.ntesmail.com (mail-m81205.xmail.ntesmail.com\n [156.224.81.205])\n by smtp4.osuosl.org (Postfix) with ESMTPS id 6178A4130B\n for <intel-wired-lan@lists.osuosl.org>; Thu, 22 Jan 2026 03:32:01 +0000 (UTC)", "from LAPTOP-N070L597.localdomain (unknown [223.112.146.162])\n by smtp.qiye.163.com (Hmail) with ESMTP id 318765b89;\n Thu, 22 Jan 2026 11:26:48 +0800 (GMT+08:00)" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp4.osuosl.org 47BC641E26", "OpenDKIM Filter v2.11.0 smtp4.osuosl.org 6178A4130B" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1769052727;\n\tbh=ffflAwULRkleIYICFHP/WFtQuZMy6nCm9F9CV+XYt/M=;\n\th=From:To:Cc:Date:Subject:List-Id:List-Unsubscribe:List-Archive:\n\t List-Post:List-Help:List-Subscribe:From;\n\tb=ug6ulRixBXivi2jFoe8jd0nsqoSRpLzQfIZBIqHbRJBs5ffxCOD/u2Z+QCGQbWVzU\n\t InCez+r43Ws52sx1vljbK4Xsk3zj9+efzS80dPotb2dUoZWUglp8wOwz/5dN3ckYaq\n\t sZiWGTHSS7fOXAD4ySeK+MVu5w7OrD+CbmrJTFyxmw99mmgmoT7KiQzRvTF/5YebkM\n\t uftqmCvLqli38WLPY6/FQtMNXJcVGR2sP0OSuyaD3tAjX/a5Hlm2XdCHgmQN/EO63f\n\t PILOMkWtNbh/SQOD90/F8dSTyLfknr5uiAEJeCIRUhWsX/7NrAW3ARydn+x6EXpWld\n\t iFCZSrHpkSEjg==", "X-Greylist": "delayed 305 seconds by postgrey-1.37 at util1.osuosl.org;\n Thu, 22 Jan 2026 03:32:02 UTC", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp4.osuosl.org 6178A4130B", "Received-SPF": "Pass (mailfrom) identity=mailfrom; client-ip=156.224.81.205;\n helo=mail-m81205.xmail.ntesmail.com; envelope-from=zilin@seu.edu.cn;\n receiver=<UNKNOWN>", "From": "Zilin Guan <zilin@seu.edu.cn>", "To": "anthony.l.nguyen@intel.com", "Cc": "przemyslaw.kitszel@intel.com, andrew+netdev@lunn.ch, davem@davemloft.net,\n edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,\n intel-wired-lan@lists.osuosl.org, linux-kernel@vger.kernel.org,\n netdev@vger.kernel.org, jianhao.xu@seu.edu.cn,\n Zilin Guan <zilin@seu.edu.cn>", "Date": "Thu, 22 Jan 2026 03:26:44 +0000", "Message-Id": "<20260122032644.183754-1-zilin@seu.edu.cn>", "X-Mailer": "git-send-email 2.34.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-HM-Tid": "0a9be3bd8a0103a1kunm23da51ae25240", "X-HM-MType": "10", "X-HM-Spam-Status": "e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly\n tZV1koWUFITzdXWS1ZQUlXWQ8JGhUIEh9ZQVlDSEIdVkxPHk1DH00fGU5LGFYeHw5VEwETFhoSFy\n QUDg9ZV1kYEgtZQVlJSUhVSkpJVUpPTVVKTUlZV1kWGg8SFR0UWUFZT0tIVUpLSUhOQ0NVSktLVU\n tZBg++", "X-Mailman-Original-DKIM-Signature": "a=rsa-sha256;\n b=g5rPP77AIAadHAgYTZtwYjnRmlYV8BfmdytF13ibzbRfLNRYo+N2ZiuuBTT/BPd2Ga+itEls8A3dlRwyPtZaIutl/yw422dm8A08PmPG923QRndV0C6v3rQ+ifFMzR7CGgGMPQdGQe0DVTc+p4vkFZtLbUyx5aS44cNf+/4bE/A=;\n c=relaxed/relaxed; s=default; d=seu.edu.cn; v=1;\n bh=ffflAwULRkleIYICFHP/WFtQuZMy6nCm9F9CV+XYt/M=;\n h=date:mime-version:subject:message-id:from;", "X-Mailman-Original-Authentication-Results": [ "smtp4.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=seu.edu.cn", "smtp4.osuosl.org;\n dkim=pass (1024-bit key,\n unprotected) header.d=seu.edu.cn header.i=@seu.edu.cn header.a=rsa-sha256\n header.s=default header.b=g5rPP77A" ], "Subject": "[Intel-wired-lan] [PATCH net] ice: Fix memory leak in\n ice_set_ringparam()", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "In ice_set_ringparam, tx_rings and xdp_rings are allocated before\nrx_rings. If the allocation of rx_rings fails, the code jumps to\nthe done label leaking both tx_rings and xdp_rings. Furthermore, if\nthe setup of an individual Rx ring fails during the loop, the code jumps\nto the free_tx label which releases tx_rings but leaks xdp_rings.\n\nFix this by introducing a free_xdp label and updating the error paths to\nensure both xdp_rings and tx_rings are properly freed if rx_rings\nallocation or setup fails.\n\nCompile tested only. Issue found using a prototype static analysis tool\nand code review.\n\nFixes: fcea6f3da546 (\"ice: Add stats and ethtool support\")\nFixes: efc2214b6047 (\"ice: Add support for XDP\")\nSigned-off-by: Zilin Guan <zilin@seu.edu.cn>\n---\n drivers/net/ethernet/intel/ice/ice_ethtool.c | 11 +++++++++--\n 1 file changed, 9 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice_ethtool.c b/drivers/net/ethernet/intel/ice/ice_ethtool.c\nindex 969d4f8f9c02..1643b118144a 100644\n--- a/drivers/net/ethernet/intel/ice/ice_ethtool.c\n+++ b/drivers/net/ethernet/intel/ice/ice_ethtool.c\n@@ -3318,7 +3318,7 @@ ice_set_ringparam(struct net_device *netdev, struct ethtool_ringparam *ring,\n \trx_rings = kcalloc(vsi->num_rxq, sizeof(*rx_rings), GFP_KERNEL);\n \tif (!rx_rings) {\n \t\terr = -ENOMEM;\n-\t\tgoto done;\n+\t\tgoto free_xdp;\n \t}\n \n \tice_for_each_rxq(vsi, i) {\n@@ -3345,7 +3345,7 @@ ice_set_ringparam(struct net_device *netdev, struct ethtool_ringparam *ring,\n \t\t\t}\n \t\t\tkfree(rx_rings);\n \t\t\terr = -ENOMEM;\n-\t\t\tgoto free_tx;\n+\t\t\tgoto free_xdp;\n \t\t}\n \t}\n \n@@ -3398,6 +3398,13 @@ ice_set_ringparam(struct net_device *netdev, struct ethtool_ringparam *ring,\n \t}\n \tgoto done;\n \n+free_xdp:\n+\tif (xdp_rings) {\n+\t\tice_for_each_xdp_txq(vsi, i)\n+\t\t\tice_free_tx_ring(&xdp_rings[i]);\n+\t\tkfree(xdp_rings);\n+\t}\n+\n free_tx:\n \t/* error cleanup if the Rx allocations failed after getting Tx */\n \tif (tx_rings) {\n", "prefixes": [ "net" ] }