Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2186741/?format=api
{ "id": 2186741, "url": "http://patchwork.ozlabs.org/api/patches/2186741/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260120134434.1931602-6-jedrzej.jagielski@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260120134434.1931602-6-jedrzej.jagielski@intel.com>", "list_archive_url": null, "date": "2026-01-20T13:44:33", "name": "[iwl-next,v2,5/6] ixgbe: move EEE config validation out of ixgbe_set_eee()", "commit_ref": null, "pull_url": null, "state": "under-review", "archived": false, "hash": "e08b7ddc296437ac85d65b546e616441dad4991b", "submitter": { "id": 81850, "url": "http://patchwork.ozlabs.org/api/people/81850/?format=api", "name": "Jedrzej Jagielski", "email": "jedrzej.jagielski@intel.com" }, "delegate": { "id": 109701, "url": "http://patchwork.ozlabs.org/api/users/109701/?format=api", "username": "anguy11", "first_name": "Anthony", "last_name": "Nguyen", "email": "anthony.l.nguyen@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260120134434.1931602-6-jedrzej.jagielski@intel.com/mbox/", "series": [ { "id": 489069, "url": "http://patchwork.ozlabs.org/api/series/489069/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=489069", "date": "2026-01-20T13:44:28", "name": "ixgbe: enable EEE for E610 devices", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/489069/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2186741/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2186741/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=LzkqhkeD;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.136; helo=smtp3.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4dwTYH6G9wz1xsg\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 21 Jan 2026 01:02:43 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 054B86FE3B;\n\tTue, 20 Jan 2026 14:02:37 +0000 (UTC)", "from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id UetgWV0FPnRY; Tue, 20 Jan 2026 14:02:36 +0000 (UTC)", "from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 5762E6FE33;\n\tTue, 20 Jan 2026 14:02:36 +0000 (UTC)", "from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136])\n by lists1.osuosl.org (Postfix) with ESMTP id 0728C2A8\n for <intel-wired-lan@lists.osuosl.org>; Tue, 20 Jan 2026 14:02:35 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp3.osuosl.org (Postfix) with ESMTP id E04E26FE33\n for <intel-wired-lan@lists.osuosl.org>; Tue, 20 Jan 2026 14:02:34 +0000 (UTC)", "from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id 7Dj8UpQTlB8V for <intel-wired-lan@lists.osuosl.org>;\n Tue, 20 Jan 2026 14:02:34 +0000 (UTC)", "from mgamail.intel.com (mgamail.intel.com [192.198.163.13])\n by smtp3.osuosl.org (Postfix) with ESMTPS id F31266FE3B\n for <intel-wired-lan@lists.osuosl.org>; Tue, 20 Jan 2026 14:02:33 +0000 (UTC)", "from fmviesa004.fm.intel.com ([10.60.135.144])\n by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 20 Jan 2026 06:02:34 -0800", "from os-delivery.igk.intel.com ([10.102.18.218])\n by fmviesa004.fm.intel.com with ESMTP; 20 Jan 2026 06:02:32 -0800" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp3.osuosl.org 5762E6FE33", "OpenDKIM Filter v2.11.0 smtp3.osuosl.org F31266FE3B" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1768917756;\n\tbh=TmX7qeEk99+f2hlVJdkI32wBOusK2l4iChq9IgUa39o=;\n\th=From:To:Cc:Date:In-Reply-To:References:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=LzkqhkeDW4Sg69SZQFmH4ZaEHoEmA/c0+qnD1KzvaiXinXmC0PoKE6qwwjQ4Fkxf9\n\t zgCL+4DjK0Tp5vVtxARMe+i+MVdigwri3OkWkKYHwbdw2S2T06ljWQXRoQc8I6ikIZ\n\t w9A/O8HLqrTBCJMY1tdp7PuQO7F/JxtYJJXbCu+/RfyZp5Vu5/eSns5zq/zTmz7gsk\n\t nmCQFkc0ikKOaeT6TiatkMZ6AopBjZCmP0cyuh029K/A23KD7FcB2MI9qG8eK6OjX6\n\t rr99LC5WOM6+2qn5pf/v/803wQzmpMp2Ez85AdxSR/QrCwxLmNNKYWYdTzXs45irGM\n\t WMY0IS7HmvEXA==", "Received-SPF": "Pass (mailfrom) identity=mailfrom; client-ip=192.198.163.13;\n helo=mgamail.intel.com; envelope-from=jedrzej.jagielski@intel.com;\n receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp3.osuosl.org F31266FE3B", "X-CSE-ConnectionGUID": [ "DIScbmOvT0qlkP+9A1UBUg==", "8uKMYPhoSK2gpQreG+FKhg==" ], "X-CSE-MsgGUID": [ "ZDXfDyx/Q3i8Sbl9oIPWfQ==", "6C8FiCIsRjekQaed+DnMbA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6800,10657,11676\"; a=\"72711784\"", "E=Sophos;i=\"6.21,240,1763452800\"; d=\"scan'208\";a=\"72711784\"", "E=Sophos;i=\"6.21,240,1763452800\"; d=\"scan'208\";a=\"210978958\"" ], "X-ExtLoop1": "1", "From": "Jedrzej Jagielski <jedrzej.jagielski@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Cc": "anthony.l.nguyen@intel.com, netdev@vger.kernel.org,\n Jedrzej Jagielski <jedrzej.jagielski@intel.com>,\n Aleksandr Loktionov <aleksandr.loktionov@intel.com>", "Date": "Tue, 20 Jan 2026 14:44:33 +0100", "Message-Id": "<20260120134434.1931602-6-jedrzej.jagielski@intel.com>", "X-Mailer": "git-send-email 2.31.1", "In-Reply-To": "<20260120134434.1931602-1-jedrzej.jagielski@intel.com>", "References": "<20260120134434.1931602-1-jedrzej.jagielski@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Original-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1768917754; x=1800453754;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=0YkMMnRQnUttBI9ws8lik8ieeR5UeFB3lq4CtOHZ8O0=;\n b=Pz1NFQaNbZCgRUMttFmoqrsGKVWtfdiiu4c/3edgi9MDrU5ms4ThKk4z\n s4TJa61zU3Oj24ec/J1JUdOC+CahGjNtoRgNK3MSJJIlYaf5/1S6cEP3w\n Eah7ryMvPYVmtrs1KAtRtStYpdZ8q/eo2PdUbIPn7/q+IfmCpRGCrhzNb\n eK2/3ghFPolgKt/JhM7diTSRH/EzC3Ir8MKBAr8f/nPAcAzJvmxaA0Sff\n EULoHuCCjBngjGnpvGr0uhmq+9Zg9ZTD9lYyCSm+JHC+RM1lPwGXLieO8\n cg0zUmRgp2zIpqmvWPB31hha5GKKV/reDQNZeSn/AhSjihVdZpJRuesR/\n g==;", "X-Mailman-Original-Authentication-Results": [ "smtp3.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com", "smtp3.osuosl.org;\n dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.a=rsa-sha256 header.s=Intel header.b=Pz1NFQaN" ], "Subject": "[Intel-wired-lan] [PATCH iwl-next v2 5/6] ixgbe: move EEE config\n validation out of ixgbe_set_eee()", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "To make this part of the code mode reusable move all\nEEE input checks out of ixgbe_set_eee().\n\nReviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>\nSigned-off-by: Jedrzej Jagielski <jedrzej.jagielski@intel.com>\n---\nv2: add comment on returning EALREADY\n---\n .../net/ethernet/intel/ixgbe/ixgbe_ethtool.c | 98 +++++++++++--------\n 1 file changed, 57 insertions(+), 41 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c\nindex 779e2425e4aa..b5b9b9335d52 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c\n@@ -3556,6 +3556,47 @@ static const struct {\n \t{ FW_PHY_ACT_UD_2_10G_KR_EEE, ETHTOOL_LINK_MODE_10000baseKR_Full_BIT},\n };\n \n+static int ixgbe_validate_keee(struct net_device *netdev,\n+\t\t\t struct ethtool_keee *keee_requested)\n+{\n+\tstruct ixgbe_adapter *adapter = ixgbe_from_netdev(netdev);\n+\tstruct ethtool_keee keee_stored = {};\n+\tint err;\n+\n+\tif (!(adapter->flags2 & IXGBE_FLAG2_EEE_CAPABLE))\n+\t\treturn -EOPNOTSUPP;\n+\n+\terr = netdev->ethtool_ops->get_eee(netdev, &keee_stored);\n+\tif (err)\n+\t\treturn err;\n+\n+\tif (keee_stored.tx_lpi_enabled != keee_requested->tx_lpi_enabled) {\n+\t\te_err(drv, \"Setting EEE tx-lpi is not supported\\n\");\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tif (keee_stored.tx_lpi_timer != keee_requested->tx_lpi_timer) {\n+\t\te_err(drv,\n+\t\t \"Setting EEE Tx LPI timer is not supported\\n\");\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tif (!linkmode_equal(keee_stored.advertised,\n+\t\t\t keee_requested->advertised)) {\n+\t\te_err(drv,\n+\t\t \"Setting EEE advertised speeds is not supported\\n\");\n+\t\treturn -EINVAL;\n+\t}\n+\n+\t/* -EALREADY here is for internal use only, must be converted into\n+\t * early bail out with 0 by caller\n+\t */\n+\tif (keee_stored.eee_enabled == keee_requested->eee_enabled)\n+\t\treturn -EALREADY;\n+\n+\treturn 0;\n+}\n+\n static int\n ixgbe_get_eee_fw(struct ixgbe_adapter *adapter, struct ethtool_keee *edata)\n {\n@@ -3614,53 +3655,28 @@ static int ixgbe_set_eee(struct net_device *netdev, struct ethtool_keee *edata)\n {\n \tstruct ixgbe_adapter *adapter = ixgbe_from_netdev(netdev);\n \tstruct ixgbe_hw *hw = &adapter->hw;\n-\tstruct ethtool_keee eee_data;\n \tint ret_val;\n \n-\tif (!(adapter->flags2 & IXGBE_FLAG2_EEE_CAPABLE))\n-\t\treturn -EOPNOTSUPP;\n-\n-\tmemset(&eee_data, 0, sizeof(struct ethtool_keee));\n-\n-\tret_val = ixgbe_get_eee(netdev, &eee_data);\n-\tif (ret_val)\n+\tret_val = ixgbe_validate_keee(netdev, edata);\n+\tif (ret_val == -EALREADY)\n+\t\treturn 0;\n+\telse if (ret_val)\n \t\treturn ret_val;\n \n-\tif (eee_data.eee_enabled && !edata->eee_enabled) {\n-\t\tif (eee_data.tx_lpi_enabled != edata->tx_lpi_enabled) {\n-\t\t\te_err(drv, \"Setting EEE tx-lpi is not supported\\n\");\n-\t\t\treturn -EINVAL;\n-\t\t}\n-\n-\t\tif (eee_data.tx_lpi_timer != edata->tx_lpi_timer) {\n-\t\t\te_err(drv,\n-\t\t\t \"Setting EEE Tx LPI timer is not supported\\n\");\n-\t\t\treturn -EINVAL;\n-\t\t}\n-\n-\t\tif (!linkmode_equal(eee_data.advertised, edata->advertised)) {\n-\t\t\te_err(drv,\n-\t\t\t \"Setting EEE advertised speeds is not supported\\n\");\n-\t\t\treturn -EINVAL;\n-\t\t}\n+\tif (edata->eee_enabled) {\n+\t\tadapter->flags2 |= IXGBE_FLAG2_EEE_ENABLED;\n+\t\thw->phy.eee_speeds_advertised =\n+\t\t\t\t\t hw->phy.eee_speeds_supported;\n+\t} else {\n+\t\tadapter->flags2 &= ~IXGBE_FLAG2_EEE_ENABLED;\n+\t\thw->phy.eee_speeds_advertised = 0;\n \t}\n \n-\tif (eee_data.eee_enabled != edata->eee_enabled) {\n-\t\tif (edata->eee_enabled) {\n-\t\t\tadapter->flags2 |= IXGBE_FLAG2_EEE_ENABLED;\n-\t\t\thw->phy.eee_speeds_advertised =\n-\t\t\t\t\t\t hw->phy.eee_speeds_supported;\n-\t\t} else {\n-\t\t\tadapter->flags2 &= ~IXGBE_FLAG2_EEE_ENABLED;\n-\t\t\thw->phy.eee_speeds_advertised = 0;\n-\t\t}\n-\n-\t\t/* reset link */\n-\t\tif (netif_running(netdev))\n-\t\t\tixgbe_reinit_locked(adapter);\n-\t\telse\n-\t\t\tixgbe_reset(adapter);\n-\t}\n+\t/* reset link */\n+\tif (netif_running(netdev))\n+\t\tixgbe_reinit_locked(adapter);\n+\telse\n+\t\tixgbe_reset(adapter);\n \n \treturn 0;\n }\n", "prefixes": [ "iwl-next", "v2", "5/6" ] }