Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2186738/?format=api
{ "id": 2186738, "url": "http://patchwork.ozlabs.org/api/patches/2186738/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260120134434.1931602-3-jedrzej.jagielski@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260120134434.1931602-3-jedrzej.jagielski@intel.com>", "list_archive_url": null, "date": "2026-01-20T13:44:30", "name": "[iwl-next,v2,2/6] ixgbe: E610: use new version of 0x601 ACI command buffer", "commit_ref": null, "pull_url": null, "state": "under-review", "archived": false, "hash": "ce3d02d948f41184bf94349d822df001f73ff6b8", "submitter": { "id": 81850, "url": "http://patchwork.ozlabs.org/api/people/81850/?format=api", "name": "Jedrzej Jagielski", "email": "jedrzej.jagielski@intel.com" }, "delegate": { "id": 109701, "url": "http://patchwork.ozlabs.org/api/users/109701/?format=api", "username": "anguy11", "first_name": "Anthony", "last_name": "Nguyen", "email": "anthony.l.nguyen@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260120134434.1931602-3-jedrzej.jagielski@intel.com/mbox/", "series": [ { "id": 489069, "url": "http://patchwork.ozlabs.org/api/series/489069/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=489069", "date": "2026-01-20T13:44:28", "name": "ixgbe: enable EEE for E610 devices", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/489069/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2186738/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2186738/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=imd0cYMV;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.138; helo=smtp1.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4dwTYB62Hvz1xsg\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 21 Jan 2026 01:02:38 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id C535285BF8;\n\tTue, 20 Jan 2026 14:02:32 +0000 (UTC)", "from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id ih9ax-WPdCfQ; Tue, 20 Jan 2026 14:02:32 +0000 (UTC)", "from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 3980A85BFA;\n\tTue, 20 Jan 2026 14:02:32 +0000 (UTC)", "from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136])\n by lists1.osuosl.org (Postfix) with ESMTP id 20394160\n for <intel-wired-lan@lists.osuosl.org>; Tue, 20 Jan 2026 14:02:31 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp3.osuosl.org (Postfix) with ESMTP id 115716FE3B\n for <intel-wired-lan@lists.osuosl.org>; Tue, 20 Jan 2026 14:02:31 +0000 (UTC)", "from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id VPD7VVt5LM7q for <intel-wired-lan@lists.osuosl.org>;\n Tue, 20 Jan 2026 14:02:30 +0000 (UTC)", "from mgamail.intel.com (mgamail.intel.com [192.198.163.13])\n by smtp3.osuosl.org (Postfix) with ESMTPS id E23306FE33\n for <intel-wired-lan@lists.osuosl.org>; Tue, 20 Jan 2026 14:02:29 +0000 (UTC)", "from fmviesa004.fm.intel.com ([10.60.135.144])\n by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 20 Jan 2026 06:02:29 -0800", "from os-delivery.igk.intel.com ([10.102.18.218])\n by fmviesa004.fm.intel.com with ESMTP; 20 Jan 2026 06:02:27 -0800" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp1.osuosl.org 3980A85BFA", "OpenDKIM Filter v2.11.0 smtp3.osuosl.org E23306FE33" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1768917752;\n\tbh=0Z6VrNnIqfgRzNwqf78eMp+vjzJGicROND2x04njY0w=;\n\th=From:To:Cc:Date:In-Reply-To:References:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=imd0cYMVvyaF2kw3TGub3ZopAFEJTiYA+9CbvPQRvAJkClfy0aTpQYPpWdmCdg3mH\n\t h+LLWXJKhBGBd1XWRPHiSZ6kz9S/HtEgT1/az49DDZQvk8Wg0MMUuM1f/VQm0h38lo\n\t nrLJrP7nbKxEtreL4DNEC+ltE8vUXpLq9fKhH95I9ToRgoMnNS5sK+mgNRJKqW8teR\n\t U+z2bo2tDvOgQirlp1hTYXyQwo9S0e+6Fz2zW9/Yq6ocNtIYSKBvLSxUu9J651k3jo\n\t 6qBCJeKFuWJOgU/rO0MCbYOT6q9JVsRTmA/elCm0qGK2xoiDtCLxEpSX42hXMQ43UP\n\t I8OQFmaC+rPgQ==", "Received-SPF": "Pass (mailfrom) identity=mailfrom; client-ip=192.198.163.13;\n helo=mgamail.intel.com; envelope-from=jedrzej.jagielski@intel.com;\n receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp3.osuosl.org E23306FE33", "X-CSE-ConnectionGUID": [ "++XdgoXURxWwyc0j9qm4ew==", "0hmNlgYgSAyhvDQW1kbBtA==" ], "X-CSE-MsgGUID": [ "VkBxwiK9T1KWSQzKae6xjw==", "Oda85k0BS7S4WTnPxHeIkQ==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6800,10657,11676\"; a=\"72711758\"", "E=Sophos;i=\"6.21,240,1763452800\"; d=\"scan'208\";a=\"72711758\"", "E=Sophos;i=\"6.21,240,1763452800\"; d=\"scan'208\";a=\"210978904\"" ], "X-ExtLoop1": "1", "From": "Jedrzej Jagielski <jedrzej.jagielski@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Cc": "anthony.l.nguyen@intel.com, netdev@vger.kernel.org,\n Jedrzej Jagielski <jedrzej.jagielski@intel.com>,\n Aleksandr Loktionov <aleksandr.loktionov@intel.com>,\n Przemek Kitszel <przemyslaw.kitszel@intel.com>", "Date": "Tue, 20 Jan 2026 14:44:30 +0100", "Message-Id": "<20260120134434.1931602-3-jedrzej.jagielski@intel.com>", "X-Mailer": "git-send-email 2.31.1", "In-Reply-To": "<20260120134434.1931602-1-jedrzej.jagielski@intel.com>", "References": "<20260120134434.1931602-1-jedrzej.jagielski@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Original-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1768917750; x=1800453750;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=u6BDPVmJnQcjyrbWwPYe11Nbl9F6UGAuH3XDGMTgEw8=;\n b=TJ4ZMwJG2Z4k7Zo3SX17HYYepOYbYiSDYtpFE4ByoKB1pmUBrchTPXCj\n SxjZ0Ey3jVjXrZhdbIoGmes3MzSFQwWAqXvNnmaWcCauKi3HzxaD3+tB9\n Ke/mbgcv2oZbGh5IKZ0rC+YqqY21dQ9erJtx3Ai7/uyhuitWlYy5zLVY6\n UPJBmbfQ7VDiZfrQCiv5x9Mw91CPlgUbC86XAHDNfevnAgtvs3c8Rs8W5\n 83xHe77SwZLjPZ+q6pY9rK2ZXsq11GGUPYkTMG+VOKYvo+cVLn6SX7haq\n Ut4R4i1TFQYQi5EjOb/WuX4OyinYaDPISdOmnaUT3l094pafPovQkg97/\n Q==;", "X-Mailman-Original-Authentication-Results": [ "smtp3.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com", "smtp3.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=TJ4ZMwJG" ], "Subject": "[Intel-wired-lan] [PATCH iwl-next v2 2/6] ixgbe: E610: use new\n version of 0x601 ACI command buffer", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Since FW version 1.40, buffer size of the 0x601 cmd has been increased\nby 2B - from 24 to 26B. Buffer has been extended with new field\nwhich can be used to configure EEE entry delay.\n\nPre-1.40 FW versions still expect 24B buffer and throws error when\nreceipts 26B buffer. To keep compatibility, check whether EEE\ndevice capability flag is set and basing on it use appropriate\nsize of the command buffer.\n\nAdditionally place Set PHY Config capabilities defines out of\nstructs definitions.\n\nReviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>\nReviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>\nSigned-off-by: Jedrzej Jagielski <jedrzej.jagielski@intel.com>\n---\n drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c | 17 ++++++++++++++++-\n .../net/ethernet/intel/ixgbe/ixgbe_type_e610.h | 15 +++++++++------\n 2 files changed, 25 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c\nindex 9ae1e3620ee1..431c932f036b 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c\n@@ -1096,11 +1096,16 @@ int ixgbe_aci_set_phy_cfg(struct ixgbe_hw *hw,\n {\n \tstruct ixgbe_aci_cmd_set_phy_cfg *cmd;\n \tstruct libie_aq_desc desc;\n+\tbool use_buff_eee_field;\n+\tu16 buf_size;\n \tint err;\n \n \tif (!cfg)\n \t\treturn -EINVAL;\n \n+\t/* If FW supports EEE, we have to use buffer with EEE field. */\n+\tuse_buff_eee_field = hw->dev_caps.common_cap.eee_support;\n+\n \tcmd = libie_aq_raw(&desc);\n \t/* Ensure that only valid bits of cfg->caps can be turned on. */\n \tcfg->caps &= IXGBE_ACI_PHY_ENA_VALID_MASK;\n@@ -1109,7 +1114,17 @@ int ixgbe_aci_set_phy_cfg(struct ixgbe_hw *hw,\n \tcmd->lport_num = hw->bus.func;\n \tdesc.flags |= cpu_to_le16(LIBIE_AQ_FLAG_RD);\n \n-\terr = ixgbe_aci_send_cmd(hw, &desc, cfg, sizeof(*cfg));\n+\tif (use_buff_eee_field)\n+\t\tbuf_size = sizeof(*cfg);\n+\telse\n+\t\t/* Buffer w/o eee_entry_delay field is 2B smaller. */\n+\t\tbuf_size = sizeof(*cfg) - sizeof(u16);\n+\n+\terr = ixgbe_aci_send_cmd(hw, &desc, cfg, buf_size);\n+\n+\t/* 1.40 config format is compatible with pre-1.40, just extends\n+\t * it at the end.\n+\t */\n \tif (!err)\n \t\thw->phy.curr_user_phy_cfg = *cfg;\n \ndiff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_type_e610.h b/drivers/net/ethernet/intel/ixgbe/ixgbe_type_e610.h\nindex 11dc7fc71b71..db62281c9413 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_type_e610.h\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_type_e610.h\n@@ -382,6 +382,15 @@ struct ixgbe_aci_cmd_set_phy_cfg_data {\n \t__le64 phy_type_low; /* Use values from IXGBE_PHY_TYPE_LOW_* */\n \t__le64 phy_type_high; /* Use values from IXGBE_PHY_TYPE_HIGH_* */\n \tu8 caps;\n+\tu8 low_power_ctrl_an;\n+\t__le16 eee_cap; /* Value from ixgbe_aci_get_phy_caps */\n+\t__le16 eeer_value; /* Use defines from ixgbe_aci_get_phy_caps */\n+\tu8 link_fec_opt; /* Use defines from ixgbe_aci_get_phy_caps */\n+\tu8 module_compliance_enforcement;\n+\t__le16 eee_entry_delay;\n+} __packed;\n+\n+/* Set PHY config capabilities (@caps) defines */\n #define IXGBE_ACI_PHY_ENA_VALID_MASK\t\t0xef\n #define IXGBE_ACI_PHY_ENA_TX_PAUSE_ABILITY\tBIT(0)\n #define IXGBE_ACI_PHY_ENA_RX_PAUSE_ABILITY\tBIT(1)\n@@ -390,12 +399,6 @@ struct ixgbe_aci_cmd_set_phy_cfg_data {\n #define IXGBE_ACI_PHY_ENA_AUTO_LINK_UPDT\tBIT(5)\n #define IXGBE_ACI_PHY_ENA_LESM\t\t\tBIT(6)\n #define IXGBE_ACI_PHY_ENA_AUTO_FEC\t\tBIT(7)\n-\tu8 low_power_ctrl_an;\n-\t__le16 eee_cap; /* Value from ixgbe_aci_get_phy_caps */\n-\t__le16 eeer_value; /* Use defines from ixgbe_aci_get_phy_caps */\n-\tu8 link_fec_opt; /* Use defines from ixgbe_aci_get_phy_caps */\n-\tu8 module_compliance_enforcement;\n-};\n \n /* Restart AN command data structure (direct 0x0605)\n * Also used for response, with only the lport_num field present.\n", "prefixes": [ "iwl-next", "v2", "2/6" ] }