Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2185450/?format=api
{ "id": 2185450, "url": "http://patchwork.ozlabs.org/api/patches/2185450/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20260117002452.1026310-4-jonas@kwiboo.se/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260117002452.1026310-4-jonas@kwiboo.se>", "list_archive_url": null, "date": "2026-01-17T00:24:39", "name": "[3/6] net: lwip: dns: Call env_set() from dns loop instead of found callback", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "4aaf0b6c0d39e821827257c1015e2c4064d4b2f3", "submitter": { "id": 71439, "url": "http://patchwork.ozlabs.org/api/people/71439/?format=api", "name": "Jonas Karlman", "email": "jonas@kwiboo.se" }, "delegate": { "id": 157425, "url": "http://patchwork.ozlabs.org/api/users/157425/?format=api", "username": "jforissier", "first_name": "Jerome", "last_name": "Forissier", "email": "jerome.forissier@linaro.org" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20260117002452.1026310-4-jonas@kwiboo.se/mbox/", "series": [ { "id": 488696, "url": "http://patchwork.ozlabs.org/api/series/488696/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=488696", "date": "2026-01-17T00:24:36", "name": "net: lwip: Command fixes and improvements", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/488696/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2185450/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2185450/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=kwiboo.se header.i=@kwiboo.se header.a=rsa-sha256\n header.s=fe-e1b5cab7be header.b=OloKcJMi;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=kwiboo.se", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (2048-bit key;\n secure) header.d=kwiboo.se header.i=@kwiboo.se header.b=\"OloKcJMi\";\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=kwiboo.se", "phobos.denx.de; spf=pass\n smtp.mailfrom=SRS0=f646=7W=kwiboo.se=jonas@fe-bounces.kwiboo.se" ], "Received": [ "from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4dtHYy1TgGz1xsN\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 17 Jan 2026 11:25:42 +1100 (AEDT)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 9C1D18389A;\n\tSat, 17 Jan 2026 01:25:17 +0100 (CET)", "by phobos.denx.de (Postfix, from userid 109)\n id 5564B83015; Sat, 17 Jan 2026 01:25:16 +0100 (CET)", "from smtp.forwardemail.net (smtp.forwardemail.net [121.127.44.73])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 6CBA18397D\n for <u-boot@lists.denx.de>; Sat, 17 Jan 2026 01:25:13 +0100 (CET)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,\n RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED,\n SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=kwiboo.se;\n h=Content-Transfer-Encoding: MIME-Version: References: In-Reply-To:\n Message-ID: Date: Subject: Cc: To: From; q=dns/txt; s=fe-e1b5cab7be;\n t=1768609512; bh=psFrlP7U74HdJ0ajS4EUpkjMeG3qpR3bLCfsl5hWkuA=;\n b=OloKcJMiw/6VdNaF1dAIy/I8sLFetwePQFFNHbdmqtchtMTXYit7TCMNz9O8piHHR6vwSFR2t\n SOxsNv6tYZ28tFaVppA221rYUujDWAyGiDMPB2OhpWZIh8jk091eUzea3QTGKERBzxNyEnUGluM\n 6sjjP2Lk9YVsOW6N5er9a8eoUTEn9YaF/OVr0n0Tym12nP9gJx2aqO/C3XtlGw2qJzE8S7f8CE3\n SxHNxQJwbHz+u4C2BkxnQhz68wbp4O80krGw3XSc5CJEVmmTI7U7712AIgnSFN5kYzb21ApBHZa\n 4iYBD6g3ZwM1BpDdZR0bhwMpobFchVBxZgOtkD5TnhSA==", "X-Forward-Email-ID": "696ad6e675104fdab5e8c37a", "X-Forward-Email-Sender": "rfc822; jonas@kwiboo.se, smtp.forwardemail.net,\n 121.127.44.73", "X-Forward-Email-Version": "2.2.8", "X-Forward-Email-Website": "https://forwardemail.net", "X-Complaints-To": "abuse@forwardemail.net", "X-Report-Abuse": "abuse@forwardemail.net", "X-Report-Abuse-To": "abuse@forwardemail.net", "From": "Jonas Karlman <jonas@kwiboo.se>", "To": "Jerome Forissier <jerome@forissier.org>,\n Joe Hershberger <joe.hershberger@ni.com>,\n Ramon Fried <rfried.dev@gmail.com>, Tom Rini <trini@konsulko.com>", "Cc": "u-boot@lists.denx.de,\n\tJonas Karlman <jonas@kwiboo.se>", "Subject": "[PATCH 3/6] net: lwip: dns: Call env_set() from dns loop instead of\n found callback", "Date": "Sat, 17 Jan 2026 00:24:39 +0000", "Message-ID": "<20260117002452.1026310-4-jonas@kwiboo.se>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20260117002452.1026310-1-jonas@kwiboo.se>", "References": "<20260117002452.1026310-1-jonas@kwiboo.se>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.8 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "The lwIP dns command handle env_set() calls from the found callback and\nprintf() to console in the dns loop. Making it more complex than it\nneeds to be.\n\nSimplify and ensure any environment variable that is being set is the\nsame value that would have been printed on console.\n\nThere should not be any intended change in behavior, besides the change\nfrom using ip4addr helper to using version less ipaddr helper.\n\nSigned-off-by: Jonas Karlman <jonas@kwiboo.se>\n---\n net/lwip/dns.c | 15 ++++++---------\n 1 file changed, 6 insertions(+), 9 deletions(-)", "diff": "diff --git a/net/lwip/dns.c b/net/lwip/dns.c\nindex 2b2a5947a2b8..2222e2b0b045 100644\n--- a/net/lwip/dns.c\n+++ b/net/lwip/dns.c\n@@ -14,7 +14,6 @@\n \n struct dns_cb_arg {\n \tip_addr_t host_ipaddr;\n-\tconst char *var;\n \tbool done;\n };\n \n@@ -26,7 +25,6 @@ static void do_dns_tmr(void *arg)\n static void dns_cb(const char *name, const ip_addr_t *ipaddr, void *arg)\n {\n \tstruct dns_cb_arg *dns_cb_arg = arg;\n-\tchar *ipstr = ip4addr_ntoa(ipaddr);\n \n \tdns_cb_arg->done = true;\n \n@@ -37,21 +35,17 @@ static void dns_cb(const char *name, const ip_addr_t *ipaddr, void *arg)\n \t}\n \n \tdns_cb_arg->host_ipaddr.addr = ipaddr->addr;\n-\n-\tif (dns_cb_arg->var)\n-\t\tenv_set(dns_cb_arg->var, ipstr);\n }\n \n static int dns_loop(struct udevice *udev, const char *name, const char *var)\n {\n \tstruct dns_cb_arg dns_cb_arg = { };\n \tstruct netif *netif;\n+\tconst char *ipstr;\n \tip_addr_t ipaddr;\n \tulong start;\n \tint ret;\n \n-\tdns_cb_arg.var = var;\n-\n \tnetif = net_lwip_new_netif(udev);\n \tif (!netif)\n \t\treturn CMD_RET_FAILURE;\n@@ -85,8 +79,11 @@ static int dns_loop(struct udevice *udev, const char *name, const char *var)\n \tnet_lwip_remove_netif(netif);\n \n \tif (dns_cb_arg.done && dns_cb_arg.host_ipaddr.addr != 0) {\n-\t\tif (!var)\n-\t\t\tprintf(\"%s\\n\", ipaddr_ntoa(&dns_cb_arg.host_ipaddr));\n+\t\tipstr = ipaddr_ntoa(&dns_cb_arg.host_ipaddr);\n+\t\tif (var)\n+\t\t\tenv_set(var, ipstr);\n+\t\telse\n+\t\t\tprintf(\"%s\\n\", ipstr);\n \t\treturn CMD_RET_SUCCESS;\n \t}\n \n", "prefixes": [ "3/6" ] }