Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2184116/?format=api
{ "id": 2184116, "url": "http://patchwork.ozlabs.org/api/patches/2184116/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20260114-tftp_fix-v2-2-8de8e6ecf4e8@linaro.org/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260114-tftp_fix-v2-2-8de8e6ecf4e8@linaro.org>", "list_archive_url": null, "date": "2026-01-14T15:12:10", "name": "[v2,2/2] net: lwip: dhcp: Do not write past end of buffer", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "aa059edd47decfdaf6380d40d81b985515816b5b", "submitter": { "id": 88793, "url": "http://patchwork.ozlabs.org/api/people/88793/?format=api", "name": "Andrew Goodbody", "email": "andrew.goodbody@linaro.org" }, "delegate": { "id": 157425, "url": "http://patchwork.ozlabs.org/api/users/157425/?format=api", "username": "jforissier", "first_name": "Jerome", "last_name": "Forissier", "email": "jerome.forissier@linaro.org" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20260114-tftp_fix-v2-2-8de8e6ecf4e8@linaro.org/mbox/", "series": [ { "id": 488348, "url": "http://patchwork.ozlabs.org/api/series/488348/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=488348", "date": "2026-01-14T15:12:08", "name": "net: lwip: Do not write past end of buffer", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/488348/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2184116/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2184116/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=XpAVK8M2;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=linaro.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.b=\"XpAVK8M2\";\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=linaro.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=andrew.goodbody@linaro.org" ], "Received": [ "from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4drqNq0QJGz1xrQ\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 15 Jan 2026 02:12:43 +1100 (AEDT)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id B122383655;\n\tWed, 14 Jan 2026 16:12:23 +0100 (CET)", "by phobos.denx.de (Postfix, from userid 109)\n id D1459835B3; Wed, 14 Jan 2026 16:12:20 +0100 (CET)", "from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com\n [IPv6:2a00:1450:4864:20::32b])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id ADFE3830E4\n for <u-boot@lists.denx.de>; Wed, 14 Jan 2026 16:12:18 +0100 (CET)", "by mail-wm1-x32b.google.com with SMTP id\n 5b1f17b1804b1-47775fb6c56so83922265e9.1\n for <u-boot@lists.denx.de>; Wed, 14 Jan 2026 07:12:18 -0800 (PST)", "from artemis2.elfringham.co.uk\n ([2a0a:ef40:fed:3801:2d90:e4f1:d19d:4c32])\n by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-432bd0dacc5sm50455212f8f.5.2026.01.14.07.12.17\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 14 Jan 2026 07:12:17 -0800 (PST)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,\n SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1768403538; x=1769008338; darn=lists.denx.de;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:from:to:cc:subject:date:message-id\n :reply-to; bh=ZT3Sa9ASlhk7HDjx1Bwk/ZOElZh8by+gNc+C5VlKT6A=;\n b=XpAVK8M2NJaTaeen8eFzq6I+bOwdKAs6JYRZDl3ofyu4jfXYx843chcPJE9/Ey/ru5\n A3HK4ehGAMkh5wtEC9gungGJgjIM3O/kz2rXO8d1ZZBN1SDFZcvlblUabHD5zM9fbaNc\n azgbBCkoHef1uGNF4rzV1D0YOrNe6V9jVW9tmAlxnjzJ74aojdYAVIh+llLmmdYHGR+1\n 19FdYN4knXIjV8NW0WI03adFVQrTpIwVaLSkBXHUpU/tBSbfbx7Crb+cpj2ANiH3Zx4X\n NPNudzE16IR+WCR1t7yOCmjakWQrKCKkWytDag1lUHcXg6BLSeroxkbE+6wFujy+ejn4\n JgSw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1768403538; x=1769008338;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to\n :cc:subject:date:message-id:reply-to;\n bh=ZT3Sa9ASlhk7HDjx1Bwk/ZOElZh8by+gNc+C5VlKT6A=;\n b=OzxNwj9BeKTEsQxxXViNNoaUqN3eU43EDkwESREpadK6EYthqIYQSSBOWqMxZcdJT8\n zl+zQFLdlxN7t1HsHesdTFiLreHm1qstCaXs+pBC9uzZqaf4lBrnY9+ZDzSF44cL/wMA\n 751M6LAwE3o5wyg340alJR0n8M5Qdt4rVDYQwHu3W+8gZEQG0hruJ1Eyh76Yu/F5h2Ft\n 9BaSH8N0GOU06lgXNCy3xgBH1MPs4TlRGMQuapgH7f2KGESplhVrggGVF+6s8qFKtj1/\n Kf/KiH+FTyIKC7xmM8zmhBS749fsVGhuBBDtpNNlh//o7iyuStUTi0anEek3bQdhOKqf\n TJhA==", "X-Forwarded-Encrypted": "i=1;\n AJvYcCU59AR5aPIXnndW0afCQiuVt2MFVFwDRWrey74CAj8syYHxZUW1kiA719TuwrRslJ6OtTP7I+s=@lists.denx.de", "X-Gm-Message-State": "AOJu0Yyyz2keYjYmaV53gh3sLXDJG8LB1Eo8uT54omEpyojgizaAIWQN\n VfqZFcw4ZqBKM9Fz7tkpzDh/bozu1xY75FlvV8u04Gr4XWjQHsL+K77utADHR0fCbKY=", "X-Gm-Gg": "AY/fxX7Rs65S8nTYOSv8JahuDfcfxBOZNtd3511OWHb2U1z55Q/Hx7x0giNFBEen0z+\n OzAhFdW6L2HulQ0jd68iKWYcaB0YgwRtnBpsc6T5wEMItymefg/hv+9JlrCg4Rj+KtTknHFB5aI\n uaiO4VDw4lf/RZFOrJ5EDmN7rzUpcfMAUZDhTQBS82G41mokI6xdq/Fd3Khi3jO4SK4c2Ave+OX\n 1OoEd/IwlCav8FebQMEnzTrUdpBIxCNkmohXwDUDwOqlXCDgTNzGCrATbomjcU1cBUM7p1LRDOV\n ZSytef4h0555E3LK8d/Ni682Af+Ryurvsv0hEff8x+Xp8vdNpAlPgW0yZqWtNtjilS+WGi2fjXN\n 4XYFfPSo22TNDA0OhuloWlGbVpTyMP747IaNLcTpIlZiLSO56b7Vii1S3yZE+nHe/QQ2mErfDmM\n EPbMPYBtRj+aFaKNfKKIHwZmo63OpubdhURtvfGnc=", "X-Received": "by 2002:a05:600c:1f85:b0:477:9986:5e6b with SMTP id\n 5b1f17b1804b1-47ee338a5e2mr33758425e9.28.1768403538048;\n Wed, 14 Jan 2026 07:12:18 -0800 (PST)", "From": "Andrew Goodbody <andrew.goodbody@linaro.org>", "Date": "Wed, 14 Jan 2026 15:12:10 +0000", "Subject": "[PATCH v2 2/2] net: lwip: dhcp: Do not write past end of buffer", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "<20260114-tftp_fix-v2-2-8de8e6ecf4e8@linaro.org>", "References": "<20260114-tftp_fix-v2-0-8de8e6ecf4e8@linaro.org>", "In-Reply-To": "<20260114-tftp_fix-v2-0-8de8e6ecf4e8@linaro.org>", "To": "Ilias Apalodimas <ilias.apalodimas@linaro.org>,\n Jerome Forissier <jerome@forissier.org>, u-boot@lists.denx.de", "Cc": "Tom Rini <trini@konsulko.com>, Heinrich Schuchardt <xypron.glpk@gmx.de>,\n Michal Simek <michal.simek@amd.com>,\n Joe Hershberger <joe.hershberger@ni.com>,\n Ramon Fried <rfried.dev@gmail.com>,\n Martyn Welch <martyn.welch@collabora.com>, Benjamin Hahn <B.Hahn@phytec.de>,\n Simon Glass <sjg@chromium.org>, Tim Harvey <tharvey@gateworks.com>,\n Andrew Goodbody <andrew.goodbody@linaro.org>", "X-Mailer": "b4 0.14.2", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.8 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "sprintf will write a trailing \\0 at the end of the string so when\nwriting into a buffer, that buffer must be sized to allow for that\ntrailing zero. In the DHCP code when the index is a number needing two\ndigits to express the index would use up the two \\0 bytes in the buffer\nand the trailing \\0 from sprintf would be beyond the end of the\nallocation. Fix this by adding a third \\0 in the buffer.\n\nThis was found by code inspection when looking for an issue reported by\nMichal Simek, but I do not have the hardware to reproduce, so cannot\nconfirm if this addresses that issue or not.\n\nFixes: 98ad145db61a (\"net: lwip: add DHCP support and dhcp commmand\")\nSigned-off-by: Andrew Goodbody <andrew.goodbody@linaro.org>\n---\n net/lwip/dhcp.c | 6 +++---\n net/lwip/net-lwip.c | 6 +++---\n 2 files changed, 6 insertions(+), 6 deletions(-)", "diff": "diff --git a/net/lwip/dhcp.c b/net/lwip/dhcp.c\nindex b798014ebcb97dee688e29ccb34da916296c6772..731b57de3ba4336a22fee5957b6e2163360d78a1 100644\n--- a/net/lwip/dhcp.c\n+++ b/net/lwip/dhcp.c\n@@ -30,9 +30,9 @@ static void call_lwip_dhcp_fine_tmr(void *ctx)\n \n static int dhcp_loop(struct udevice *udev)\n {\n-\tchar ipstr[] = \"ipaddr\\0\\0\";\n-\tchar maskstr[] = \"netmask\\0\\0\";\n-\tchar gwstr[] = \"gatewayip\\0\\0\";\n+\tchar ipstr[] = \"ipaddr\\0\\0\\0\";\n+\tchar maskstr[] = \"netmask\\0\\0\\0\";\n+\tchar gwstr[] = \"gatewayip\\0\\0\\0\";\n \tconst ip_addr_t *ntpserverip;\n \tunsigned long start;\n \tstruct netif *netif;\ndiff --git a/net/lwip/net-lwip.c b/net/lwip/net-lwip.c\nindex 8741f65fe12e23cc30068506453a762533f8a67f..0fa33730a636727d0718625215a69002242810d0 100644\n--- a/net/lwip/net-lwip.c\n+++ b/net/lwip/net-lwip.c\n@@ -108,9 +108,9 @@ struct netif *net_lwip_get_netif(void)\n static int get_udev_ipv4_info(struct udevice *dev, ip4_addr_t *ip,\n \t\t\t ip4_addr_t *mask, ip4_addr_t *gw)\n {\n-\tchar ipstr[] = \"ipaddr\\0\\0\";\n-\tchar maskstr[] = \"netmask\\0\\0\";\n-\tchar gwstr[] = \"gatewayip\\0\\0\";\n+\tchar ipstr[] = \"ipaddr\\0\\0\\0\";\n+\tchar maskstr[] = \"netmask\\0\\0\\0\";\n+\tchar gwstr[] = \"gatewayip\\0\\0\\0\";\n \tint idx = dev_seq(dev);\n \tchar *env;\n \n", "prefixes": [ "v2", "2/2" ] }