Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2184115/?format=api
{ "id": 2184115, "url": "http://patchwork.ozlabs.org/api/patches/2184115/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20260114-tftp_fix-v2-1-8de8e6ecf4e8@linaro.org/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260114-tftp_fix-v2-1-8de8e6ecf4e8@linaro.org>", "list_archive_url": null, "date": "2026-01-14T15:12:09", "name": "[v2,1/2] net: lwip: tftp: Do not write past buffer end", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "3342dbe7fae499b1652dc2a1de489340f5cbe2ad", "submitter": { "id": 88793, "url": "http://patchwork.ozlabs.org/api/people/88793/?format=api", "name": "Andrew Goodbody", "email": "andrew.goodbody@linaro.org" }, "delegate": { "id": 157425, "url": "http://patchwork.ozlabs.org/api/users/157425/?format=api", "username": "jforissier", "first_name": "Jerome", "last_name": "Forissier", "email": "jerome.forissier@linaro.org" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20260114-tftp_fix-v2-1-8de8e6ecf4e8@linaro.org/mbox/", "series": [ { "id": 488348, "url": "http://patchwork.ozlabs.org/api/series/488348/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=488348", "date": "2026-01-14T15:12:08", "name": "net: lwip: Do not write past end of buffer", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/488348/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2184115/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2184115/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=bj0V0skR;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=linaro.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.b=\"bj0V0skR\";\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=linaro.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=andrew.goodbody@linaro.org" ], "Received": [ "from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4drqNd4Skyz1xrQ\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 15 Jan 2026 02:12:33 +1100 (AEDT)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 735D48352B;\n\tWed, 14 Jan 2026 16:12:21 +0100 (CET)", "by phobos.denx.de (Postfix, from userid 109)\n id D08DB80325; Wed, 14 Jan 2026 16:12:19 +0100 (CET)", "from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com\n [IPv6:2a00:1450:4864:20::42c])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id AF67D82C7F\n for <u-boot@lists.denx.de>; Wed, 14 Jan 2026 16:12:17 +0100 (CET)", "by mail-wr1-x42c.google.com with SMTP id\n ffacd0b85a97d-43246af170aso627354f8f.0\n for <u-boot@lists.denx.de>; Wed, 14 Jan 2026 07:12:17 -0800 (PST)", "from artemis2.elfringham.co.uk\n ([2a0a:ef40:fed:3801:2d90:e4f1:d19d:4c32])\n by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-432bd0dacc5sm50455212f8f.5.2026.01.14.07.12.16\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 14 Jan 2026 07:12:16 -0800 (PST)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,\n SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1768403537; x=1769008337; darn=lists.denx.de;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:from:to:cc:subject:date:message-id\n :reply-to; bh=ApFncLtJWsiaoiuu2Ck3TYxZADO8Hrv7IoGQ710cdRE=;\n b=bj0V0skR3uD4dxlh8nRNGbuuvlURZk/ao69z87UvcN0g9nbEFQOr11F8a/zEfx03rP\n mHPxoLiUCzCDanVTYSMFUKIee6sJBVTOadTw4LyUGBqp2DpWUeyhUdkNc+znS0Pm3WZS\n 7+D+mAXi/UcD5n2SWlryciAGdDIiHfAF0tfH/ev6oNfwmUkLWC8HQVcrkwXo0/zCbcEU\n +VRT0kdB9NU7NuI8/RlxnwhvVr8J6+4W9pwYmHb0xrPzyZoPaXmNm7/wCnnysbb69IeF\n knyTcFJ7BuXra9XV6qE0+gzzp3ZElF2xwBulb8pCS2Xa0eslFX+2NndPDEqH+ZXhTgjg\n b3Mw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1768403537; x=1769008337;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to\n :cc:subject:date:message-id:reply-to;\n bh=ApFncLtJWsiaoiuu2Ck3TYxZADO8Hrv7IoGQ710cdRE=;\n b=PXxPR+UE0q6siEm9k0ACW5Mem/7Xdb9UyYuW2ypQNR0nlXBbX1bFBdxeMfUE/nOsWN\n FnTfOlOVNpseAaMxXcxBabnZ7n/5P9IdIlAtFi7AqwvOKvdSm8FHEoz3fOBNfKjDOGxE\n yxzSWavulHNX97qTK/JNiQS3FXeqxLU6+TSGoquk+2R7tbblFfsMVxQvsdUuf8ns8FOj\n ChTEgnBtvNLlg1MIrojdHbeAUe/taAvZkMcxfnYnKEgokd0+4R7XJf2YydxFLi4Lv8xt\n Oudz3Z8418R3OTg7WUvahMwZ+1YrmYKs4smvGKjiXQ0VSERWPfU3CGqVTYK0RE4Fd9py\n hgJA==", "X-Forwarded-Encrypted": "i=1;\n AJvYcCWFSbqEvTK9BjdDm1AKwkPqOLigtLJZmsrjCESfN4RTzzmUVMO74qIvZ+c72ciMCHyKuKtfV2w=@lists.denx.de", "X-Gm-Message-State": "AOJu0Ywvc+RwbtThVn/CeGWjMtvifRi/oxEF7GoYakjMeuEe1gP5Tbqm\n Q5GKVDSru89g0dk6C+R0/bke69jtBNxHCbv2ALlHnQxarHk+pdSY7A61u/wg6g/DgKs=", "X-Gm-Gg": "AY/fxX5Oo59dyWYyxB/jFw6uCCq73N/M/99PIbtqJpims96U5GF2wObMesKfKfyfxL1\n u24sTeZgrTD7qHh5MVBmyNxGmRJ5hOzzX1PL8tGUnxbu3RwfKdcZY2wf/AEkym2HCCRTvxEsjxR\n HQ7zgSOTUHHjr+TpNvffPQe+ZWEXYnDGp+Lqt9t+Gl3Ew1wpYzQZhV253Je9m/lIDkLP2n+tql+\n AGxXqgfB4QrougQSNAv8u4I2K8C8UN1tDpvs5NGa/2XkxIUYgZwxhyB6uNGHsOQBaLwPMLgHp3o\n vvdhEXcNRxlFvMsliDE38mil/fh405/CORKCULezU1WhB1OrmJ6s1Bgyqbumk5HKDt7XRIomUpJ\n /MY+SfcOehzICvl3cHg9LS7CIzmP8df/9ThWGwwosohisOAkKb/P7fB3B/6mZJPR7WMkRE22GXl\n KRlCH1dtr9hUfQ1zEdsodwDRkTxK7Xn6ZRkIjOWwXWsFQScOkSRw==", "X-Received": "by 2002:a05:6000:2dc9:b0:431:f5:c36f with SMTP id\n ffacd0b85a97d-43423ee5857mr8973950f8f.31.1768403537107;\n Wed, 14 Jan 2026 07:12:17 -0800 (PST)", "From": "Andrew Goodbody <andrew.goodbody@linaro.org>", "Date": "Wed, 14 Jan 2026 15:12:09 +0000", "Subject": "[PATCH v2 1/2] net: lwip: tftp: Do not write past buffer end", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "<20260114-tftp_fix-v2-1-8de8e6ecf4e8@linaro.org>", "References": "<20260114-tftp_fix-v2-0-8de8e6ecf4e8@linaro.org>", "In-Reply-To": "<20260114-tftp_fix-v2-0-8de8e6ecf4e8@linaro.org>", "To": "Ilias Apalodimas <ilias.apalodimas@linaro.org>,\n Jerome Forissier <jerome@forissier.org>, u-boot@lists.denx.de", "Cc": "Tom Rini <trini@konsulko.com>, Heinrich Schuchardt <xypron.glpk@gmx.de>,\n Michal Simek <michal.simek@amd.com>,\n Joe Hershberger <joe.hershberger@ni.com>,\n Ramon Fried <rfried.dev@gmail.com>,\n Martyn Welch <martyn.welch@collabora.com>, Benjamin Hahn <B.Hahn@phytec.de>,\n Simon Glass <sjg@chromium.org>, Tim Harvey <tharvey@gateworks.com>,\n Andrew Goodbody <andrew.goodbody@linaro.org>", "X-Mailer": "b4 0.14.2", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.8 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "sprintf will add a trailing \\0 so manually adding a trailing \\0 will\nresult in an extra unaccounted for character being written. This\noverwrote the first byte of the following allocation block resulting in\nunexpected behavior.\n\nThis was found by Running 'pxe get' with no available file resulting in\nmultiple attempts, using the default algorithm, to attempt to find a file.\nEventually there would be a failed assert when free() was called.\nFailing the assert would result in a system reset.\n\nFixes: 27d7ccda94fa (\"net: lwip: tftp: add support of blksize option to client\")\nReported-by: Michal Simek <michal.simek@amd.com>\nTested-by: Michal Simek <michal.simek@amd.com>\n\nSigned-off-by: Andrew Goodbody <andrew.goodbody@linaro.org>\n---\n lib/lwip/lwip/src/apps/tftp/tftp.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/lib/lwip/lwip/src/apps/tftp/tftp.c b/lib/lwip/lwip/src/apps/tftp/tftp.c\nindex ecb6c55ae1100779187e7b138d098a0ef1e48ca1..25da952e92566cbca1c64bc89c89102e74d0a42c 100644\n--- a/lib/lwip/lwip/src/apps/tftp/tftp.c\n+++ b/lib/lwip/lwip/src/apps/tftp/tftp.c\n@@ -191,7 +191,7 @@ send_request(const ip_addr_t *addr, u16_t port, u16_t opcode, const char* fname,\n MEMCPY(payload+2, fname, fname_length);\n MEMCPY(payload+2+fname_length, mode, mode_length);\n if (tftp_state.blksize)\n- sprintf(payload+2+fname_length+mode_length, \"blksize%c%d%c\", 0, tftp_state.blksize, 0);\n+ sprintf(payload+2+fname_length+mode_length, \"blksize%c%d\", 0, tftp_state.blksize);\n \n tftp_state.wait_oack = true;\n ret = udp_sendto(tftp_state.upcb, p, addr, port);\n", "prefixes": [ "v2", "1/2" ] }