Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2183744/?format=api
{ "id": 2183744, "url": "http://patchwork.ozlabs.org/api/patches/2183744/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260113193817.582-3-dawid.osuchowski@linux.intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260113193817.582-3-dawid.osuchowski@linux.intel.com>", "list_archive_url": null, "date": "2026-01-13T19:38:17", "name": "[iwl-net,2/2] ice: fix retry for AQ command 0x06EE", "commit_ref": null, "pull_url": null, "state": "under-review", "archived": false, "hash": "f27b9ac45877661c931961d1dc8ebe7a1b61902d", "submitter": { "id": 88401, "url": "http://patchwork.ozlabs.org/api/people/88401/?format=api", "name": "Dawid Osuchowski", "email": "dawid.osuchowski@linux.intel.com" }, "delegate": { "id": 109701, "url": "http://patchwork.ozlabs.org/api/users/109701/?format=api", "username": "anguy11", "first_name": "Anthony", "last_name": "Nguyen", "email": "anthony.l.nguyen@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260113193817.582-3-dawid.osuchowski@linux.intel.com/mbox/", "series": [ { "id": 488233, "url": "http://patchwork.ozlabs.org/api/series/488233/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=488233", "date": "2026-01-13T19:38:15", "name": "ice: fix AQ command 0x06EE usage by retrying", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/488233/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2183744/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2183744/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=vJs182dB;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.136; helo=smtp3.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4drKLd3rV1z1xtB\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 14 Jan 2026 06:39:05 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 17CC060C27;\n\tTue, 13 Jan 2026 19:39:04 +0000 (UTC)", "from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id gCd6sgm7K8Vo; Tue, 13 Jan 2026 19:39:03 +0000 (UTC)", "from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 3BFFA60C28;\n\tTue, 13 Jan 2026 19:39:03 +0000 (UTC)", "from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n by lists1.osuosl.org (Postfix) with ESMTP id AAD891C3\n for <intel-wired-lan@lists.osuosl.org>; Tue, 13 Jan 2026 19:39:01 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp1.osuosl.org (Postfix) with ESMTP id 8F8E282C84\n for <intel-wired-lan@lists.osuosl.org>; Tue, 13 Jan 2026 19:39:01 +0000 (UTC)", "from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id NlQoASlOCVgR for <intel-wired-lan@lists.osuosl.org>;\n Tue, 13 Jan 2026 19:39:00 +0000 (UTC)", "from mgamail.intel.com (mgamail.intel.com [192.198.163.10])\n by smtp1.osuosl.org (Postfix) with ESMTPS id 627BF82C7D\n for <intel-wired-lan@lists.osuosl.org>; Tue, 13 Jan 2026 19:39:00 +0000 (UTC)", "from orviesa003.jf.intel.com ([10.64.159.143])\n by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 13 Jan 2026 11:39:00 -0800", "from kasadzad-mobl.ger.corp.intel.com (HELO\n soc-5CG4396XFB.clients.intel.com) ([10.94.252.226])\n by ORVIESA003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 13 Jan 2026 11:38:58 -0800" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp3.osuosl.org 3BFFA60C28", "OpenDKIM Filter v2.11.0 smtp1.osuosl.org 627BF82C7D" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1768333143;\n\tbh=8HY+/aUCdY5h2MmvPMMewf5KlTv59tJt1cHVbYr/JT8=;\n\th=From:To:Cc:Date:In-Reply-To:References:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=vJs182dB1jnJZKQB2vqGGl0/ipcVmKeBWl6PZDL+mjW3x7KPa9JBtyOyknTCvDhTF\n\t nm1O1UQtBvuOCznniVL/Q2bb72tzfHq0yEpPvtjO6HtdBEy7uqKEFA8SzhwJYhUQQz\n\t WY8gZSBSghn7UUbr3w4dsg60pn3KBn6cRTYBi1YZ9VwwCqA69frVv7srZa4xQ7lgYe\n\t iCo22GHsN7mEgIUl2WXGrVS+BFTzJe5Pe2H2YPMGMoY/Xchao8nofMkAjZXt44IyDi\n\t ueu9FS7WSOT25ksyT73aLHc78Icvx92XFHDXS1sTlqN8CnQNtKF62aPbdoj2i52OWw\n\t 6nKa061iv39jw==", "Received-SPF": "Pass (mailfrom) identity=mailfrom; client-ip=192.198.163.10;\n helo=mgamail.intel.com; envelope-from=dawid.osuchowski@linux.intel.com;\n receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp1.osuosl.org 627BF82C7D", "X-CSE-ConnectionGUID": [ "1cagiHH5TSWtaYBYanHneQ==", "fuUb7S8FSd+1isAwjaWYGQ==" ], "X-CSE-MsgGUID": [ "XTLBOuiXRqqxsvRGUFc4Mw==", "XmFmkVOGTBSszu2DWXYeFg==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6800,10657,11670\"; a=\"80993530\"", "E=Sophos;i=\"6.21,222,1763452800\"; d=\"scan'208\";a=\"80993530\"", "E=Sophos;i=\"6.21,222,1763452800\"; d=\"scan'208\";a=\"208629085\"" ], "X-ExtLoop1": "1", "From": "Dawid Osuchowski <dawid.osuchowski@linux.intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Cc": "netdev@vger.kernel.org,\n Jakub Staniszewski <jakub.staniszewski@linux.intel.com>,\n stable@vger.kernel.org,\n Dawid Osuchowski <dawid.osuchowski@linux.intel.com>,\n Aleksandr Loktionov <aleksandr.loktionov@intel.com>,\n Przemek Kitszel <przemyslaw.kitszel@intel.com>", "Date": "Tue, 13 Jan 2026 20:38:17 +0100", "Message-ID": "<20260113193817.582-3-dawid.osuchowski@linux.intel.com>", "X-Mailer": "git-send-email 2.51.0", "In-Reply-To": "<20260113193817.582-1-dawid.osuchowski@linux.intel.com>", "References": "<20260113193817.582-1-dawid.osuchowski@linux.intel.com>", "MIME-Version": "1.0", "Organization": "Intel Technology Poland sp. z o.o. - ul. Slowackiego 173,\n 80-298 Gdansk - KRS 101882 - NIP 957-07-52-316", "Content-Transfer-Encoding": "8bit", "X-Mailman-Original-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1768333140; x=1799869140;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=cQBJ2VxWuFTxQUDOTo6qtyEYlivydYoNMrH+/6fqZRo=;\n b=J0Vy1xbO0Mw7OSJ9f7VU+PF3C4aBt/66TSUh+UIyb5hOTWh75IltLM46\n Euk9SLzr3VnlA0OyN0CKpK4bQ+zsHgJcKIirHYs23sCxrBEtuAG0g8lpW\n 2SmkAxn1dgBCkYI6uSBfzujRJ2BDjZ6lqbXB1jMKWVThHfxX7sgayc1v0\n NIAIepiIChLn4/GYHbNgLsZ6NrXM+4ac3m8RjTpAA5A13X+ZMHk7245aJ\n WHDO6qVmTquVFccBZ4UmLaTUxuYKW3pkxvGkcOQRRwe/TLMnFishlGVUs\n 7t3JQHhofxKTVAgzYq0aDCgis0U2aA4nKfd1OHBPbIrJTUXwmEAHDROwN\n w==;", "X-Mailman-Original-Authentication-Results": [ "smtp1.osuosl.org;\n dmarc=none (p=none dis=none)\n header.from=linux.intel.com", "smtp1.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=J0Vy1xbO" ], "Subject": "[Intel-wired-lan] [PATCH iwl-net 2/2] ice: fix retry for AQ command\n 0x06EE", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Jakub Staniszewski <jakub.staniszewski@linux.intel.com>\n\nExecuting ethtool -m can fail reporting a netlink I/O error while firmware\nlink management holds the i2c bus used to communicate with the module.\n\nAccording to Intel(R) Ethernet Controller E810 Datasheet Rev 2.8 [1]\nSection 3.3.10.4 Read/Write SFF EEPROM (0x06EE)\nrequest should to be retried upon receiving EBUSY from firmware.\n\nCommit e9c9692c8a81 (\"ice: Reimplement module reads used by ethtool\")\nimplemented it only for part of ice_get_module_eeprom(), leaving all other\ncalls to ice_aq_sff_eeprom() vulnerable to returning early on getting\nEBUSY without retrying.\n\nRemove the retry loop from ice_get_module_eeprom() and add Admin Queue\n(AQ) command with opcode 0x06EE to the list of commands that should be\nretried on receiving EBUSY from firmware.\n\nCc: stable@vger.kernel.org\nFixes: e9c9692c8a81 (\"ice: Reimplement module reads used by ethtool\")\nSigned-off-by: Jakub Staniszewski <jakub.staniszewski@linux.intel.com>\nCo-developed-by: Dawid Osuchowski <dawid.osuchowski@linux.intel.com>\nSigned-off-by: Dawid Osuchowski <dawid.osuchowski@linux.intel.com>\nReviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>\nReviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>\nLink: https://www.intel.com/content/www/us/en/content-details/613875/intel-ethernet-controller-e810-datasheet.html [1]\n---\n drivers/net/ethernet/intel/ice/ice_common.c | 1 +\n drivers/net/ethernet/intel/ice/ice_ethtool.c | 35 ++++++++------------\n 2 files changed, 15 insertions(+), 21 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice_common.c b/drivers/net/ethernet/intel/ice/ice_common.c\nindex aab00c44e9b2..26eb8e05498b 100644\n--- a/drivers/net/ethernet/intel/ice/ice_common.c\n+++ b/drivers/net/ethernet/intel/ice/ice_common.c\n@@ -1854,6 +1854,7 @@ static bool ice_should_retry_sq_send_cmd(u16 opcode)\n \tcase ice_aqc_opc_lldp_stop:\n \tcase ice_aqc_opc_lldp_start:\n \tcase ice_aqc_opc_lldp_filter_ctrl:\n+\tcase ice_aqc_opc_sff_eeprom:\n \t\treturn true;\n \t}\n \ndiff --git a/drivers/net/ethernet/intel/ice/ice_ethtool.c b/drivers/net/ethernet/intel/ice/ice_ethtool.c\nindex 3565a5d96c6d..478876908db1 100644\n--- a/drivers/net/ethernet/intel/ice/ice_ethtool.c\n+++ b/drivers/net/ethernet/intel/ice/ice_ethtool.c\n@@ -4496,7 +4496,7 @@ ice_get_module_eeprom(struct net_device *netdev,\n \tu8 addr = ICE_I2C_EEPROM_DEV_ADDR;\n \tstruct ice_hw *hw = &pf->hw;\n \tbool is_sfp = false;\n-\tunsigned int i, j;\n+\tunsigned int i;\n \tu16 offset = 0;\n \tu8 page = 0;\n \tint status;\n@@ -4538,26 +4538,19 @@ ice_get_module_eeprom(struct net_device *netdev,\n \t\tif (page == 0 || !(data[0x2] & 0x4)) {\n \t\t\tu32 copy_len;\n \n-\t\t\t/* If i2c bus is busy due to slow page change or\n-\t\t\t * link management access, call can fail. This is normal.\n-\t\t\t * So we retry this a few times.\n-\t\t\t */\n-\t\t\tfor (j = 0; j < 4; j++) {\n-\t\t\t\tstatus = ice_aq_sff_eeprom(hw, 0, addr, offset, page,\n-\t\t\t\t\t\t\t !is_sfp, value,\n-\t\t\t\t\t\t\t SFF_READ_BLOCK_SIZE,\n-\t\t\t\t\t\t\t 0, NULL);\n-\t\t\t\tnetdev_dbg(netdev, \"SFF %02X %02X %02X %X = %02X%02X%02X%02X.%02X%02X%02X%02X (%X)\\n\",\n-\t\t\t\t\t addr, offset, page, is_sfp,\n-\t\t\t\t\t value[0], value[1], value[2], value[3],\n-\t\t\t\t\t value[4], value[5], value[6], value[7],\n-\t\t\t\t\t status);\n-\t\t\t\tif (status) {\n-\t\t\t\t\tusleep_range(1500, 2500);\n-\t\t\t\t\tmemset(value, 0, SFF_READ_BLOCK_SIZE);\n-\t\t\t\t\tcontinue;\n-\t\t\t\t}\n-\t\t\t\tbreak;\n+\t\t\tstatus = ice_aq_sff_eeprom(hw, 0, addr, offset, page,\n+\t\t\t\t\t\t !is_sfp, value,\n+\t\t\t\t\t\t SFF_READ_BLOCK_SIZE,\n+\t\t\t\t\t\t 0, NULL);\n+\t\t\tnetdev_dbg(netdev, \"SFF %02X %02X %02X %X = %02X%02X%02X%02X.%02X%02X%02X%02X (%pe)\\n\",\n+\t\t\t\t addr, offset, page, is_sfp,\n+\t\t\t\t value[0], value[1], value[2], value[3],\n+\t\t\t\t value[4], value[5], value[6], value[7],\n+\t\t\t\t ERR_PTR(status));\n+\t\t\tif (status) {\n+\t\t\t\tnetdev_err(netdev, \"%s: error reading module EEPROM: status %pe\\n\",\n+\t\t\t\t\t __func__, ERR_PTR(status));\n+\t\t\t\treturn status;\n \t\t\t}\n \n \t\t\t/* Make sure we have enough room for the new block */\n", "prefixes": [ "iwl-net", "2/2" ] }