Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2183743/?format=api
{ "id": 2183743, "url": "http://patchwork.ozlabs.org/api/patches/2183743/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260113193817.582-2-dawid.osuchowski@linux.intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260113193817.582-2-dawid.osuchowski@linux.intel.com>", "list_archive_url": null, "date": "2026-01-13T19:38:16", "name": "[iwl-net,1/2] ice: reintroduce retry mechanism for indirect AQ", "commit_ref": null, "pull_url": null, "state": "under-review", "archived": false, "hash": "213fb36a01c0829af92a237b3dbdc0faf7f9a3e9", "submitter": { "id": 88401, "url": "http://patchwork.ozlabs.org/api/people/88401/?format=api", "name": "Dawid Osuchowski", "email": "dawid.osuchowski@linux.intel.com" }, "delegate": { "id": 109701, "url": "http://patchwork.ozlabs.org/api/users/109701/?format=api", "username": "anguy11", "first_name": "Anthony", "last_name": "Nguyen", "email": "anthony.l.nguyen@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260113193817.582-2-dawid.osuchowski@linux.intel.com/mbox/", "series": [ { "id": 488233, "url": "http://patchwork.ozlabs.org/api/series/488233/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=488233", "date": "2026-01-13T19:38:15", "name": "ice: fix AQ command 0x06EE usage by retrying", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/488233/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2183743/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2183743/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=UZlqIaWY;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.138; helo=smtp1.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4drKLK66WZz1xtB\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 14 Jan 2026 06:38:49 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 655A682FB1;\n\tTue, 13 Jan 2026 19:38:48 +0000 (UTC)", "from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id FThD2zzJ1MZM; Tue, 13 Jan 2026 19:38:47 +0000 (UTC)", "from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 99CF882D04;\n\tTue, 13 Jan 2026 19:38:47 +0000 (UTC)", "from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n by lists1.osuosl.org (Postfix) with ESMTP id 1F423231\n for <intel-wired-lan@lists.osuosl.org>; Tue, 13 Jan 2026 19:38:46 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp3.osuosl.org (Postfix) with ESMTP id 109F460C12\n for <intel-wired-lan@lists.osuosl.org>; Tue, 13 Jan 2026 19:38:46 +0000 (UTC)", "from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id dYO_tHASwMKo for <intel-wired-lan@lists.osuosl.org>;\n Tue, 13 Jan 2026 19:38:45 +0000 (UTC)", "from mgamail.intel.com (mgamail.intel.com [192.198.163.10])\n by smtp3.osuosl.org (Postfix) with ESMTPS id 1D9C860C11\n for <intel-wired-lan@lists.osuosl.org>; Tue, 13 Jan 2026 19:38:45 +0000 (UTC)", "from orviesa003.jf.intel.com ([10.64.159.143])\n by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 13 Jan 2026 11:38:44 -0800", "from kasadzad-mobl.ger.corp.intel.com (HELO\n soc-5CG4396XFB.clients.intel.com) ([10.94.252.226])\n by ORVIESA003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 13 Jan 2026 11:38:42 -0800" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp1.osuosl.org 99CF882D04", "OpenDKIM Filter v2.11.0 smtp3.osuosl.org 1D9C860C11" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1768333127;\n\tbh=q1UZH657e9U/pOxps24hiRieMoXbsBDhId1HOxosUtE=;\n\th=From:To:Date:In-Reply-To:References:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t Cc:From;\n\tb=UZlqIaWYXvJ56NXvYURo17Xdjv1cCEe8yOU0MJhS4a37evSmh0zVaJbrPj7oR04GH\n\t 4XdczmaPk+c1KpJUYa7uoEt6AuSA7NsSWegIqWUZCBivvJNg6oxDmlpCrhV72uqn4Q\n\t 0SRiE5jJADrl5RqAT2wwn1hDT++VCiv3LZ9QtcBFe4G9/jDXtHWA9xUA4Y5sx3KZc0\n\t KixbtCvZgZFR4vDFctZd7UfUCPspBb376z4BWgEGKrk/5Lm5rqSWllUyfB6YWHALjY\n\t 9JT8rAglHRyMxnzZXgECMRr8Y1m0xCH2RAt5V0AKMBejRaHWI6EZVUgm891j5TX0VG\n\t xZnL5TuyeMgzA==", "Received-SPF": "Pass (mailfrom) identity=mailfrom; client-ip=192.198.163.10;\n helo=mgamail.intel.com; envelope-from=dawid.osuchowski@linux.intel.com;\n receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp3.osuosl.org 1D9C860C11", "X-CSE-ConnectionGUID": [ "lZ0A9JBzRUyU+XC1ndLoIw==", "Wk4Q4ESsRWaYfdnVw0F4dQ==" ], "X-CSE-MsgGUID": [ "rEYAGGvjRUaYuGNWgwjsgQ==", "kznnjLrFS9ymw2PuD78+/w==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6800,10657,11670\"; a=\"80993505\"", "E=Sophos;i=\"6.21,222,1763452800\"; d=\"scan'208\";a=\"80993505\"", "E=Sophos;i=\"6.21,222,1763452800\"; d=\"scan'208\";a=\"208629040\"" ], "X-ExtLoop1": "1", "From": "Dawid Osuchowski <dawid.osuchowski@linux.intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Tue, 13 Jan 2026 20:38:16 +0100", "Message-ID": "<20260113193817.582-2-dawid.osuchowski@linux.intel.com>", "X-Mailer": "git-send-email 2.51.0", "In-Reply-To": "<20260113193817.582-1-dawid.osuchowski@linux.intel.com>", "References": "<20260113193817.582-1-dawid.osuchowski@linux.intel.com>", "MIME-Version": "1.0", "Organization": "Intel Technology Poland sp. z o.o. - ul. Slowackiego 173,\n 80-298 Gdansk - KRS 101882 - NIP 957-07-52-316", "Content-Transfer-Encoding": "8bit", "X-Mailman-Original-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1768333125; x=1799869125;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=jEtf1ydCCX46cmNa/3QR3V9ozblq9GLYYAgW3YJ8E94=;\n b=Lx3W1//zzCuBGGKILF0Bh9j07xaFr4b6bzuErKACTUSs/RRo1+j2BIDj\n aFjshU8NZa0LTGpRe/7yGw84RmgB5HpvHe+QBo3x2FQTlrGlpH3sLqrDd\n ziQcuIILx0r7KPhKY5fXWPl9q4LLm56CSippg6pM3wwYQDlL53kzZaSWy\n a2VDtSVFig64t0ez1A0OzzCBNEASVPyC9TVGnzDR+39oanUdsw6OxyGAn\n L6mgyOYNNgyI08qn+4F8IPIty201RiZw4xEXymYFbW7yk3Wwly3XDdZeC\n kx02ON9Rn+AFgmahkOOufNoY3rItiyH+c1JVBMzG7kAiNWNrUu7K5jGM8\n w==;", "X-Mailman-Original-Authentication-Results": [ "smtp3.osuosl.org;\n dmarc=none (p=none dis=none)\n header.from=linux.intel.com", "smtp3.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=Lx3W1//z" ], "Subject": "[Intel-wired-lan] [PATCH iwl-net 1/2] ice: reintroduce retry\n mechanism for indirect AQ", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "netdev@vger.kernel.org, stable@vger.kernel.org,\n Aleksandr Loktionov <aleksandr.loktionov@intel.com>,\n Jakub Staniszewski <jakub.staniszewski@linux.intel.com>,\n Przemek Kitszel <przemyslaw.kitszel@intel.com>,\n Dawid Osuchowski <dawid.osuchowski@linux.intel.com>", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Jakub Staniszewski <jakub.staniszewski@linux.intel.com>\n\nAdd retry mechanism for indirect Admin Queue (AQ) commands. To do so we\nneed to keep the command buffer.\n\nThis technically reverts commit 43a630e37e25\n(\"ice: remove unused buffer copy code in ice_sq_send_cmd_retry()\"),\nbut combines it with a fix in the logic by using a kmemdup() call,\nmaking it more robust and less likely to break in the future due to\nprogrammer error.\n\nCc: Michal Schmidt <mschmidt@redhat.com>\nCc: stable@vger.kernel.org\nFixes: 3056df93f7a8 (\"ice: Re-send some AQ commands, as result of EBUSY AQ error\")\nSigned-off-by: Jakub Staniszewski <jakub.staniszewski@linux.intel.com>\nCo-developed-by: Dawid Osuchowski <dawid.osuchowski@linux.intel.com>\nSigned-off-by: Dawid Osuchowski <dawid.osuchowski@linux.intel.com>\nReviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>\nReviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>\n---\nCcing Michal, given they are the author of the \"reverted\" commit.\n\n drivers/net/ethernet/intel/ice/ice_common.c | 12 +++++++++---\n 1 file changed, 9 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice_common.c b/drivers/net/ethernet/intel/ice/ice_common.c\nindex a400bf4f239a..aab00c44e9b2 100644\n--- a/drivers/net/ethernet/intel/ice/ice_common.c\n+++ b/drivers/net/ethernet/intel/ice/ice_common.c\n@@ -1879,34 +1879,40 @@ ice_sq_send_cmd_retry(struct ice_hw *hw, struct ice_ctl_q_info *cq,\n {\n \tstruct libie_aq_desc desc_cpy;\n \tbool is_cmd_for_retry;\n+\tu8 *buf_cpy = NULL;\n \tu8 idx = 0;\n \tu16 opcode;\n \tint status;\n \n \topcode = le16_to_cpu(desc->opcode);\n \tis_cmd_for_retry = ice_should_retry_sq_send_cmd(opcode);\n \tmemset(&desc_cpy, 0, sizeof(desc_cpy));\n \n \tif (is_cmd_for_retry) {\n-\t\t/* All retryable cmds are direct, without buf. */\n-\t\tWARN_ON(buf);\n+\t\tif (buf) {\n+\t\t\tbuf_cpy = kmemdup(buf, buf_size, GFP_KERNEL);\n+\t\t\tif (!buf_cpy)\n+\t\t\t\treturn -ENOMEM;\n+\t\t}\n \n \t\tmemcpy(&desc_cpy, desc, sizeof(desc_cpy));\n \t}\n \n \tdo {\n \t\tstatus = ice_sq_send_cmd(hw, cq, desc, buf, buf_size, cd);\n \n \t\tif (!is_cmd_for_retry || !status ||\n \t\t hw->adminq.sq_last_status != LIBIE_AQ_RC_EBUSY)\n \t\t\tbreak;\n \n+\t\tif (buf_cpy)\n+\t\t\tmemcpy(buf, buf_cpy, buf_size);\n \t\tmemcpy(desc, &desc_cpy, sizeof(desc_cpy));\n-\n \t\tmsleep(ICE_SQ_SEND_DELAY_TIME_MS);\n \n \t} while (++idx < ICE_SQ_SEND_MAX_EXECUTE);\n \n+\tkfree(buf_cpy);\n \treturn status;\n }\n \n", "prefixes": [ "iwl-net", "1/2" ] }