Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2183740/?format=api
{ "id": 2183740, "url": "http://patchwork.ozlabs.org/api/patches/2183740/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260113180113.2478622-1-sreedevi.joshi@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260113180113.2478622-1-sreedevi.joshi@intel.com>", "list_archive_url": null, "date": "2026-01-13T18:01:13", "name": "[iwl-net] idpf: Fix flow rule delete failure due to invalid validation", "commit_ref": null, "pull_url": null, "state": "under-review", "archived": false, "hash": "409f7ce37a02569dcbdcd6a360e86e17ef38e560", "submitter": { "id": 91730, "url": "http://patchwork.ozlabs.org/api/people/91730/?format=api", "name": "Sreedevi Joshi", "email": "sreedevi.joshi@intel.com" }, "delegate": { "id": 109701, "url": "http://patchwork.ozlabs.org/api/users/109701/?format=api", "username": "anguy11", "first_name": "Anthony", "last_name": "Nguyen", "email": "anthony.l.nguyen@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260113180113.2478622-1-sreedevi.joshi@intel.com/mbox/", "series": [ { "id": 488231, "url": "http://patchwork.ozlabs.org/api/series/488231/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=488231", "date": "2026-01-13T18:01:13", "name": "[iwl-net] idpf: Fix flow rule delete failure due to invalid validation", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/488231/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2183740/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2183740/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=KjHmtFEm;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.136; helo=smtp3.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4drHLN2dkVz1xpf\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 14 Jan 2026 05:08:43 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 0855060A64;\n\tTue, 13 Jan 2026 18:08:42 +0000 (UTC)", "from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id ka4UOiU5G-fb; Tue, 13 Jan 2026 18:08:41 +0000 (UTC)", "from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id A47CA60A67;\n\tTue, 13 Jan 2026 18:08:40 +0000 (UTC)", "from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n by lists1.osuosl.org (Postfix) with ESMTP id 16B0F1C3\n for <intel-wired-lan@lists.osuosl.org>; Tue, 13 Jan 2026 18:08:39 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp2.osuosl.org (Postfix) with ESMTP id E717940232\n for <intel-wired-lan@lists.osuosl.org>; Tue, 13 Jan 2026 18:08:38 +0000 (UTC)", "from smtp2.osuosl.org ([127.0.0.1])\n by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id z7u838jTVP0a for <intel-wired-lan@lists.osuosl.org>;\n Tue, 13 Jan 2026 18:08:38 +0000 (UTC)", "from mgamail.intel.com (mgamail.intel.com [198.175.65.17])\n by smtp2.osuosl.org (Postfix) with ESMTPS id CB198400C7\n for <intel-wired-lan@lists.osuosl.org>; Tue, 13 Jan 2026 18:08:37 +0000 (UTC)", "from orviesa007.jf.intel.com ([10.64.159.147])\n by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 13 Jan 2026 10:01:28 -0800", "from aus-labsrv3.an.intel.com ([10.123.116.23])\n by orviesa007.jf.intel.com with ESMTP; 13 Jan 2026 10:01:28 -0800" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp3.osuosl.org A47CA60A67", "OpenDKIM Filter v2.11.0 smtp2.osuosl.org CB198400C7" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1768327720;\n\tbh=AE+Q0BZCGWjcLPwZwRKe+d7B+gAquL9rQnPuGo4VtL8=;\n\th=From:To:Cc:Date:Subject:List-Id:List-Unsubscribe:List-Archive:\n\t List-Post:List-Help:List-Subscribe:From;\n\tb=KjHmtFEmtB7iJFRr4LFSGLcUQv6SlAVMoY9bpYlxd7BQN5k8UUD+c6Isb6Iq9ZMS6\n\t FoQ1GlTIgeY5YZtnUuW61GpBVSlNzeE5eZnO1dC1hZ5T5SupIYiyFTmvVbkN5zYOKJ\n\t EfFrdJb32FVgn3KJ4fq2UegyDM81WH4VJNJufDg44k8a7RZM+XFAi+bVp86dCD3u2Y\n\t PX17NZ/oxiRGvqUKn7+/PHWgpH25zCLnSURQyWRG+XfsiO7K0kXyrcrgnAZZQZllIy\n\t CyiYTM1PYqXft8hCShsRuXHKm8a3xEIRFPkBtp29qtJb83MxxbeeKW7NRoLYDPoDU/\n\t fBuOq1jUsA58A==", "X-Greylist": "delayed 428 seconds by postgrey-1.37 at util1.osuosl.org;\n Tue, 13 Jan 2026 18:08:37 UTC", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp2.osuosl.org CB198400C7", "Received-SPF": "Pass (mailfrom) identity=mailfrom; client-ip=198.175.65.17;\n helo=mgamail.intel.com; envelope-from=sreedevi.joshi@intel.com;\n receiver=<UNKNOWN>", "X-CSE-ConnectionGUID": [ "3WL0vYEXTfuaw/NXpsTL0w==", "gzRybBr/RRKFjHdsBDp/9A==" ], "X-CSE-MsgGUID": [ "F6lIBRkES5+Dibi7TR69jw==", "IxdieCaESjKbzSp+CSYvkA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6800,10657,11670\"; a=\"69603400\"", "E=Sophos;i=\"6.21,222,1763452800\"; d=\"scan'208\";a=\"69603400\"", "E=Sophos;i=\"6.21,222,1763452800\"; d=\"scan'208\";a=\"204472276\"" ], "X-ExtLoop1": "1", "From": "Sreedevi Joshi <sreedevi.joshi@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Cc": "netdev@vger.kernel.org, Sreedevi Joshi <sreedevi.joshi@intel.com>,\n Aleksandr Loktionov <aleksandr.loktionov@intel.com>", "Date": "Tue, 13 Jan 2026 12:01:13 -0600", "Message-Id": "<20260113180113.2478622-1-sreedevi.joshi@intel.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Original-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1768327718; x=1799863718;\n h=from:to:cc:subject:date:message-id:mime-version:\n content-transfer-encoding;\n bh=C7/h/yMHwzAFrC90V61WazgaAYBmCRbi7WqmJYLsack=;\n b=I2wd0lpPaK6S+Qkz7zV9c66EucuYCF+AvcAqCsSZ2EwBClkv/mqLM+wk\n vAWQRO5ZoP7cycpcdGaelrOdSvJO2vPIbmHOas8DVL4LLNet6OlYnFN7R\n XoQRYRbL9umOizElNeQlCVSh3WiiAJ+SKVWDtgpEFFKp21NssorNksNKI\n oF0USraX3Crr1trJfDocatIkkEoMa/LVVKZLd5mSaYUW8RMvGbpBR5dn/\n FeY4iatd/teMJWsxqyYdJ1+5+NT1lbme8pTR/09bp5BlV15yVesS4ioCd\n KWygx6AmFV51g22taAcwWCGJiVjKMT5mxc0zrYigWNMJw5KpK9sPOSl/j\n Q==;", "X-Mailman-Original-Authentication-Results": [ "smtp2.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com", "smtp2.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=I2wd0lpP" ], "Subject": "[Intel-wired-lan] [PATCH iwl-net] idpf: Fix flow rule delete\n failure due to invalid validation", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "When deleting a flow rule using \"ethtool -N <dev> delete <location>\",\nidpf_sideband_action_ena() incorrectly validates fsp->ring_cookie even\nthough ethtool doesn't populate this field for delete operations. The\nuninitialized ring_cookie may randomly match RX_CLS_FLOW_DISC or\nRX_CLS_FLOW_WAKE, causing validation to fail and preventing legitimate\nrule deletions. Remove the unnecessary sideband action enable check and\nring_cookie validation during delete operations since action validation\nis not required when removing existing rules.\n\nFixes: ada3e24b84a0 (\"idpf: add flow steering support\")\nSigned-off-by: Sreedevi Joshi <sreedevi.joshi@intel.com>\nReviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>\n---\n drivers/net/ethernet/intel/idpf/idpf_ethtool.c | 3 ---\n 1 file changed, 3 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/idpf/idpf_ethtool.c b/drivers/net/ethernet/intel/idpf/idpf_ethtool.c\nindex 2efa3c08aba5..49cefb973f4d 100644\n--- a/drivers/net/ethernet/intel/idpf/idpf_ethtool.c\n+++ b/drivers/net/ethernet/intel/idpf/idpf_ethtool.c\n@@ -307,9 +307,6 @@ static int idpf_del_flow_steer(struct net_device *netdev,\n \tvport_config = vport->adapter->vport_config[np->vport_idx];\n \tuser_config = &vport_config->user_config;\n \n-\tif (!idpf_sideband_action_ena(vport, fsp))\n-\t\treturn -EOPNOTSUPP;\n-\n \trule = kzalloc(struct_size(rule, rule_info, 1), GFP_KERNEL);\n \tif (!rule)\n \t\treturn -ENOMEM;\n", "prefixes": [ "iwl-net" ] }