Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2183370/?format=api
{ "id": 2183370, "url": "http://patchwork.ozlabs.org/api/patches/2183370/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260112230944.3085309-3-boolli@google.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260112230944.3085309-3-boolli@google.com>", "list_archive_url": null, "date": "2026-01-12T23:09:44", "name": "[2/2] idpf: skip deallocating txq group's txqs if it is NULL.", "commit_ref": null, "pull_url": null, "state": "under-review", "archived": false, "hash": "156de59291beeb5fcea226b157e60a19c0448cea", "submitter": { "id": 92373, "url": "http://patchwork.ozlabs.org/api/people/92373/?format=api", "name": "Li Li", "email": "boolli@google.com" }, "delegate": { "id": 109701, "url": "http://patchwork.ozlabs.org/api/users/109701/?format=api", "username": "anguy11", "first_name": "Anthony", "last_name": "Nguyen", "email": "anthony.l.nguyen@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260112230944.3085309-3-boolli@google.com/mbox/", "series": [ { "id": 488113, "url": "http://patchwork.ozlabs.org/api/series/488113/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=488113", "date": "2026-01-12T23:09:42", "name": "idpf: skip NULL pointers during deallocation.", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/488113/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2183370/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2183370/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=AumEYq5O;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::137; helo=smtp4.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4dqp4p6T8tz1xqD\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 13 Jan 2026 10:10:18 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id C037A41270;\n\tMon, 12 Jan 2026 23:10:15 +0000 (UTC)", "from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id CaQPkiRRvNca; Mon, 12 Jan 2026 23:10:15 +0000 (UTC)", "from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id F3956411C4;\n\tMon, 12 Jan 2026 23:10:14 +0000 (UTC)", "from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n by lists1.osuosl.org (Postfix) with ESMTP id C339018D\n for <intel-wired-lan@lists.osuosl.org>; Mon, 12 Jan 2026 23:10:13 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp3.osuosl.org (Postfix) with ESMTP id A8369610D9\n for <intel-wired-lan@lists.osuosl.org>; Mon, 12 Jan 2026 23:10:13 +0000 (UTC)", "from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id C_ZjWII6bCpG for <intel-wired-lan@lists.osuosl.org>;\n Mon, 12 Jan 2026 23:10:13 +0000 (UTC)", "from mail-dl1-x124a.google.com (mail-dl1-x124a.google.com\n [IPv6:2607:f8b0:4864:20::124a])\n by smtp3.osuosl.org (Postfix) with ESMTPS id EF7DA610D5\n for <intel-wired-lan@lists.osuosl.org>; Mon, 12 Jan 2026 23:10:12 +0000 (UTC)", "by mail-dl1-x124a.google.com with SMTP id\n a92af1059eb24-11dd10b03c6so10185839c88.0\n for <intel-wired-lan@lists.osuosl.org>; Mon, 12 Jan 2026 15:10:12 -0800 (PST)" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp4.osuosl.org F3956411C4", "OpenDKIM Filter v2.11.0 smtp3.osuosl.org EF7DA610D5" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1768259415;\n\tbh=1GtgZegM7FjbeyuOL5Y6kyqpA7dLG8bpU56qxoB17r0=;\n\th=Date:In-Reply-To:References:From:To:Cc:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=AumEYq5OWNJgowNVhOT8WSykEBFXOiD8v5HeOjWfTSRY16QnBzkArYoAYcDnejO9J\n\t +Ts0qwRg6qsBt1NahO7deqsenRpyvyuG6QeBus8x2FlQ7icZtsuLF6ThjoMKLne3Kl\n\t zHG64QlCWKhZxQnGM2QIkKhErS8/VI7EifxkHmywaK0Gl7LpbpazeTcYsHjTE5Dmzd\n\t poZemC0NCkSsgfr2M2Ar7bljnVBy82g9DW/es7Gtx5vz18AAgXKZ5myyr1JnlsGDFT\n\t K6HG6UbiOdRWwYrMcI8Y5+kkglucDFRxguGhHx8H2SKTEw1HB637WMybE3/YKiJRi7\n\t OLAhctU0lGZig==", "Received-SPF": "Pass (mailfrom) identity=mailfrom;\n client-ip=2607:f8b0:4864:20::124a; helo=mail-dl1-x124a.google.com;\n envelope-from=3u39laqykdzoxkkhheckkcha.ykiejpah-senaz-hwjheopo.koqkoh.knc@flex--boolli.bounces.google.com;\n receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp3.osuosl.org EF7DA610D5", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1768259412; x=1768864212;\n h=cc:to:from:subject:message-id:references:mime-version:in-reply-to\n :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n bh=1GtgZegM7FjbeyuOL5Y6kyqpA7dLG8bpU56qxoB17r0=;\n b=D0PCucwMoSkbZQeuEnMtoe0hKVkVVMbUPdSQSY080FYcntPYm0fts984QqK8aRs1IN\n TA2VGYB0QRmHsZlCAeIM6ldhdzVw2TQzjG8+O5q2e8PkyXwfVBfdcQpQEDwuxOdYnriL\n Pa6MHlNYj7iB4A60y+KJmD6UcitsRyb5e4wJuSdA5m4dI2gjKrQywIkfnL8+iweYCfYf\n NGVmEwKHDdMRdgPcLi++I89n9FVq0DUpkcZ9CqGAWqPoOMITc9Agh6dqhu48ec8PIYyq\n HdVRzd9geFPT0QKsJv2ozx3NE22ios8ARi1FtYjmw3j72cvpttFc7CSyleeazZgl/WvE\n WykA==", "X-Forwarded-Encrypted": "i=1;\n AJvYcCUsxZQpN0sacrKKrT60w2wO0jnLq+Onn7/dBVkGtXrYbL3CX7T/yuLY6eXEBUCyMG1Klkjf9RRHQGkCtuwB3VY=@lists.osuosl.org", "X-Gm-Message-State": "AOJu0Yz4RBcoFHn0wUbDaQI8wXsVqhbFt2Bk5axpVb/G+Z7Snu9x4apP\n K5kSzPLP70I7hRNM7yGAKBrYGl8yiTVN6UAwyJMwQoHXMGvfnSukL4ZIAqCHv1uZ17r8M3WvbrQ\n qkWNy1Q==", "X-Google-Smtp-Source": "\n AGHT+IFUZfbTXF1Fw1Cvh/r4GdD8A92eVq9LwJaEBG9JrsMm9bSGeUApjkJeHgxbw+xleiw77AYeSVOJYO4=", "X-Received": "from dlbti6.prod.google.com\n ([2002:a05:7022:1b06:b0:11f:3484:4f15])\n (user=boolli job=prod-delivery.src-stubby-dispatcher) by\n 2002:a05:7022:f90:b0:11d:c04a:dc5b\n with SMTP id a92af1059eb24-121f8b7a790mr16487972c88.30.1768259411873; Mon, 12\n Jan 2026 15:10:11 -0800 (PST)", "Date": "Mon, 12 Jan 2026 23:09:44 +0000", "In-Reply-To": "<20260112230944.3085309-1-boolli@google.com>", "Mime-Version": "1.0", "References": "<20260112230944.3085309-1-boolli@google.com>", "X-Mailer": "git-send-email 2.52.0.457.g6b5491de43-goog", "Message-ID": "<20260112230944.3085309-3-boolli@google.com>", "From": "Li Li <boolli@google.com>", "To": "Tony Nguyen <anthony.l.nguyen@intel.com>,\n Przemek Kitszel <przemyslaw.kitszel@intel.com>,\n \"David S. Miller\" <davem@davemloft.net>,\n Jakub Kicinski <kuba@kernel.org>, Eric Dumazet <edumazet@google.com>,\n intel-wired-lan@lists.osuosl.org", "Cc": "netdev@vger.kernel.org, linux-kernel@vger.kernel.org,\n David Decotigny <decot@google.com>,\n Anjali Singhai <anjali.singhai@intel.com>,\n Sridhar Samudrala <sridhar.samudrala@intel.com>,\n Brian Vazquez <brianvv@google.com>,\n Li Li <boolli@google.com>, emil.s.tantilov@intel.com", "Content-Type": "text/plain; charset=\"UTF-8\"", "X-Mailman-Original-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=google.com; s=20230601; t=1768259412; x=1768864212; darn=lists.osuosl.org;\n h=cc:to:from:subject:message-id:references:mime-version:in-reply-to\n :date:from:to:cc:subject:date:message-id:reply-to;\n bh=1GtgZegM7FjbeyuOL5Y6kyqpA7dLG8bpU56qxoB17r0=;\n b=E0j/AznrYq7BxkOS4UNyuIkMXTw7ofM7I7065KR4/lthnyak3Ab+VewPX+nCO2YSSM\n flNyTv7jkCHKONW5Up0VFVPDhsdqNvfYFXyWIzfPwmW+oFjsT4oqI1k+WmBkrt2MWRvP\n YbOBsemWI8Xc4pbGnAlSBCH381URFkHCm8isdnBFc2XwsT/5Tp2CH24HDp1EY3JRyNks\n l/r/jj/CAMMzfG6cpy7+BlTPRy/++POrzxe+yk4OCfWMzjtu+uuzYUzxkrYRJjpkyB7c\n cN/a3txVfM8pw3b2ctwRqebQsLY0UfaYQcwT1oRTmw8nnoxYahaHgeZXWJPRL61MplQ6\n OU7g==", "X-Mailman-Original-Authentication-Results": [ "smtp3.osuosl.org;\n dmarc=pass (p=reject dis=none)\n header.from=google.com", "smtp3.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256\n header.s=20230601 header.b=E0j/Aznr" ], "Subject": "[Intel-wired-lan] [PATCH 2/2] idpf: skip deallocating txq group's\n txqs if it is NULL.", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "In idpf_txq_group_alloc(), if any txq group's txqs failed to\nallocate memory:\n\n\tfor (j = 0; j < tx_qgrp->num_txq; j++) {\n\t\ttx_qgrp->txqs[j] = kzalloc(sizeof(*tx_qgrp->txqs[j]),\n\t\t\t\t\t GFP_KERNEL);\n\t\tif (!tx_qgrp->txqs[j])\n\t\t\tgoto err_alloc;\n\t}\n\nIt would cause a NULL ptr kernel panic in idpf_txq_group_rel():\n\n\tfor (j = 0; j < txq_grp->num_txq; j++) {\n\t\tif (flow_sch_en) {\n\t\t\tkfree(txq_grp->txqs[j]->refillq);\n\t\t\ttxq_grp->txqs[j]->refillq = NULL;\n\t\t}\n\n\t\tkfree(txq_grp->txqs[j]);\n\t\ttxq_grp->txqs[j] = NULL;\n\t}\n\n[ 6.532461] BUG: kernel NULL pointer dereference, address: 0000000000000058\n...\n[ 6.534433] RIP: 0010:idpf_txq_group_rel+0xc9/0x110\n...\n[ 6.538513] Call Trace:\n[ 6.538639] <TASK>\n[ 6.538760] idpf_vport_queues_alloc+0x75/0x550\n[ 6.538978] idpf_vport_open+0x4d/0x3f0\n[ 6.539164] idpf_open+0x71/0xb0\n[ 6.539324] __dev_open+0x142/0x260\n[ 6.539506] netif_open+0x2f/0xe0\n[ 6.539670] dev_open+0x3d/0x70\n[ 6.539827] bond_enslave+0x5ed/0xf50\n[ 6.540005] ? rcutree_enqueue+0x1f/0xb0\n[ 6.540193] ? call_rcu+0xde/0x2a0\n[ 6.540375] ? barn_get_empty_sheaf+0x5c/0x80\n[ 6.540594] ? __kfree_rcu_sheaf+0xb6/0x1a0\n[ 6.540793] ? nla_put_ifalias+0x3d/0x90\n[ 6.540981] ? kvfree_call_rcu+0xb5/0x3b0\n[ 6.541173] ? kvfree_call_rcu+0xb5/0x3b0\n[ 6.541365] do_set_master+0x114/0x160\n[ 6.541547] do_setlink+0x412/0xfb0\n[ 6.541717] ? security_sock_rcv_skb+0x2a/0x50\n[ 6.541931] ? sk_filter_trim_cap+0x7c/0x320\n[ 6.542136] ? skb_queue_tail+0x20/0x50\n[ 6.542322] ? __nla_validate_parse+0x92/0xe50\nro[o t t o6 .d5e4f2a5u4l0t]- ? security_capable+0x35/0x60\n[ 6.542792] rtnl_newlink+0x95c/0xa00\n[ 6.542972] ? __rtnl_unlock+0x37/0x70\n[ 6.543152] ? netdev_run_todo+0x63/0x530\n[ 6.543343] ? allocate_slab+0x280/0x870\n[ 6.543531] ? security_capable+0x35/0x60\n[ 6.543722] rtnetlink_rcv_msg+0x2e6/0x340\n[ 6.543918] ? __pfx_rtnetlink_rcv_msg+0x10/0x10\n[ 6.544138] netlink_rcv_skb+0x16a/0x1a0\n[ 6.544328] netlink_unicast+0x20a/0x320\n[ 6.544516] netlink_sendmsg+0x304/0x3b0\n[ 6.544748] __sock_sendmsg+0x89/0xb0\n[ 6.544928] ____sys_sendmsg+0x167/0x1c0\n[ 6.545116] ? ____sys_recvmsg+0xed/0x150\n[ 6.545308] ___sys_sendmsg+0xdd/0x120\n[ 6.545489] ? ___sys_recvmsg+0x124/0x1e0\n[ 6.545680] ? rcutree_enqueue+0x1f/0xb0\n[ 6.545867] ? rcutree_enqueue+0x1f/0xb0\n[ 6.546055] ? call_rcu+0xde/0x2a0\n[ 6.546222] ? evict+0x286/0x2d0\n[ 6.546389] ? rcutree_enqueue+0x1f/0xb0\n[ 6.546577] ? kmem_cache_free+0x2c/0x350\n[ 6.546784] __x64_sys_sendmsg+0x72/0xc0\n[ 6.546972] do_syscall_64+0x6f/0x890\n[ 6.547150] entry_SYSCALL_64_after_hwframe+0x76/0x7e\n[ 6.547393] RIP: 0033:0x7fc1a3347bd0\n...\n[ 6.551375] RIP: 0010:idpf_txq_group_rel+0xc9/0x110\n...\n[ 6.578856] Rebooting in 10 seconds..\n\nWe should skip deallocating txqs[j] if it is NULL in the first place.\n\nTested: with this patch, the kernel panic no longer appears.\nFixes: 1c325aac10a8 (\"idpf: configure resources for TX queues\")\n\nSigned-off-by: Li Li <boolli@google.com>\n---\n drivers/net/ethernet/intel/idpf/idpf_txrx.c | 3 +++\n 1 file changed, 3 insertions(+)", "diff": "diff --git a/drivers/net/ethernet/intel/idpf/idpf_txrx.c b/drivers/net/ethernet/intel/idpf/idpf_txrx.c\nindex b4dab4a8ee11b..25207da6c995d 100644\n--- a/drivers/net/ethernet/intel/idpf/idpf_txrx.c\n+++ b/drivers/net/ethernet/intel/idpf/idpf_txrx.c\n@@ -1311,6 +1311,9 @@ static void idpf_txq_group_rel(struct idpf_vport *vport)\n \t\tstruct idpf_txq_group *txq_grp = &vport->txq_grps[i];\n \n \t\tfor (j = 0; j < txq_grp->num_txq; j++) {\n+\t\t\tif (!txq_grp->txqs[j])\n+\t\t\t\tcontinue;\n+\n \t\t\tif (flow_sch_en) {\n \t\t\t\tkfree(txq_grp->txqs[j]->refillq);\n \t\t\t\ttxq_grp->txqs[j]->refillq = NULL;\n", "prefixes": [ "2/2" ] }