Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2183369/?format=api
{ "id": 2183369, "url": "http://patchwork.ozlabs.org/api/patches/2183369/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260112230944.3085309-2-boolli@google.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260112230944.3085309-2-boolli@google.com>", "list_archive_url": null, "date": "2026-01-12T23:09:43", "name": "[1/2] idpf: skip deallocating bufq_sets from rx_qgrp if it is NULL.", "commit_ref": null, "pull_url": null, "state": "under-review", "archived": false, "hash": "a00fd62cb91e0e77805287a55a52de07a6f3aef2", "submitter": { "id": 92373, "url": "http://patchwork.ozlabs.org/api/people/92373/?format=api", "name": "Li Li", "email": "boolli@google.com" }, "delegate": { "id": 109701, "url": "http://patchwork.ozlabs.org/api/users/109701/?format=api", "username": "anguy11", "first_name": "Anthony", "last_name": "Nguyen", "email": "anthony.l.nguyen@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260112230944.3085309-2-boolli@google.com/mbox/", "series": [ { "id": 488113, "url": "http://patchwork.ozlabs.org/api/series/488113/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=488113", "date": "2026-01-12T23:09:42", "name": "idpf: skip NULL pointers during deallocation.", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/488113/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2183369/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2183369/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=xw95TICO;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::137; helo=smtp4.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4dqp4m2xwKz1xqD\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 13 Jan 2026 10:10:16 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 5DB644111B;\n\tMon, 12 Jan 2026 23:10:14 +0000 (UTC)", "from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id zm5E7QhXSAxj; Mon, 12 Jan 2026 23:10:12 +0000 (UTC)", "from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 75716410F6;\n\tMon, 12 Jan 2026 23:10:12 +0000 (UTC)", "from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n by lists1.osuosl.org (Postfix) with ESMTP id 0EFE91CC\n for <intel-wired-lan@lists.osuosl.org>; Mon, 12 Jan 2026 23:10:11 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp1.osuosl.org (Postfix) with ESMTP id E76D4811D3\n for <intel-wired-lan@lists.osuosl.org>; Mon, 12 Jan 2026 23:10:10 +0000 (UTC)", "from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id fT7KEwOYq6LX for <intel-wired-lan@lists.osuosl.org>;\n Mon, 12 Jan 2026 23:10:10 +0000 (UTC)", "from mail-dy1-x134a.google.com (mail-dy1-x134a.google.com\n [IPv6:2607:f8b0:4864:20::134a])\n by smtp1.osuosl.org (Postfix) with ESMTPS id 36F14811D1\n for <intel-wired-lan@lists.osuosl.org>; Mon, 12 Jan 2026 23:10:10 +0000 (UTC)", "by mail-dy1-x134a.google.com with SMTP id\n 5a478bee46e88-2b21d136010so1863286eec.1\n for <intel-wired-lan@lists.osuosl.org>; Mon, 12 Jan 2026 15:10:10 -0800 (PST)" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp4.osuosl.org 75716410F6", "OpenDKIM Filter v2.11.0 smtp1.osuosl.org 36F14811D1" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1768259412;\n\tbh=ys9dvyGwIYrmKuQ4BRnJwsHizh4UyGAtZEMdFdAVXfI=;\n\th=Date:In-Reply-To:References:To:Cc:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From:Reply-To:From;\n\tb=xw95TICOwOz/FqJjbFEUO6EW95DsGUdZCjYaayu1b1Du39zaHNBUdOVfdTSVT3nHy\n\t eXNGKEEfmRF2tTNmgA09UXa9SkNOkaNNjNGfB2s80tDZVzcyNFi5mbpU8BdZcTvugm\n\t ezJDAs1+LdMrb5nzGF5kwtkmdEnERhJawpMOseuirAM4cqfDoZhkEerpy9HedTkQX5\n\t 0asGi1SEydgy3knnrRAnpWSRGvQ6hfMV9HE9Gx8M08CowgVbK0gTA266he4ecWCe2Q\n\t hBpEbforal/KHrPqDODyiEEvpkZKWRP0TeDn4WCvuEQ8brMJdUBQIA1pmL6IpcvKVt\n\t nwn1YF8U+ZOvw==", "Received-SPF": "Pass (mailfrom) identity=mailfrom;\n client-ip=2607:f8b0:4864:20::134a; helo=mail-dy1-x134a.google.com;\n envelope-from=3ux9laqykdzgviiffcaiiafy.wigchnyf-qclyx-fuhfcmnm.imoimf.ila@flex--boolli.bounces.google.com;\n receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp1.osuosl.org 36F14811D1", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1768259409; x=1768864209;\n h=cc:to:from:subject:message-id:references:mime-version:in-reply-to\n :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n bh=ys9dvyGwIYrmKuQ4BRnJwsHizh4UyGAtZEMdFdAVXfI=;\n b=CaLMPmmvHesiOLfYhR9RWWKz5ntxaMY/ajwW/KR6dl4qhNa1PP+2qpE+xjHjqnHkSL\n vdVj+SKTmXxZofsy/mwDCk/eWnDoZHiFm7ipwoSgff/vuJ9119RKbishqK8yzVSFvew8\n p5T1iarXoeeFakdLP2u/5IMkF5UxuiPkiRoXa+MKsQ/JSE7P9+1YNj3lhdU6qIsrQWdK\n E+Rg92JHhuTEsVVVBsIhWQgkTx3yI+NbZb9Sz1ovmGCUYGfi6raQfBpFoJxO7CxzXIXd\n ERWqr4exKCnoRbMu97dSFxcqHUroqIry6ymkd36yrlMPng8G7v1u8It24NCytCZ+e1dj\n IK8g==", "X-Forwarded-Encrypted": "i=1;\n AJvYcCUzu8Jp/EUuuyOUP3iAFKHMnau/mbwxf7g4Wnntwapa6uFHJ+rvnSzMSzj52naut0HoygSgjDjmcZ1WckcadCw=@lists.osuosl.org", "X-Gm-Message-State": "AOJu0Yy8Glng/syr3mRNvYsJNrq1itMILExtsYdXCR4XZXC9LhdKE5we\n Qz6Pg0eoo/KWbIzNuGqnqA0yOcsR/PLKGuWJiCOi6N4S8z75gvm+dTTFfPMNiLOa/JVuzqNTEeN\n Pc9CBLw==", "X-Google-Smtp-Source": "\n AGHT+IG2eLtwALIqRuLzTvWBZTR3JwnqCHU/cLQ/o7m/M8FDpJLzndU6O/Y0t/1rJsF81ci2jWQlHUXyLwY=", "X-Received": "from dlbtp2.prod.google.com ([2002:a05:7022:3b82:b0:123:2dd9:db4])\n (user=boolli job=prod-delivery.src-stubby-dispatcher) by\n 2002:a05:7022:6286:b0:119:e56b:9899\n with SMTP id a92af1059eb24-121f8a5b4demr19013846c88.0.1768259409124; Mon, 12\n Jan 2026 15:10:09 -0800 (PST)", "Date": "Mon, 12 Jan 2026 23:09:43 +0000", "In-Reply-To": "<20260112230944.3085309-1-boolli@google.com>", "Mime-Version": "1.0", "References": "<20260112230944.3085309-1-boolli@google.com>", "X-Mailer": "git-send-email 2.52.0.457.g6b5491de43-goog", "Message-ID": "<20260112230944.3085309-2-boolli@google.com>", "To": "Tony Nguyen <anthony.l.nguyen@intel.com>,\n Przemek Kitszel <przemyslaw.kitszel@intel.com>,\n \"David S. Miller\" <davem@davemloft.net>,\n Jakub Kicinski <kuba@kernel.org>, Eric Dumazet <edumazet@google.com>,\n intel-wired-lan@lists.osuosl.org", "Cc": "netdev@vger.kernel.org, linux-kernel@vger.kernel.org,\n David Decotigny <decot@google.com>,\n Anjali Singhai <anjali.singhai@intel.com>,\n Sridhar Samudrala <sridhar.samudrala@intel.com>,\n Brian Vazquez <brianvv@google.com>,\n Li Li <boolli@google.com>, emil.s.tantilov@intel.com", "Content-Type": "text/plain; charset=\"UTF-8\"", "X-Mailman-Original-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=google.com; s=20230601; t=1768259409; x=1768864209; darn=lists.osuosl.org;\n h=cc:to:from:subject:message-id:references:mime-version:in-reply-to\n :date:from:to:cc:subject:date:message-id:reply-to;\n bh=ys9dvyGwIYrmKuQ4BRnJwsHizh4UyGAtZEMdFdAVXfI=;\n b=SsBKtZm72J9AkJLdvOXj6ihHqbYkHgQpTV7CJyqB/P/b32LaNm7lZQh2L82qTY2Q/Z\n 0glnp839gxz+F9VP1dUq8abpSIg1OXWIMk0ACj+yvGM6s5ZWAruf26Bh59VQRBQW9hMN\n EQGgj4gYW7ZB2PD8CR0HljPR3W6/cR5uzkuMEY2cWf1BTgHoOZWcpiZFvIb/j+Qq7YhD\n t9WZm+VTYQ4M+FaHq0gO4tDGfoSd4bgsEQzwrjhRLANPxGzbviBY2IpTRMrvIVRnLGLt\n 87JM8Cph8W8A4tseQh7xmcuU+RHh31pnog9IaNnSEVAHWgLEqaTtCqMb7Pe+rd4yAxa5\n tJwA==", "X-Mailman-Original-Authentication-Results": [ "smtp1.osuosl.org;\n dmarc=pass (p=reject dis=none)\n header.from=google.com", "smtp1.osuosl.org;\n dkim=pass (2048-bit key) header.d=google.com header.i=@google.com\n header.a=rsa-sha256 header.s=20230601 header.b=SsBKtZm7" ], "Subject": "[Intel-wired-lan] [PATCH 1/2] idpf: skip deallocating bufq_sets\n from rx_qgrp if it is NULL.", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "From": "Li Li via Intel-wired-lan <intel-wired-lan@osuosl.org>", "Reply-To": "Li Li <boolli@google.com>", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "In idpf_rxq_group_alloc(), if rx_qgrp->splitq.bufq_sets failed to get\nallocated:\n\n\trx_qgrp->splitq.bufq_sets = kcalloc(vport->num_bufqs_per_qgrp,\n\t\t\t\t\t sizeof(struct idpf_bufq_set),\n\t\t\t\t\t GFP_KERNEL);\n\tif (!rx_qgrp->splitq.bufq_sets) {\n\t\terr = -ENOMEM;\n\t\tgoto err_alloc;\n\t}\n\nidpf_rxq_group_rel() would attempt to deallocate it in\nidpf_rxq_sw_queue_rel(), causing a kernel panic:\n\n```\n[ 7.967242] early-network-sshd-n-rexd[3148]: knetbase: Info: [ 8.127804] BUG: kernel NULL pointer dereference, address: 00000000000000c0\n...\n[ 8.129779] RIP: 0010:idpf_rxq_group_rel+0x101/0x170\n...\n[ 8.133854] Call Trace:\n[ 8.133980] <TASK>\n[ 8.134092] idpf_vport_queues_alloc+0x286/0x500\n[ 8.134313] idpf_vport_open+0x4d/0x3f0\n[ 8.134498] idpf_open+0x71/0xb0\n[ 8.134668] __dev_open+0x142/0x260\n[ 8.134840] netif_open+0x2f/0xe0\n[ 8.135004] dev_open+0x3d/0x70\n[ 8.135166] bond_enslave+0x5ed/0xf50\n[ 8.135345] ? nla_put_ifalias+0x3d/0x90\n[ 8.135533] ? kvfree_call_rcu+0xb5/0x3b0\n[ 8.135725] ? kvfree_call_rcu+0xb5/0x3b0\n[ 8.135916] do_set_master+0x114/0x160\n[ 8.136098] do_setlink+0x412/0xfb0\n[ 8.136269] ? security_sock_rcv_skb+0x2a/0x50\n[ 8.136509] ? sk_filter_trim_cap+0x7c/0x320\n[ 8.136714] ? skb_queue_tail+0x20/0x50\n[ 8.136899] ? __nla_validate_parse+0x92/0xe50\n[ 8.137112] ? security_capable+0x35/0x60\n[ 8.137304] rtnl_newlink+0x95c/0xa00\n[ 8.137483] ? __rtnl_unlock+0x37/0x70\n[ 8.137664] ? netdev_run_todo+0x63/0x530\n[ 8.137855] ? allocate_slab+0x280/0x870\n[ 8.138044] ? security_capable+0x35/0x60\n[ 8.138235] rtnetlink_rcv_msg+0x2e6/0x340\n[ 8.138431] ? __pfx_rtnetlink_rcv_msg+0x10/0x10\n[ 8.138650] netlink_rcv_skb+0x16a/0x1a0\n[ 8.138840] netlink_unicast+0x20a/0x320\n[ 8.139028] netlink_sendmsg+0x304/0x3b0\n[ 8.139217] __sock_sendmsg+0x89/0xb0\n[ 8.139399] ____sys_sendmsg+0x167/0x1c0\n[ 8.139588] ? ____sys_recvmsg+0xed/0x150\n[ 8.139780] ___sys_sendmsg+0xdd/0x120\n[ 8.139960] ? ___sys_recvmsg+0x124/0x1e0\n[ 8.140152] ? rcutree_enqueue+0x1f/0xb0\n[ 8.140341] ? rcutree_enqueue+0x1f/0xb0\n[ 8.140528] ? call_rcu+0xde/0x2a0\n[ 8.140695] ? evict+0x286/0x2d0\n[ 8.140856] ? rcutree_enqueue+0x1f/0xb0\n[ 8.141043] ? kmem_cache_free+0x2c/0x350\n[ 8.141236] __x64_sys_sendmsg+0x72/0xc0\n[ 8.141424] do_syscall_64+0x6f/0x890\n[ 8.141603] entry_SYSCALL_64_after_hwframe+0x76/0x7e\n[ 8.141841] RIP: 0033:0x7f2799d21bd0\n...\n[ 8.149905] Kernel panic - not syncing: Fatal exception\n[ 8.175940] Kernel Offset: 0xf800000 from 0xffffffff81000000 (relocation range: 0xffffffff80000000-0xffffffffbfffffff)\n[ 8.176425] Rebooting in 10 seconds..\n```\n\nTested: With this patch, the kernel panic no longer appears.\nFixes: 95af467d9a4e (\"idpf: configure resources for RX queues\")\n\nSigned-off-by: Li Li <boolli@google.com>\n---\n drivers/net/ethernet/intel/idpf/idpf_txrx.c | 2 ++\n 1 file changed, 2 insertions(+)", "diff": "diff --git a/drivers/net/ethernet/intel/idpf/idpf_txrx.c b/drivers/net/ethernet/intel/idpf/idpf_txrx.c\nindex e7b131dba200c..b4dab4a8ee11b 100644\n--- a/drivers/net/ethernet/intel/idpf/idpf_txrx.c\n+++ b/drivers/net/ethernet/intel/idpf/idpf_txrx.c\n@@ -1337,6 +1337,8 @@ static void idpf_txq_group_rel(struct idpf_vport *vport)\n static void idpf_rxq_sw_queue_rel(struct idpf_rxq_group *rx_qgrp)\n {\n \tint i, j;\n+\tif (!rx_qgrp->splitq.bufq_sets)\n+\t\treturn;\n \n \tfor (i = 0; i < rx_qgrp->vport->num_bufqs_per_qgrp; i++) {\n \t\tstruct idpf_bufq_set *bufq_set = &rx_qgrp->splitq.bufq_sets[i];\n", "prefixes": [ "1/2" ] }