Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2183212/?format=api
{ "id": 2183212, "url": "http://patchwork.ozlabs.org/api/patches/2183212/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260112192035.10427-36-ebiggers@kernel.org/", "project": { "id": 2, "url": "http://patchwork.ozlabs.org/api/projects/2/?format=api", "name": "Linux PPC development", "link_name": "linuxppc-dev", "list_id": "linuxppc-dev.lists.ozlabs.org", "list_email": "linuxppc-dev@lists.ozlabs.org", "web_url": "https://github.com/linuxppc/wiki/wiki", "scm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git", "webscm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/", "list_archive_url_format": "https://lore.kernel.org/linuxppc-dev/{}/", "commit_url_format": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}" }, "msgid": "<20260112192035.10427-36-ebiggers@kernel.org>", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/20260112192035.10427-36-ebiggers@kernel.org/", "date": "2026-01-12T19:20:33", "name": "[v2,35/35] lib/crypto: aes: Drop 'volatile' from aes_sbox and aes_inv_sbox", "commit_ref": null, "pull_url": null, "state": "handled-elsewhere", "archived": false, "hash": "5d5762a6807db5bcc47231f71c0548407cdf584f", "submitter": { "id": 74690, "url": "http://patchwork.ozlabs.org/api/people/74690/?format=api", "name": "Eric Biggers", "email": "ebiggers@kernel.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260112192035.10427-36-ebiggers@kernel.org/mbox/", "series": [ { "id": 488089, "url": "http://patchwork.ozlabs.org/api/series/488089/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=488089", "date": "2026-01-12T19:19:58", "name": "AES library improvements", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/488089/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2183212/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2183212/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linuxppc-dev+bounces-15574-incoming=patchwork.ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=a0KxQKZz;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=112.213.38.117; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-15574-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)", "lists.ozlabs.org;\n arc=none smtp.remote-ip=172.105.4.254", "lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org", "lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=a0KxQKZz;\n\tdkim-atps=neutral", "lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org\n (client-ip=172.105.4.254; helo=tor.source.kernel.org;\n envelope-from=ebiggers@kernel.org; receiver=lists.ozlabs.org)" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4dqj6B19dNz1xpY\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 13 Jan 2026 06:26:10 +1100 (AEDT)", "from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4dqj3J1D8dz3bl5;\n\tTue, 13 Jan 2026 06:23:40 +1100 (AEDT)", "from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4dqj3H2Ck4z3bkb\n\tfor <linuxppc-dev@lists.ozlabs.org>; Tue, 13 Jan 2026 06:23:39 +1100 (AEDT)", "from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n\tby tor.source.kernel.org (Postfix) with ESMTP id 7B91260130;\n\tMon, 12 Jan 2026 19:23:37 +0000 (UTC)", "by smtp.kernel.org (Postfix) with ESMTPSA id BF6FEC2BC87;\n\tMon, 12 Jan 2026 19:23:36 +0000 (UTC)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1768245820;\n\tcv=none;\n b=gtlTgzXHwkgQuNX9lhBEERbJzbsmA/pKK8OkphBDmpzlP0wrNYfHK5G0893nv2gMlf/Cn7VbBVnKUsKQoSiVzgkIT4xOlZNb2nv6iFixN9H/r4E9KlgycEbS6pQbmrxZhMp+XnkmgyLs5RjWY0hSQVrL7MwTXQtpDW/jGUD4Iyq7Sl7yZH0QVHe6ejGY6TBnMy2LZIPkxtlX8vSI1GRFVCk6BvZ2UbDvulhZaLN8kvHfRHFahMj5dVJReFqhcB553exRxRRM8pNkbhSvr2BzClM39BeVhZSwcBHo52lyuVHZpwwCjPCrUlzxEv//7uCruSlZTZc3BjDDekiNKy/eWA==", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1768245820; c=relaxed/relaxed;\n\tbh=0SA0X29mU5F0+X6H2Q6w5W2EIk3MslJYeRMNLAqdogo=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=L/ZgoUMKJU42fxxV2iXnN++VXXSjdRu/BbopIGtYC46FDIviMNLgvoevSAHzi0wCNQefgLtI300DR9Fj25lPsIu8UUs817fHjy2jtM6TKK4+0w8Gi/AgAYqAzQMJvrUHeXxULKj3xMnlvXbTTyVwfphydGr8ZJJZacJWkftcde64m4Fo4qiAlHEySryaBykwNmRjaud9wPt+V/4B4RuWR3Kx5zLKM/nESKZzk0xofWxpKpK3FqUrRhiO1CJwz6W3wUf2qMhUQP6GNdQsEkPSBVQ30vEZHxdGc6OuIBok2DqtjXCcipNDrx5vDfSrroKwotnYOlN1k+cB0xPfEQIW4A==", "ARC-Authentication-Results": "i=1; lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org;\n dkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=a0KxQKZz; dkim-atps=neutral;\n spf=pass (client-ip=172.105.4.254; helo=tor.source.kernel.org;\n envelope-from=ebiggers@kernel.org;\n receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1768245817;\n\tbh=b8+2isc/mWUmlO/3JdSbmkX86zq1F/K7GlRJMz6JOGg=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=a0KxQKZz4i1RsOIjwLOOJXRfsPl591C6xVTDsyPT/wulXI86KQAv8RU2kd7ep/SaL\n\t zQvgA1Gym7fI7zoT+USMG//U9qE9UXwwME2vdvVHXKVdXjAtx54Ohch2D7CMbhkA5/\n\t X6C0SH88Al9aHufVFNgjnGM96SggfDltB7624aEEJGCeq/fizRgyG19Oi5XUMRgsY3\n\t N5+7hHLYL3IuXtC2+uvsqfw8e5vT743c3gn+zrczsKCTpxZzMemonA8zrSunSiIagR\n\t D96qKtgMHNtpzT799tZxr8HGA0htwIxkqmMFBRFAiCEHlUA9gxLwDwC6SW2U2VaUuN\n\t x3lQpzaJ9SoXw==", "From": "Eric Biggers <ebiggers@kernel.org>", "To": "linux-crypto@vger.kernel.org", "Cc": "linux-kernel@vger.kernel.org,\n\tArd Biesheuvel <ardb@kernel.org>,\n\t\"Jason A . Donenfeld\" <Jason@zx2c4.com>,\n\tHerbert Xu <herbert@gondor.apana.org.au>,\n\tlinux-arm-kernel@lists.infradead.org,\n\tlinuxppc-dev@lists.ozlabs.org,\n\tlinux-riscv@lists.infradead.org,\n\tlinux-s390@vger.kernel.org,\n\tsparclinux@vger.kernel.org,\n\tx86@kernel.org,\n\tHolger Dengler <dengler@linux.ibm.com>,\n\tHarald Freudenberger <freude@linux.ibm.com>,\n\tEric Biggers <ebiggers@kernel.org>", "Subject": "[PATCH v2 35/35] lib/crypto: aes: Drop 'volatile' from aes_sbox and\n aes_inv_sbox", "Date": "Mon, 12 Jan 2026 11:20:33 -0800", "Message-ID": "<20260112192035.10427-36-ebiggers@kernel.org>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20260112192035.10427-1-ebiggers@kernel.org>", "References": "<20260112192035.10427-1-ebiggers@kernel.org>", "X-Mailing-List": "linuxppc-dev@lists.ozlabs.org", "List-Id": "<linuxppc-dev.lists.ozlabs.org>", "List-Help": "<mailto:linuxppc-dev+help@lists.ozlabs.org>", "List-Owner": "<mailto:linuxppc-dev+owner@lists.ozlabs.org>", "List-Post": "<mailto:linuxppc-dev@lists.ozlabs.org>", "List-Archive": "<https://lore.kernel.org/linuxppc-dev/>,\n <https://lists.ozlabs.org/pipermail/linuxppc-dev/>", "List-Subscribe": "<mailto:linuxppc-dev+subscribe@lists.ozlabs.org>,\n <mailto:linuxppc-dev+subscribe-digest@lists.ozlabs.org>,\n <mailto:linuxppc-dev+subscribe-nomail@lists.ozlabs.org>", "List-Unsubscribe": "<mailto:linuxppc-dev+unsubscribe@lists.ozlabs.org>", "Precedence": "list", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Spam-Status": "No, score=-0.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,\n\tDKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS\n\tautolearn=disabled version=4.0.1 OzLabs 8", "X-Spam-Checker-Version": "SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org" }, "content": "The volatile keyword is no longer necessary or useful on aes_sbox and\naes_inv_sbox, since the table prefetching is now done using a helper\nfunction that casts to volatile itself and also includes an optimization\nbarrier. Since it prevents some compiler optimizations, remove it.\n\nAcked-by: Ard Biesheuvel <ardb@kernel.org>\nSigned-off-by: Eric Biggers <ebiggers@kernel.org>\n---\n lib/crypto/aes.c | 10 +++-------\n 1 file changed, 3 insertions(+), 7 deletions(-)", "diff": "diff --git a/lib/crypto/aes.c b/lib/crypto/aes.c\nindex b7ab2d0c4e59..b73e19f1bb95 100644\n--- a/lib/crypto/aes.c\n+++ b/lib/crypto/aes.c\n@@ -9,15 +9,11 @@\n #include <linux/crypto.h>\n #include <linux/export.h>\n #include <linux/module.h>\n #include <linux/unaligned.h>\n \n-/*\n- * Emit the sbox as volatile const to prevent the compiler from doing\n- * constant folding on sbox references involving fixed indexes.\n- */\n-static volatile const u8 ____cacheline_aligned aes_sbox[] = {\n+static const u8 ____cacheline_aligned aes_sbox[] = {\n \t0x63, 0x7c, 0x77, 0x7b, 0xf2, 0x6b, 0x6f, 0xc5,\n \t0x30, 0x01, 0x67, 0x2b, 0xfe, 0xd7, 0xab, 0x76,\n \t0xca, 0x82, 0xc9, 0x7d, 0xfa, 0x59, 0x47, 0xf0,\n \t0xad, 0xd4, 0xa2, 0xaf, 0x9c, 0xa4, 0x72, 0xc0,\n \t0xb7, 0xfd, 0x93, 0x26, 0x36, 0x3f, 0xf7, 0xcc,\n@@ -48,11 +44,11 @@ static volatile const u8 ____cacheline_aligned aes_sbox[] = {\n \t0x9b, 0x1e, 0x87, 0xe9, 0xce, 0x55, 0x28, 0xdf,\n \t0x8c, 0xa1, 0x89, 0x0d, 0xbf, 0xe6, 0x42, 0x68,\n \t0x41, 0x99, 0x2d, 0x0f, 0xb0, 0x54, 0xbb, 0x16,\n };\n \n-static volatile const u8 ____cacheline_aligned aes_inv_sbox[] = {\n+static const u8 ____cacheline_aligned aes_inv_sbox[] = {\n \t0x52, 0x09, 0x6a, 0xd5, 0x30, 0x36, 0xa5, 0x38,\n \t0xbf, 0x40, 0xa3, 0x9e, 0x81, 0xf3, 0xd7, 0xfb,\n \t0x7c, 0xe3, 0x39, 0x82, 0x9b, 0x2f, 0xff, 0x87,\n \t0x34, 0x8e, 0x43, 0x44, 0xc4, 0xde, 0xe9, 0xcb,\n \t0x54, 0x7b, 0x94, 0x32, 0xa6, 0xc2, 0x23, 0x3d,\n@@ -428,11 +424,11 @@ static void __maybe_unused aes_decrypt_generic(const u32 inv_rndkeys[],\n \t\tw[1] = w1;\n \t\tw[2] = w2;\n \t\tw[3] = w3;\n \t} while (--n);\n \n-\taes_prefetch((const void *)aes_inv_sbox, sizeof(aes_inv_sbox));\n+\taes_prefetch(aes_inv_sbox, sizeof(aes_inv_sbox));\n \tput_unaligned_le32(declast_quarterround(w, 0, *rkp++), &out[0]);\n \tput_unaligned_le32(declast_quarterround(w, 1, *rkp++), &out[4]);\n \tput_unaligned_le32(declast_quarterround(w, 2, *rkp++), &out[8]);\n \tput_unaligned_le32(declast_quarterround(w, 3, *rkp++), &out[12]);\n }\n", "prefixes": [ "v2", "35/35" ] }