Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2183203/?format=api
{ "id": 2183203, "url": "http://patchwork.ozlabs.org/api/patches/2183203/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260112192035.10427-32-ebiggers@kernel.org/", "project": { "id": 2, "url": "http://patchwork.ozlabs.org/api/projects/2/?format=api", "name": "Linux PPC development", "link_name": "linuxppc-dev", "list_id": "linuxppc-dev.lists.ozlabs.org", "list_email": "linuxppc-dev@lists.ozlabs.org", "web_url": "https://github.com/linuxppc/wiki/wiki", "scm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git", "webscm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/", "list_archive_url_format": "https://lore.kernel.org/linuxppc-dev/{}/", "commit_url_format": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}" }, "msgid": "<20260112192035.10427-32-ebiggers@kernel.org>", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/20260112192035.10427-32-ebiggers@kernel.org/", "date": "2026-01-12T19:20:29", "name": "[v2,31/35] crypto: omap - Use new AES library API", "commit_ref": null, "pull_url": null, "state": "handled-elsewhere", "archived": false, "hash": "65e959d4c599a5935e03704ad76b06f385996ccf", "submitter": { "id": 74690, "url": "http://patchwork.ozlabs.org/api/people/74690/?format=api", "name": "Eric Biggers", "email": "ebiggers@kernel.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260112192035.10427-32-ebiggers@kernel.org/mbox/", "series": [ { "id": 488089, "url": "http://patchwork.ozlabs.org/api/series/488089/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=488089", "date": "2026-01-12T19:19:58", "name": "AES library improvements", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/488089/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2183203/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2183203/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linuxppc-dev+bounces-15569-incoming=patchwork.ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=m+iQkfre;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-15569-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)", "lists.ozlabs.org;\n arc=none smtp.remote-ip=172.234.252.31", "lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org", "lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=m+iQkfre;\n\tdkim-atps=neutral", "lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org\n (client-ip=172.234.252.31; helo=sea.source.kernel.org;\n envelope-from=ebiggers@kernel.org; receiver=lists.ozlabs.org)" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4dqj5K2F3Vz1xpY\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 13 Jan 2026 06:25:25 +1100 (AEDT)", "from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4dqj3D2kVJz30Vq;\n\tTue, 13 Jan 2026 06:23:36 +1100 (AEDT)", "from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4dqj3C30NTz30Tc\n\tfor <linuxppc-dev@lists.ozlabs.org>; Tue, 13 Jan 2026 06:23:35 +1100 (AEDT)", "from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n\tby sea.source.kernel.org (Postfix) with ESMTP id 2292344404;\n\tMon, 12 Jan 2026 19:23:35 +0000 (UTC)", "by smtp.kernel.org (Postfix) with ESMTPSA id 92D62C2BC9E;\n\tMon, 12 Jan 2026 19:23:34 +0000 (UTC)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1768245816;\n\tcv=none;\n b=ah9pcbNJWqiKSMulEOToYB8q9izcNRGs/NyZnRbKrhbb4puFbNJzbxucEFXri04ZPdfvSI41ir0w1Tmf2nfRUZsI9US18StFRYDC8T0ThFGrztIu0A4LhqhbX4Su7dVV5MNGPo9iwsNX/EKNBOeV5X1jI5guxuPcTnJ20elaVBWkMgqoDTihzRoitxueejHBag2ZEymA5PTbaQcfoObUFgxbMI5ppXbiGC3iILXqoXIz1zCq77Wf+j5MjDnvvDC65QO4+JIZ7LhwXzVaseSdAUfsT/OEhE98O3mlLRwQYzQoYSdyRhmU/adw3wzl4EJp/sfT/735mFU7kHjz/01J3g==", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1768245816; c=relaxed/relaxed;\n\tbh=DWUiS6AJQJZcAWVdakexnBMIfXhXehTznfwkYQW9Ms4=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=fL9TzjnzxbOpgoPrkAG1zXe49XX40vvyQUhZ8XsCsZkUy+1HUlEoI5Wo6dovEADepLdkw1CLJkvLirMHA2RVUS+hDa9CLGVT/LUaO+CRf5zQXPpXqWadmFLW9tWKTm0NVlc3KEfgOutI1kKlLZSjqwE4xHSUlunfett4Ovm/NRcsuv5eu0FoOXwD/yn9pFQsiHOcfty0ZrUdcZgJd1dS57k8+eptNmsciPbvSrHwXE6M3IBkqmKr0JFR6aDMixk+XPSF13EAM5wqILkJjih4COL4GXg3Xk+zQPDg5NU9M8Z3n0osFPdV/HOncAQtR4q37cRe3wEqqueQTlGVflOZgg==", "ARC-Authentication-Results": "i=1; lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org;\n dkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=m+iQkfre; dkim-atps=neutral;\n spf=pass (client-ip=172.234.252.31; helo=sea.source.kernel.org;\n envelope-from=ebiggers@kernel.org;\n receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1768245815;\n\tbh=o3zwy8vdt1uNhlRXa37yap+uRed8L836MSpoje1i5gA=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=m+iQkfrebqurkYNcMsEDhd2QqbiCtp7wnSgHoAica72oEzTDfUKkSMUWZXpuRb9em\n\t 1Do/8hqedeDta5gxo8MqlDW61v9x7Q7vZTzXp2TkY2U7zjXVxEQdDb5Tc0XzAX7VVU\n\t 9TKEdQm8jHgXrAALBCww1rQnpHL301XBCKXcpnpH8fVqyvtxN0AZzZ4xBw/eYgSrKk\n\t cV3ifLIvrwSzEZQPhWE6hzNHFva8oR20xdbCbycacxePJ6OtQUL7re5uWOMRmer5Mp\n\t aKzUopZrsfMlXGNoISdPApHFyM2o8Bm7RRE27u6Iu2eUcffx29++btLMVG3D96Ohac\n\t Y99nAkUMvYzgA==", "From": "Eric Biggers <ebiggers@kernel.org>", "To": "linux-crypto@vger.kernel.org", "Cc": "linux-kernel@vger.kernel.org,\n\tArd Biesheuvel <ardb@kernel.org>,\n\t\"Jason A . Donenfeld\" <Jason@zx2c4.com>,\n\tHerbert Xu <herbert@gondor.apana.org.au>,\n\tlinux-arm-kernel@lists.infradead.org,\n\tlinuxppc-dev@lists.ozlabs.org,\n\tlinux-riscv@lists.infradead.org,\n\tlinux-s390@vger.kernel.org,\n\tsparclinux@vger.kernel.org,\n\tx86@kernel.org,\n\tHolger Dengler <dengler@linux.ibm.com>,\n\tHarald Freudenberger <freude@linux.ibm.com>,\n\tEric Biggers <ebiggers@kernel.org>", "Subject": "[PATCH v2 31/35] crypto: omap - Use new AES library API", "Date": "Mon, 12 Jan 2026 11:20:29 -0800", "Message-ID": "<20260112192035.10427-32-ebiggers@kernel.org>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20260112192035.10427-1-ebiggers@kernel.org>", "References": "<20260112192035.10427-1-ebiggers@kernel.org>", "X-Mailing-List": "linuxppc-dev@lists.ozlabs.org", "List-Id": "<linuxppc-dev.lists.ozlabs.org>", "List-Help": "<mailto:linuxppc-dev+help@lists.ozlabs.org>", "List-Owner": "<mailto:linuxppc-dev+owner@lists.ozlabs.org>", "List-Post": "<mailto:linuxppc-dev@lists.ozlabs.org>", "List-Archive": "<https://lore.kernel.org/linuxppc-dev/>,\n <https://lists.ozlabs.org/pipermail/linuxppc-dev/>", "List-Subscribe": "<mailto:linuxppc-dev+subscribe@lists.ozlabs.org>,\n <mailto:linuxppc-dev+subscribe-digest@lists.ozlabs.org>,\n <mailto:linuxppc-dev+subscribe-nomail@lists.ozlabs.org>", "List-Unsubscribe": "<mailto:linuxppc-dev+unsubscribe@lists.ozlabs.org>", "Precedence": "list", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Spam-Status": "No, score=-0.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,\n\tDKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS\n\tautolearn=disabled version=4.0.1 OzLabs 8", "X-Spam-Checker-Version": "SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org" }, "content": "Switch from the old AES library functions (which use struct\ncrypto_aes_ctx) to the new ones (which use struct aes_enckey). This\neliminates the unnecessary computation and caching of the decryption\nround keys. The new AES en/decryption functions are also much faster\nand use AES instructions when supported by the CPU.\n\nNote that in addition to the change in the key preparation function and\nthe key struct type itself, the change in the type of the key struct\nresults in aes_encrypt() (which is temporarily a type-generic macro)\ncalling the new encryption function rather than the old one.\n\nAcked-by: Ard Biesheuvel <ardb@kernel.org>\nSigned-off-by: Eric Biggers <ebiggers@kernel.org>\n---\n drivers/crypto/omap-aes-gcm.c | 6 +++---\n drivers/crypto/omap-aes.h | 2 +-\n 2 files changed, 4 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/crypto/omap-aes-gcm.c b/drivers/crypto/omap-aes-gcm.c\nindex 1f4586509ca4..c652f9d0062f 100644\n--- a/drivers/crypto/omap-aes-gcm.c\n+++ b/drivers/crypto/omap-aes-gcm.c\n@@ -175,11 +175,11 @@ static int omap_aes_gcm_copy_buffers(struct omap_aes_dev *dd,\n \n static int do_encrypt_iv(struct aead_request *req, u32 *tag, u32 *iv)\n {\n \tstruct omap_aes_gcm_ctx *ctx = crypto_aead_ctx(crypto_aead_reqtfm(req));\n \n-\taes_encrypt(&ctx->actx, (u8 *)tag, (u8 *)iv);\n+\taes_encrypt(&ctx->akey, (u8 *)tag, (const u8 *)iv);\n \treturn 0;\n }\n \n void omap_aes_gcm_dma_out_callback(void *data)\n {\n@@ -312,11 +312,11 @@ int omap_aes_gcm_setkey(struct crypto_aead *tfm, const u8 *key,\n \t\t\tunsigned int keylen)\n {\n \tstruct omap_aes_gcm_ctx *ctx = crypto_aead_ctx(tfm);\n \tint ret;\n \n-\tret = aes_expandkey(&ctx->actx, key, keylen);\n+\tret = aes_prepareenckey(&ctx->akey, key, keylen);\n \tif (ret)\n \t\treturn ret;\n \n \tmemcpy(ctx->octx.key, key, keylen);\n \tctx->octx.keylen = keylen;\n@@ -332,11 +332,11 @@ int omap_aes_4106gcm_setkey(struct crypto_aead *tfm, const u8 *key,\n \n \tif (keylen < 4)\n \t\treturn -EINVAL;\n \tkeylen -= 4;\n \n-\tret = aes_expandkey(&ctx->actx, key, keylen);\n+\tret = aes_prepareenckey(&ctx->akey, key, keylen);\n \tif (ret)\n \t\treturn ret;\n \n \tmemcpy(ctx->octx.key, key, keylen);\n \tmemcpy(ctx->octx.nonce, key + keylen, 4);\ndiff --git a/drivers/crypto/omap-aes.h b/drivers/crypto/omap-aes.h\nindex 99c36a777e97..6aa70bde387a 100644\n--- a/drivers/crypto/omap-aes.h\n+++ b/drivers/crypto/omap-aes.h\n@@ -96,11 +96,11 @@ struct omap_aes_ctx {\n \tstruct crypto_skcipher\t*fallback;\n };\n \n struct omap_aes_gcm_ctx {\n \tstruct omap_aes_ctx\toctx;\n-\tstruct crypto_aes_ctx\tactx;\n+\tstruct aes_enckey\takey;\n };\n \n struct omap_aes_reqctx {\n \tstruct omap_aes_dev *dd;\n \tunsigned long mode;\n", "prefixes": [ "v2", "31/35" ] }