Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2183201/?format=api
{ "id": 2183201, "url": "http://patchwork.ozlabs.org/api/patches/2183201/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260112192035.10427-28-ebiggers@kernel.org/", "project": { "id": 2, "url": "http://patchwork.ozlabs.org/api/projects/2/?format=api", "name": "Linux PPC development", "link_name": "linuxppc-dev", "list_id": "linuxppc-dev.lists.ozlabs.org", "list_email": "linuxppc-dev@lists.ozlabs.org", "web_url": "https://github.com/linuxppc/wiki/wiki", "scm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git", "webscm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/", "list_archive_url_format": "https://lore.kernel.org/linuxppc-dev/{}/", "commit_url_format": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}" }, "msgid": "<20260112192035.10427-28-ebiggers@kernel.org>", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/20260112192035.10427-28-ebiggers@kernel.org/", "date": "2026-01-12T19:20:25", "name": "[v2,27/35] crypto: chelsio - Use new AES library API", "commit_ref": null, "pull_url": null, "state": "handled-elsewhere", "archived": false, "hash": "bcd009757a13493af9090f99bc06e7a53d3ae861", "submitter": { "id": 74690, "url": "http://patchwork.ozlabs.org/api/people/74690/?format=api", "name": "Eric Biggers", "email": "ebiggers@kernel.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260112192035.10427-28-ebiggers@kernel.org/mbox/", "series": [ { "id": 488089, "url": "http://patchwork.ozlabs.org/api/series/488089/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=488089", "date": "2026-01-12T19:19:58", "name": "AES library improvements", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/488089/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2183201/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2183201/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linuxppc-dev+bounces-15567-incoming=patchwork.ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=PymYATdt;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-15567-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)", "lists.ozlabs.org;\n arc=none smtp.remote-ip=172.234.252.31", "lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org", "lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=PymYATdt;\n\tdkim-atps=neutral", "lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org\n (client-ip=172.234.252.31; helo=sea.source.kernel.org;\n envelope-from=ebiggers@kernel.org; receiver=lists.ozlabs.org)" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4dqj5314Kwz1xqD\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 13 Jan 2026 06:25:11 +1100 (AEDT)", "from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4dqj3C1LKgz30RN;\n\tTue, 13 Jan 2026 06:23:35 +1100 (AEDT)", "from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4dqj3B3SnWz30Ff\n\tfor <linuxppc-dev@lists.ozlabs.org>; Tue, 13 Jan 2026 06:23:34 +1100 (AEDT)", "from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n\tby sea.source.kernel.org (Postfix) with ESMTP id ED3F84438E;\n\tMon, 12 Jan 2026 19:23:32 +0000 (UTC)", "by smtp.kernel.org (Postfix) with ESMTPSA id 6BE59C19425;\n\tMon, 12 Jan 2026 19:23:32 +0000 (UTC)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1768245815;\n\tcv=none;\n b=EktVG+hFVzJbDCU8oyS40dhFG1X54BVYZkTvsE/ErbeW2QqYUTVzsP7LOiv7+zPrCSUhpveuxLhIg5DstYqVsh6Js+kPg7KVkEqCpIytrr1j5xvX53z2c2o6mgbzWCGQAsWB+OlOn6Q0PXWmei90VpuLderzl3X6tKhZ6Rd+YMZAPzuA1OgYVkOw/ueiGnwy2Ra8mzGElps/kweMuAD0j/H3a5A84c9i5MxU0QueF0eDcOpYp6GNIpKy4z8LFP+ELSV4SZB2tNM8fS/02vmFtBYiJph2yWDsdPyxBMZaZ3t0KdPM62IIg0VkTUUDHBTpmDSYgQsMveItVxp663tPRg==", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1768245815; c=relaxed/relaxed;\n\tbh=KIl5K2qYYK8RvfpjTbcuRVSN10jgiRWA5zJEwMngV24=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=JYxN5H2cLBKTx6u2WmVGrMmGwxF0uhKSaYAGhNctXBmZXtEm562IM6XGr30fAuxuuzLkvR6pvHL6eqeTn9yPl8UoZGm1OSqRLejdEKI7vkiPZEO9Tn1m0GQ+QifUyH4KrmRSO0hR8EFw6C3avy2qdhOiPfwbDz2oHwyn7TneHRRLbRHm1Rx+TGYVkeeajK/1IVGmPPHBzbPglKW65w1xhdKMGHDMKuJnh8/qrwiUWEUOg5zqwwktI5rpkE8Hb1ortMSFkpNSc3idFkOGZ+l0rAYDXfimMfnakKOdzU5qHoORConpxOY18wLopBUnATSA5ukXrrPtqnwedoJlPW9Ohw==", "ARC-Authentication-Results": "i=1; lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org;\n dkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=PymYATdt; dkim-atps=neutral;\n spf=pass (client-ip=172.234.252.31; helo=sea.source.kernel.org;\n envelope-from=ebiggers@kernel.org;\n receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1768245812;\n\tbh=7I4DcEvD7P+NyOF/LOh0qFaXJ6PJTspoaqEhJ+gX51o=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=PymYATdtVCGHtK+IbBx3OFqORWyLECLJGtun3Jj0HzhwQUnp5PEQ2Z9S9x88kkdko\n\t jUXgwbgKhfLYl9+rn22YpJ6nMXJhRWGUZMMOnLkD1ttB7pCshIL8f6DatUASbcIJPh\n\t w3dt6U3TeqjuUwc+5wzfDRo2vDDVv1aQI42Oz6rzi6v2VG4qwgWSOEOiyhxKhUsghP\n\t qepcFLhDk7/7wRQCfEOZKxibmYmQeA/7sqB6KT5TTszT3MkOnTULUKSQI5UqSvt8mP\n\t juZKyxZVaIqSygbpdRTz8OnZqX0J+Gxb55kqte5mEeQyVUsERKFlNqc/04wqru1f7+\n\t pC3yvHkPsxIVQ==", "From": "Eric Biggers <ebiggers@kernel.org>", "To": "linux-crypto@vger.kernel.org", "Cc": "linux-kernel@vger.kernel.org,\n\tArd Biesheuvel <ardb@kernel.org>,\n\t\"Jason A . Donenfeld\" <Jason@zx2c4.com>,\n\tHerbert Xu <herbert@gondor.apana.org.au>,\n\tlinux-arm-kernel@lists.infradead.org,\n\tlinuxppc-dev@lists.ozlabs.org,\n\tlinux-riscv@lists.infradead.org,\n\tlinux-s390@vger.kernel.org,\n\tsparclinux@vger.kernel.org,\n\tx86@kernel.org,\n\tHolger Dengler <dengler@linux.ibm.com>,\n\tHarald Freudenberger <freude@linux.ibm.com>,\n\tEric Biggers <ebiggers@kernel.org>", "Subject": "[PATCH v2 27/35] crypto: chelsio - Use new AES library API", "Date": "Mon, 12 Jan 2026 11:20:25 -0800", "Message-ID": "<20260112192035.10427-28-ebiggers@kernel.org>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20260112192035.10427-1-ebiggers@kernel.org>", "References": "<20260112192035.10427-1-ebiggers@kernel.org>", "X-Mailing-List": "linuxppc-dev@lists.ozlabs.org", "List-Id": "<linuxppc-dev.lists.ozlabs.org>", "List-Help": "<mailto:linuxppc-dev+help@lists.ozlabs.org>", "List-Owner": "<mailto:linuxppc-dev+owner@lists.ozlabs.org>", "List-Post": "<mailto:linuxppc-dev@lists.ozlabs.org>", "List-Archive": "<https://lore.kernel.org/linuxppc-dev/>,\n <https://lists.ozlabs.org/pipermail/linuxppc-dev/>", "List-Subscribe": "<mailto:linuxppc-dev+subscribe@lists.ozlabs.org>,\n <mailto:linuxppc-dev+subscribe-digest@lists.ozlabs.org>,\n <mailto:linuxppc-dev+subscribe-nomail@lists.ozlabs.org>", "List-Unsubscribe": "<mailto:linuxppc-dev+unsubscribe@lists.ozlabs.org>", "Precedence": "list", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Spam-Status": "No, score=-0.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,\n\tDKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS\n\tautolearn=disabled version=4.0.1 OzLabs 8", "X-Spam-Checker-Version": "SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org" }, "content": "Switch from the old AES library functions (which use struct\ncrypto_aes_ctx) to the new ones (which use struct aes_key and struct\naes_enckey). In encryption-only use cases, this eliminates the\nunnecessary computation and caching of the decryption round keys. The\nnew AES en/decryption functions are also much faster and use AES\ninstructions when supported by the CPU.\n\nNote that in addition to the change in the key preparation function and\nthe key struct type itself, the change in the type of the key struct\nresults in aes_encrypt() (which is temporarily a type-generic macro)\ncalling the new encryption function rather than the old one. Likewise\nfor decryption.\n\nAcked-by: Ard Biesheuvel <ardb@kernel.org>\nSigned-off-by: Eric Biggers <ebiggers@kernel.org>\n---\n drivers/crypto/chelsio/chcr_algo.c | 10 +++++-----\n 1 file changed, 5 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/crypto/chelsio/chcr_algo.c b/drivers/crypto/chelsio/chcr_algo.c\nindex 22cbc343198a..6dec42282768 100644\n--- a/drivers/crypto/chelsio/chcr_algo.c\n+++ b/drivers/crypto/chelsio/chcr_algo.c\n@@ -1026,11 +1026,11 @@ static int chcr_update_tweak(struct skcipher_request *req, u8 *iv,\n \t\t\t u32 isfinal)\n {\n \tstruct crypto_skcipher *tfm = crypto_skcipher_reqtfm(req);\n \tstruct ablk_ctx *ablkctx = ABLK_CTX(c_ctx(tfm));\n \tstruct chcr_skcipher_req_ctx *reqctx = skcipher_request_ctx(req);\n-\tstruct crypto_aes_ctx aes;\n+\tstruct aes_key aes;\n \tint ret, i;\n \tu8 *key;\n \tunsigned int keylen;\n \tint round = reqctx->last_req_len / AES_BLOCK_SIZE;\n \tint round8 = round / 8;\n@@ -1042,13 +1042,13 @@ static int chcr_update_tweak(struct skcipher_request *req, u8 *iv,\n \t/* For a 192 bit key remove the padded zeroes which was\n \t * added in chcr_xts_setkey\n \t */\n \tif (KEY_CONTEXT_CK_SIZE_G(ntohl(ablkctx->key_ctx_hdr))\n \t\t\t== CHCR_KEYCTX_CIPHER_KEY_SIZE_192)\n-\t\tret = aes_expandkey(&aes, key, keylen - 8);\n+\t\tret = aes_preparekey(&aes, key, keylen - 8);\n \telse\n-\t\tret = aes_expandkey(&aes, key, keylen);\n+\t\tret = aes_preparekey(&aes, key, keylen);\n \tif (ret)\n \t\treturn ret;\n \taes_encrypt(&aes, iv, iv);\n \tfor (i = 0; i < round8; i++)\n \t\tgf128mul_x8_ble((le128 *)iv, (le128 *)iv);\n@@ -3404,11 +3404,11 @@ static int chcr_gcm_setkey(struct crypto_aead *aead, const u8 *key,\n {\n \tstruct chcr_aead_ctx *aeadctx = AEAD_CTX(a_ctx(aead));\n \tstruct chcr_gcm_ctx *gctx = GCM_CTX(aeadctx);\n \tunsigned int ck_size;\n \tint ret = 0, key_ctx_size = 0;\n-\tstruct crypto_aes_ctx aes;\n+\tstruct aes_enckey aes;\n \n \taeadctx->enckey_len = 0;\n \tcrypto_aead_clear_flags(aeadctx->sw_cipher, CRYPTO_TFM_REQ_MASK);\n \tcrypto_aead_set_flags(aeadctx->sw_cipher, crypto_aead_get_flags(aead)\n \t\t\t & CRYPTO_TFM_REQ_MASK);\n@@ -3442,11 +3442,11 @@ static int chcr_gcm_setkey(struct crypto_aead *aead, const u8 *key,\n \t\t\t\t\t\t0, 0,\n \t\t\t\t\t\tkey_ctx_size >> 4);\n \t/* Calculate the H = CIPH(K, 0 repeated 16 times).\n \t * It will go in key context\n \t */\n-\tret = aes_expandkey(&aes, key, keylen);\n+\tret = aes_prepareenckey(&aes, key, keylen);\n \tif (ret) {\n \t\taeadctx->enckey_len = 0;\n \t\tgoto out;\n \t}\n \tmemset(gctx->ghash_h, 0, AEAD_H_SIZE);\n", "prefixes": [ "v2", "27/35" ] }