Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2183197/?format=api
{ "id": 2183197, "url": "http://patchwork.ozlabs.org/api/patches/2183197/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260112192035.10427-24-ebiggers@kernel.org/", "project": { "id": 2, "url": "http://patchwork.ozlabs.org/api/projects/2/?format=api", "name": "Linux PPC development", "link_name": "linuxppc-dev", "list_id": "linuxppc-dev.lists.ozlabs.org", "list_email": "linuxppc-dev@lists.ozlabs.org", "web_url": "https://github.com/linuxppc/wiki/wiki", "scm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git", "webscm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/", "list_archive_url_format": "https://lore.kernel.org/linuxppc-dev/{}/", "commit_url_format": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}" }, "msgid": "<20260112192035.10427-24-ebiggers@kernel.org>", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/20260112192035.10427-24-ebiggers@kernel.org/", "date": "2026-01-12T19:20:21", "name": "[v2,23/35] crypto: arm/ghash - Use new AES library API", "commit_ref": null, "pull_url": null, "state": "handled-elsewhere", "archived": false, "hash": "d865d108101ac23cb4ddd57ad6fa1dc7d3e795ef", "submitter": { "id": 74690, "url": "http://patchwork.ozlabs.org/api/people/74690/?format=api", "name": "Eric Biggers", "email": "ebiggers@kernel.org" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260112192035.10427-24-ebiggers@kernel.org/mbox/", "series": [ { "id": 488089, "url": "http://patchwork.ozlabs.org/api/series/488089/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=488089", "date": "2026-01-12T19:19:58", "name": "AES library improvements", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/488089/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2183197/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2183197/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "\n <linuxppc-dev+bounces-15565-incoming=patchwork.ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "linuxppc-dev@lists.ozlabs.org" ], "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=qJkYL4tl;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-15565-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)", "lists.ozlabs.org;\n arc=none smtp.remote-ip=172.105.4.254", "lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org", "lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=qJkYL4tl;\n\tdkim-atps=neutral", "lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org\n (client-ip=172.105.4.254; helo=tor.source.kernel.org;\n envelope-from=ebiggers@kernel.org; receiver=lists.ozlabs.org)" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4dqj4f3v9Wz1xqD\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 13 Jan 2026 06:24:50 +1100 (AEDT)", "from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4dqj394Jqgz2ywy;\n\tTue, 13 Jan 2026 06:23:33 +1100 (AEDT)", "from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4dqj3872wLz2yvv\n\tfor <linuxppc-dev@lists.ozlabs.org>; Tue, 13 Jan 2026 06:23:32 +1100 (AEDT)", "from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n\tby tor.source.kernel.org (Postfix) with ESMTP id DAB926011F;\n\tMon, 12 Jan 2026 19:23:30 +0000 (UTC)", "by smtp.kernel.org (Postfix) with ESMTPSA id 2C5B2C2BC87;\n\tMon, 12 Jan 2026 19:23:30 +0000 (UTC)" ], "ARC-Seal": "i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1768245813;\n\tcv=none;\n b=Em9JYIuzLE/pHT6XpVTCGxBAwJUNq/tSDbMNa23LpcAXwRR5OzP7AyyxrEkoc6rRmakT4MKNOGvg6C1q0vOE8aqWz92If7iKnaEJvsen1H41etebs2EELdYGHxkhIw9qrgB1t5S7bCbED0B5nI6Y6XSfSRI3fSr/1tH5MMxCcSNs2TDBbECIjA3So9/jeLLrl0hVB2pb7Vbh5dP1kvkaGqPTRx1ohNdeoE2N8ORWm/XwW3JTTwM6eQiwrg1pHHb7xQLdaRpgv7OX+LeVYg0KNu+HgSUUv4vg0e/zKkvRjWt8sT3mK4b+DwC4BfjiHvg8OfIAfhSpSOAPsiyp/plBUA==", "ARC-Message-Signature": "i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1768245813; c=relaxed/relaxed;\n\tbh=RR5ZFYsG/57JxgYnr/js/tTygCXYA/UUGjCJI42v3HE=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=ZOf1PgwVevezMESrv28/3QRjcMdLZi3eOB2QXaqbGcqhG4uLFjOjpngp1D7IOHKNMQ9UrGkpXTNwasev9CfU4A79e4t/okRMW894oDTDWsvCtSd3eJTFc6sBCxXqvazl6woi9VMxHqHYxLSaS85I2gkuxvtcEFpIsU9np2ewGn+n+cdWjY2UnweJ+ayj/V9qWTEDO6hA5qmNm8fuRk86HtqKB4n7d8bY1xPa0OKelPJv8KcjJOKOiiagHGBdZdvcIWpzpJa904OFHOSJy5EgfAuxFEoEY80q43jwIYvUmrpzadT0sS5M4XDkixtkU6F6V1cnxdqq4QvgQVV6oTjXIA==", "ARC-Authentication-Results": "i=1; lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org;\n dkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=qJkYL4tl; dkim-atps=neutral;\n spf=pass (client-ip=172.105.4.254; helo=tor.source.kernel.org;\n envelope-from=ebiggers@kernel.org;\n receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1768245810;\n\tbh=XxVEddn0GZ4fAoRx75wvjk3qCu0xXHueABJbpQv5kcU=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=qJkYL4tlLseMCpjL0U8f9dN8rYOWty3Ia3FUjnNcg7VcooPjVOuyBHwvFmikb5DmU\n\t pMtl8HaKrWDzqclqykHr8CmsyWul/bIEeKUlWjzKQ+F0jKg+XwG7e7VHsndtQvTEtZ\n\t 9f5XMP5x9WrcB8YwEFncIk56cJ8jSp4bcYHgrnHb2B6oz+d656hEfmVICWK40JTNU4\n\t oe7522xHypkdJVq/s9K3C/nzvsTCTsM8mL1DYY7ZaPSQwUx3MYpNbwaSLQRBo1XF2G\n\t XPJy92dYb9nUXQPduk/5+ffe80SJhQOL8169Svozyyh/NAO7RavagZZj7D1QMvjAhK\n\t UTLHZ9ckPvfGw==", "From": "Eric Biggers <ebiggers@kernel.org>", "To": "linux-crypto@vger.kernel.org", "Cc": "linux-kernel@vger.kernel.org,\n\tArd Biesheuvel <ardb@kernel.org>,\n\t\"Jason A . Donenfeld\" <Jason@zx2c4.com>,\n\tHerbert Xu <herbert@gondor.apana.org.au>,\n\tlinux-arm-kernel@lists.infradead.org,\n\tlinuxppc-dev@lists.ozlabs.org,\n\tlinux-riscv@lists.infradead.org,\n\tlinux-s390@vger.kernel.org,\n\tsparclinux@vger.kernel.org,\n\tx86@kernel.org,\n\tHolger Dengler <dengler@linux.ibm.com>,\n\tHarald Freudenberger <freude@linux.ibm.com>,\n\tEric Biggers <ebiggers@kernel.org>", "Subject": "[PATCH v2 23/35] crypto: arm/ghash - Use new AES library API", "Date": "Mon, 12 Jan 2026 11:20:21 -0800", "Message-ID": "<20260112192035.10427-24-ebiggers@kernel.org>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20260112192035.10427-1-ebiggers@kernel.org>", "References": "<20260112192035.10427-1-ebiggers@kernel.org>", "X-Mailing-List": "linuxppc-dev@lists.ozlabs.org", "List-Id": "<linuxppc-dev.lists.ozlabs.org>", "List-Help": "<mailto:linuxppc-dev+help@lists.ozlabs.org>", "List-Owner": "<mailto:linuxppc-dev+owner@lists.ozlabs.org>", "List-Post": "<mailto:linuxppc-dev@lists.ozlabs.org>", "List-Archive": "<https://lore.kernel.org/linuxppc-dev/>,\n <https://lists.ozlabs.org/pipermail/linuxppc-dev/>", "List-Subscribe": "<mailto:linuxppc-dev+subscribe@lists.ozlabs.org>,\n <mailto:linuxppc-dev+subscribe-digest@lists.ozlabs.org>,\n <mailto:linuxppc-dev+subscribe-nomail@lists.ozlabs.org>", "List-Unsubscribe": "<mailto:linuxppc-dev+unsubscribe@lists.ozlabs.org>", "Precedence": "list", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Spam-Status": "No, score=-0.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,\n\tDKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS\n\tautolearn=disabled version=4.0.1 OzLabs 8", "X-Spam-Checker-Version": "SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org" }, "content": "Switch from the old AES library functions (which use struct\ncrypto_aes_ctx) to the new ones (which use struct aes_enckey). This\neliminates the unnecessary computation and caching of the decryption\nround keys. The new AES en/decryption functions are also much faster\nand use AES instructions when supported by the CPU.\n\nNote that in addition to the change in the key preparation function and\nthe key struct type itself, the change in the type of the key struct\nresults in aes_encrypt() (which is temporarily a type-generic macro)\ncalling the new encryption function rather than the old one.\n\nAcked-by: Ard Biesheuvel <ardb@kernel.org>\nSigned-off-by: Eric Biggers <ebiggers@kernel.org>\n---\n arch/arm/crypto/ghash-ce-glue.c | 14 +++++++++-----\n 1 file changed, 9 insertions(+), 5 deletions(-)", "diff": "diff --git a/arch/arm/crypto/ghash-ce-glue.c b/arch/arm/crypto/ghash-ce-glue.c\nindex a52dcc8c1e33..454adcc62cc6 100644\n--- a/arch/arm/crypto/ghash-ce-glue.c\n+++ b/arch/arm/crypto/ghash-ce-glue.c\n@@ -202,24 +202,28 @@ int pmull_gcm_dec_final(int bytes, u64 dg[], char *tag,\n \n static int gcm_aes_setkey(struct crypto_aead *tfm, const u8 *inkey,\n \t\t\t unsigned int keylen)\n {\n \tstruct gcm_key *ctx = crypto_aead_ctx(tfm);\n-\tstruct crypto_aes_ctx aes_ctx;\n+\tstruct aes_enckey aes_key;\n \tbe128 h, k;\n \tint ret;\n \n-\tret = aes_expandkey(&aes_ctx, inkey, keylen);\n+\tret = aes_prepareenckey(&aes_key, inkey, keylen);\n \tif (ret)\n \t\treturn -EINVAL;\n \n-\taes_encrypt(&aes_ctx, (u8 *)&k, (u8[AES_BLOCK_SIZE]){});\n+\taes_encrypt(&aes_key, (u8 *)&k, (u8[AES_BLOCK_SIZE]){});\n \n-\tmemcpy(ctx->rk, aes_ctx.key_enc, sizeof(ctx->rk));\n+\t/*\n+\t * Note: this assumes that the arm implementation of the AES library\n+\t * stores the standard round keys in k.rndkeys.\n+\t */\n+\tmemcpy(ctx->rk, aes_key.k.rndkeys, sizeof(ctx->rk));\n \tctx->rounds = 6 + keylen / 4;\n \n-\tmemzero_explicit(&aes_ctx, sizeof(aes_ctx));\n+\tmemzero_explicit(&aes_key, sizeof(aes_key));\n \n \tghash_reflect(ctx->h[0], &k);\n \n \th = k;\n \tgf128mul_lle(&h, &k);\n", "prefixes": [ "v2", "23/35" ] }