Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2181851/?format=api
{ "id": 2181851, "url": "http://patchwork.ozlabs.org/api/patches/2181851/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260109085339.49839-1-marcin.szycik@linux.intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260109085339.49839-1-marcin.szycik@linux.intel.com>", "list_archive_url": null, "date": "2026-01-09T08:53:39", "name": "[net] ice: fix setting RSS VSI hash for E830", "commit_ref": null, "pull_url": null, "state": "under-review", "archived": false, "hash": "8bbb2c9ac62c518ceeb6a3f87fc447931fbd2ac8", "submitter": { "id": 82782, "url": "http://patchwork.ozlabs.org/api/people/82782/?format=api", "name": "Marcin Szycik", "email": "marcin.szycik@linux.intel.com" }, "delegate": { "id": 109701, "url": "http://patchwork.ozlabs.org/api/users/109701/?format=api", "username": "anguy11", "first_name": "Anthony", "last_name": "Nguyen", "email": "anthony.l.nguyen@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260109085339.49839-1-marcin.szycik@linux.intel.com/mbox/", "series": [ { "id": 487767, "url": "http://patchwork.ozlabs.org/api/series/487767/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=487767", "date": "2026-01-09T08:53:39", "name": "[net] ice: fix setting RSS VSI hash for E830", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/487767/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2181851/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2181851/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=UuKC4o+l;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::136; helo=smtp3.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4dncY24t1vz1xqD\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 09 Jan 2026 20:53:42 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id C02CC60E0E;\n\tFri, 9 Jan 2026 09:53:40 +0000 (UTC)", "from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id 3Crf1a5P8lhM; Fri, 9 Jan 2026 09:53:39 +0000 (UTC)", "from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 5FF6760D66;\n\tFri, 9 Jan 2026 09:53:39 +0000 (UTC)", "from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n by lists1.osuosl.org (Postfix) with ESMTP id 63FEB131\n for <intel-wired-lan@lists.osuosl.org>; Fri, 9 Jan 2026 09:53:37 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp2.osuosl.org (Postfix) with ESMTP id 4B541401EA\n for <intel-wired-lan@lists.osuosl.org>; Fri, 9 Jan 2026 09:53:37 +0000 (UTC)", "from smtp2.osuosl.org ([127.0.0.1])\n by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id iWz-LSYVYzbX for <intel-wired-lan@lists.osuosl.org>;\n Fri, 9 Jan 2026 09:53:36 +0000 (UTC)", "from mgamail.intel.com (mgamail.intel.com [198.175.65.13])\n by smtp2.osuosl.org (Postfix) with ESMTPS id 5BC404011A\n for <intel-wired-lan@lists.osuosl.org>; Fri, 9 Jan 2026 09:53:35 +0000 (UTC)", "from fmviesa002.fm.intel.com ([10.60.135.142])\n by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 09 Jan 2026 01:53:35 -0800", "from irvmail002.ir.intel.com ([10.43.11.120])\n by fmviesa002.fm.intel.com with ESMTP; 09 Jan 2026 01:53:33 -0800", "from gond.igk.intel.com (gond.igk.intel.com [10.123.220.52])\n by irvmail002.ir.intel.com (Postfix) with ESMTP id 86320278D4;\n Fri, 9 Jan 2026 09:53:32 +0000 (GMT)" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp3.osuosl.org 5FF6760D66", "OpenDKIM Filter v2.11.0 smtp2.osuosl.org 5BC404011A" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1767952419;\n\tbh=J0fV7Q6QwtvNo/R0F1+7rc9zpPvYCDlIAaoCm76Z1eA=;\n\th=From:To:Cc:Date:Subject:List-Id:List-Unsubscribe:List-Archive:\n\t List-Post:List-Help:List-Subscribe:From;\n\tb=UuKC4o+lm5+mm23yIYamlvu5atf8mya+/0Ag9NA1kQ62Q8zBaLf2DGJKiOtql43uu\n\t 7J4ToZE4FrvL4D7FlvNb6WLzZqZYbD+gwwqXmN+TInf01v7e1HJ1iuL4kBn/GvN/Qq\n\t BeBqs9Vw+9sBkY0mAblAFYDP5bma31A3igcknyjbCB1ZwXr2W5PJGLHV/VVrDxzLYc\n\t /i74LxuYgbp/brTcftZvO3ISUeDu3wncPaxzGIYsFEW+iWY6+KpZV24ghxdOSSResS\n\t Z9jwd+EyCSsqDH9+ZtmpnYu+w0WKhIE/KeIfkIROgUWEMvYXm3J0NfDki5b7vHHHFW\n\t c1Y9vJDctlKXw==", "Received-SPF": "Pass (mailfrom) identity=mailfrom; client-ip=198.175.65.13;\n helo=mgamail.intel.com; envelope-from=marcin.szycik@linux.intel.com;\n receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp2.osuosl.org 5BC404011A", "X-CSE-ConnectionGUID": [ "X+jghJy1THmV2O+zUYl/IA==", "wq7xPbJ/SriYC6E5Y/eZAA==" ], "X-CSE-MsgGUID": [ "EQGuKdYmQQ6PU47zxxc2tw==", "TAQXvhJ3QIOgUXKXYCknJw==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6800,10657,11665\"; a=\"80444232\"", "E=Sophos;i=\"6.21,212,1763452800\"; d=\"scan'208\";a=\"80444232\"", "E=Sophos;i=\"6.21,212,1763452800\"; d=\"scan'208\";a=\"226813256\"" ], "X-ExtLoop1": "1", "From": "Marcin Szycik <marcin.szycik@linux.intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Cc": "netdev@vger.kernel.org, Marcin Szycik <marcin.szycik@linux.intel.com>,\n Aleksandr Loktionov <aleksandr.loktionov@intel.com>,\n Przemek Kitszel <przemyslaw.kitszel@intel.com>", "Date": "Fri, 9 Jan 2026 09:53:39 +0100", "Message-ID": "<20260109085339.49839-1-marcin.szycik@linux.intel.com>", "X-Mailer": "git-send-email 2.49.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Original-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1767952417; x=1799488417;\n h=from:to:cc:subject:date:message-id:mime-version:\n content-transfer-encoding;\n bh=RB5uC0PLRMLIszW++ntMi95ZkbuVdAu3AgLwewqxGYU=;\n b=lft4QVq2hmY8wpe+pQ+A7IUdZDPDJt5fqbVyUSY+XNMdKnJIGScwWEsR\n EDVohp4ADzbOm7da4Gh4z8ljUCkupOSj8h2TgApThoTVH39qxrlS3Q5HT\n Km6fP7GQDo6X1iflkk9rvn6CcW+mTgHGk+kgr5O2Wwg4hQVDQb4Ek+3J+\n Vgd4NZ8pxuMqXo7YvHFbAz08wb0EHdc94KuxafQo6vlesJplDB2HTclYS\n kz7zDjXlVNb2kRjVD0HvDwJV+5uygyMxRsNulZ+SFGOZ0Izhms3M4DxOg\n 4XHQWeski8ItU86KtPo9NyQ2U1GB8z4tJXkr7mHb6Bcpd3FbiHfivlQdU\n g==;", "X-Mailman-Original-Authentication-Results": [ "smtp2.osuosl.org;\n dmarc=none (p=none dis=none)\n header.from=linux.intel.com", "smtp2.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=lft4QVq2" ], "Subject": "[Intel-wired-lan] [PATCH net] ice: fix setting RSS VSI hash for E830", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "ice_set_rss_hfunc() performs a VSI update, in which it sets hashing\nfunction, leaving other VSI options unchanged. However, ::q_opt_flags is\nmistakenly set to the value of another field, instead of its original\nvalue, probably due to a typo. What happens next is hardware-dependent:\n\nOn E810, only the first bit is meaningful (see\nICE_AQ_VSI_Q_OPT_PE_FLTR_EN) and can potentially end up in a different\nstate than before VSI update.\n\nOn E830, some of the remaining bits are not reserved. Setting them\nto some unrelated values can cause the firmware to reject the update\nbecause of invalid settings, or worse - succeed.\n\nReproducer:\n sudo ethtool -X $PF1 equal 8\n\nOutput in dmesg:\n Failed to configure RSS hash for VSI 6, error -5\n\nFixes: 352e9bf23813 (\"ice: enable symmetric-xor RSS for Toeplitz hash function\")\nReviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>\nReviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>\nSigned-off-by: Marcin Szycik <marcin.szycik@linux.intel.com>\n---\n drivers/net/ethernet/intel/ice/ice_main.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c\nindex cf8ba5a85384..08268f1a03da 100644\n--- a/drivers/net/ethernet/intel/ice/ice_main.c\n+++ b/drivers/net/ethernet/intel/ice/ice_main.c\n@@ -8038,7 +8038,7 @@ int ice_set_rss_hfunc(struct ice_vsi *vsi, u8 hfunc)\n \tctx->info.q_opt_rss |=\n \t\tFIELD_PREP(ICE_AQ_VSI_Q_OPT_RSS_HASH_M, hfunc);\n \tctx->info.q_opt_tc = vsi->info.q_opt_tc;\n-\tctx->info.q_opt_flags = vsi->info.q_opt_rss;\n+\tctx->info.q_opt_flags = vsi->info.q_opt_flags;\n \n \terr = ice_update_vsi(hw, vsi->idx, ctx, NULL);\n \tif (err) {\n", "prefixes": [ "net" ] }