Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2179748/?format=api
{ "id": 2179748, "url": "http://patchwork.ozlabs.org/api/patches/2179748/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260105064729.800308-1-boolli@google.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20260105064729.800308-1-boolli@google.com>", "list_archive_url": null, "date": "2026-01-05T06:47:28", "name": "[v2] idpf: increment completion queue next_to_clean in sw marker wait routine", "commit_ref": null, "pull_url": null, "state": "under-review", "archived": false, "hash": "d5ae7e4f1c42f795dbc881064da1224b3b39684a", "submitter": { "id": 92373, "url": "http://patchwork.ozlabs.org/api/people/92373/?format=api", "name": "Li Li", "email": "boolli@google.com" }, "delegate": { "id": 109701, "url": "http://patchwork.ozlabs.org/api/users/109701/?format=api", "username": "anguy11", "first_name": "Anthony", "last_name": "Nguyen", "email": "anthony.l.nguyen@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260105064729.800308-1-boolli@google.com/mbox/", "series": [ { "id": 487146, "url": "http://patchwork.ozlabs.org/api/series/487146/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=487146", "date": "2026-01-05T06:47:28", "name": "[v2] idpf: increment completion queue next_to_clean in sw marker wait routine", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/487146/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2179748/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2179748/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=bfhyea3k;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::136; helo=smtp3.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4dl4cK1ljNz1xqj\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 05 Jan 2026 17:47:44 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id CD8026087E;\n\tMon, 5 Jan 2026 06:47:42 +0000 (UTC)", "from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id I70mdvH_Wxc2; Mon, 5 Jan 2026 06:47:41 +0000 (UTC)", "from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 37AE160868;\n\tMon, 5 Jan 2026 06:47:41 +0000 (UTC)", "from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n by lists1.osuosl.org (Postfix) with ESMTP id E6F1B249\n for <intel-wired-lan@lists.osuosl.org>; Mon, 5 Jan 2026 06:47:39 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp1.osuosl.org (Postfix) with ESMTP id D971580C78\n for <intel-wired-lan@lists.osuosl.org>; Mon, 5 Jan 2026 06:47:39 +0000 (UTC)", "from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id wawXawhySPq2 for <intel-wired-lan@lists.osuosl.org>;\n Mon, 5 Jan 2026 06:47:39 +0000 (UTC)", "from mail-pg1-x54a.google.com (mail-pg1-x54a.google.com\n [IPv6:2607:f8b0:4864:20::54a])\n by smtp1.osuosl.org (Postfix) with ESMTPS id 314DF80C61\n for <intel-wired-lan@lists.osuosl.org>; Mon, 5 Jan 2026 06:47:39 +0000 (UTC)", "by mail-pg1-x54a.google.com with SMTP id\n 41be03b00d2f7-be8c77ecc63so21311871a12.2\n for <intel-wired-lan@lists.osuosl.org>; Sun, 04 Jan 2026 22:47:39 -0800 (PST)" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp3.osuosl.org 37AE160868", "OpenDKIM Filter v2.11.0 smtp1.osuosl.org 314DF80C61" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1767595661;\n\tbh=mjAQnRT+AxzqanaejE5B0HLUFAhnUu0WbGuSKAysFj0=;\n\th=Date:To:Cc:Subject:List-Id:List-Unsubscribe:List-Archive:\n\t List-Post:List-Help:List-Subscribe:From:Reply-To:From;\n\tb=bfhyea3kH/eXiUQEZVBdrKUj2LOrtClUVudR/kTBzY+RLHbimgHKITlbcc5WYp9Eu\n\t SPrRUOe4mLzZgOT5dMYd/hDw0hKpuFHiyFnxCnja+nYAFtANK0r4nC2uLamPdcI8v9\n\t 3uewXCtf1ZWGiyeDJT6R3aseTaSlifsgVUYYk0Zu7Y2YGeAbng2NkQsmmNyjrABAxL\n\t oBDRhrTXE93QOlVo3OwdtW2Tzi1zIPReQExTLTuKzRQmOYL9U3KKph3QGjVLh/1nlU\n\t h1A4oYHb+2lnnfef1fBl5qVu4Pg614BPlwtXkoOjNNcY2YbzZd2iH5r2OonvPqcYEh\n\t M/L4PNAFq/Iug==", "Received-SPF": "Pass (mailfrom) identity=mailfrom;\n client-ip=2607:f8b0:4864:20::54a; helo=mail-pg1-x54a.google.com;\n envelope-from=3il5baqykdwcivvsspnvvnsl.jvtpu0ls-3pylk-shuspz0z.vz1vzs.vyn@flex--boolli.bounces.google.com;\n receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp1.osuosl.org 314DF80C61", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1767595658; x=1768200458;\n h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state\n :from:to:cc:subject:date:message-id:reply-to;\n bh=mjAQnRT+AxzqanaejE5B0HLUFAhnUu0WbGuSKAysFj0=;\n b=NX1hYky+DNMT/sODL3UtliuWyRNWmNFP76ZzdiMp0qc7s6eQ+yrnuoqVQRvKCVSj+o\n k8uv6bQIg79oZSGNrH4Hh9BvIwOEEhYYIIRn0N4uCGMGj2Ak3DifqlV0I0d6pQ7gkHTw\n fqw0UR3zGUlNNhuWP6XUZNxO1rQzbtfh0AoURoBVa/+6ptNyf7K5wktOdSeWg9HGzdnM\n uQyIbGfF7dIZd2pj8MQOvdRm0YfN+LLNZt+P3zt94nI6wY+jQSxf+CQtNE7aq+zftUn0\n pWyhzB+L8GSYtMXURMO6VoEgFpSEVLMJzCeev1QHi+X73XqeqXGpv9vodavTqHSj1g7X\n BNKQ==", "X-Forwarded-Encrypted": "i=1;\n AJvYcCVxgec2trW1BkkVYpIcLh8k39Wym2c3X4TI8LumHj7tvt37PkFddwDLS/w1qFDjlEkvaee557RxgteUOE6EHZI=@lists.osuosl.org", "X-Gm-Message-State": "AOJu0YwhJeSe4ZEju5QrbX2wc+BEP8OjMpeZ7BWen3r+H2Abkx8FvZQX\n vGhdD47b12jWg5MDdLRkmkk0IzjyxquG0WMqFnIkFDkbOa/yloFSSW5PlyCGzfRD3oo9OedNZ4N\n kJfNJyQ==", "X-Google-Smtp-Source": "\n AGHT+IGecM3V1/67Gd3XVwwfB7BDjB6Zhr/zQO+BcKcQf4wP5oFodn945+Se44z7byhEdWZJPiihQV1BfV4=", "X-Received": "from dybnj41.prod.google.com\n ([2002:a05:7300:d0a9:b0:2ac:3545:743c])\n (user=boolli job=prod-delivery.src-stubby-dispatcher) by\n 2002:a05:693c:240b:b0:2a4:3593:c7d9\n with SMTP id 5a478bee46e88-2b05ec34963mr39421255eec.25.1767595658236; Sun, 04\n Jan 2026 22:47:38 -0800 (PST)", "Date": "Mon, 5 Jan 2026 06:47:28 +0000", "Mime-Version": "1.0", "X-Mailer": "git-send-email 2.52.0.351.gbe84eed79e-goog", "Message-ID": "<20260105064729.800308-1-boolli@google.com>", "To": "Tony Nguyen <anthony.l.nguyen@intel.com>,\n Przemek Kitszel <przemyslaw.kitszel@intel.com>,\n \"David S. Miller\" <davem@davemloft.net>,\n Jakub Kicinski <kuba@kernel.org>, Eric Dumazet <edumazet@google.com>,\n intel-wired-lan@lists.osuosl.org", "Cc": "netdev@vger.kernel.org, linux-kernel@vger.kernel.org,\n David Decotigny <decot@google.com>,\n Anjali Singhai <anjali.singhai@intel.com>,\n Sridhar Samudrala <sridhar.samudrala@intel.com>,\n Brian Vazquez <brianvv@google.com>,\n emil.s.tantilov@intel.com, Li Li <boolli@google.com>", "Content-Type": "text/plain; charset=\"UTF-8\"", "X-Mailman-Original-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=google.com; s=20230601; t=1767595658; x=1768200458; darn=lists.osuosl.org;\n h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject\n :date:message-id:reply-to;\n bh=mjAQnRT+AxzqanaejE5B0HLUFAhnUu0WbGuSKAysFj0=;\n b=Lg8YkR1DezjudSZ0QoISm4BU/acrP0wPN4jGBzjHycABWi+RTci2x/fQrGgDEBEmbs\n NTCnoV1pjhaaCrO1dULP0/bdEyaKLA1PbYgPzoKfUKXxM610RpVihFhMExdCDBKfba43\n pxoG0Ax2ZQuf9BJnRDlYZTOLGkwi4sLyZywMFW1b2+BMEcg/Bgquox7qCyWkQNk6qEBD\n JRDBLeGk66QverdPke75znM8TvqGc7kFIr4Fxlv1K9Fu241srx2+4iNqE1JUSj1IwHAg\n ro4fMbqhGNaEJYOt4aNG8F9XhfF8sG/0/4uuHrSk0W+WgPIZGz7b6xXEXXUDPQ9kcqbt\n u5UQ==", "X-Mailman-Original-Authentication-Results": [ "smtp1.osuosl.org;\n dmarc=pass (p=reject dis=none)\n header.from=google.com", "smtp1.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256\n header.s=20230601 header.b=Lg8YkR1D" ], "Subject": "[Intel-wired-lan] [PATCH v2] idpf: increment completion queue\n next_to_clean in sw marker wait routine", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "From": "Li Li via Intel-wired-lan <intel-wired-lan@osuosl.org>", "Reply-To": "Li Li <boolli@google.com>", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Currently, in idpf_wait_for_sw_marker_completion(), when an\nIDPF_TXD_COMPLT_SW_MARKER packet is found, the routine breaks out of\nthe for loop and does not increment the next_to_clean counter. This\ncauses the subsequent NAPI polls to run into the same\nIDPF_TXD_COMPLT_SW_MARKER packet again and print out the following:\n\n [ 23.261341] idpf 0000:05:00.0 eth1: Unknown TX completion type: 5\n\nInstead, we should increment next_to_clean regardless when an\nIDPF_TXD_COMPLT_SW_MARKER packet is found.\n\nTested: with the patch applied, we do not see the errors above from NAPI\npolls anymore.\n\nSigned-off-by: Li Li <boolli@google.com>\n---\nChanges in v2:\n - Initialize idpf_tx_queue *target to NULL to suppress the \"'target'\n uninitialized when 'if' statement is true warning\".\n\n drivers/net/ethernet/intel/idpf/idpf_txrx.c | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/idpf/idpf_txrx.c b/drivers/net/ethernet/intel/idpf/idpf_txrx.c\nindex 69bab7187e541..452d0a9e83a4f 100644\n--- a/drivers/net/ethernet/intel/idpf/idpf_txrx.c\n+++ b/drivers/net/ethernet/intel/idpf/idpf_txrx.c\n@@ -2326,7 +2326,7 @@ void idpf_wait_for_sw_marker_completion(const struct idpf_tx_queue *txq)\n \n \tdo {\n \t\tstruct idpf_splitq_4b_tx_compl_desc *tx_desc;\n-\t\tstruct idpf_tx_queue *target;\n+\t\tstruct idpf_tx_queue *target = NULL;\n \t\tu32 ctype_gen, id;\n \n \t\ttx_desc = flow ? &complq->comp[ntc].common :\n@@ -2346,14 +2346,14 @@ void idpf_wait_for_sw_marker_completion(const struct idpf_tx_queue *txq)\n \t\ttarget = complq->txq_grp->txqs[id];\n \n \t\tidpf_queue_clear(SW_MARKER, target);\n-\t\tif (target == txq)\n-\t\t\tbreak;\n \n next:\n \t\tif (unlikely(++ntc == complq->desc_count)) {\n \t\t\tntc = 0;\n \t\t\tgen_flag = !gen_flag;\n \t\t}\n+\t\tif (target == txq)\n+\t\t\tbreak;\n \t} while (time_before(jiffies, timeout));\n \n \tidpf_queue_assign(GEN_CHK, complq, gen_flag);\n", "prefixes": [ "v2" ] }