Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2177619/?format=api
{ "id": 2177619, "url": "http://patchwork.ozlabs.org/api/patches/2177619/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20251226211930.27565-25-farosas@suse.de/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20251226211930.27565-25-farosas@suse.de>", "list_archive_url": null, "date": "2025-12-26T21:19:26", "name": "[RFC,24/25] migration: Move URI parsing to channel.c", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "836f1178bdc3a534abc76628faf6d4a52146f5b4", "submitter": { "id": 85343, "url": "http://patchwork.ozlabs.org/api/people/85343/?format=api", "name": "Fabiano Rosas", "email": "farosas@suse.de" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20251226211930.27565-25-farosas@suse.de/mbox/", "series": [ { "id": 486505, "url": "http://patchwork.ozlabs.org/api/series/486505/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=486505", "date": "2025-12-26T21:19:04", "name": "migration: Cleanup early connection code", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/486505/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2177619/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2177619/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256\n header.s=susede2_rsa header.b=pKRETSC5;\n\tdkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=ZSMs43g+;\n\tdkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.a=rsa-sha256 header.s=susede2_rsa header.b=pKRETSC5;\n\tdkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=ZSMs43g+;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)", "smtp-out2.suse.de;\n\tnone" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4ddJTY6J10z1y3s\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 27 Dec 2025 08:21:53 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vZFFF-0003bJ-7O; Fri, 26 Dec 2025 16:21:09 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <farosas@suse.de>) id 1vZFFD-0003R6-Hl\n for qemu-devel@nongnu.org; Fri, 26 Dec 2025 16:21:07 -0500", "from smtp-out2.suse.de ([195.135.223.131])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <farosas@suse.de>) id 1vZFFB-0004LO-DZ\n for qemu-devel@nongnu.org; Fri, 26 Dec 2025 16:21:07 -0500", "from imap1.dmz-prg2.suse.org (unknown [10.150.64.97])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-out2.suse.de (Postfix) with ESMTPS id BC37B5BCE4;\n Fri, 26 Dec 2025 21:20:14 +0000 (UTC)", "from imap1.dmz-prg2.suse.org (localhost [127.0.0.1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id B46453EA63;\n Fri, 26 Dec 2025 21:20:13 +0000 (UTC)", "from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167])\n by imap1.dmz-prg2.suse.org with ESMTPSA id WGwAHQ38TmnwJwAAD6G6ig\n (envelope-from <farosas@suse.de>); Fri, 26 Dec 2025 21:20:13 +0000" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1766784014;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=nZYij0rOuEg38KzRK+gK1tvVNvAJC0Im/etk/9Ju80I=;\n b=pKRETSC5rEQTB1lsw1BfII6gIDoQY+JML/nyLfJmm+57/oUXG4dmjnxkN7if+sbjZlRUCb\n mFmRxkimqvPzdj4XyhCYcCA/E56mlmPc54nLFnOBNuFWOxBXS3qvwBAcGaQ78aVFQdWKnY\n Q8/RQlRynjHybLpUF2bZqjt7U0/v/Eo=", "v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1766784014;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=nZYij0rOuEg38KzRK+gK1tvVNvAJC0Im/etk/9Ju80I=;\n b=ZSMs43g+G0MD6x0iRE1mFOguKP4bGOCOAF/po9UcJrmzWFH4K+xmuDl+YzECdQyN1xU5wc\n Iqys7otIRG8SuWDA==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1766784014;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=nZYij0rOuEg38KzRK+gK1tvVNvAJC0Im/etk/9Ju80I=;\n b=pKRETSC5rEQTB1lsw1BfII6gIDoQY+JML/nyLfJmm+57/oUXG4dmjnxkN7if+sbjZlRUCb\n mFmRxkimqvPzdj4XyhCYcCA/E56mlmPc54nLFnOBNuFWOxBXS3qvwBAcGaQ78aVFQdWKnY\n Q8/RQlRynjHybLpUF2bZqjt7U0/v/Eo=", "v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1766784014;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=nZYij0rOuEg38KzRK+gK1tvVNvAJC0Im/etk/9Ju80I=;\n b=ZSMs43g+G0MD6x0iRE1mFOguKP4bGOCOAF/po9UcJrmzWFH4K+xmuDl+YzECdQyN1xU5wc\n Iqys7otIRG8SuWDA==" ], "From": "Fabiano Rosas <farosas@suse.de>", "To": "qemu-devel@nongnu.org", "Cc": "peterx@redhat.com", "Subject": "[RFC PATCH 24/25] migration: Move URI parsing to channel.c", "Date": "Fri, 26 Dec 2025 18:19:26 -0300", "Message-ID": "<20251226211930.27565-25-farosas@suse.de>", "X-Mailer": "git-send-email 2.51.0", "In-Reply-To": "<20251226211930.27565-1-farosas@suse.de>", "References": "<20251226211930.27565-1-farosas@suse.de>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Spam-Score": "-2.80", "X-Spamd-Result": "default: False [-2.80 / 50.00]; BAYES_HAM(-3.00)[100.00%];\n NEURAL_HAM_LONG(-1.00)[-1.000]; MID_CONTAINS_FROM(1.00)[];\n R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-0.987];\n MIME_GOOD(-0.10)[text/plain]; RCPT_COUNT_TWO(0.00)[2];\n FUZZY_RATELIMITED(0.00)[rspamd.com]; ARC_NA(0.00)[];\n RCVD_VIA_SMTP_AUTH(0.00)[];\n DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519];\n DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,suse.de:email,suse.de:mid];\n FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[];\n MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2];\n TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_NONE(0.00)[];\n RCVD_TLS_ALL(0.00)[]", "Received-SPF": "pass client-ip=195.135.223.131; envelope-from=farosas@suse.de;\n helo=smtp-out2.suse.de", "X-Spam_score_int": "-43", "X-Spam_score": "-4.4", "X-Spam_bar": "----", "X-Spam_report": "(-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "The migrate_uri_parse function is responsible for converting the URI\nstring into a MigrationChannel for consumption by the rest of the\ncode. Move it to channel.c and add a wrapper that calls both URI and\nchannels parsing.\n\nWhile here, add some words about the memory management of the\nMigrationChannel object, which is slightly different from\nmigrate_uri_parse() and migrate_channels_parse(). The former takes a\nstring and has to allocate a MigrationChannel, the latter takes a QAPI\nobject that is managed by the QAPI code.\n\nSigned-off-by: Fabiano Rosas <farosas@suse.de>\n---\n migration/channel.c | 97 +++++++++++++++++++++++++++++++++++++++++--\n migration/channel.h | 9 ++--\n migration/migration.c | 95 ++----------------------------------------\n 3 files changed, 101 insertions(+), 100 deletions(-)", "diff": "diff --git a/migration/channel.c b/migration/channel.c\nindex 8b43c3d983..d30e29c9b3 100644\n--- a/migration/channel.c\n+++ b/migration/channel.c\n@@ -40,6 +40,12 @@ bool migration_connect(MigrationAddress *addr, bool out, Error **errp)\n SocketAddress *saddr;\n ERRP_GUARD();\n \n+ /*\n+ * This is reached from a QMP command, the transport code below\n+ * must copy the relevant parts of 'addr' before this function\n+ * returns because the QAPI code will free it.\n+ */\n+\n switch (addr->transport) {\n case MIGRATION_ADDRESS_TYPE_SOCKET:\n saddr = &addr->u.socket;\n@@ -318,10 +324,10 @@ int migration_channel_read_peek(QIOChannel *ioc,\n return 0;\n }\n \n-bool migrate_channels_parse(MigrationChannelList *channels,\n- MigrationChannel **main_channelp,\n- MigrationChannel **cpr_channelp,\n- Error **errp)\n+static bool migrate_channels_parse(MigrationChannelList *channels,\n+ MigrationChannel **main_channelp,\n+ MigrationChannel **cpr_channelp,\n+ Error **errp)\n {\n MigrationChannel *channelv[MIGRATION_CHANNEL_TYPE__MAX] = { NULL };\n bool single_channel;\n@@ -353,6 +359,15 @@ bool migrate_channels_parse(MigrationChannelList *channels,\n }\n }\n \n+ /*\n+ * These don't technically need to be cloned because they come\n+ * from a QAPI object ('channels'). The top-level caller\n+ * (qmp_migrate) needs to copy the necessary information before\n+ * returning from the QMP command. Cloning here is just to keep\n+ * the interface consistent with migrate_uri_parse() that _does\n+ * not_ take a QAPI object and instead allocates and transfers\n+ * ownership of a MigrationChannel to qmp_migrate.\n+ */\n if (cpr_channelp) {\n *cpr_channelp = QAPI_CLONE(MigrationChannel,\n channelv[MIGRATION_CHANNEL_TYPE_CPR]);\n@@ -368,3 +383,77 @@ bool migrate_channels_parse(MigrationChannelList *channels,\n \n return true;\n }\n+\n+bool migrate_uri_parse(const char *uri, MigrationChannel **channel,\n+ Error **errp)\n+{\n+ g_autoptr(MigrationChannel) val = g_new0(MigrationChannel, 1);\n+ g_autoptr(MigrationAddress) addr = g_new0(MigrationAddress, 1);\n+ InetSocketAddress *isock = &addr->u.rdma;\n+ strList **tail = &addr->u.exec.args;\n+\n+ if (strstart(uri, \"exec:\", NULL)) {\n+ addr->transport = MIGRATION_ADDRESS_TYPE_EXEC;\n+#ifdef WIN32\n+ QAPI_LIST_APPEND(tail, g_strdup(exec_get_cmd_path()));\n+ QAPI_LIST_APPEND(tail, g_strdup(\"/c\"));\n+#else\n+ QAPI_LIST_APPEND(tail, g_strdup(\"/bin/sh\"));\n+ QAPI_LIST_APPEND(tail, g_strdup(\"-c\"));\n+#endif\n+ QAPI_LIST_APPEND(tail, g_strdup(uri + strlen(\"exec:\")));\n+ } else if (strstart(uri, \"rdma:\", NULL)) {\n+ if (inet_parse(isock, uri + strlen(\"rdma:\"), errp)) {\n+ qapi_free_InetSocketAddress(isock);\n+ return false;\n+ }\n+ addr->transport = MIGRATION_ADDRESS_TYPE_RDMA;\n+ } else if (strstart(uri, \"tcp:\", NULL) ||\n+ strstart(uri, \"unix:\", NULL) ||\n+ strstart(uri, \"vsock:\", NULL) ||\n+ strstart(uri, \"fd:\", NULL)) {\n+ addr->transport = MIGRATION_ADDRESS_TYPE_SOCKET;\n+ SocketAddress *saddr = socket_parse(uri, errp);\n+ if (!saddr) {\n+ return false;\n+ }\n+ addr->u.socket.type = saddr->type;\n+ addr->u.socket.u = saddr->u;\n+ /* Don't free the objects inside; their ownership moved to \"addr\" */\n+ g_free(saddr);\n+ } else if (strstart(uri, \"file:\", NULL)) {\n+ addr->transport = MIGRATION_ADDRESS_TYPE_FILE;\n+ addr->u.file.filename = g_strdup(uri + strlen(\"file:\"));\n+ if (file_parse_offset(addr->u.file.filename, &addr->u.file.offset,\n+ errp)) {\n+ return false;\n+ }\n+ } else {\n+ error_setg(errp, \"unknown migration protocol: %s\", uri);\n+ return false;\n+ }\n+\n+ val->channel_type = MIGRATION_CHANNEL_TYPE_MAIN;\n+ val->addr = g_steal_pointer(&addr);\n+ *channel = g_steal_pointer(&val);\n+ return true;\n+}\n+\n+bool migration_channel_parse_input(const char *uri,\n+ MigrationChannelList *channels,\n+ MigrationChannel **main_channelp,\n+ MigrationChannel **cpr_channelp,\n+ Error **errp)\n+{\n+ if (!uri == !channels) {\n+ error_setg(errp, \"need either 'uri' or 'channels' argument\");\n+ return false;\n+ }\n+\n+ if (channels) {\n+ return migrate_channels_parse(channels, main_channelp, cpr_channelp,\n+ errp);\n+ } else {\n+ return migrate_uri_parse(uri, main_channelp, errp);\n+ }\n+}\ndiff --git a/migration/channel.h b/migration/channel.h\nindex b3276550b7..3724b0493a 100644\n--- a/migration/channel.h\n+++ b/migration/channel.h\n@@ -52,8 +52,9 @@ static inline bool migration_connect_incoming(MigrationAddress *addr,\n return migration_connect(addr, false, errp);\n }\n \n-bool migrate_channels_parse(MigrationChannelList *channels,\n- MigrationChannel **main_channelp,\n- MigrationChannel **cpr_channelp,\n- Error **errp);\n+bool migration_channel_parse_input(const char *uri,\n+ MigrationChannelList *channels,\n+ MigrationChannel **main_channelp,\n+ MigrationChannel **cpr_channelp,\n+ Error **errp);\n #endif\ndiff --git a/migration/migration.c b/migration/migration.c\nindex 6064f1e5ea..15d8459a81 100644\n--- a/migration/migration.c\n+++ b/migration/migration.c\n@@ -15,7 +15,6 @@\n \n #include \"qemu/osdep.h\"\n #include \"qemu/ctype.h\"\n-#include \"qemu/cutils.h\"\n #include \"qemu/error-report.h\"\n #include \"qemu/main-loop.h\"\n #include \"migration/blocker.h\"\n@@ -659,61 +658,6 @@ bool migrate_is_uri(const char *uri)\n return *uri == ':';\n }\n \n-bool migrate_uri_parse(const char *uri, MigrationChannel **channel,\n- Error **errp)\n-{\n- g_autoptr(MigrationChannel) val = g_new0(MigrationChannel, 1);\n- g_autoptr(MigrationAddress) addr = g_new0(MigrationAddress, 1);\n- InetSocketAddress *isock = &addr->u.rdma;\n- strList **tail = &addr->u.exec.args;\n-\n- if (strstart(uri, \"exec:\", NULL)) {\n- addr->transport = MIGRATION_ADDRESS_TYPE_EXEC;\n-#ifdef WIN32\n- QAPI_LIST_APPEND(tail, g_strdup(exec_get_cmd_path()));\n- QAPI_LIST_APPEND(tail, g_strdup(\"/c\"));\n-#else\n- QAPI_LIST_APPEND(tail, g_strdup(\"/bin/sh\"));\n- QAPI_LIST_APPEND(tail, g_strdup(\"-c\"));\n-#endif\n- QAPI_LIST_APPEND(tail, g_strdup(uri + strlen(\"exec:\")));\n- } else if (strstart(uri, \"rdma:\", NULL)) {\n- if (inet_parse(isock, uri + strlen(\"rdma:\"), errp)) {\n- qapi_free_InetSocketAddress(isock);\n- return false;\n- }\n- addr->transport = MIGRATION_ADDRESS_TYPE_RDMA;\n- } else if (strstart(uri, \"tcp:\", NULL) ||\n- strstart(uri, \"unix:\", NULL) ||\n- strstart(uri, \"vsock:\", NULL) ||\n- strstart(uri, \"fd:\", NULL)) {\n- addr->transport = MIGRATION_ADDRESS_TYPE_SOCKET;\n- SocketAddress *saddr = socket_parse(uri, errp);\n- if (!saddr) {\n- return false;\n- }\n- addr->u.socket.type = saddr->type;\n- addr->u.socket.u = saddr->u;\n- /* Don't free the objects inside; their ownership moved to \"addr\" */\n- g_free(saddr);\n- } else if (strstart(uri, \"file:\", NULL)) {\n- addr->transport = MIGRATION_ADDRESS_TYPE_FILE;\n- addr->u.file.filename = g_strdup(uri + strlen(\"file:\"));\n- if (file_parse_offset(addr->u.file.filename, &addr->u.file.offset,\n- errp)) {\n- return false;\n- }\n- } else {\n- error_setg(errp, \"unknown migration protocol: %s\", uri);\n- return false;\n- }\n-\n- val->channel_type = MIGRATION_CHANNEL_TYPE_MAIN;\n- val->addr = g_steal_pointer(&addr);\n- *channel = g_steal_pointer(&val);\n- return true;\n-}\n-\n static bool\n migration_incoming_state_setup(MigrationIncomingState *mis, Error **errp)\n {\n@@ -744,27 +688,10 @@ static void qemu_setup_incoming_migration(const char *uri, bool has_channels,\n g_autoptr(MigrationChannel) main_ch = NULL;\n MigrationIncomingState *mis = migration_incoming_get_current();\n \n- /*\n- * Having preliminary checks for uri and channel\n- */\n- if (!uri == !channels) {\n- error_setg(errp, \"need either 'uri' or 'channels' argument\");\n+ if (!migration_channel_parse_input(uri, channels, &main_ch, NULL, errp)) {\n return;\n }\n \n- if (channels) {\n- if (!migrate_channels_parse(channels, &main_ch, NULL, errp)) {\n- return;\n- }\n- }\n-\n- if (uri) {\n- /* caller uses the old URI syntax */\n- if (!migrate_uri_parse(uri, &main_ch, errp)) {\n- return;\n- }\n- }\n-\n /* transport mechanism not suitable for migration? */\n if (!migration_transport_compatible(main_ch->addr, errp)) {\n return;\n@@ -2124,27 +2051,11 @@ void qmp_migrate(const char *uri, bool has_channels,\n g_autoptr(MigrationChannel) main_ch = NULL;\n g_autoptr(MigrationChannel) cpr_ch = NULL;\n \n- /*\n- * Having preliminary checks for uri and channel\n- */\n- if (!uri == !channels) {\n- error_setg(errp, \"need either 'uri' or 'channels' argument\");\n+ if (!migration_channel_parse_input(uri, channels, &main_ch, &cpr_ch,\n+ errp)) {\n return;\n }\n \n- if (channels) {\n- if (!migrate_channels_parse(channels, &main_ch, &cpr_ch, errp)) {\n- return;\n- }\n- }\n-\n- if (uri) {\n- /* caller uses the old URI syntax */\n- if (!migrate_uri_parse(uri, &main_ch, errp)) {\n- return;\n- }\n- }\n-\n /* transport mechanism not suitable for migration? */\n if (!migration_transport_compatible(main_ch->addr, errp)) {\n return;\n", "prefixes": [ "RFC", "24/25" ] }