Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2177615/?format=api
{ "id": 2177615, "url": "http://patchwork.ozlabs.org/api/patches/2177615/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20251226211930.27565-12-farosas@suse.de/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20251226211930.27565-12-farosas@suse.de>", "list_archive_url": null, "date": "2025-12-26T21:19:13", "name": "[RFC,11/25] migration: yank: Move register instance earlier", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "1bf37647d2f83605e5ac954ce0cf48c28f259bc0", "submitter": { "id": 85343, "url": "http://patchwork.ozlabs.org/api/people/85343/?format=api", "name": "Fabiano Rosas", "email": "farosas@suse.de" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20251226211930.27565-12-farosas@suse.de/mbox/", "series": [ { "id": 486505, "url": "http://patchwork.ozlabs.org/api/series/486505/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=486505", "date": "2025-12-26T21:19:04", "name": "migration: Cleanup early connection code", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/486505/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2177615/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2177615/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256\n header.s=susede2_rsa header.b=isaXeDl8;\n\tdkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=aCtRPeRF;\n\tdkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.a=rsa-sha256 header.s=susede2_rsa header.b=isaXeDl8;\n\tdkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=aCtRPeRF;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)", "smtp-out2.suse.de;\n dkim=pass header.d=suse.de header.s=susede2_rsa header.b=isaXeDl8;\n dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=aCtRPeRF" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4ddJTF6k2pz1y3s\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 27 Dec 2025 08:21:37 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vZFEY-0001WV-Ck; Fri, 26 Dec 2025 16:20:26 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <farosas@suse.de>) id 1vZFES-0001SB-KU\n for qemu-devel@nongnu.org; Fri, 26 Dec 2025 16:20:22 -0500", "from smtp-out2.suse.de ([2a07:de40:b251:101:10:150:64:2])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <farosas@suse.de>) id 1vZFEQ-00047g-Ih\n for qemu-devel@nongnu.org; Fri, 26 Dec 2025 16:20:20 -0500", "from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org\n [IPv6:2a07:de40:b281:104:10:150:64:97])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-out2.suse.de (Postfix) with ESMTPS id A2E8C5BCCD;\n Fri, 26 Dec 2025 21:19:51 +0000 (UTC)", "from imap1.dmz-prg2.suse.org (localhost [127.0.0.1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 9556C3EA63;\n Fri, 26 Dec 2025 21:19:50 +0000 (UTC)", "from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167])\n by imap1.dmz-prg2.suse.org with ESMTPSA id yJpBFfb7TmnwJwAAD6G6ig\n (envelope-from <farosas@suse.de>); Fri, 26 Dec 2025 21:19:50 +0000" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1766783991;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=7r6/NdIrXQWN/TYypsd1QV8a5Q9F/V/0J5HYKXLPdEY=;\n b=isaXeDl8I5B/sZIWnSIHhoINp6OSH4UAhRinAODbsQYnkURoWeFFua564bLXIOwQB3Sp/j\n 4aWoVMNmEatVO5sCr5xfP8O8EgW5MfpvQn4wdENg5b6+32s8xsogLKWhxNGTNUjD8ceEIk\n 9LnRo3uvHM5hWQGp8Uxv55jhYTyjNoo=", "v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1766783991;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=7r6/NdIrXQWN/TYypsd1QV8a5Q9F/V/0J5HYKXLPdEY=;\n b=aCtRPeRFnw8MubedDH0nLXTqHCkqd0u6AllxCDajHxPZ0kRm1jbLQ81tAi/4dtbMfP7kHr\n X4RYieYh9BUFbgAA==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1766783991;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=7r6/NdIrXQWN/TYypsd1QV8a5Q9F/V/0J5HYKXLPdEY=;\n b=isaXeDl8I5B/sZIWnSIHhoINp6OSH4UAhRinAODbsQYnkURoWeFFua564bLXIOwQB3Sp/j\n 4aWoVMNmEatVO5sCr5xfP8O8EgW5MfpvQn4wdENg5b6+32s8xsogLKWhxNGTNUjD8ceEIk\n 9LnRo3uvHM5hWQGp8Uxv55jhYTyjNoo=", "v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1766783991;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=7r6/NdIrXQWN/TYypsd1QV8a5Q9F/V/0J5HYKXLPdEY=;\n b=aCtRPeRFnw8MubedDH0nLXTqHCkqd0u6AllxCDajHxPZ0kRm1jbLQ81tAi/4dtbMfP7kHr\n X4RYieYh9BUFbgAA==" ], "From": "Fabiano Rosas <farosas@suse.de>", "To": "qemu-devel@nongnu.org", "Cc": "peterx@redhat.com", "Subject": "[RFC PATCH 11/25] migration: yank: Move register instance earlier", "Date": "Fri, 26 Dec 2025 18:19:13 -0300", "Message-ID": "<20251226211930.27565-12-farosas@suse.de>", "X-Mailer": "git-send-email 2.51.0", "In-Reply-To": "<20251226211930.27565-1-farosas@suse.de>", "References": "<20251226211930.27565-1-farosas@suse.de>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Spamd-Result": "default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[100.00%];\n MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000];\n R_MISSING_CHARSET(0.50)[];\n R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519];\n NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain];\n MX_GOOD(-0.01)[]; MIME_TRACE(0.00)[0:+];\n FUZZY_RATELIMITED(0.00)[rspamd.com];\n DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,suse.de:email,suse.de:dkim,suse.de:mid];\n RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[];\n RCPT_COUNT_TWO(0.00)[2];\n DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519];\n FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[];\n SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from];\n RCVD_TLS_ALL(0.00)[]; TO_DN_NONE(0.00)[];\n RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[];\n DKIM_TRACE(0.00)[suse.de:+]", "X-Rspamd-Action": "no action", "X-Rspamd-Server": "rspamd2.dmz-prg2.suse.org", "X-Rspamd-Queue-Id": "A2E8C5BCCD", "X-Spam-Score": "-3.01", "Received-SPF": "pass client-ip=2a07:de40:b251:101:10:150:64:2;\n envelope-from=farosas@suse.de; helo=smtp-out2.suse.de", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Move the register_instance call to migrate_prepare() so it can be\npaired with the unregister_instance at migration_cleanup(). Otherwise,\nthe cleanup cannot be run when cpr_state_save() fails because the\ninstance is registered only after it.\n\nWhen resuming from a paused postcopy migration, migrate_prepare()\nreturns early, but migration_cleanup() doesn't run, so the yank will\nremain paired.\n\nSigned-off-by: Fabiano Rosas <farosas@suse.de>\n---\n migration/migration.c | 26 ++++++++------------------\n 1 file changed, 8 insertions(+), 18 deletions(-)", "diff": "diff --git a/migration/migration.c b/migration/migration.c\nindex e1c00867ab..0f1644b276 100644\n--- a/migration/migration.c\n+++ b/migration/migration.c\n@@ -2181,11 +2181,12 @@ static bool migrate_prepare(MigrationState *s, bool resume, Error **errp)\n return false;\n }\n \n+ yank_register_instance(MIGRATION_YANK_INSTANCE, &error_abort);\n+\n return true;\n }\n \n-static void qmp_migrate_finish(MigrationAddress *addr, bool resume_requested,\n- Error **errp);\n+static void qmp_migrate_finish(MigrationAddress *addr, Error **errp);\n \n static void migrate_hup_add(MigrationState *s, QIOChannel *ioc, GSourceFunc cb,\n void *opaque)\n@@ -2210,7 +2211,7 @@ static gboolean qmp_migrate_finish_cb(QIOChannel *channel,\n {\n MigrationAddress *addr = opaque;\n \n- qmp_migrate_finish(addr, false, NULL);\n+ qmp_migrate_finish(addr, NULL);\n \n cpr_state_close();\n migrate_hup_delete(migrate_get_current());\n@@ -2222,7 +2223,6 @@ void qmp_migrate(const char *uri, bool has_channels,\n MigrationChannelList *channels, bool has_detach, bool detach,\n bool has_resume, bool resume, Error **errp)\n {\n- bool resume_requested;\n Error *local_err = NULL;\n MigrationState *s = migrate_get_current();\n g_autoptr(MigrationChannel) channel = NULL;\n@@ -2275,8 +2275,7 @@ void qmp_migrate(const char *uri, bool has_channels,\n return;\n }\n \n- resume_requested = has_resume && resume;\n- if (!migrate_prepare(s, resume_requested, errp)) {\n+ if (!migrate_prepare(s, has_resume && resume, errp)) {\n /* Error detected, put into errp */\n return;\n }\n@@ -2300,28 +2299,22 @@ void qmp_migrate(const char *uri, bool has_channels,\n QAPI_CLONE(MigrationAddress, addr));\n \n } else {\n- qmp_migrate_finish(addr, resume_requested, errp);\n+ qmp_migrate_finish(addr, errp);\n }\n \n out:\n if (local_err) {\n+ yank_unregister_instance(MIGRATION_YANK_INSTANCE);\n migration_connect_error_propagate(s, error_copy(local_err));\n error_propagate(errp, local_err);\n }\n }\n \n-static void qmp_migrate_finish(MigrationAddress *addr, bool resume_requested,\n- Error **errp)\n+static void qmp_migrate_finish(MigrationAddress *addr, Error **errp)\n {\n MigrationState *s = migrate_get_current();\n Error *local_err = NULL;\n \n- if (!resume_requested) {\n- if (!yank_register_instance(MIGRATION_YANK_INSTANCE, errp)) {\n- return;\n- }\n- }\n-\n if (addr->transport == MIGRATION_ADDRESS_TYPE_SOCKET) {\n SocketAddress *saddr = &addr->u.socket;\n if (saddr->type == SOCKET_ADDRESS_TYPE_INET ||\n@@ -2344,9 +2337,6 @@ static void qmp_migrate_finish(MigrationAddress *addr, bool resume_requested,\n }\n \n if (local_err) {\n- if (!resume_requested) {\n- yank_unregister_instance(MIGRATION_YANK_INSTANCE);\n- }\n migration_connect_error_propagate(s, error_copy(local_err));\n error_propagate(errp, local_err);\n return;\n", "prefixes": [ "RFC", "11/25" ] }