Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2177605/?format=api
{ "id": 2177605, "url": "http://patchwork.ozlabs.org/api/patches/2177605/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20251226211930.27565-11-farosas@suse.de/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20251226211930.27565-11-farosas@suse.de>", "list_archive_url": null, "date": "2025-12-26T21:19:12", "name": "[RFC,10/25] migration: Expand migration_connect_error_propagate to cover cancelling", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "c877266a75ac8cb381b95d0a2b568afa791b9d6c", "submitter": { "id": 85343, "url": "http://patchwork.ozlabs.org/api/people/85343/?format=api", "name": "Fabiano Rosas", "email": "farosas@suse.de" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20251226211930.27565-11-farosas@suse.de/mbox/", "series": [ { "id": 486505, "url": "http://patchwork.ozlabs.org/api/series/486505/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=486505", "date": "2025-12-26T21:19:04", "name": "migration: Cleanup early connection code", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/486505/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2177605/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2177605/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256\n header.s=susede2_rsa header.b=wPatnqmY;\n\tdkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=kZ8R3u0m;\n\tdkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.a=rsa-sha256 header.s=susede2_rsa header.b=wPatnqmY;\n\tdkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=kZ8R3u0m;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)", "smtp-out2.suse.de;\n dkim=pass header.d=suse.de header.s=susede2_rsa header.b=wPatnqmY;\n dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=kZ8R3u0m" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4ddJSS4psKz1y3s\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 27 Dec 2025 08:20:56 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vZFES-0001Ri-GV; Fri, 26 Dec 2025 16:20:22 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <farosas@suse.de>) id 1vZFEL-0001R7-Ko\n for qemu-devel@nongnu.org; Fri, 26 Dec 2025 16:20:14 -0500", "from smtp-out2.suse.de ([195.135.223.131])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <farosas@suse.de>) id 1vZFEK-00045c-4j\n for qemu-devel@nongnu.org; Fri, 26 Dec 2025 16:20:13 -0500", "from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org\n [IPv6:2a07:de40:b281:104:10:150:64:97])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-out2.suse.de (Postfix) with ESMTPS id 110225BCE4;\n Fri, 26 Dec 2025 21:19:50 +0000 (UTC)", "from imap1.dmz-prg2.suse.org (localhost [127.0.0.1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 071AD3EA65;\n Fri, 26 Dec 2025 21:19:48 +0000 (UTC)", "from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167])\n by imap1.dmz-prg2.suse.org with ESMTPSA id MAIOLvT7TmnwJwAAD6G6ig\n (envelope-from <farosas@suse.de>); Fri, 26 Dec 2025 21:19:48 +0000" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1766783990;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=r6feVrZedvuia2CRgWiWkzfS/88hHiX+QYNAlOrNJFI=;\n b=wPatnqmYU5wCBdvbTaAHQNPJDLryktjV1tYFLzgZoETG36uHh8lBKKfmPMWn3ZwbVJDT9P\n 9KMplYG6XZih68j4+v5EJQSxdi1c+IMBfNv2iJ5E5JwI5aMjxY8p+xn+fxZjr2X9oKnWCy\n 9YxTJlmgxTpMRC8ZgOqV6Tdcle+mhEk=", "v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1766783990;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=r6feVrZedvuia2CRgWiWkzfS/88hHiX+QYNAlOrNJFI=;\n b=kZ8R3u0mEdU35Dnaj7MPyrmJhJXGADghGUn0o6kha66jMinfbCM1JFVfuAEv+kywwwYv5E\n vk6wgrVEO7fE2jDw==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1766783990;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=r6feVrZedvuia2CRgWiWkzfS/88hHiX+QYNAlOrNJFI=;\n b=wPatnqmYU5wCBdvbTaAHQNPJDLryktjV1tYFLzgZoETG36uHh8lBKKfmPMWn3ZwbVJDT9P\n 9KMplYG6XZih68j4+v5EJQSxdi1c+IMBfNv2iJ5E5JwI5aMjxY8p+xn+fxZjr2X9oKnWCy\n 9YxTJlmgxTpMRC8ZgOqV6Tdcle+mhEk=", "v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1766783990;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=r6feVrZedvuia2CRgWiWkzfS/88hHiX+QYNAlOrNJFI=;\n b=kZ8R3u0mEdU35Dnaj7MPyrmJhJXGADghGUn0o6kha66jMinfbCM1JFVfuAEv+kywwwYv5E\n vk6wgrVEO7fE2jDw==" ], "From": "Fabiano Rosas <farosas@suse.de>", "To": "qemu-devel@nongnu.org", "Cc": "peterx@redhat.com", "Subject": "[RFC PATCH 10/25] migration: Expand migration_connect_error_propagate\n to cover cancelling", "Date": "Fri, 26 Dec 2025 18:19:12 -0300", "Message-ID": "<20251226211930.27565-11-farosas@suse.de>", "X-Mailer": "git-send-email 2.51.0", "In-Reply-To": "<20251226211930.27565-1-farosas@suse.de>", "References": "<20251226211930.27565-1-farosas@suse.de>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Spam-Score": "-3.01", "X-Rspamd-Queue-Id": "110225BCE4", "X-Spamd-Result": "default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[99.99%];\n NEURAL_HAM_LONG(-1.00)[-1.000]; MID_CONTAINS_FROM(1.00)[];\n R_MISSING_CHARSET(0.50)[];\n R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519];\n NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain];\n MX_GOOD(-0.01)[]; RCVD_VIA_SMTP_AUTH(0.00)[];\n FUZZY_RATELIMITED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[];\n ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; FROM_HAS_DN(0.00)[];\n TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_NONE(0.00)[];\n RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2];\n URIBL_BLOCKED(0.00)[imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo,suse.de:mid,suse.de:dkim,suse.de:email];\n DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo,suse.de:mid,suse.de:dkim,suse.de:email];\n DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519];\n RCPT_COUNT_TWO(0.00)[2];\n SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from];\n DKIM_TRACE(0.00)[suse.de:+]", "X-Rspamd-Server": "rspamd1.dmz-prg2.suse.org", "X-Rspamd-Action": "no action", "Received-SPF": "pass client-ip=195.135.223.131; envelope-from=farosas@suse.de;\n helo=smtp-out2.suse.de", "X-Spam_score_int": "-43", "X-Spam_score": "-4.4", "X-Spam_bar": "----", "X-Spam_report": "(-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "Cover the CANCELLING state in migration_connect_error_propagate() and\nuse it to funnel errors from migrate_prepare() until the end of\nmigration_connect().\n\n(add some line breaks for legibility)\n\nSigned-off-by: Fabiano Rosas <farosas@suse.de>\n---\n migration/migration.c | 24 +++++++++++++++---------\n 1 file changed, 15 insertions(+), 9 deletions(-)", "diff": "diff --git a/migration/migration.c b/migration/migration.c\nindex 83854d084a..e1c00867ab 100644\n--- a/migration/migration.c\n+++ b/migration/migration.c\n@@ -1575,18 +1575,25 @@ static void migrate_error_free(MigrationState *s)\n static void migration_connect_error_propagate(MigrationState *s, Error *error)\n {\n MigrationStatus current = s->state;\n- MigrationStatus next;\n-\n- assert(s->to_dst_file == NULL);\n+ MigrationStatus next = MIGRATION_STATUS_NONE;\n \n switch (current) {\n case MIGRATION_STATUS_SETUP:\n next = MIGRATION_STATUS_FAILED;\n break;\n+\n case MIGRATION_STATUS_POSTCOPY_RECOVER_SETUP:\n /* Never fail a postcopy migration; switch back to PAUSED instead */\n next = MIGRATION_STATUS_POSTCOPY_PAUSED;\n break;\n+\n+ case MIGRATION_STATUS_CANCELLING:\n+ /*\n+ * Don't move out of CANCELLING, the only valid transition is to\n+ * CANCELLED, at migration_cleanup().\n+ */\n+ break;\n+\n default:\n /*\n * This really shouldn't happen. Just be careful to not crash a VM\n@@ -1597,7 +1604,10 @@ static void migration_connect_error_propagate(MigrationState *s, Error *error)\n return;\n }\n \n- migrate_set_state(&s->state, current, next);\n+ if (next) {\n+ migrate_set_state(&s->state, current, next);\n+ }\n+\n migrate_error_propagate(s, error);\n }\n \n@@ -4107,11 +4117,7 @@ void migration_connect(MigrationState *s, Error *error_in)\n return;\n \n fail:\n- migrate_error_propagate(s, error_copy(local_err));\n- if (s->state != MIGRATION_STATUS_CANCELLING) {\n- migrate_set_state(&s->state, s->state, MIGRATION_STATUS_FAILED);\n- }\n- error_report_err(local_err);\n+ migration_connect_error_propagate(s, local_err);\n migration_cleanup(s);\n if (s->error) {\n error_report_err(error_copy(s->error));\n", "prefixes": [ "RFC", "10/25" ] }