Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2177604/?format=api
{ "id": 2177604, "url": "http://patchwork.ozlabs.org/api/patches/2177604/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20251226211930.27565-10-farosas@suse.de/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20251226211930.27565-10-farosas@suse.de>", "list_archive_url": null, "date": "2025-12-26T21:19:11", "name": "[RFC,09/25] migration: Move error reporting out of migration_cleanup", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "68804e6abca417caf73ae4d967a1db15169cf3dd", "submitter": { "id": 85343, "url": "http://patchwork.ozlabs.org/api/people/85343/?format=api", "name": "Fabiano Rosas", "email": "farosas@suse.de" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20251226211930.27565-10-farosas@suse.de/mbox/", "series": [ { "id": 486505, "url": "http://patchwork.ozlabs.org/api/series/486505/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=486505", "date": "2025-12-26T21:19:04", "name": "migration: Cleanup early connection code", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/486505/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2177604/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2177604/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256\n header.s=susede2_rsa header.b=mikkdq5R;\n\tdkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=1WyFcX3u;\n\tdkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.a=rsa-sha256 header.s=susede2_rsa header.b=TSFrzKig;\n\tdkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=6ea8dy1X;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)", "smtp-out2.suse.de;\n dkim=pass header.d=suse.de header.s=susede2_rsa header.b=TSFrzKig;\n dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=6ea8dy1X" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4ddJSR5Lk3z1y3s\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 27 Dec 2025 08:20:55 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vZFEI-0001Qd-9E; Fri, 26 Dec 2025 16:20:10 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <farosas@suse.de>) id 1vZFEF-0001Px-UA\n for qemu-devel@nongnu.org; Fri, 26 Dec 2025 16:20:07 -0500", "from smtp-out2.suse.de ([2a07:de40:b251:101:10:150:64:2])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <farosas@suse.de>) id 1vZFEE-00042F-Et\n for qemu-devel@nongnu.org; Fri, 26 Dec 2025 16:20:07 -0500", "from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org\n [IPv6:2a07:de40:b281:104:10:150:64:97])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-out2.suse.de (Postfix) with ESMTPS id 769705BCCB;\n Fri, 26 Dec 2025 21:19:48 +0000 (UTC)", "from imap1.dmz-prg2.suse.org (localhost [127.0.0.1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 6D28C3EA63;\n Fri, 26 Dec 2025 21:19:47 +0000 (UTC)", "from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167])\n by imap1.dmz-prg2.suse.org with ESMTPSA id kDGXC/P7TmnwJwAAD6G6ig\n (envelope-from <farosas@suse.de>); Fri, 26 Dec 2025 21:19:47 +0000" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1766783989;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=iSfg6fj1BGzF/CndAbhCOMUK0MIKIg2sHcFH7KCBgIg=;\n b=mikkdq5RQbd4TUNwoGwJK8kHqT/f+j5R9vS9qJsqlKsrgQAH+5QllpVljTrT851Y2+YOD6\n R7BNyXE2+MCTP9C4af4mNWoc1eFYiUDB0HXPO3QJu13ic/vzx4XVBjirF43VEDXdEl5naC\n Ca1nRjMiddFE7m6LAjAW+Q1Hz3U2wAo=", "v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1766783989;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=iSfg6fj1BGzF/CndAbhCOMUK0MIKIg2sHcFH7KCBgIg=;\n b=1WyFcX3uUGbDJtyI/i4qZpVuT5V77VjsTy/DpnWSfDY3yeJmdjgRGbdsHxPms6dN5y9up3\n 4G9XG/jit07MZSAA==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1766783988;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=iSfg6fj1BGzF/CndAbhCOMUK0MIKIg2sHcFH7KCBgIg=;\n b=TSFrzKigWhIDlcFoEHmoYM0ODOQU48s9t0j6U+J3sHC5y1yv+1QeNeMkZqIAy41/Z/VODq\n SCANF44MObSeTx+vhhrmm7jb/EhDPJep1ugANp0VUpoydgMRYCgFgSf72Hc+HaR/m+zW31\n B1sSAD7sV98mtk5FlOM8lmjsp/1aOZ8=", "v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1766783988;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=iSfg6fj1BGzF/CndAbhCOMUK0MIKIg2sHcFH7KCBgIg=;\n b=6ea8dy1XqjYZHRecAWEbzTxK0u69XPQYpxgWTkc7nYDbLib4pgIb+cU2ZE6GXN3LQyN428\n oB4DUz0crnqGSuDA==" ], "From": "Fabiano Rosas <farosas@suse.de>", "To": "qemu-devel@nongnu.org", "Cc": "peterx@redhat.com", "Subject": "[RFC PATCH 09/25] migration: Move error reporting out of\n migration_cleanup", "Date": "Fri, 26 Dec 2025 18:19:11 -0300", "Message-ID": "<20251226211930.27565-10-farosas@suse.de>", "X-Mailer": "git-send-email 2.51.0", "In-Reply-To": "<20251226211930.27565-1-farosas@suse.de>", "References": "<20251226211930.27565-1-farosas@suse.de>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Spamd-Result": "default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[99.99%];\n MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000];\n R_MISSING_CHARSET(0.50)[];\n R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519];\n NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain];\n MX_GOOD(-0.01)[]; MIME_TRACE(0.00)[0:+];\n FUZZY_RATELIMITED(0.00)[rspamd.com];\n DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email,suse.de:dkim,suse.de:mid,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns];\n RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[];\n RCPT_COUNT_TWO(0.00)[2];\n DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519];\n FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[];\n SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from];\n RCVD_TLS_ALL(0.00)[]; TO_DN_NONE(0.00)[];\n RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[];\n DKIM_TRACE(0.00)[suse.de:+]", "X-Rspamd-Action": "no action", "X-Rspamd-Server": "rspamd2.dmz-prg2.suse.org", "X-Rspamd-Queue-Id": "769705BCCB", "X-Spam-Score": "-3.01", "Received-SPF": "pass client-ip=2a07:de40:b251:101:10:150:64:2;\n envelope-from=farosas@suse.de; helo=smtp-out2.suse.de", "X-Spam_score_int": "-20", "X-Spam_score": "-2.1", "X-Spam_bar": "--", "X-Spam_report": "(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "In the next patches migration_cleanup() will be used in qmp_migrate(),\nwhich currently does not show an error message. Move the error\nreporting out of migration_cleanup() to avoid duplicated messages.\n\nSigned-off-by: Fabiano Rosas <farosas@suse.de>\n---\n migration/migration.c | 28 +++++++++++++---------------\n 1 file changed, 13 insertions(+), 15 deletions(-)", "diff": "diff --git a/migration/migration.c b/migration/migration.c\nindex a56f8fb05e..83854d084a 100644\n--- a/migration/migration.c\n+++ b/migration/migration.c\n@@ -1528,10 +1528,6 @@ static void migration_cleanup(MigrationState *s)\n MIGRATION_STATUS_CANCELLED);\n }\n \n- if (s->error) {\n- /* It is used on info migrate. We can't free it */\n- error_report_err(error_copy(s->error));\n- }\n type = migration_has_failed(s) ? MIG_EVENT_PRECOPY_FAILED :\n MIG_EVENT_PRECOPY_DONE;\n migration_call_notifiers(s, type, NULL);\n@@ -1540,7 +1536,12 @@ static void migration_cleanup(MigrationState *s)\n \n static void migration_cleanup_bh(void *opaque)\n {\n- migration_cleanup(opaque);\n+ MigrationState *s = opaque;\n+\n+ migration_cleanup(s);\n+ if (s->error) {\n+ error_report_err(error_copy(s->error));\n+ }\n }\n \n /*\n@@ -4026,18 +4027,12 @@ void migration_connect(MigrationState *s, Error *error_in)\n s->expected_downtime = migrate_downtime_limit();\n if (error_in) {\n migration_connect_error_propagate(s, error_in);\n- if (resume) {\n- /*\n- * Don't do cleanup for resume if channel is invalid, but only dump\n- * the error. We wait for another channel connect from the user.\n- * The error_report still gives HMP user a hint on what failed.\n- * It's normally done in migration_cleanup(), but call it here\n- * explicitly.\n- */\n- error_report_err(error_copy(s->error));\n- } else {\n+ if (!resume) {\n migration_cleanup(s);\n }\n+ if (s->error) {\n+ error_report_err(error_copy(s->error));\n+ }\n return;\n }\n \n@@ -4118,6 +4113,9 @@ fail:\n }\n error_report_err(local_err);\n migration_cleanup(s);\n+ if (s->error) {\n+ error_report_err(error_copy(s->error));\n+ }\n }\n \n static void migration_class_init(ObjectClass *klass, const void *data)\n", "prefixes": [ "RFC", "09/25" ] }