Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2177603/?format=api
{ "id": 2177603, "url": "http://patchwork.ozlabs.org/api/patches/2177603/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20251226211930.27565-7-farosas@suse.de/", "project": { "id": 14, "url": "http://patchwork.ozlabs.org/api/projects/14/?format=api", "name": "QEMU Development", "link_name": "qemu-devel", "list_id": "qemu-devel.nongnu.org", "list_email": "qemu-devel@nongnu.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20251226211930.27565-7-farosas@suse.de>", "list_archive_url": null, "date": "2025-12-26T21:19:08", "name": "[RFC,06/25] migration: Move postcopy_try_recover into migration_incoming_process", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "501071a33078d1e54459ccd03e34ed7c8cca1c6e", "submitter": { "id": 85343, "url": "http://patchwork.ozlabs.org/api/people/85343/?format=api", "name": "Fabiano Rosas", "email": "farosas@suse.de" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/qemu-devel/patch/20251226211930.27565-7-farosas@suse.de/mbox/", "series": [ { "id": 486505, "url": "http://patchwork.ozlabs.org/api/series/486505/?format=api", "web_url": "http://patchwork.ozlabs.org/project/qemu-devel/list/?series=486505", "date": "2025-12-26T21:19:04", "name": "migration: Cleanup early connection code", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/486505/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2177603/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2177603/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256\n header.s=susede2_rsa header.b=U+o5DfkN;\n\tdkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=j9Q4lugJ;\n\tdkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.a=rsa-sha256 header.s=susede2_rsa header.b=CU5QfUiY;\n\tdkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=gd601Ffq;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)", "smtp-out2.suse.de;\n dkim=pass header.d=suse.de header.s=susede2_rsa header.b=CU5QfUiY;\n dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=gd601Ffq" ], "Received": [ "from lists.gnu.org (lists.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4ddJSP2fJlz1y3s\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 27 Dec 2025 08:20:53 +1100 (AEDT)", "from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1vZFE8-0001JO-Ig; Fri, 26 Dec 2025 16:20:01 -0500", "from eggs.gnu.org ([2001:470:142:3::10])\n by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <farosas@suse.de>) id 1vZFE5-0001IP-1c\n for qemu-devel@nongnu.org; Fri, 26 Dec 2025 16:19:57 -0500", "from smtp-out2.suse.de ([195.135.223.131])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <farosas@suse.de>) id 1vZFE3-0003iP-Cl\n for qemu-devel@nongnu.org; Fri, 26 Dec 2025 16:19:56 -0500", "from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org\n [IPv6:2a07:de40:b281:104:10:150:64:97])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-out2.suse.de (Postfix) with ESMTPS id B89475BCC4;\n Fri, 26 Dec 2025 21:19:43 +0000 (UTC)", "from imap1.dmz-prg2.suse.org (localhost [127.0.0.1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id AD7163EA66;\n Fri, 26 Dec 2025 21:19:42 +0000 (UTC)", "from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167])\n by imap1.dmz-prg2.suse.org with ESMTPSA id 4JW1Gu77TmnwJwAAD6G6ig\n (envelope-from <farosas@suse.de>); Fri, 26 Dec 2025 21:19:42 +0000" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1766783985;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=BOcAqkAuhAmuQs4Pc4hz0xfBFtyvIAn0tePpQ1zREGg=;\n b=U+o5DfkNhi86okuiuv9CaefVBbXwb0UKmX4Fqs9EOVm5etpqbR0n5jdDoZXaraiAs5hPo/\n aJF+6Kl8JCfeLZJZU5xZXY2/QWC4mCKQXgDoIGeFHolT2wvVXGH33IFScQmj4dJkT1BXQB\n x2degfJfURhNOEDy9glNy4zIDpsV9Fg=", "v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1766783985;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=BOcAqkAuhAmuQs4Pc4hz0xfBFtyvIAn0tePpQ1zREGg=;\n b=j9Q4lugJpfLk0zP9KxvMQ/IhUAokGtdK2pvHP9JEO7kZn1wotoN+wpixEXVOX6XhOqotAf\n Py7BsuQTR556v+Cw==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1766783983;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=BOcAqkAuhAmuQs4Pc4hz0xfBFtyvIAn0tePpQ1zREGg=;\n b=CU5QfUiY5OxsAgyI6RQaM3gdS7gynqJrY4G63X9aZQ1175QIRgnZefserT0Rk96IxzEVT2\n 80uTDFv5otE5EnNUwBocXjhVrW0823ukyqjFZCUuaoVro0ZK3UoaiMDtP7n07G9L6OOGhD\n fcKUThWM/oPWNNtiYBMrSHoBRwzRA1k=", "v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1766783983;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=BOcAqkAuhAmuQs4Pc4hz0xfBFtyvIAn0tePpQ1zREGg=;\n b=gd601FfqPZN4fgqiRa6ebA2WXt4grBiyvZOzZk+6y/fgkrPwjPH+CbTU0cPO0LL/2iZX+e\n 6gKlkzPs5VcywVAQ==" ], "From": "Fabiano Rosas <farosas@suse.de>", "To": "qemu-devel@nongnu.org", "Cc": "peterx@redhat.com", "Subject": "[RFC PATCH 06/25] migration: Move postcopy_try_recover into\n migration_incoming_process", "Date": "Fri, 26 Dec 2025 18:19:08 -0300", "Message-ID": "<20251226211930.27565-7-farosas@suse.de>", "X-Mailer": "git-send-email 2.51.0", "In-Reply-To": "<20251226211930.27565-1-farosas@suse.de>", "References": "<20251226211930.27565-1-farosas@suse.de>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Spam-Score": "-3.01", "X-Rspamd-Queue-Id": "B89475BCC4", "X-Spamd-Result": "default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[99.99%];\n NEURAL_HAM_LONG(-1.00)[-1.000]; MID_CONTAINS_FROM(1.00)[];\n R_MISSING_CHARSET(0.50)[];\n R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519];\n NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain];\n MX_GOOD(-0.01)[]; RCVD_VIA_SMTP_AUTH(0.00)[];\n FUZZY_RATELIMITED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[];\n ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; FROM_HAS_DN(0.00)[];\n TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_NONE(0.00)[];\n RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2];\n URIBL_BLOCKED(0.00)[imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo,suse.de:mid,suse.de:dkim,suse.de:email];\n DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo,suse.de:mid,suse.de:dkim,suse.de:email];\n DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519];\n RCPT_COUNT_TWO(0.00)[2];\n SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from];\n DKIM_TRACE(0.00)[suse.de:+]", "X-Rspamd-Server": "rspamd1.dmz-prg2.suse.org", "X-Rspamd-Action": "no action", "Received-SPF": "pass client-ip=195.135.223.131; envelope-from=farosas@suse.de;\n helo=smtp-out2.suse.de", "X-Spam_score_int": "-43", "X-Spam_score": "-4.4", "X-Spam_bar": "----", "X-Spam_report": "(-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no", "X-Spam_action": "no action", "X-BeenThere": "qemu-devel@nongnu.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<qemu-devel.nongnu.org>", "List-Unsubscribe": "<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>", "List-Archive": "<https://lists.nongnu.org/archive/html/qemu-devel>", "List-Post": "<mailto:qemu-devel@nongnu.org>", "List-Help": "<mailto:qemu-devel-request@nongnu.org?subject=help>", "List-Subscribe": "<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>", "Errors-To": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org", "Sender": "qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org" }, "content": "The postcopy_try_recover() call doesn't need to be duplicated, move it\ninto migration_incoming_process().\n\nThis removes code from migration_fd_process_incoming() so it can be\nremoved in the near future.\n\n(the diff is a bit strange because migration_incoming_process() was\nmoved after postcopy_try_recover())\n\nSigned-off-by: Fabiano Rosas <farosas@suse.de>\n---\n migration/migration.c | 23 ++++++++++-------------\n 1 file changed, 10 insertions(+), 13 deletions(-)", "diff": "diff --git a/migration/migration.c b/migration/migration.c\nindex 974313944c..f2933f7789 100644\n--- a/migration/migration.c\n+++ b/migration/migration.c\n@@ -947,12 +947,6 @@ static void migration_incoming_setup(QEMUFile *f)\n qemu_file_set_blocking(f, false, &error_abort);\n }\n \n-void migration_incoming_process(void)\n-{\n- Coroutine *co = qemu_coroutine_create(process_incoming_migration_co, NULL);\n- qemu_coroutine_enter(co);\n-}\n-\n /* Returns true if recovered from a paused migration, otherwise false */\n static bool postcopy_try_recover(void)\n {\n@@ -986,12 +980,19 @@ static bool postcopy_try_recover(void)\n return false;\n }\n \n+void migration_incoming_process(void)\n+{\n+ if (postcopy_try_recover()) {\n+ return;\n+ }\n+\n+ Coroutine *co = qemu_coroutine_create(process_incoming_migration_co, NULL);\n+ qemu_coroutine_enter(co);\n+}\n+\n void migration_fd_process_incoming(QEMUFile *f)\n {\n migration_incoming_setup(f);\n- if (postcopy_try_recover()) {\n- return;\n- }\n migration_incoming_process();\n }\n \n@@ -1087,10 +1088,6 @@ void migration_ioc_process_incoming(QIOChannel *ioc, Error **errp)\n }\n \n if (migration_has_main_and_multifd_channels()) {\n- /* If it's a recovery, we're done */\n- if (postcopy_try_recover()) {\n- return;\n- }\n migration_incoming_process();\n }\n }\n", "prefixes": [ "RFC", "06/25" ] }