Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2175480/?format=api
{ "id": 2175480, "url": "http://patchwork.ozlabs.org/api/patches/2175480/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20251218094428.1762860-1-grzegorz.nitka@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20251218094428.1762860-1-grzegorz.nitka@intel.com>", "list_archive_url": null, "date": "2025-12-18T09:44:28", "name": "[iwl-net] ice: fix 'adjust' timer programming for E830 devices", "commit_ref": null, "pull_url": null, "state": "under-review", "archived": false, "hash": "cb3824182d8c0d1e3d41bf3507e1ac6e28471c72", "submitter": { "id": 82711, "url": "http://patchwork.ozlabs.org/api/people/82711/?format=api", "name": "Nitka, Grzegorz", "email": "grzegorz.nitka@intel.com" }, "delegate": { "id": 109701, "url": "http://patchwork.ozlabs.org/api/users/109701/?format=api", "username": "anguy11", "first_name": "Anthony", "last_name": "Nguyen", "email": "anthony.l.nguyen@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20251218094428.1762860-1-grzegorz.nitka@intel.com/mbox/", "series": [ { "id": 485809, "url": "http://patchwork.ozlabs.org/api/series/485809/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=485809", "date": "2025-12-18T09:44:28", "name": "[iwl-net] ice: fix 'adjust' timer programming for E830 devices", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/485809/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2175480/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2175480/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=TdGwsA32;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::138; helo=smtp1.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4dX5Rl288pz1y2F\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 18 Dec 2025 20:47:14 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 0BF338386F;\n\tThu, 18 Dec 2025 09:47:12 +0000 (UTC)", "from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id V_SWqu-9UDZU; Thu, 18 Dec 2025 09:47:10 +0000 (UTC)", "from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 67C5F835A7;\n\tThu, 18 Dec 2025 09:47:10 +0000 (UTC)", "from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136])\n by lists1.osuosl.org (Postfix) with ESMTP id 600732A2\n for <intel-wired-lan@lists.osuosl.org>; Thu, 18 Dec 2025 09:47:08 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp3.osuosl.org (Postfix) with ESMTP id 42119608F6\n for <intel-wired-lan@lists.osuosl.org>; Thu, 18 Dec 2025 09:47:08 +0000 (UTC)", "from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id PNcidP1EyN9C for <intel-wired-lan@lists.osuosl.org>;\n Thu, 18 Dec 2025 09:47:07 +0000 (UTC)", "from mgamail.intel.com (mgamail.intel.com [198.175.65.16])\n by smtp3.osuosl.org (Postfix) with ESMTPS id 28B4E60BC8\n for <intel-wired-lan@lists.osuosl.org>; Thu, 18 Dec 2025 09:47:06 +0000 (UTC)", "from orviesa004.jf.intel.com ([10.64.159.144])\n by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 18 Dec 2025 01:47:05 -0800", "from gklab-003-001.igk.intel.com ([10.91.173.48])\n by orviesa004.jf.intel.com with ESMTP; 18 Dec 2025 01:47:04 -0800" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp1.osuosl.org 67C5F835A7", "OpenDKIM Filter v2.11.0 smtp3.osuosl.org 28B4E60BC8" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1766051230;\n\tbh=aFS5LPyBsi7qQGlpGLQ+5gQubplMRyYhhS5C6QLO4j0=;\n\th=From:To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:\n\t List-Post:List-Help:List-Subscribe:Cc:From;\n\tb=TdGwsA32IoMrc5EYOlUysd3WVcnvutAMVFHoqh4r0oP9wjhhY2pPC5Ld++s5fbsUB\n\t jAmM/85jEQgrrfQlC6kfERfZYjkkOtfJq8XcDdpUvk/bmoX6pmULxpHFIf3j05/wFv\n\t 6OoIJLghiOT6pLoD4aUqYqgRTbHR7tOTwvEr4MBMiW7F7tKIXktsR5HabQ39bhXh76\n\t Xn8KLEKyJTlHXnon8XCed+z1igQXQChT9YzWYLNuLJnVeSnx67wjjMeQoY3BJkdRyM\n\t tes5mU9dZ7Szu7MaAcKlLO1fP70YTuSYuczg1tFhoRZV9hzYMqyy7JNnbH9V81Di8N\n\t 4bw7DNtfLTflw==", "Received-SPF": "Pass (mailfrom) identity=mailfrom; client-ip=198.175.65.16;\n helo=mgamail.intel.com; envelope-from=grzegorz.nitka@intel.com;\n receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp3.osuosl.org 28B4E60BC8", "X-CSE-ConnectionGUID": [ "tZdH5kGPT86+I1SZ9ZvdUw==", "IGeDR+cWRGCFTVmHvrH+5g==" ], "X-CSE-MsgGUID": [ "BaPIV+wITmiIm5aP8JPH/A==", "2nuNSzGPQ12ToZJU0bV3Pg==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6800,10657,11645\"; a=\"68155799\"", "E=Sophos;i=\"6.21,158,1763452800\"; d=\"scan'208\";a=\"68155799\"", "E=Sophos;i=\"6.21,158,1763452800\"; d=\"scan'208\";a=\"203060583\"" ], "X-ExtLoop1": "1", "From": "Grzegorz Nitka <grzegorz.nitka@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Thu, 18 Dec 2025 10:44:28 +0100", "Message-Id": "<20251218094428.1762860-1-grzegorz.nitka@intel.com>", "X-Mailer": "git-send-email 2.39.3", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-Mailman-Original-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1766051227; x=1797587227;\n h=from:to:cc:subject:date:message-id:mime-version:\n content-transfer-encoding;\n bh=2l7sftU6c2VGwi3zbDZTUPbXZ3sqKJV8IEPxc4XG1bE=;\n b=WVnRtPL59Nl2PHzadviEX0omgcrNLyViOb4Tp3/XgnXcv3ycazo7tO8L\n 4i2AtG5htUXsJfO90H269Xxyi4SWGhThGEtrLC/80gUO3zKdEMkThaY83\n TLO8Ygtqyan9Q/VVhGzN2eI51l0iU5LYS51eaqOmS07Lq+Rs7dQ3AQBhI\n JO5th8pZ07bXPzkg4VLO3KEOtusDztsjJVyTgFL7bKCDAao1q8TRKGCRl\n b5UR4PURCZDUYyEDMl2qK5l0/n4VZ1zBSkqXcsB6gSPVKLvw2WWzvptL5\n zw5Fc+6QcDFlVi9vJE68nJYLm5sum1YG4HMJR6kM9qtbbPsInK+O9v8Di\n g==;", "X-Mailman-Original-Authentication-Results": [ "smtp3.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com", "smtp3.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=WVnRtPL5" ], "Subject": "[Intel-wired-lan] [PATCH iwl-net] ice: fix 'adjust' timer\n programming for E830 devices", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Cc": "Aleksandr Loktionov <aleksandr.loktionov@intel.com>,\n netdev@vger.kernel.org,\n anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "Fix incorrect 'adjust the timer' programming sequence for E830 devices\nseries. Only shadow registers GLTSYN_SHADJ were programmed in the\ncurrent implementation. According to the specification [1], write to\ncommand GLTSYN_CMD register is also required with CMD field set to\n\"Adjust the Time\" value, for the timer adjustment to take the effect.\n\nThe flow was broken for the adjustment less than S32_MAX/MIN range\n(around +/- 2 seconds). For bigger adjustment, non-atomic programming\nflow is used, involving set timer programming. Non-atomic flow is\nimplemented correctly.\n\nTesting hints:\nRun command:\n\tphc_ctl /dev/ptpX get adj 2 get\nExpected result:\n\tReturned timstamps differ at least by 2 seconds\n\n[1] Intel® Ethernet Controller E830 Datasheet rev 1.3, chapter 9.7.5.4\nhttps://cdrdv2.intel.com/v1/dl/getContent/787353?explicitVersion=true\n\nFixes: f00307522786 (\"ice: Implement PTP support for E830 devices\")\nReviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>\nSigned-off-by: Grzegorz Nitka <grzegorz.nitka@intel.com>\n---\n drivers/net/ethernet/intel/ice/ice_ptp_hw.c | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)\n\n\nbase-commit: 8282ed7f73cf08f99288d3d0131e07f149063fbe", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice_ptp_hw.c b/drivers/net/ethernet/intel/ice/ice_ptp_hw.c\nindex 35680dbe4a7f..161a0ae8599c 100644\n--- a/drivers/net/ethernet/intel/ice/ice_ptp_hw.c\n+++ b/drivers/net/ethernet/intel/ice/ice_ptp_hw.c\n@@ -5381,8 +5381,8 @@ int ice_ptp_write_incval_locked(struct ice_hw *hw, u64 incval)\n */\n int ice_ptp_adj_clock(struct ice_hw *hw, s32 adj)\n {\n+\tint err = 0;\n \tu8 tmr_idx;\n-\tint err;\n \n \ttmr_idx = hw->func_caps.ts_func_info.tmr_index_owned;\n \n@@ -5399,8 +5399,8 @@ int ice_ptp_adj_clock(struct ice_hw *hw, s32 adj)\n \t\terr = ice_ptp_prep_phy_adj_e810(hw, adj);\n \t\tbreak;\n \tcase ICE_MAC_E830:\n-\t\t/* E830 sync PHYs automatically after setting GLTSYN_SHADJ */\n-\t\treturn 0;\n+\t\t/* E830 sync PHYs automatically after setting cmd register */\n+\t\tbreak;\n \tcase ICE_MAC_GENERIC:\n \t\terr = ice_ptp_prep_phy_adj_e82x(hw, adj);\n \t\tbreak;\n", "prefixes": [ "iwl-net" ] }