Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2173731/?format=api
{ "id": 2173731, "url": "http://patchwork.ozlabs.org/api/patches/2173731/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20251212-lwip_nfs-v2-2-9cb5a60520d8@linaro.org/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20251212-lwip_nfs-v2-2-9cb5a60520d8@linaro.org>", "list_archive_url": null, "date": "2025-12-12T11:32:25", "name": "[v2,2/6] net: Move some variables to net-common files", "commit_ref": "3938ae6457193cd3b0abb8b74957a388a6b3e639", "pull_url": null, "state": "accepted", "archived": false, "hash": "c97add0ba06ee2fe6dcef17f163f963b97fb4c81", "submitter": { "id": 88793, "url": "http://patchwork.ozlabs.org/api/people/88793/?format=api", "name": "Andrew Goodbody", "email": "andrew.goodbody@linaro.org" }, "delegate": { "id": 157425, "url": "http://patchwork.ozlabs.org/api/users/157425/?format=api", "username": "jforissier", "first_name": "Jerome", "last_name": "Forissier", "email": "jerome.forissier@linaro.org" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20251212-lwip_nfs-v2-2-9cb5a60520d8@linaro.org/mbox/", "series": [ { "id": 485199, "url": "http://patchwork.ozlabs.org/api/series/485199/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=485199", "date": "2025-12-12T11:32:23", "name": "net: Port NFS to lwIP", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/485199/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2173731/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2173731/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=rtUhFbTp;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=linaro.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.b=\"rtUhFbTp\";\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=linaro.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=andrew.goodbody@linaro.org" ], "Received": [ "from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4dSS4D54gpz1xsK\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 12 Dec 2025 22:32:44 +1100 (AEDT)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 575D1839B7;\n\tFri, 12 Dec 2025 12:32:33 +0100 (CET)", "by phobos.denx.de (Postfix, from userid 109)\n id DD642837F2; Fri, 12 Dec 2025 12:32:31 +0100 (CET)", "from mail-wm1-x331.google.com (mail-wm1-x331.google.com\n [IPv6:2a00:1450:4864:20::331])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 55BE0837F2\n for <u-boot@lists.denx.de>; Fri, 12 Dec 2025 12:32:28 +0100 (CET)", "by mail-wm1-x331.google.com with SMTP id\n 5b1f17b1804b1-47775fb6cb4so8720265e9.0\n for <u-boot@lists.denx.de>; Fri, 12 Dec 2025 03:32:28 -0800 (PST)", "from artemis2.elfringham.co.uk\n ([2a0a:ef40:fed:3801:9287:1e8a:f239:8d00])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-47a8f8f39c6sm26277235e9.14.2025.12.12.03.32.26\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 12 Dec 2025 03:32:27 -0800 (PST)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,\n SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1765539148; x=1766143948; darn=lists.denx.de;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:from:to:cc:subject:date:message-id\n :reply-to; bh=drqCWXGIvc6g2B7eoAzXCwMapcMX83m1YjHcjgm4I78=;\n b=rtUhFbTpl3TiQtmQSRttAwQwJXg4vRrvFAGi+cZWaLc8ut2uOMGnD6khXDFJrmTbYa\n Ry6F/mRn7T3tCRPYKpbiMtezc+kUHLP6eJUojVyw2zhDrRSh8Keifck1dbKK3IrfzHM7\n /nvX4DE6t7M7kWOQb36FVjaclJ7HkTePK3SKLM+N4bhQLVn7/fCqTPtFY5GdOIQ6s2wv\n oyvXjPP1TPGS/S+Dqq0UCQL/9URrqPqBL29pArDIAVr2uXQNpe0oaKSKi1LjeN+nZH2G\n CAaNrjEnLOTVWzrTPGZok4OAWkgaKUMXhXG36v7X4C2lfO8IdrParSpNpAv1/YhzL7+i\n NJtA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1765539148; x=1766143948;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to\n :cc:subject:date:message-id:reply-to;\n bh=drqCWXGIvc6g2B7eoAzXCwMapcMX83m1YjHcjgm4I78=;\n b=fqI30d1muz4mWOUqseOYDfvRctkJfWf3TlvWpSe9HnfVcDqHHiJqXc26JbSA1HgshN\n Jicn7qR0/PnAWqpp9fhnS2zNoKsFD7i4l9rqMnIXzF49ysj5Smh/5qvUQJ5l78+kAoJW\n pSnIrUzgjWnsUXK42lTR6aOpWfjCILZxTLfm8gUCExneEalPKlO7xZyCLZ2l9gCQ0tiI\n 3YtFJlw9UUCd+JbIIrhOaiqmmdyrzLGggoJPnk5VlrOaPZq1KJsHqJMrFKqra4XkWzqO\n dLD5bbZY6A3wSLgwvU8Qpy64a5TVqyqMD115hanvJjnvXxjwumvTRJTwSAtD81VxHBLF\n 48mA==", "X-Gm-Message-State": "AOJu0YyiAvocZ7TdCeQ0WYNzYFSCP6wRdLBVpAl914ZgHaZs8pvGAwNe\n d67auHl8t5HLZlzZcOKB4vAM6B28rg1U1PDncZHj1knTTUNyRMP0pr5A6iSCVrd9t4I=", "X-Gm-Gg": "AY/fxX44HM4z0g09abgQYP0bIJoIlaTnqnbiesbUxze667Mxy0hdp4zOTo9aN/LlFBL\n 6sUpDxMDf6d4VKrSKAyAaCg2kIm4YDJQuOa2h1udCrtrNvoSuMpzRu+0VRXS0/9krQOsQYx3Msm\n lXUUv67RujkZ+ee6/gLtJb67bMDJPeWuH+3xMe8gm/OT/oTVxjSq3uL14QJoeSyWxp7WW9VTvqI\n FCL0QKIOYr8lyfQekVvFwurhCyPyl20s6bE4/41XWclGcK6ulWXs+m3io3WE3FwuTdzIwG5715e\n SdBeY9C0myxoB5WP2N2MqcyldMC9bVlyxUP+LlNpD2Ab6nMhYNniGNkdWEb/7rUD77Sm5p9fpI1\n ErwzVaILrmnijxptg8pviTaFUERhuc88tC/ZRGDOBdoOGIosMCT/F3eGppVI4BWtW82krfu9olS\n BIRsbwm49q1cnU4PLcTEUna2hNzSBYUROMYrOdy8w=", "X-Google-Smtp-Source": "\n AGHT+IFYoiaSwpmPY9f+4UpGQLYrRBQ1IZqndSbL3jWCmV4EgdH7S42VaSXNEOL/MIFB4bddgpEQWg==", "X-Received": "by 2002:a05:600c:860b:b0:47a:814c:eea1 with SMTP id\n 5b1f17b1804b1-47a8f91d91fmr18199465e9.35.1765539147682;\n Fri, 12 Dec 2025 03:32:27 -0800 (PST)", "From": "Andrew Goodbody <andrew.goodbody@linaro.org>", "Date": "Fri, 12 Dec 2025 11:32:25 +0000", "Subject": "[PATCH v2 2/6] net: Move some variables to net-common files", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "<20251212-lwip_nfs-v2-2-9cb5a60520d8@linaro.org>", "References": "<20251212-lwip_nfs-v2-0-9cb5a60520d8@linaro.org>", "In-Reply-To": "<20251212-lwip_nfs-v2-0-9cb5a60520d8@linaro.org>", "To": "u-boot@lists.denx.de", "Cc": "Tom Rini <trini@konsulko.com>, Joe Hershberger <joe.hershberger@ni.com>,\n Ramon Fried <rfried.dev@gmail.com>,\n Jerome Forissier <jerome.forissier@linaro.org>,\n Simon Glass <sjg@chromium.org>, Benjamin Hahn <B.Hahn@phytec.de>,\n Heinrich Schuchardt <xypron.glpk@gmx.de>,\n Adriano Cordova <adrianox@gmail.com>,\n Max Merchel <Max.Merchel@ew.tq-group.com>,\n Mikhail Kshevetskiy <mikhail.kshevetskiy@iopsys.eu>,\n Andre Przywara <andre.przywara@arm.com>, Tim Harvey <tharvey@gateworks.com>,\n Ilias Apalodimas <ilias.apalodimas@linaro.org>,\n Michal Simek <michal.simek@amd.com>,\n Michael Trimarchi <michael@amarulasolutions.com>,\n Ibai Erkiaga <ibai.erkiaga-elorza@amd.com>,\n Wolfgang Wallner <wolfgang.wallner@br-automation.com>,\n \"Kory Maincent (TI.com)\" <kory.maincent@bootlin.com>,\n Martyn Welch <martyn.welch@collabora.com>,\n Tuomas Tynkkynen <tuomas.tynkkynen@iki.fi>,\n Andrew Goodbody <andrew.goodbody@linaro.org>", "X-Mailer": "b4 0.14.2", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.8 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "Make some variables available to be used by either the legacy network\ncode or lwIP by moving them into the net-common files. This also allowed\nremoving a small number of duplicated variables from the lwIP code.\n\nSigned-off-by: Andrew Goodbody <andrew.goodbody@linaro.org>\n---\n include/net-common.h | 12 ++++++++++--\n include/net-legacy.h | 5 -----\n net/lwip/net-lwip.c | 5 -----\n net/net-common.c | 9 +++++++++\n net/net.c | 10 ----------\n 5 files changed, 19 insertions(+), 22 deletions(-)", "diff": "diff --git a/include/net-common.h b/include/net-common.h\nindex d7a0f7dff7e50527e77419ead9a9ff30deeea545..f293b21bc0bb3c8e1a04ffd8f5188e5ce67d1d12 100644\n--- a/include/net-common.h\n+++ b/include/net-common.h\n@@ -132,13 +132,21 @@ static inline void net_set_state(enum net_loop_state state)\n }\n \n extern int\t\tnet_restart_wrap;\t/* Tried all network devices */\n-extern uchar *net_rx_packets[PKTBUFSRX]; /* Receive packets */\n+extern uchar\t\t*net_rx_packets[PKTBUFSRX]; /* Receive packets */\n extern const u8\t\tnet_bcast_ethaddr[ARP_HLEN];\t/* Ethernet broadcast address */\n-extern char\tnet_boot_file_name[1024];/* Boot File name */\n extern struct in_addr\tnet_ip;\t\t/* Our IP addr (0 = unknown) */\n /* Indicates whether the pxe path prefix / config file was specified in dhcp option */\n extern char *pxelinux_configfile;\n \n+/* Our IP addr (0 = unknown) */\n+extern struct in_addr\tnet_ip;\n+/* Boot File name */\n+extern char\tnet_boot_file_name[1024];\n+/* The actual transferred size of the bootfile (in bytes) */\n+extern u32\tnet_boot_file_size;\n+/* Boot file size in blocks as reported by the DHCP server */\n+extern u32\tnet_boot_file_expected_size_in_blocks;\n+\n /**\n * compute_ip_checksum() - Compute IP checksum\n *\ndiff --git a/include/net-legacy.h b/include/net-legacy.h\nindex 0a10121b0cf50898a90bb1179966f01dbdda65ad..d489c2480cd89adec6026b4fcb0b1165f8a28081 100644\n--- a/include/net-legacy.h\n+++ b/include/net-legacy.h\n@@ -289,7 +289,6 @@ extern u8\t\tnet_ethaddr[ARP_HLEN];\t\t/* Our ethernet address */\n extern u8\t\tnet_server_ethaddr[ARP_HLEN];\t/* Boot server enet address */\n extern struct in_addr\tnet_server_ip;\t/* Server IP addr (0 = unknown) */\n extern uchar\t\t*net_tx_packet;\t\t/* THE transmit packet */\n-extern uchar\t\t*net_rx_packets[PKTBUFSRX]; /* Receive packets */\n extern uchar\t\t*net_rx_packet;\t\t/* Current receive packet */\n extern int\t\tnet_rx_packet_len;\t/* Current rx packet length */\n extern const u8\t\tnet_null_ethaddr[ARP_HLEN];\n@@ -309,10 +308,6 @@ enum proto_t {\n \n /* Indicates whether the file name was specified on the command line */\n extern bool\tnet_boot_file_name_explicit;\n-/* The actual transferred size of the bootfile (in bytes) */\n-extern u32\tnet_boot_file_size;\n-/* Boot file size in blocks as reported by the DHCP server */\n-extern u32\tnet_boot_file_expected_size_in_blocks;\n \n #if defined(CONFIG_DNS)\n extern char *net_dns_resolve;\t\t/* The host to resolve */\ndiff --git a/net/lwip/net-lwip.c b/net/lwip/net-lwip.c\nindex 8741f65fe12e23cc30068506453a762533f8a67f..b3b6c796976ea9d7aec4148992f7cd41cd8f8743 100644\n--- a/net/lwip/net-lwip.c\n+++ b/net/lwip/net-lwip.c\n@@ -33,13 +33,8 @@ static int net_restarted;\n int net_restart_wrap;\n static uchar net_pkt_buf[(PKTBUFSRX) * PKTSIZE_ALIGN + PKTALIGN]\n \t__aligned(PKTALIGN);\n-uchar *net_rx_packets[PKTBUFSRX];\n-uchar *net_rx_packet;\n const u8 net_bcast_ethaddr[6] = { 0xff, 0xff, 0xff, 0xff, 0xff, 0xff };\n char *pxelinux_configfile;\n-/* Our IP addr (0 = unknown) */\n-struct in_addr\tnet_ip;\n-char net_boot_file_name[1024];\n \n static err_t net_lwip_tx(struct netif *netif, struct pbuf *p)\n {\ndiff --git a/net/net-common.c b/net/net-common.c\nindex ec1e179f7d9cdd459dc3b8c2d13f6e478ad4ce87..f21a80357f6c6d923c9485969d4c4c80bbb98bfb 100644\n--- a/net/net-common.c\n+++ b/net/net-common.c\n@@ -8,6 +8,15 @@\n \n /* Network loop state */\n enum net_loop_state net_state;\n+/* Our IP addr (0 = unknown) */\n+struct in_addr\tnet_ip;\n+/* Boot File name */\n+char net_boot_file_name[1024];\n+/* The actual transferred size of the bootfile (in bytes) */\n+u32 net_boot_file_size;\n+/* Boot file size in blocks as reported by the DHCP server */\n+u32 net_boot_file_expected_size_in_blocks;\n+uchar *net_rx_packets[PKTBUFSRX];\n \n void copy_filename(char *dst, const char *src, int size)\n {\ndiff --git a/net/net.c b/net/net.c\nindex 03a39419d10817aff5f12badc0f604a403fe7fb2..62f03a84a6c076bc431acdcf7390220cb85359f8 100644\n--- a/net/net.c\n+++ b/net/net.c\n@@ -147,8 +147,6 @@ char *pxelinux_configfile;\n u8 net_ethaddr[6];\n /* Boot server enet address */\n u8 net_server_ethaddr[6];\n-/* Our IP addr (0 = unknown) */\n-struct in_addr\tnet_ip;\n /* Server IP addr (0 = unknown) */\n struct in_addr\tnet_server_ip;\n /* Current receive packet */\n@@ -176,18 +174,10 @@ ushort\t\tnet_our_vlan = 0xFFFF;\n /* ditto */\n ushort\t\tnet_native_vlan = 0xFFFF;\n \n-/* Boot File name */\n-char net_boot_file_name[1024];\n /* Indicates whether the file name was specified on the command line */\n bool net_boot_file_name_explicit;\n-/* The actual transferred size of the bootfile (in bytes) */\n-u32 net_boot_file_size;\n-/* Boot file size in blocks as reported by the DHCP server */\n-u32 net_boot_file_expected_size_in_blocks;\n \n static uchar net_pkt_buf[(PKTBUFSRX+1) * PKTSIZE_ALIGN + PKTALIGN];\n-/* Receive packets */\n-uchar *net_rx_packets[PKTBUFSRX];\n /* Current UDP RX packet handler */\n static rxhand_f *udp_packet_handler;\n /* Current ARP RX packet handler */\n", "prefixes": [ "v2", "2/6" ] }