Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2171993/?format=api
{ "id": 2171993, "url": "http://patchwork.ozlabs.org/api/patches/2171993/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20251205-lwip_fixes-v1-1-90bbca659923@linaro.org/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20251205-lwip_fixes-v1-1-90bbca659923@linaro.org>", "list_archive_url": null, "date": "2025-12-05T17:28:36", "name": "net: lwip: tftp: Fix filename handling", "commit_ref": "8910efa71b8bab88b0ca81b681b5842fd25b1000", "pull_url": null, "state": "accepted", "archived": false, "hash": "856a940d2644ff1e7654fee5618a9b1d87ac764f", "submitter": { "id": 88793, "url": "http://patchwork.ozlabs.org/api/people/88793/?format=api", "name": "Andrew Goodbody", "email": "andrew.goodbody@linaro.org" }, "delegate": { "id": 157425, "url": "http://patchwork.ozlabs.org/api/users/157425/?format=api", "username": "jforissier", "first_name": "Jerome", "last_name": "Forissier", "email": "jerome.forissier@linaro.org" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20251205-lwip_fixes-v1-1-90bbca659923@linaro.org/mbox/", "series": [ { "id": 484565, "url": "http://patchwork.ozlabs.org/api/series/484565/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=484565", "date": "2025-12-05T17:28:36", "name": "net: lwip: tftp: Fix filename handling", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/484565/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2171993/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2171993/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=V0837Du3;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=linaro.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.b=\"V0837Du3\";\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=linaro.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=andrew.goodbody@linaro.org" ], "Received": [ "from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4dNJJM0hbnz1xvn\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 06 Dec 2025 04:28:50 +1100 (AEDT)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id DBB3984223;\n\tFri, 5 Dec 2025 18:28:47 +0100 (CET)", "by phobos.denx.de (Postfix, from userid 109)\n id 8881184230; Fri, 5 Dec 2025 18:28:46 +0100 (CET)", "from mail-wm1-x334.google.com (mail-wm1-x334.google.com\n [IPv6:2a00:1450:4864:20::334])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 7409F8421E\n for <u-boot@lists.denx.de>; Fri, 5 Dec 2025 18:28:39 +0100 (CET)", "by mail-wm1-x334.google.com with SMTP id\n 5b1f17b1804b1-477619f8ae5so20431895e9.3\n for <u-boot@lists.denx.de>; Fri, 05 Dec 2025 09:28:39 -0800 (PST)", "from artemis2.elfringham.co.uk\n ([2a0a:ef40:f7b:b001:ff09:b7cb:eda8:67f3])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-47930c747b8sm94780945e9.9.2025.12.05.09.28.37\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 05 Dec 2025 09:28:38 -0800 (PST)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,\n SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1764955719; x=1765560519; darn=lists.denx.de;\n h=cc:to:message-id:content-transfer-encoding:mime-version:subject\n :date:from:from:to:cc:subject:date:message-id:reply-to;\n bh=wPxK4+4xjJB3YEoVa9tRBNixN5kQ0lMCPR88fGQBWI4=;\n b=V0837Du3GLBcoz3gpsLI/dwjoKkTOqi4oWnwdngKT+BKQP2PDHoo8np2xjMhSwsapO\n bCfrnIb9/UXK9JbxA94QonCqgEEshDRtbGm7o/ZmZWdpIPk71s2djIIh0cBnoEWtJfD6\n iiXaQ+778zQ31eYb1exbbgT/HAgaqXY8lTklql1B5Vf0rHoEJcbvcanAnQRnXUqoTzuw\n VcuH9NpXr42kBmmdCHboD6/883HZ+UHZL3LE0AVd0yBGNmPlsXBczawoHScIJVQs1yCy\n xd04TKYY8Z6uUJo+UH81aEV9SIbOVO9/N4MJMtbG//0Pw0jZzHV2b9NudqDuptHIoQ7i\n tYlg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1764955719; x=1765560519;\n h=cc:to:message-id:content-transfer-encoding:mime-version:subject\n :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=wPxK4+4xjJB3YEoVa9tRBNixN5kQ0lMCPR88fGQBWI4=;\n b=lNjnq3lmx8//Py567r1kLDRteu3wTFFRbl0hrXpsUEKQYBHa32JQ5OsRgwkPxlRLgK\n OGYKU1ioOi0tkLxym8cUcAWKL7t3+IlFAolBXcDqTyTynJU98vXc7lwmxNh0sEqhnvA+\n Fqq93XZyCZdZK5j/sMxmVCtvdxRKXBjefGVVA/Y7AIxYYs0Hg9blNXduIaOomFZBfXHD\n Jfw7BK2tjodaql8X5ygw01fHbBqPXbrPIzIU91VWsQ+VMAi2l/vZTJhOorKCh2JlPhXA\n 2VH5Qi1JFce0qPl6AUQK0pfnY77rmxw32FU8bo0DHu7stYhTA41eDTiJ19w/Xu9bATur\n idFA==", "X-Gm-Message-State": "AOJu0YwHmseK77NoeAkvv6jGAR3Yy1OVRVj14aYQ8yOEyS3fROaUmBdr\n P4rtPGwfEAmBZRwcDd6w54VoqcehFrrwezd8VasnLohSrP+168xY2n42MoL3FAxWUEsAqXHLJqR\n 0SuRIYfY=", "X-Gm-Gg": "ASbGncvGmJjTWpjj5zWPdrVEMX/QZqaDV1py2LryaCDf2cVhKVBIhIF31SeNGKB6vmM\n hufInyVECTLj9iNNcnvLOlmRm7ReTreMxz+FRBGyymPXkjvFw/dRmC4LsZjONZrSGwNPN49Kj0a\n JjpVQ9VvhRoqXkxGpIFFBfctDYwxtfPIz5QJTRAyCOAjq0A8q4y6wpU0bbxKyvOydrvjZI0ZSwc\n 9U1UrbFidzD/kEIKN/1sBNFA85LBYjmXVbejQoxqbwn8qfZpPaP2GjpdyDsvKmUzm/2gd99mubQ\n J/MxwQBh1cwQOiXclNAx71BV9mw9eVghwIm1xoeT0ffsBvG0cvaqsHXRmGZg6zvY8SAusExdogd\n +hPjm0XJzeAyvZrRIMEPzAoCuV8hQ/5TLJ2hlSnJcpS31IauOdVHN4H2F7WjSGN1vBvTnwIiqIa\n jrKjKnOf8tRx5BOC6RdO7Qov3JDdoJZ/1RPMD3ZzFhi5jP+r7g7g==", "X-Google-Smtp-Source": "\n AGHT+IH8HMOX3QPlgk3F5jb9Mj5GbMjrHFAY32gP5FnxD4laogvhQsf9H1MQVuJTUUf9p+5jCL131w==", "X-Received": "by 2002:a05:600c:3508:b0:477:89d5:fdb2 with SMTP id\n 5b1f17b1804b1-47939dfcb2amr880685e9.14.1764955718827;\n Fri, 05 Dec 2025 09:28:38 -0800 (PST)", "From": "Andrew Goodbody <andrew.goodbody@linaro.org>", "Date": "Fri, 05 Dec 2025 17:28:36 +0000", "Subject": "[PATCH] net: lwip: tftp: Fix filename handling", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "<20251205-lwip_fixes-v1-1-90bbca659923@linaro.org>", "X-B4-Tracking": "v=1; b=H4sIAEMWM2kC/x2LQQqAIBAAvyJ7TtAtPfSViJDaaiFMFCoI/97Sc\n ZiZFwplpgK9eiHTxYXPKGAbBfMe4kaaF2FAg86icfq4OU0rP1Q0hc442zrvLYIMKdMvpB/GWj+\n riDdlXAAAAA==", "X-Change-ID": "20251205-lwip_fixes-ea4051356612", "To": "u-boot@lists.denx.de", "Cc": "Jerome Forissier <jerome.forissier@linaro.org>,\n Joe Hershberger <joe.hershberger@ni.com>,\n Ramon Fried <rfried.dev@gmail.com>, Tom Rini <trini@konsulko.com>,\n Tim Harvey <tharvey@gateworks.com>, Simon Glass <sjg@chromium.org>,\n Wolfgang Wallner <wolfgang.wallner@br-automation.com>,\n Sughosh Ganu <sughosh.ganu@linaro.org>,\n Andrew Goodbody <andrew.goodbody@linaro.org>", "X-Mailer": "b4 0.14.2", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.8 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "The code to choose the filename to use does not cope with no name set at\nall. Firstly the test for a name in net_boot_file_name tests the pointer\nrather than the string it points to. Secondly the cleanup on exit in\nthis case attempts to free a global variable. Fix both issues.\n\nSigned-off-by: Andrew Goodbody <andrew.goodbody@linaro.org>\n---\n net/lwip/tftp.c | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)\n\n\n---\nbase-commit: 59f9fcc1f514762674ac07c13c2a85f7aace7250\nchange-id: 20251205-lwip_fixes-ea4051356612\n\nBest regards,", "diff": "diff --git a/net/lwip/tftp.c b/net/lwip/tftp.c\nindex 94bacf630752d20357cef40775a25cca39d811dc..6c7ffba661e5903b6b3a6349edf2c8b22eb0d36b 100644\n--- a/net/lwip/tftp.c\n+++ b/net/lwip/tftp.c\n@@ -279,7 +279,7 @@ int do_tftpb(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[])\n \tif (!arg)\n \t\targ = net_boot_file_name;\n \n-\tif (arg) {\n+\tif (*arg) {\n \t\t/* Parse [ip:[port:]]fname */\n \t\ti = 0;\n \t\twhile ((*(words + i) = strsep(&arg, \":\")))\n@@ -342,6 +342,7 @@ int do_tftpb(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[])\n \tif (tftp_loop(eth_get_dev(), laddr, fname, srvip, port) < 0)\n \t\tret = CMD_RET_FAILURE;\n out:\n-\tfree(arg);\n+\tif (arg != net_boot_file_name)\n+\t\tfree(arg);\n \treturn ret;\n }\n", "prefixes": [] }