Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2171136/?format=api
{ "id": 2171136, "url": "http://patchwork.ozlabs.org/api/patches/2171136/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20251203132949.325245-1-larysa.zaremba@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20251203132949.325245-1-larysa.zaremba@intel.com>", "list_archive_url": null, "date": "2025-12-03T13:29:48", "name": "[iwl-net] ice: fix adding AQ LLDP filter for VF", "commit_ref": null, "pull_url": null, "state": "under-review", "archived": false, "hash": "8cd84cbd4daae238b2884caf142db0b7fae7013f", "submitter": { "id": 84900, "url": "http://patchwork.ozlabs.org/api/people/84900/?format=api", "name": "Larysa Zaremba", "email": "larysa.zaremba@intel.com" }, "delegate": { "id": 109701, "url": "http://patchwork.ozlabs.org/api/users/109701/?format=api", "username": "anguy11", "first_name": "Anthony", "last_name": "Nguyen", "email": "anthony.l.nguyen@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20251203132949.325245-1-larysa.zaremba@intel.com/mbox/", "series": [ { "id": 484263, "url": "http://patchwork.ozlabs.org/api/series/484263/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=484263", "date": "2025-12-03T13:29:48", "name": "[iwl-net] ice: fix adding AQ LLDP filter for VF", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/484263/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2171136/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2171136/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=srsgQT7l;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.136; helo=smtp3.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4dLzYd08tWz1yFD\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 4 Dec 2025 00:50:44 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id C48F8606E6;\n\tWed, 3 Dec 2025 13:50:42 +0000 (UTC)", "from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id KzT1Hs-q-IiX; Wed, 3 Dec 2025 13:50:41 +0000 (UTC)", "from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 5E29060AF6;\n\tWed, 3 Dec 2025 13:50:41 +0000 (UTC)", "from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n by lists1.osuosl.org (Postfix) with ESMTP id 6E37FE4\n for <intel-wired-lan@lists.osuosl.org>; Wed, 3 Dec 2025 13:50:39 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp4.osuosl.org (Postfix) with ESMTP id 4C6E841153\n for <intel-wired-lan@lists.osuosl.org>; Wed, 3 Dec 2025 13:50:39 +0000 (UTC)", "from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id 2IPpQdxS-rwm for <intel-wired-lan@lists.osuosl.org>;\n Wed, 3 Dec 2025 13:50:38 +0000 (UTC)", "from mgamail.intel.com (mgamail.intel.com [198.175.65.12])\n by smtp4.osuosl.org (Postfix) with ESMTPS id 4AF0741129\n for <intel-wired-lan@lists.osuosl.org>; Wed, 3 Dec 2025 13:50:37 +0000 (UTC)", "from orviesa010.jf.intel.com ([10.64.159.150])\n by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 03 Dec 2025 05:50:37 -0800", "from irvmail002.ir.intel.com ([10.43.11.120])\n by orviesa010.jf.intel.com with ESMTP; 03 Dec 2025 05:50:34 -0800", "from lincoln.igk.intel.com (lincoln.igk.intel.com [10.102.21.235])\n by irvmail002.ir.intel.com (Postfix) with ESMTP id 6D50337E31;\n Wed, 3 Dec 2025 13:50:32 +0000 (GMT)" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp3.osuosl.org 5E29060AF6", "OpenDKIM Filter v2.11.0 smtp4.osuosl.org 4AF0741129" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1764769841;\n\tbh=cnpduqlsjNgydl7B9sYYmxtWAv6d/C2d7DwmHng6ums=;\n\th=From:To:Cc:Date:Subject:List-Id:List-Unsubscribe:List-Archive:\n\t List-Post:List-Help:List-Subscribe:From;\n\tb=srsgQT7lw+a3bfPg/ieY8ylSnPF4SLMWwvv9cypXKxoyPXnZi4r7Ph1Dxplaw4YOD\n\t A7d5otYF0eCRQs1LLP9ApuAHq/AQyjXO41uq6OnuPwV4fTFtw6w8w2Ao/BK2bWA1hs\n\t RIVCcFT5/pXeBmox+1gm1dzFzJOCStnE27X6DhlgonzKKU8pY5pgyql/eOZDenCpmn\n\t /bRv68QSfaA3EEdIEhKJg3YpaI0eoyAHHhfV0/7rJs9fp13/5hs3FvICx1nfHRyW/r\n\t hdj6571OfznI1BFjeID6DjMHdj63WPeIq0G22wEI++5mX7cJJBa+idcVpM3zevmj/A\n\t GAN9gLeSWD+KQ==", "Received-SPF": "Pass (mailfrom) identity=mailfrom; client-ip=198.175.65.12;\n helo=mgamail.intel.com; envelope-from=larysa.zaremba@intel.com;\n receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp4.osuosl.org 4AF0741129", "X-CSE-ConnectionGUID": [ "e3FMB+P3R3ygn3KGKd+v4Q==", "hoeT8WcUQ76Br1aw4cG2uA==" ], "X-CSE-MsgGUID": [ "mltWC0pRSuSYEcFJmVO6tw==", "alym2E/qQImeki8Jix/smg==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6800,10657,11631\"; a=\"78226130\"", "E=Sophos;i=\"6.20,246,1758610800\"; d=\"scan'208\";a=\"78226130\"", "E=Sophos;i=\"6.20,246,1758610800\"; d=\"scan'208\";a=\"193959474\"" ], "X-ExtLoop1": "1", "From": "Larysa Zaremba <larysa.zaremba@intel.com>", "To": "Tony Nguyen <anthony.l.nguyen@intel.com>, intel-wired-lan@lists.osuosl.org", "Cc": "Larysa Zaremba <larysa.zaremba@intel.com>,\n Przemek Kitszel <przemyslaw.kitszel@intel.com>,\n Andrew Lunn <andrew+netdev@lunn.ch>,\n \"David S. Miller\" <davem@davemloft.net>,\n Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>,\n Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,\n Michal Swiatkowski <michal.swiatkowski@linux.intel.com>,\n Aleksandr Loktionov <aleksandr.loktionov@intel.com>", "Date": "Wed, 3 Dec 2025 14:29:48 +0100", "Message-ID": "<20251203132949.325245-1-larysa.zaremba@intel.com>", "X-Mailer": "git-send-email 2.51.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Original-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1764769838; x=1796305838;\n h=from:to:cc:subject:date:message-id:mime-version:\n content-transfer-encoding;\n bh=h9M9nant/ybWqUHk1UdyR584/OSsbCdHhcxyRuMhARs=;\n b=fDZGk7k/3EJH6KtXIcGYuZ46G/NI1E4Yk8imoWuaheaGdtHyRcbWiWr3\n ErQzHDT+oCsHDhiEJ2UsdZL/GyKNaCNEpO0YIwO0CEOfjodc7d4baRZ0D\n jkRK6BymJ8hVnSIPEE1iznl1IYhVkpi0s37S9Cn3J8OWsWpFycQ1k4kUE\n uHJVQ7HwdNO/oL01TS5uolWHaLBBzkzrjPcUeQxfd0MvT10/wETu6Y4Cf\n /nhEZ5K+VZrsgW4ww0d9OB26en/p8vvPaAtJYAQfRqMLJlygo+gMmPS74\n sbPI65Fe+PTpt1ukH2MBBlCOD8tDeGKMa7yhaJXCLhsBeLBZaPtsffUCT\n w==;", "X-Mailman-Original-Authentication-Results": [ "smtp4.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com", "smtp4.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=fDZGk7k/" ], "Subject": "[Intel-wired-lan] [PATCH iwl-net] ice: fix adding AQ LLDP filter\n for VF", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "The referenced commit came from a misunderstanding of the FW LLDP filter\nAQ (Admin Queue) command due to the error in the internal documentation.\nContrary to the assumptions in the original commit, VFs can be added and\ndeleted from this filter without any problems. Introduced dev_info message\nproved to be useful, so reverting the whole commit does not make sense.\n\nWithout this fix, trusted VFs do not receive LLDP traffic, if there is an\nAQ LLDP filter on PF. When trusted VF attempts to add an LLDP multicast\nMAC address, the following message can be seen in dmesg on host:\n\nice 0000:33:00.0: Failed to add Rx LLDP rule on VSI 20 error: -95\n\nRevert checking VSI type when adding LLDP filter through AQ.\n\nFixes: 4d5a1c4e6d49 (\"ice: do not add LLDP-specific filter if not necessary\")\nReviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>\nSigned-off-by: Larysa Zaremba <larysa.zaremba@intel.com>\n---\n drivers/net/ethernet/intel/ice/ice_common.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ice/ice_common.c b/drivers/net/ethernet/intel/ice/ice_common.c\nindex c0a19f232538..0271822c1737 100644\n--- a/drivers/net/ethernet/intel/ice/ice_common.c\n+++ b/drivers/net/ethernet/intel/ice/ice_common.c\n@@ -6392,7 +6392,7 @@ int ice_lldp_fltr_add_remove(struct ice_hw *hw, struct ice_vsi *vsi, bool add)\n \tstruct ice_aqc_lldp_filter_ctrl *cmd;\n \tstruct libie_aq_desc desc;\n \n-\tif (vsi->type != ICE_VSI_PF || !ice_fw_supports_lldp_fltr_ctrl(hw))\n+\tif (!ice_fw_supports_lldp_fltr_ctrl(hw))\n \t\treturn -EOPNOTSUPP;\n \n \tcmd = libie_aq_raw(&desc);\n", "prefixes": [ "iwl-net" ] }