Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2169763/?format=api
{ "id": 2169763, "url": "http://patchwork.ozlabs.org/api/patches/2169763/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20251127152646.3283967-1-mwalle@kernel.org/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20251127152646.3283967-1-mwalle@kernel.org>", "list_archive_url": null, "date": "2025-11-27T15:25:27", "name": "net: phy: broadcom: fix RGMII delays for BCM54210E", "commit_ref": "7c1b99bd60185c24d2c78862c3345895ffcd1d71", "pull_url": null, "state": "accepted", "archived": false, "hash": "9126c18715fa30d9a8a369b5caaa51158b77cb82", "submitter": { "id": 86646, "url": "http://patchwork.ozlabs.org/api/people/86646/?format=api", "name": "Michael Walle", "email": "mwalle@kernel.org" }, "delegate": { "id": 157425, "url": "http://patchwork.ozlabs.org/api/users/157425/?format=api", "username": "jforissier", "first_name": "Jerome", "last_name": "Forissier", "email": "jerome.forissier@linaro.org" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20251127152646.3283967-1-mwalle@kernel.org/mbox/", "series": [ { "id": 483743, "url": "http://patchwork.ozlabs.org/api/series/483743/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=483743", "date": "2025-11-27T15:25:27", "name": "net: phy: broadcom: fix RGMII delays for BCM54210E", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/483743/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2169763/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2169763/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=mDYA+Vh4;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)", "phobos.denx.de;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.b=\"mDYA+Vh4\";\n\tdkim-atps=neutral", "phobos.denx.de; dmarc=pass (p=quarantine dis=none)\n header.from=kernel.org", "phobos.denx.de;\n spf=pass smtp.mailfrom=mwalle@kernel.org" ], "Received": [ "from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4dHKzc0dpSz1yDT\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 28 Nov 2025 02:27:08 +1100 (AEDT)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 7A42A8440A;\n\tThu, 27 Nov 2025 16:27:02 +0100 (CET)", "by phobos.denx.de (Postfix, from userid 109)\n id 7F4808440B; Thu, 27 Nov 2025 16:27:01 +0100 (CET)", "from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 2392A84409\n for <u-boot@lists.denx.de>; Thu, 27 Nov 2025 16:26:59 +0100 (CET)", "from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n by sea.source.kernel.org (Postfix) with ESMTP id 4C44244240;\n Thu, 27 Nov 2025 15:26:57 +0000 (UTC)", "by smtp.kernel.org (Postfix) with ESMTPSA id 5F446C116C6;\n Thu, 27 Nov 2025 15:26:55 +0000 (UTC)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-2.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED,\n RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n s=k20201202; t=1764257217;\n bh=N0EJ1Gug07yaTV3d1oefmkmcDZqoGdBXmhXklCnPpXw=;\n h=From:To:Cc:Subject:Date:From;\n b=mDYA+Vh4PftwDZPS0rtfFkDj0DqJO408Awruq875N5usyIwXylBlIR2NklJHUiRVa\n FZ/c4T7IMo2ortyhLD/VIDgmNF7NgUFCVisk+iiTkCRGgv5DgjpIP/KKs/6jFvVP9V\n up/qndT3WPvln1Bt6wZQYb7lFj73W1iYUJYBDEzaEZJRdLgDqJ7oNDt3Ju1n1ZoMLg\n uhsc/om34BwHiNQTIKAbVuLX5HdrJyLv5oXn8uMNFAOvtuI5ZBiVBUXo3BIFqkZW4D\n 2l4ikVXYJYVOewFCYdOKOTLjXEmD7EwdeaRDIWTwCURCdWYWkJKug3kLMCrjkbM3PH\n AClogGORUo2pg==", "From": "Michael Walle <mwalle@kernel.org>", "To": "Joe Hershberger <joe.hershberger@ni.com>,\n Ramon Fried <rfried.dev@gmail.com>,\n Jerome Forissier <jerome.forissier@linaro.org>,\n Tom Rini <trini@konsulko.com>", "Cc": "=?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= <rafal@milecki.pl>,\n Marek Vasut <marex@denx.de>, u-boot@lists.denx.de,\n Michael Walle <mwalle@kernel.org>", "Subject": "[PATCH] net: phy: broadcom: fix RGMII delays for BCM54210E", "Date": "Thu, 27 Nov 2025 16:25:27 +0100", "Message-ID": "<20251127152646.3283967-1-mwalle@kernel.org>", "X-Mailer": "git-send-email 2.47.3", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.8 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "bcm54210e_config() configures the RGMII delays and then calls\nbcm5461_config(). But the latter will do a PHY soft reset and thus\nresets the delay settings again. Call bcm5461_config() first to fix it.\n\nFixes: cba79a1b2e11 (\"net: phy: broadcom: add support for BCM54210E\")\nSigned-off-by: Michael Walle <mwalle@kernel.org>\n---\nOur board has rgmii-id set as PHY mode. Before commit 4b10bcfdef9c\n(\"net: ethernet: ti: am65-cpsw: fix up PHY mode for fixed RGMII TX\ndelay\") the delay on the MAC side would be disabled and masked the\nactual error. After that commit, the MAC side will always enable the TX\ndelay, but that then uncovered the wrong behavior of the PHY driver.\n---\n drivers/net/phy/broadcom.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/phy/broadcom.c b/drivers/net/phy/broadcom.c\nindex 1c02e3efedc..2d93ce0c966 100644\n--- a/drivers/net/phy/broadcom.c\n+++ b/drivers/net/phy/broadcom.c\n@@ -176,11 +176,11 @@ static int bcm54210e_config(struct phy_device *phydev)\n {\n \tint ret;\n \n-\tret = bcm54xx_config_clock_delay(phydev);\n+\tret = bcm5461_config(phydev);\n \tif (ret < 0)\n \t\treturn ret;\n \n-\tret = bcm5461_config(phydev);\n+\tret = bcm54xx_config_clock_delay(phydev);\n \tif (ret < 0)\n \t\treturn ret;\n \n", "prefixes": [] }