Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2167148/?format=api
{ "id": 2167148, "url": "http://patchwork.ozlabs.org/api/patches/2167148/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20251120083855.2350372-1-l.anderweit@phytec.de/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20251120083855.2350372-1-l.anderweit@phytec.de>", "list_archive_url": null, "date": "2025-11-20T08:38:55", "name": "[v2] net: tftp: Remove tftp_init_load_addr error path", "commit_ref": "c10e1c2eded4783b8f4650da879ebae2beffcce6", "pull_url": null, "state": "accepted", "archived": false, "hash": "960609fa80c551c0403970b9905a6034109ad9e2", "submitter": { "id": 88161, "url": "http://patchwork.ozlabs.org/api/people/88161/?format=api", "name": "Leonard Anderweit", "email": "l.anderweit@phytec.de" }, "delegate": { "id": 157425, "url": "http://patchwork.ozlabs.org/api/users/157425/?format=api", "username": "jforissier", "first_name": "Jerome", "last_name": "Forissier", "email": "jerome.forissier@linaro.org" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20251120083855.2350372-1-l.anderweit@phytec.de/mbox/", "series": [ { "id": 482896, "url": "http://patchwork.ozlabs.org/api/series/482896/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=482896", "date": "2025-11-20T08:38:55", "name": "[v2] net: tftp: Remove tftp_init_load_addr error path", "version": 2, "mbox": "http://patchwork.ozlabs.org/series/482896/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2167148/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2167148/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=phytec.de header.i=@phytec.de header.a=rsa-sha256\n header.s=selector2 header.b=QVUS3jD5;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)", "phobos.denx.de;\n dmarc=pass (p=quarantine dis=none) header.from=phytec.de", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=phytec.de header.i=@phytec.de header.b=\"QVUS3jD5\";\n\tdkim-atps=neutral", "phobos.denx.de; dmarc=pass (p=quarantine dis=none)\n header.from=phytec.de", "phobos.denx.de;\n spf=pass smtp.mailfrom=L.Anderweit@phytec.de" ], "Received": [ "from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (secp384r1))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4dBsGM4H1Lz1yDM\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 20 Nov 2025 19:39:23 +1100 (AEDT)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id E371E84067;\n\tThu, 20 Nov 2025 09:39:17 +0100 (CET)", "by phobos.denx.de (Postfix, from userid 109)\n id 4C5EF8406D; Thu, 20 Nov 2025 09:39:16 +0100 (CET)", "from AM0PR02CU008.outbound.protection.outlook.com\n (mail-westeuropeazlp170130006.outbound.protection.outlook.com\n [IPv6:2a01:111:f403:c201::6])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 4ED3384062\n for <u-boot@lists.denx.de>; Thu, 20 Nov 2025 09:39:11 +0100 (CET)", "from DU2P251CA0021.EURP251.PROD.OUTLOOK.COM (2603:10a6:10:230::24)\n by VI0P195MB3250.EURP195.PROD.OUTLOOK.COM (2603:10a6:800:31e::12) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9343.10; Thu, 20 Nov\n 2025 08:39:07 +0000", "from DB1PEPF000509E5.eurprd03.prod.outlook.com\n (2603:10a6:10:230:cafe::de) by DU2P251CA0021.outlook.office365.com\n (2603:10a6:10:230::24) with Microsoft SMTP Server (version=TLS1_3,\n cipher=TLS_AES_256_GCM_SHA384) id 15.20.9343.10 via Frontend Transport; Thu,\n 20 Nov 2025 08:39:03 +0000", "from Postix.phytec.de (91.26.50.189) by\n DB1PEPF000509E5.mail.protection.outlook.com (10.167.242.55) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.9343.9 via Frontend Transport; Thu, 20 Nov 2025 08:39:06 +0000", "from llp-anderweit.phytec.de (172.25.32.82) by Postix.phytec.de\n (172.25.0.11) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.29; Thu, 20 Nov\n 2025 09:39:06 +0100" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,\n SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2", "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=mlG/Rq+jL/lnwjzpR9p7HbGQGTkeZnY7rBgrKrwusjpgvxj4kVEtU7BHeahTGj3JnK82t8d9ty0Iuq0Dx4yZUzB6W+Ve6HYw/V8ASGNfotqzdTLjJVrC9TavxbZQybRdCHLz6JnNQeHetEd22U1kN6brSzlO3XN9GZq1/Y3WbA9meqadbxF4CWfPXyBApjnmAdCTFJ3KsFetq1H4xWlQY3wt5n4q+oYtdpfCqqzaE9oDf99SChQz7vppXT2SeWv+uLgKNDsspp2hwVxJLeROXVcs0rtwXinWpiPytPmzf6Kef0Xq80BxVdYKnnpZDC/UhT4h1OF3MDzqnAc/rcQ0Rw==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=J6nTtEVvPdM/vqRu/yOzCcHaVA2xo1+OVZO652EoXDQ=;\n b=OmkjgSSP5kHr6UdFk6qZB13CZyNjFLn5x8MAnblxY2ENg/cFJ7aHHXlYXPkqPuDF+NZq6dKoiOSP1JYhZaT4BZ+N8/pLc/2ElC8Cn6nAE3oY3T5bLbOfpiIw+7/G88avXwRK7hJNPG7jclpRxndo5a2BMQ/c9zafIzKJDaWQUAm63IjI4TPq3H0oxIti5VQn2kY8UASiTgCOrMvEcXwv5i47a7Ar1ccfRCprdJbm0F79Yynx7rRm9CCbNTjQ+XrIp2oAAyfxUHFjupYnLUIi/c3oWgxGFqPnaf188xBfsSrJl6iQb0Z4IZ6NADfOCuNd3BqnUC85u5+rv6TTpSRBAQ==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=softfail (sender ip\n is 91.26.50.189) smtp.rcpttodomain=lists.denx.de smtp.mailfrom=phytec.de;\n dmarc=fail (p=quarantine sp=quarantine pct=100) action=quarantine\n header.from=phytec.de; dkim=none (message not signed); arc=none (0)", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=phytec.de;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=J6nTtEVvPdM/vqRu/yOzCcHaVA2xo1+OVZO652EoXDQ=;\n b=QVUS3jD5myWCjKWrpvbSHaxf5eYF6bmyV0LtKpuvPhK3qQ/XSOLgK5jE0OI081B+kIfLi3VcmRmjsHT3s3zgwWTm5xC3WVb5mXe4NOpOBzDN8Hm1GQ/QpIymZmu0ShMa9azJ3o+VoIqSE+Zg8HEWk+QW7YXA/Sc9I0OTwJTmoCaXheRJDut8wYuD1bWaykMjiMB+YAd16zvPap4xXhnhVxmIdXOzQBcvt4WVBnaitUgZnxY81rr/dbXsUt24/M5zIqVWKyo/qz+LaMl/sl12tngflxMZI6g3O54X3AtCzWeCUuGTJYjan9U774cepLpyQpS6Oeztyppms4GaotBYyg==", "X-MS-Exchange-Authentication-Results": "spf=softfail (sender IP is 91.26.50.189)\n smtp.mailfrom=phytec.de;\n dkim=none (message not signed)\n header.d=none;dmarc=fail action=quarantine header.from=phytec.de;", "Received-SPF": "SoftFail (protection.outlook.com: domain of transitioning\n phytec.de discourages use of 91.26.50.189 as permitted sender)", "From": "Leonard Anderweit <l.anderweit@phytec.de>", "To": "<u-boot@lists.denx.de>", "CC": "<joe.hershberger@ni.com>, <rfried.dev@gmail.com>,\n <jerome.forissier@linaro.org>, <y.moog@phytec.de>", "Subject": "[PATCH v2] net: tftp: Remove tftp_init_load_addr error path", "Date": "Thu, 20 Nov 2025 09:38:55 +0100", "Message-ID": "<20251120083855.2350372-1-l.anderweit@phytec.de>", "X-Mailer": "git-send-email 2.43.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[172.25.32.82]", "X-ClientProxiedBy": "Postix.phytec.de (172.25.0.11) To Postix.phytec.de\n (172.25.0.11)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "DB1PEPF000509E5:EE_|VI0P195MB3250:EE_", "X-MS-Office365-Filtering-Correlation-Id": "fc20b8ff-414b-4c02-5ac2-08de28104475", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;\n ARA:13230040|36860700013|82310400026|1800799024|376014;", "X-Microsoft-Antispam-Message-Info": "\n YOZvfaSCC8fxljEbQAwD4KO3FmUfMLzaeoKQosP1fPmN1yADDiDLHC8Zp5LVPSBGAg5WZnUJIWgjS+1m+V+ZnBddJ0ZCh2gVqBKXqtP7P2fwmB2myu4WZB15vclyt6C1P6CjA/bpHFu7/M+KiT7Rh4HzbKcuS2BkeJHnSATqqOPT1rSgxId6hpLNC5sUVCve7x4259TdsxP0qlf8yOBk6s5LCm/s2LSEZfiwzHnDOId2Yx5NNpDI3HOlbe/1ilHxk7yocG/F4EagYbS6c+dXQNxn7bmzTVmy3FphQL90bqX1tm8XNIbSa2/n9RG/YzPVC4BllzQMzRHKozmz4V8zBUnIDZlrWqWvD8OSfiYiQWGNQhMwqfUYS0dQxYZd88aSfxQCCd+kUeEq7gofIPbSC9XfK2rd3EqF7PGk4z0ANM/88RFFZgPOmCn+budXnEOm9SOeiMOgb+nda9pUiWf6nmdbYi7WNrhgxw4eZsOotbtBOLS7Rc8Vwy73ZDPmb740McFGj6f35EUldJ5emSIfAGfydOYT6N90+EE4u9+eEFGB6/Vodk/0syqIK7Jmt1waJsJX7PvFMhP/TSHka021OSyxY496X7I19XG67YZNn6a1t1OjXiTEg9t3TPvNtGT/brHO9wBcyNSq8Ucq2tt+089mwTr/Oq1CL+d/1TNnOg6mGSOI7v16nZl0kIDlGzJ08LXQWiZoJdqWeJTl/HP+s40eB+OR+pnyWC6H79YYLOxNQQ+8RTWNYOJYeQEkJSmWZnkj7U6nZn2xJ1kPfXupbNWyDYN/37f8NOiNNo2GTcAnn1XYgdEKToY9JrQycTqqT6/IASEokXa1/7df0MUlCS+1Op0agRtEgctCr51NLlfpM3XiYc35DiZQ+e513TWrdaNfnOWHrwRxha6FUW1KQxrC/y5dA93jNHLREM3bJItuoDy84gSvcZ+BpcxcIskaBWQo56b9gucc2WsHGtcWjP+hA5lGh7apwmjWZZ4NrhII8uCjicmOZfoCphD4y7pScenFkS02xK0VQJ9+wcRnGSjBrWJ0lsuYcArOfhWwmOklD0O/vAK45wyrkLhvaFcB3DmB0xBBvFkjPGXMkqk2zL6b3bdnXT3eLAn59X7pt2RYByZU+trBmmgHPI2PfV7RxDA9wPgkVr38NblvF6YYuRU9bOqpfLLHwYFO5KoOnPM9eiAbVNLicx9L2kkqB5cSTtQ+22OB0TkzRpoY/96LBMw6UPAjhTQRgawm5Bmj6BD2JgsDJ03n78gUfh2aLzufbi34G4YQMxqPE1MmoqCgtpmv2aAOs3201TPNDCKNaCWr/6OV828/iARp5t9AcdF6gCiLkb6jh/8M1aLPw845cGBq/RkTbwzPTvcBHRbK1UAoDS18hojaLV8Kb8pTxpKpRwVJF38yCDvAJ93Fa9/nGNbECXoEIUHjmUuD08qEdVSS5MKTLSJIKu7UMWAv3C0nLj1gBrxdZsT/Pvj+AclP5gdfnCjMv1inkzAO2wb4dt6pJ9z5uxi+AoWLh+PYF9KOT2C6zAiwvHJvU8cRNsOU4mIyCg2L5lMvdjt9p0i/pnM=", "X-Forefront-Antispam-Report": "CIP:91.26.50.189; CTRY:DE; LANG:en; SCL:1; SRV:;\n IPV:CAL; SFV:NSPM; H:Postix.phytec.de; PTR:InfoDomainNonexistent; CAT:NONE;\n SFS:(13230040)(36860700013)(82310400026)(1800799024)(376014); DIR:OUT;\n SFP:1102;", "X-OriginatorOrg": "phytec.de", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "20 Nov 2025 08:39:06.5624 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n fc20b8ff-414b-4c02-5ac2-08de28104475", "X-MS-Exchange-CrossTenant-Id": "e609157c-80e2-446d-9be3-9c99c2399d29", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=e609157c-80e2-446d-9be3-9c99c2399d29; Ip=[91.26.50.189];\n Helo=[Postix.phytec.de]", "X-MS-Exchange-CrossTenant-AuthSource": "\n DB1PEPF000509E5.eurprd03.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "VI0P195MB3250", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.8 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "tftp_init_load_addr() always returns 0 since commit af45c84871e4 (\"tftp:\nrework the logic to validate the load address\"), so we don't need to\ncheck if it failed and can remove the error handling.\nAlso change tftp_init_load_addr() to static void since the return value\nis now unused.\n\nSigned-off-by: Leonard Anderweit <l.anderweit@phytec.de>\n---\nv2: change tftp_init_load_addr() to static void as suggested by Yannic\n---\n net/tftp.c | 18 +++---------------\n 1 file changed, 3 insertions(+), 15 deletions(-)", "diff": "diff --git a/net/tftp.c b/net/tftp.c\nindex 1760877107fa..3b0f4cd2006e 100644\n--- a/net/tftp.c\n+++ b/net/tftp.c\n@@ -714,10 +714,9 @@ static void tftp_timeout_handler(void)\n \t}\n }\n \n-static int tftp_init_load_addr(void)\n+static void tftp_init_load_addr(void)\n {\n \ttftp_load_addr = image_load_addr;\n-\treturn 0;\n }\n \n static int saved_tftp_block_size_option;\n@@ -901,13 +900,7 @@ void tftp_start(enum proto_t protocol)\n \t} else\n #endif\n \t{\n-\t\tif (tftp_init_load_addr()) {\n-\t\t\teth_halt();\n-\t\t\tnet_set_state(NETLOOP_FAIL);\n-\t\t\tputs(\"\\nTFTP error: \");\n-\t\t\tputs(\"trying to overwrite reserved memory...\\n\");\n-\t\t\treturn;\n-\t\t}\n+\t\ttftp_init_load_addr();\n \t\tprintf(\"Load address: 0x%lx\\n\", tftp_load_addr);\n \t\tputs(\"Loading: *\\b\");\n \t\ttftp_state = STATE_SEND_RRQ;\n@@ -953,12 +946,7 @@ void tftp_start_server(void)\n {\n \ttftp_filename[0] = 0;\n \n-\tif (tftp_init_load_addr()) {\n-\t\teth_halt();\n-\t\tnet_set_state(NETLOOP_FAIL);\n-\t\tputs(\"\\nTFTP error: trying to overwrite reserved memory...\\n\");\n-\t\treturn;\n-\t}\n+\ttftp_init_load_addr();\n \tprintf(\"Using %s device\\n\", eth_get_name());\n \tprintf(\"Listening for TFTP transfer on %pI4\\n\", &net_ip);\n \tprintf(\"Load address: 0x%lx\\n\", tftp_load_addr);\n", "prefixes": [ "v2" ] }