Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2165664/?format=api
{ "id": 2165664, "url": "http://patchwork.ozlabs.org/api/patches/2165664/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20251117134912.18566-11-larysa.zaremba@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20251117134912.18566-11-larysa.zaremba@intel.com>", "list_archive_url": null, "date": "2025-11-17T13:48:50", "name": "[iwl-next,v5,10/15] idpf: make mbx_task queueing and cancelling more consistent", "commit_ref": null, "pull_url": null, "state": "under-review", "archived": false, "hash": "48f2cc01b811de20319d151441e66b2934d29064", "submitter": { "id": 84900, "url": "http://patchwork.ozlabs.org/api/people/84900/?format=api", "name": "Larysa Zaremba", "email": "larysa.zaremba@intel.com" }, "delegate": { "id": 109701, "url": "http://patchwork.ozlabs.org/api/users/109701/?format=api", "username": "anguy11", "first_name": "Anthony", "last_name": "Nguyen", "email": "anthony.l.nguyen@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20251117134912.18566-11-larysa.zaremba@intel.com/mbox/", "series": [ { "id": 482391, "url": "http://patchwork.ozlabs.org/api/series/482391/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=482391", "date": "2025-11-17T13:48:40", "name": "Introduce iXD driver", "version": 5, "mbox": "http://patchwork.ozlabs.org/series/482391/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2165664/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2165664/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=itHsPAKI;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::136; helo=smtp3.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4d98Hs2WLYz1yDb\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 18 Nov 2025 00:49:45 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id DEBB460DA1;\n\tMon, 17 Nov 2025 13:49:43 +0000 (UTC)", "from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id jdWKtX__nazn; Mon, 17 Nov 2025 13:49:41 +0000 (UTC)", "from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id B575060A9D;\n\tMon, 17 Nov 2025 13:49:41 +0000 (UTC)", "from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n by lists1.osuosl.org (Postfix) with ESMTP id DE7DB158\n for <intel-wired-lan@lists.osuosl.org>; Mon, 17 Nov 2025 13:49:39 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp3.osuosl.org (Postfix) with ESMTP id C4C2660A9D\n for <intel-wired-lan@lists.osuosl.org>; Mon, 17 Nov 2025 13:49:39 +0000 (UTC)", "from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id JE9ggLcqMsF7 for <intel-wired-lan@lists.osuosl.org>;\n Mon, 17 Nov 2025 13:49:39 +0000 (UTC)", "from mgamail.intel.com (mgamail.intel.com [198.175.65.12])\n by smtp3.osuosl.org (Postfix) with ESMTPS id CED8560DBD\n for <intel-wired-lan@lists.osuosl.org>; Mon, 17 Nov 2025 13:49:38 +0000 (UTC)", "from fmviesa007.fm.intel.com ([10.60.135.147])\n by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 17 Nov 2025 05:49:38 -0800", "from irvmail002.ir.intel.com ([10.43.11.120])\n by fmviesa007.fm.intel.com with ESMTP; 17 Nov 2025 05:49:33 -0800", "from mglak.igk.intel.com (mglak.igk.intel.com [10.237.112.146])\n by irvmail002.ir.intel.com (Postfix) with ESMTP id 4653237E27;\n Mon, 17 Nov 2025 13:49:31 +0000 (GMT)" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp3.osuosl.org B575060A9D", "OpenDKIM Filter v2.11.0 smtp3.osuosl.org CED8560DBD" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1763387381;\n\tbh=ynBTcBOUywIIRfZBc/Bjjjlz5AI7qbVHgHQDinHWIKk=;\n\th=From:To:Cc:Date:In-Reply-To:References:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=itHsPAKIRXwRIc1ulS14/xs+3XVimk029kyN8782Hr6UYeoW4l0PoIHTJvYVHdg0k\n\t x+zVwaIXrEFvkTsXiN0up/SsU0PJdf2XURoT26vaGbjjNUSnUo6JJ5Mp0KxGoGOAJC\n\t 8R8ESd6ANS+2Cly+MGiR/wcsn9dDShgNjpltXMf9JS2xmpFKS/kXb11P44pJ8P/4Oq\n\t Ma4Bs25Ha4vH15PveX/8F6FiqDP1UjHFEfDjSvAwdMDRVvgeKcOxU2yMaDO2LKjgqp\n\t cblM9Rzvk7h1Qdk0Q1mzUL7UDUhD/8LXYX6PLFZWPiTRLSUjksXnUf9Emi6xtcytQT\n\t 322hFlcZ0G53w==", "Received-SPF": "Pass (mailfrom) identity=mailfrom; client-ip=198.175.65.12;\n helo=mgamail.intel.com; envelope-from=larysa.zaremba@intel.com;\n receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp3.osuosl.org CED8560DBD", "X-CSE-ConnectionGUID": [ "HJSUgAuLSKGu5JarxUJQFg==", "LtfNC6LtQmGH0+DBY8JSQw==" ], "X-CSE-MsgGUID": [ "RFnpdMgeSWaOoqhQmNyezw==", "qgFF5fAWQlq0dDQ584hcDA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6800,10657,11616\"; a=\"76846146\"", "E=Sophos;i=\"6.19,311,1754982000\"; d=\"scan'208\";a=\"76846146\"", "E=Sophos;i=\"6.19,311,1754982000\"; d=\"scan'208\";a=\"190115729\"" ], "X-ExtLoop1": "1", "From": "Larysa Zaremba <larysa.zaremba@intel.com>", "To": "intel-wired-lan@lists.osuosl.org, Tony Nguyen <anthony.l.nguyen@intel.com>", "Cc": "aleksander.lobakin@intel.com, sridhar.samudrala@intel.com,\n \"Singhai, Anjali\" <anjali.singhai@intel.com>,\n Michal Swiatkowski <michal.swiatkowski@linux.intel.com>,\n Larysa Zaremba <larysa.zaremba@intel.com>,\n \"Fijalkowski, Maciej\" <maciej.fijalkowski@intel.com>,\n Emil Tantilov <emil.s.tantilov@intel.com>,\n Madhu Chittim <madhu.chittim@intel.com>, Josh Hay <joshua.a.hay@intel.com>,\n \"Keller, Jacob E\" <jacob.e.keller@intel.com>,\n jayaprakash.shanmugam@intel.com, natalia.wochtman@intel.com,\n Jiri Pirko <jiri@resnulli.us>, \"David S. Miller\" <davem@davemloft.net>,\n Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>,\n Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,\n Jonathan Corbet <corbet@lwn.net>,\n Richard Cochran <richardcochran@gmail.com>,\n Przemek Kitszel <przemyslaw.kitszel@intel.com>,\n Andrew Lunn <andrew+netdev@lunn.ch>, netdev@vger.kernel.org,\n linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org", "Date": "Mon, 17 Nov 2025 14:48:50 +0100", "Message-ID": "<20251117134912.18566-11-larysa.zaremba@intel.com>", "X-Mailer": "git-send-email 2.47.0", "In-Reply-To": "<20251117134912.18566-1-larysa.zaremba@intel.com>", "References": "<20251117134912.18566-1-larysa.zaremba@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Original-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1763387379; x=1794923379;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=ha2cZqnqoOqC1BjF4usRNgGdbwHK2tuvQLG/0LBxuLg=;\n b=ZMwZwETPm7rFkrucG7dI5y1E9mTBT4nV2Rh1GKGeoSygHC0pEbT8FBje\n VBCnEpU8HLt7BpYYksQGgfvZOL1U045KvUv+b9rrAZERigkOAEXgRaPD6\n RS0cZ6ny00EWmLWZMRcaswt8Ahl5PuILwOUaRUc1Jdg4HFw1jW3HkB14y\n pxMUbt+rUD3DnO+3PA+QqgNo04DckRzx4zIHm22oan8dyJ0gczT+HbJjC\n RtuTjs3ZuBNa1U6l6MSFkcLPNH1Dwj6+md8kF/e8gomnmZV6jF+KCfuHs\n L+KfuSIU+ReYUH/DiZ+HKhmFQqOOr8qqrrQmsvRvasE4xecqDoU0mb/sV\n A==;", "X-Mailman-Original-Authentication-Results": [ "smtp3.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com", "smtp3.osuosl.org;\n dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.a=rsa-sha256 header.s=Intel header.b=ZMwZwETP" ], "Subject": "[Intel-wired-lan] [PATCH iwl-next v5 10/15] idpf: make mbx_task\n queueing and cancelling more consistent", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "As a consequence of refactoring idpf code to use libeth APIs,\nidpf_vc_xn_shutdown was merged with and replaced by idpf_deinit_dflt_mbx.\nThis does not affect the Tx path, as it checked for a presence of an xn\nmanager anyway. Rx processing is handled by the mbx_task that is not always\ncancelled before calling the new consolidated mailbox deinit function.\nMoreover, in the reset path idpf_intr_rel() reschedules it after the deinit\nis done. This leads to mbx_task referencing the freed mailbox and causing\nKASAN warnings.\n\nTo remedy this, in the init path, do the first queueing of mbx_task in\nidpf_init_dflt_mbx(), in deinit and reset, always cancel the task in\nidpf_deinit_dflt_mbx() and in every flow first call idpf_mb_intr_rel_irq().\n\nReviewed-by: Emil Tantilov <emil.s.tantilov@intel.com>\nReviewed-by: Michal Kubiak <michal.kubiak@intel.com>\nSigned-off-by: Larysa Zaremba <larysa.zaremba@intel.com>\n---\n drivers/net/ethernet/intel/idpf/idpf.h | 1 +\n drivers/net/ethernet/intel/idpf/idpf_lib.c | 9 ++++-----\n drivers/net/ethernet/intel/idpf/idpf_virtchnl.c | 6 +++++-\n 3 files changed, 10 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/idpf/idpf.h b/drivers/net/ethernet/intel/idpf/idpf.h\nindex 0594f4a30f23..c9c681a7f4b9 100644\n--- a/drivers/net/ethernet/intel/idpf/idpf.h\n+++ b/drivers/net/ethernet/intel/idpf/idpf.h\n@@ -984,6 +984,7 @@ void idpf_vc_event_task(struct work_struct *work);\n void idpf_dev_ops_init(struct idpf_adapter *adapter);\n void idpf_vf_dev_ops_init(struct idpf_adapter *adapter);\n int idpf_intr_req(struct idpf_adapter *adapter);\n+void idpf_mb_intr_rel_irq(struct idpf_adapter *adapter);\n void idpf_intr_rel(struct idpf_adapter *adapter);\n u16 idpf_get_max_tx_hdr_size(struct idpf_adapter *adapter);\n int idpf_initiate_soft_reset(struct idpf_vport *vport,\ndiff --git a/drivers/net/ethernet/intel/idpf/idpf_lib.c b/drivers/net/ethernet/intel/idpf/idpf_lib.c\nindex 7751a81fc29d..69eb72ed6b99 100644\n--- a/drivers/net/ethernet/intel/idpf/idpf_lib.c\n+++ b/drivers/net/ethernet/intel/idpf/idpf_lib.c\n@@ -68,9 +68,11 @@ static void idpf_deinit_vector_stack(struct idpf_adapter *adapter)\n * This will also disable interrupt mode and queue up mailbox task. Mailbox\n * task will reschedule itself if not in interrupt mode.\n */\n-static void idpf_mb_intr_rel_irq(struct idpf_adapter *adapter)\n+void idpf_mb_intr_rel_irq(struct idpf_adapter *adapter)\n {\n-\tclear_bit(IDPF_MB_INTR_MODE, adapter->flags);\n+\tif (!test_and_clear_bit(IDPF_MB_INTR_MODE, adapter->flags))\n+\t\treturn;\n+\n \tkfree(free_irq(adapter->msix_entries[0].vector, adapter));\n \tqueue_delayed_work(adapter->mbx_wq, &adapter->mbx_task, 0);\n }\n@@ -1936,14 +1938,11 @@ static void idpf_init_hard_reset(struct idpf_adapter *adapter)\n \t\tgoto unlock_mutex;\n \t}\n \n-\tqueue_delayed_work(adapter->mbx_wq, &adapter->mbx_task, 0);\n-\n \t/* Initialize the state machine, also allocate memory and request\n \t * resources\n \t */\n \terr = idpf_vc_core_init(adapter);\n \tif (err) {\n-\t\tcancel_delayed_work_sync(&adapter->mbx_task);\n \t\tidpf_deinit_dflt_mbx(adapter);\n \t\tgoto unlock_mutex;\n \t}\ndiff --git a/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c b/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c\nindex 132bbe5b9d7d..1099a44314ea 100644\n--- a/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c\n+++ b/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c\n@@ -2921,6 +2921,8 @@ int idpf_init_dflt_mbx(struct idpf_adapter *adapter)\n \tadapter->xn_init_params.xnm = params.xnm;\n \tadapter->state = __IDPF_VER_CHECK;\n \n+\tqueue_delayed_work(adapter->mbx_wq, &adapter->mbx_task, 0);\n+\n \treturn 0;\n }\n \n@@ -2930,6 +2932,9 @@ int idpf_init_dflt_mbx(struct idpf_adapter *adapter)\n */\n void idpf_deinit_dflt_mbx(struct idpf_adapter *adapter)\n {\n+\tidpf_mb_intr_rel_irq(adapter);\n+\tcancel_delayed_work_sync(&adapter->mbx_task);\n+\n \tif (adapter->arq && adapter->asq) {\n \t\tidpf_mb_clean(adapter, adapter->asq);\n \t\tlibie_ctlq_xn_deinit(adapter->xn_init_params.xnm,\n@@ -3189,7 +3194,6 @@ void idpf_vc_core_deinit(struct idpf_adapter *adapter)\n \t\tidpf_deinit_dflt_mbx(adapter);\n \n \tcancel_delayed_work_sync(&adapter->serv_task);\n-\tcancel_delayed_work_sync(&adapter->mbx_task);\n \n \tidpf_vport_params_buf_rel(adapter);\n \n", "prefixes": [ "iwl-next", "v5", "10/15" ] }