Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2165661/?format=api
{ "id": 2165661, "url": "http://patchwork.ozlabs.org/api/patches/2165661/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20251117134912.18566-8-larysa.zaremba@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20251117134912.18566-8-larysa.zaremba@intel.com>", "list_archive_url": null, "date": "2025-11-17T13:48:47", "name": "[iwl-next,v5,07/15] idpf: remove 'vport_params_reqd' field", "commit_ref": null, "pull_url": null, "state": "under-review", "archived": false, "hash": "d4edee545768f563159e3981e99b30be667e1d9b", "submitter": { "id": 84900, "url": "http://patchwork.ozlabs.org/api/people/84900/?format=api", "name": "Larysa Zaremba", "email": "larysa.zaremba@intel.com" }, "delegate": { "id": 109701, "url": "http://patchwork.ozlabs.org/api/users/109701/?format=api", "username": "anguy11", "first_name": "Anthony", "last_name": "Nguyen", "email": "anthony.l.nguyen@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20251117134912.18566-8-larysa.zaremba@intel.com/mbox/", "series": [ { "id": 482391, "url": "http://patchwork.ozlabs.org/api/series/482391/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=482391", "date": "2025-11-17T13:48:40", "name": "Introduce iXD driver", "version": 5, "mbox": "http://patchwork.ozlabs.org/series/482391/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2165661/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2165661/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@legolas.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=V/iqyH/r;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::138; helo=smtp1.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)" ], "Received": [ "from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4d98Hk3kcjz1yDb\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 18 Nov 2025 00:49:38 +1100 (AEDT)", "from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 3803D80C44;\n\tMon, 17 Nov 2025 13:49:35 +0000 (UTC)", "from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id qXEGmEnqwgjU; Mon, 17 Nov 2025 13:49:34 +0000 (UTC)", "from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 8C24A80C4A;\n\tMon, 17 Nov 2025 13:49:34 +0000 (UTC)", "from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n by lists1.osuosl.org (Postfix) with ESMTP id 701AC158\n for <intel-wired-lan@lists.osuosl.org>; Mon, 17 Nov 2025 13:49:33 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n by smtp3.osuosl.org (Postfix) with ESMTP id 6CDBB60717\n for <intel-wired-lan@lists.osuosl.org>; Mon, 17 Nov 2025 13:49:33 +0000 (UTC)", "from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id qxClgo4Rh9Gd for <intel-wired-lan@lists.osuosl.org>;\n Mon, 17 Nov 2025 13:49:32 +0000 (UTC)", "from mgamail.intel.com (mgamail.intel.com [198.175.65.12])\n by smtp3.osuosl.org (Postfix) with ESMTPS id B18D060DA3\n for <intel-wired-lan@lists.osuosl.org>; Mon, 17 Nov 2025 13:49:32 +0000 (UTC)", "from fmviesa007.fm.intel.com ([10.60.135.147])\n by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 17 Nov 2025 05:49:32 -0800", "from irvmail002.ir.intel.com ([10.43.11.120])\n by fmviesa007.fm.intel.com with ESMTP; 17 Nov 2025 05:49:27 -0800", "from mglak.igk.intel.com (mglak.igk.intel.com [10.237.112.146])\n by irvmail002.ir.intel.com (Postfix) with ESMTP id 6703737E39;\n Mon, 17 Nov 2025 13:49:25 +0000 (GMT)" ], "X-Virus-Scanned": [ "amavis at osuosl.org", "amavis at osuosl.org" ], "X-Comment": "SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ", "DKIM-Filter": [ "OpenDKIM Filter v2.11.0 smtp1.osuosl.org 8C24A80C4A", "OpenDKIM Filter v2.11.0 smtp3.osuosl.org B18D060DA3" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1763387374;\n\tbh=9D6sqGVmdRf8S4UEtMvugk1zD8ErP/WQ+qvJpCnSqfA=;\n\th=From:To:Cc:Date:In-Reply-To:References:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=V/iqyH/r+RjfuLqbNbySayCn90BKWTO/NK6jOIPz0OpiPPT9YaYMixltmeZVTvAYZ\n\t fuXnzOXBlgsDA0BIkkVewFJsH0OOKaiJs2BlZDS29LA425t0a/V5ub7BvgQSt3Bsbm\n\t veDEcrY6L3JLxaPYZf6znIUdxDqKHiOjIwzVesndvd3Wp60L5U39Fj5aGScd52yARY\n\t 8JbB7FzuXLiCaFVbhAtw4LlNy4Fxh4VNQRWVJN27QOPUPpLSEI0H8/NL5y80ttuG9Z\n\t 2e/Twz1VQINwiAtxUL+abBye0Rl5kttl0NRqdYxanzE4dRvQLX/Mp3V0yVK1NR1dQO\n\t EMQFHUumCvbQg==", "Received-SPF": "Pass (mailfrom) identity=mailfrom; client-ip=198.175.65.12;\n helo=mgamail.intel.com; envelope-from=larysa.zaremba@intel.com;\n receiver=<UNKNOWN>", "DMARC-Filter": "OpenDMARC Filter v1.4.2 smtp3.osuosl.org B18D060DA3", "X-CSE-ConnectionGUID": [ "nDRlpV6MQ/W1L7tyYLqHog==", "Goufk0rKSwGVslBcXLfDtA==" ], "X-CSE-MsgGUID": [ "kau4JmSJS2yul0zI1T2F6w==", "WnZwOg0/SvK4pn8ETbY8gA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6800,10657,11616\"; a=\"76846117\"", "E=Sophos;i=\"6.19,311,1754982000\"; d=\"scan'208\";a=\"76846117\"", "E=Sophos;i=\"6.19,311,1754982000\"; d=\"scan'208\";a=\"190115719\"" ], "X-ExtLoop1": "1", "From": "Larysa Zaremba <larysa.zaremba@intel.com>", "To": "intel-wired-lan@lists.osuosl.org, Tony Nguyen <anthony.l.nguyen@intel.com>", "Cc": "aleksander.lobakin@intel.com, sridhar.samudrala@intel.com,\n \"Singhai, Anjali\" <anjali.singhai@intel.com>,\n Michal Swiatkowski <michal.swiatkowski@linux.intel.com>,\n Larysa Zaremba <larysa.zaremba@intel.com>,\n \"Fijalkowski, Maciej\" <maciej.fijalkowski@intel.com>,\n Emil Tantilov <emil.s.tantilov@intel.com>,\n Madhu Chittim <madhu.chittim@intel.com>, Josh Hay <joshua.a.hay@intel.com>,\n \"Keller, Jacob E\" <jacob.e.keller@intel.com>,\n jayaprakash.shanmugam@intel.com, natalia.wochtman@intel.com,\n Jiri Pirko <jiri@resnulli.us>, \"David S. Miller\" <davem@davemloft.net>,\n Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>,\n Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,\n Jonathan Corbet <corbet@lwn.net>,\n Richard Cochran <richardcochran@gmail.com>,\n Przemek Kitszel <przemyslaw.kitszel@intel.com>,\n Andrew Lunn <andrew+netdev@lunn.ch>, netdev@vger.kernel.org,\n linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org", "Date": "Mon, 17 Nov 2025 14:48:47 +0100", "Message-ID": "<20251117134912.18566-8-larysa.zaremba@intel.com>", "X-Mailer": "git-send-email 2.47.0", "In-Reply-To": "<20251117134912.18566-1-larysa.zaremba@intel.com>", "References": "<20251117134912.18566-1-larysa.zaremba@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Original-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1763387373; x=1794923373;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=KyIMXsqbQ/CLB4hCnfdeMDbuBOyaNAGAafbhW0WEGtU=;\n b=YJted9ByLi3PuCpRdgijcEVa21fCFE4WPbXC2uwm59KvV90+S5lajhtx\n E40rgVaiCbtpaZ9MrkoC3h+fOT/poil3Yb+0LP94yhH7pHgwiGjYGV9S7\n INqY8uEpWR/lVdXOpG/EFB+ckaJ2ulFQf0+S71P44iL3e6oqvGGeDlA75\n RGWuTYvahDHUht2b52w4FSqM3xwQJSjRaOeAA0Lru+ggy/mgiQMx7bL8I\n /M8pyFwXXC/eMsEueAJGEwK/haQN+JEnW/CQ7faGNXhxq85l/K9xcSg6C\n ljkn5piYAG1eue0oHe+xd95CGYJ2RzHI+yZuaPrMyiZBPtd/OszSw2+HP\n Q==;", "X-Mailman-Original-Authentication-Results": [ "smtp3.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com", "smtp3.osuosl.org;\n dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.a=rsa-sha256 header.s=Intel header.b=YJted9By" ], "Subject": "[Intel-wired-lan] [PATCH iwl-next v5 07/15] idpf: remove\n 'vport_params_reqd' field", "X-BeenThere": "intel-wired-lan@osuosl.org", "X-Mailman-Version": "2.1.30", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>", "List-Unsubscribe": "<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@osuosl.org?subject=help>", "List-Subscribe": "<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>", "Errors-To": "intel-wired-lan-bounces@osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>" }, "content": "From: Pavan Kumar Linga <pavan.kumar.linga@intel.com>\n\nWhile sending a create vport message to the device control plane, a create\nvport virtchnl message is prepared with all the required info to initialize\nthe vport. This info is stored in the adapter struct but never used\nthereafter. So, remove the said field.\n\nSigned-off-by: Pavan Kumar Linga <pavan.kumar.linga@intel.com>\nReviewed-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>\nReviewed-by: Madhu Chittim <madhu.chittim@intel.com>\nSigned-off-by: Larysa Zaremba <larysa.zaremba@intel.com>\n---\n drivers/net/ethernet/intel/idpf/idpf.h | 2 --\n drivers/net/ethernet/intel/idpf/idpf_lib.c | 2 --\n .../net/ethernet/intel/idpf/idpf_virtchnl.c | 31 ++++++-------------\n 3 files changed, 10 insertions(+), 25 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/idpf/idpf.h b/drivers/net/ethernet/intel/idpf/idpf.h\nindex 78e55baf4600..1a1ea3fef092 100644\n--- a/drivers/net/ethernet/intel/idpf/idpf.h\n+++ b/drivers/net/ethernet/intel/idpf/idpf.h\n@@ -638,7 +638,6 @@ struct idpf_vc_xn_manager;\n * @avail_queues: Device given queue limits\n * @vports: Array to store vports created by the driver\n * @netdevs: Associated Vport netdevs\n- * @vport_params_reqd: Vport params requested\n * @vport_params_recvd: Vport params received\n * @vport_ids: Array of device given vport identifiers\n * @singleq_pt_lkup: Lookup table for singleq RX ptypes\n@@ -697,7 +696,6 @@ struct idpf_adapter {\n \tstruct idpf_avail_queue_info avail_queues;\n \tstruct idpf_vport **vports;\n \tstruct net_device **netdevs;\n-\tstruct virtchnl2_create_vport **vport_params_reqd;\n \tstruct virtchnl2_create_vport **vport_params_recvd;\n \tu32 *vport_ids;\n \ndiff --git a/drivers/net/ethernet/intel/idpf/idpf_lib.c b/drivers/net/ethernet/intel/idpf/idpf_lib.c\nindex 36a53c9e08c2..dca7861a0a2a 100644\n--- a/drivers/net/ethernet/intel/idpf/idpf_lib.c\n+++ b/drivers/net/ethernet/intel/idpf/idpf_lib.c\n@@ -1111,8 +1111,6 @@ static void idpf_vport_rel(struct idpf_vport *vport)\n \n \tkfree(adapter->vport_params_recvd[idx]);\n \tadapter->vport_params_recvd[idx] = NULL;\n-\tkfree(adapter->vport_params_reqd[idx]);\n-\tadapter->vport_params_reqd[idx] = NULL;\n \n \tkfree(vport);\n \tadapter->num_alloc_vports--;\ndiff --git a/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c b/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c\nindex a53689885c8c..eb834f29ff77 100644\n--- a/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c\n+++ b/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c\n@@ -1548,14 +1548,10 @@ int idpf_send_create_vport_msg(struct idpf_adapter *adapter,\n \tssize_t reply_sz;\n \n \tbuf_size = sizeof(struct virtchnl2_create_vport);\n-\tif (!adapter->vport_params_reqd[idx]) {\n-\t\tadapter->vport_params_reqd[idx] = kzalloc(buf_size,\n-\t\t\t\t\t\t\t GFP_KERNEL);\n-\t\tif (!adapter->vport_params_reqd[idx])\n-\t\t\treturn -ENOMEM;\n-\t}\n+\tvport_msg = kzalloc(buf_size, GFP_KERNEL);\n+\tif (!vport_msg)\n+\t\treturn -ENOMEM;\n \n-\tvport_msg = adapter->vport_params_reqd[idx];\n \tvport_msg->vport_type = cpu_to_le16(VIRTCHNL2_VPORT_TYPE_DEFAULT);\n \tvport_msg->vport_index = cpu_to_le16(idx);\n \n@@ -1572,8 +1568,7 @@ int idpf_send_create_vport_msg(struct idpf_adapter *adapter,\n \terr = idpf_vport_calc_total_qs(adapter, idx, vport_msg, max_q);\n \tif (err) {\n \t\tdev_err(&adapter->pdev->dev, \"Enough queues are not available\");\n-\n-\t\treturn err;\n+\t\tgoto rel_buf;\n \t}\n \n \tif (!adapter->vport_params_recvd[idx]) {\n@@ -1581,7 +1576,7 @@ int idpf_send_create_vport_msg(struct idpf_adapter *adapter,\n \t\t\t\t\t\t\t GFP_KERNEL);\n \t\tif (!adapter->vport_params_recvd[idx]) {\n \t\t\terr = -ENOMEM;\n-\t\t\tgoto free_vport_params;\n+\t\t\tgoto rel_buf;\n \t\t}\n \t}\n \n@@ -1597,13 +1592,15 @@ int idpf_send_create_vport_msg(struct idpf_adapter *adapter,\n \t\tgoto free_vport_params;\n \t}\n \n+\tkfree(vport_msg);\n+\n \treturn 0;\n \n free_vport_params:\n \tkfree(adapter->vport_params_recvd[idx]);\n \tadapter->vport_params_recvd[idx] = NULL;\n-\tkfree(adapter->vport_params_reqd[idx]);\n-\tadapter->vport_params_reqd[idx] = NULL;\n+rel_buf:\n+\tkfree(vport_msg);\n \n \treturn err;\n }\n@@ -3401,8 +3398,6 @@ static void idpf_vport_params_buf_rel(struct idpf_adapter *adapter)\n {\n \tkfree(adapter->vport_params_recvd);\n \tadapter->vport_params_recvd = NULL;\n-\tkfree(adapter->vport_params_reqd);\n-\tadapter->vport_params_reqd = NULL;\n \tkfree(adapter->vport_ids);\n \tadapter->vport_ids = NULL;\n }\n@@ -3417,17 +3412,11 @@ static int idpf_vport_params_buf_alloc(struct idpf_adapter *adapter)\n {\n \tu16 num_max_vports = idpf_get_max_vports(adapter);\n \n-\tadapter->vport_params_reqd = kcalloc(num_max_vports,\n-\t\t\t\t\t sizeof(*adapter->vport_params_reqd),\n-\t\t\t\t\t GFP_KERNEL);\n-\tif (!adapter->vport_params_reqd)\n-\t\treturn -ENOMEM;\n-\n \tadapter->vport_params_recvd = kcalloc(num_max_vports,\n \t\t\t\t\t sizeof(*adapter->vport_params_recvd),\n \t\t\t\t\t GFP_KERNEL);\n \tif (!adapter->vport_params_recvd)\n-\t\tgoto err_mem;\n+\t\treturn -ENOMEM;\n \n \tadapter->vport_ids = kcalloc(num_max_vports, sizeof(u32), GFP_KERNEL);\n \tif (!adapter->vport_ids)\n", "prefixes": [ "iwl-next", "v5", "07/15" ] }