Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/215/?format=api
{ "id": 215, "url": "http://patchwork.ozlabs.org/api/patches/215/?format=api", "web_url": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/1220901653-12812-1-git-send-email-becky.bruce@freescale.com/", "project": { "id": 2, "url": "http://patchwork.ozlabs.org/api/projects/2/?format=api", "name": "Linux PPC development", "link_name": "linuxppc-dev", "list_id": "linuxppc-dev.lists.ozlabs.org", "list_email": "linuxppc-dev@lists.ozlabs.org", "web_url": "https://github.com/linuxppc/wiki/wiki", "scm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git", "webscm_url": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/", "list_archive_url_format": "https://lore.kernel.org/linuxppc-dev/{}/", "commit_url_format": "https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}" }, "msgid": "<1220901653-12812-1-git-send-email-becky.bruce@freescale.com>", "list_archive_url": "https://lore.kernel.org/linuxppc-dev/1220901653-12812-1-git-send-email-becky.bruce@freescale.com/", "date": "2008-09-08T19:20:53", "name": "Pass actual dev ptr to dma_* in ucc and cpm_uart serial", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": true, "hash": "81c67cca2fee15c0d8a09b874b85b98de1378e3c", "submitter": { "id": 12, "url": "http://patchwork.ozlabs.org/api/people/12/?format=api", "name": "Becky Bruce", "email": "becky.bruce@freescale.com" }, "delegate": { "id": 9, "url": "http://patchwork.ozlabs.org/api/users/9/?format=api", "username": "galak", "first_name": "Kumar", "last_name": "Gala", "email": "galak@kernel.crashing.org" }, "mbox": "http://patchwork.ozlabs.org/project/linuxppc-dev/patch/1220901653-12812-1-git-send-email-becky.bruce@freescale.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/215/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/215/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<linuxppc-dev-bounces+patchwork=ozlabs.org@ozlabs.org>", "X-Original-To": [ "patchwork@ozlabs.org", "linuxppc-dev@ozlabs.org" ], "Delivered-To": [ "patchwork@ozlabs.org", "linuxppc-dev@ozlabs.org" ], "Received": [ "from ozlabs.org (localhost [127.0.0.1])\n\tby ozlabs.org (Postfix) with ESMTP id 32842DE3E0\n\tfor <patchwork@ozlabs.org>; Tue, 9 Sep 2008 05:21:45 +1000 (EST)", "from de01egw02.freescale.net (de01egw02.freescale.net\n\t[192.88.165.103])\n\t(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\n\t(Client CN \"de01egw02.freescale.net\",\n\tIssuer \"Thawte Premium Server CA\" (verified OK))\n\tby ozlabs.org (Postfix) with ESMTPS id 21DD9DDF79\n\tfor <linuxppc-dev@ozlabs.org>; Tue, 9 Sep 2008 05:21:02 +1000 (EST)", "from de01smr01.freescale.net (de01smr01.freescale.net\n\t[10.208.0.31])\n\tby de01egw02.freescale.net (8.12.11/de01egw02) with ESMTP id\n\tm88JKs5v020639\n\tfor <linuxppc-dev@ozlabs.org>; Mon, 8 Sep 2008 12:20:55 -0700 (MST)", "from blarg.am.freescale.net (blarg.am.freescale.net [10.82.19.176])\n\tby de01smr01.freescale.net (8.13.1/8.13.0) with ESMTP id\n\tm88JKro0014171\n\tfor <linuxppc-dev@ozlabs.org>; Mon, 8 Sep 2008 14:20:54 -0500 (CDT)", "from blarg.am.freescale.net (localhost.localdomain [127.0.0.1])\n\tby blarg.am.freescale.net (8.14.2/8.14.2) with ESMTP id\n\tm88JKrmK012836; Mon, 8 Sep 2008 14:20:53 -0500", "(from bgill@localhost)\n\tby blarg.am.freescale.net (8.14.2/8.14.2/Submit) id m88JKrYG012834;\n\tMon, 8 Sep 2008 14:20:53 -0500" ], "From": "Becky Bruce <becky.bruce@freescale.com>", "To": "linuxppc-dev@ozlabs.org", "Subject": "[PATCH] Pass actual dev ptr to dma_* in ucc and cpm_uart serial", "Date": "Mon, 8 Sep 2008 14:20:53 -0500", "Message-Id": "<1220901653-12812-1-git-send-email-becky.bruce@freescale.com>", "X-Mailer": "git-send-email 1.5.5.1", "X-BeenThere": "linuxppc-dev@ozlabs.org", "X-Mailman-Version": "2.1.11", "Precedence": "list", "List-Id": "Linux on PowerPC Developers Mail List <linuxppc-dev.ozlabs.org>", "List-Unsubscribe": "<https://ozlabs.org/mailman/options/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@ozlabs.org?subject=unsubscribe>", "List-Archive": "<http://ozlabs.org/pipermail/linuxppc-dev>", "List-Post": "<mailto:linuxppc-dev@ozlabs.org>", "List-Help": "<mailto:linuxppc-dev-request@ozlabs.org?subject=help>", "List-Subscribe": "<https://ozlabs.org/mailman/listinfo/linuxppc-dev>,\n\t<mailto:linuxppc-dev-request@ozlabs.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Sender": "linuxppc-dev-bounces+patchwork=ozlabs.org@ozlabs.org", "Errors-To": "linuxppc-dev-bounces+patchwork=ozlabs.org@ozlabs.org" }, "content": "We're currently passing NULL, and really shouldn't be.\n\nSigned-off-by: Becky Bruce <becky.bruce@freescale.com>", "diff": "diff --git a/drivers/serial/cpm_uart/cpm_uart_cpm2.c b/drivers/serial/cpm_uart/cpm_uart_cpm2.c\nindex b8db4d3..141c0a3 100644\n--- a/drivers/serial/cpm_uart/cpm_uart_cpm2.c\n+++ b/drivers/serial/cpm_uart/cpm_uart_cpm2.c\n@@ -136,7 +136,7 @@ int cpm_uart_allocbuf(struct uart_cpm_port *pinfo, unsigned int is_con)\n \t\tdma_addr = virt_to_bus(mem_addr);\n \t}\n \telse\n-\t\tmem_addr = dma_alloc_coherent(NULL, memsz, &dma_addr,\n+\t\tmem_addr = dma_alloc_coherent(pinfo->port.dev, memsz, &dma_addr,\n \t\t\t\t\t GFP_KERNEL);\n \n \tif (mem_addr == NULL) {\n@@ -163,8 +163,8 @@ int cpm_uart_allocbuf(struct uart_cpm_port *pinfo, unsigned int is_con)\n \n void cpm_uart_freebuf(struct uart_cpm_port *pinfo)\n {\n-\tdma_free_coherent(NULL, L1_CACHE_ALIGN(pinfo->rx_nrfifos *\n-\t\t\t\t\t pinfo->rx_fifosize) +\n+\tdma_free_coherent(pinfo->port.dev, L1_CACHE_ALIGN(pinfo->rx_nrfifos *\n+\t\t\t\t\t\t\t pinfo->rx_fifosize) +\n \t\t\t L1_CACHE_ALIGN(pinfo->tx_nrfifos *\n \t\t\t\t\t pinfo->tx_fifosize), (void __force *)pinfo->mem_addr,\n \t\t\t pinfo->dma_addr);\ndiff --git a/drivers/serial/ucc_uart.c b/drivers/serial/ucc_uart.c\nindex 5c5d18d..539c933 100644\n--- a/drivers/serial/ucc_uart.c\n+++ b/drivers/serial/ucc_uart.c\n@@ -1009,7 +1009,7 @@ static int qe_uart_request_port(struct uart_port *port)\n \trx_size = L1_CACHE_ALIGN(qe_port->rx_nrfifos * qe_port->rx_fifosize);\n \ttx_size = L1_CACHE_ALIGN(qe_port->tx_nrfifos * qe_port->tx_fifosize);\n \n-\tbd_virt = dma_alloc_coherent(NULL, rx_size + tx_size, &bd_dma_addr,\n+\tbd_virt = dma_alloc_coherent(port->dev, rx_size + tx_size, &bd_dma_addr,\n \t\tGFP_KERNEL);\n \tif (!bd_virt) {\n \t\tdev_err(port->dev, \"could not allocate buffer descriptors\\n\");\n@@ -1051,7 +1051,7 @@ static void qe_uart_release_port(struct uart_port *port)\n \t\tcontainer_of(port, struct uart_qe_port, port);\n \tstruct ucc_slow_private *uccs = qe_port->us_private;\n \n-\tdma_free_coherent(NULL, qe_port->bd_size, qe_port->bd_virt,\n+\tdma_free_coherent(port->dev, qe_port->bd_size, qe_port->bd_virt,\n \t\t\t qe_port->bd_dma_addr);\n \n \tucc_slow_free(uccs);\n", "prefixes": [] }