Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2148358/?format=api
{ "id": 2148358, "url": "http://patchwork.ozlabs.org/api/patches/2148358/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20251010173633.1170642-1-trini@konsulko.com/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20251010173633.1170642-1-trini@konsulko.com>", "list_archive_url": null, "date": "2025-10-10T17:36:33", "name": "net: phy: Make driver overloading get_phy_id depend on !COMPILE_TEST", "commit_ref": "85c2c2c517ac8a6bba406bfd84fa11b26bbcb9aa", "pull_url": null, "state": "accepted", "archived": false, "hash": "a515afaed45ba10b390d99d3e12fd6812726d3d6", "submitter": { "id": 65875, "url": "http://patchwork.ozlabs.org/api/people/65875/?format=api", "name": "Tom Rini", "email": "trini@konsulko.com" }, "delegate": { "id": 157425, "url": "http://patchwork.ozlabs.org/api/users/157425/?format=api", "username": "jforissier", "first_name": "Jerome", "last_name": "Forissier", "email": "jerome.forissier@linaro.org" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20251010173633.1170642-1-trini@konsulko.com/mbox/", "series": [ { "id": 477141, "url": "http://patchwork.ozlabs.org/api/series/477141/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=477141", "date": "2025-10-10T17:36:33", "name": "net: phy: Make driver overloading get_phy_id depend on !COMPILE_TEST", "version": 1, "mbox": "http://patchwork.ozlabs.org/series/477141/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2148358/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2148358/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=konsulko.com header.i=@konsulko.com header.a=rsa-sha256\n header.s=google header.b=TnVtX+Yn;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=konsulko.com", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=konsulko.com header.i=@konsulko.com\n header.b=\"TnVtX+Yn\";\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=konsulko.com", "phobos.denx.de;\n spf=pass smtp.mailfrom=trini@konsulko.com" ], "Received": [ "from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4cjv7K0QcBz1yGy\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 11 Oct 2025 04:36:45 +1100 (AEDT)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id AC3C583FB0;\n\tFri, 10 Oct 2025 19:36:40 +0200 (CEST)", "by phobos.denx.de (Postfix, from userid 109)\n id 4462483FF0; Fri, 10 Oct 2025 19:36:39 +0200 (CEST)", "from mail-oa1-x35.google.com (mail-oa1-x35.google.com\n [IPv6:2001:4860:4864:20::35])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 300F183FAA\n for <u-boot@lists.denx.de>; Fri, 10 Oct 2025 19:36:37 +0200 (CEST)", "by mail-oa1-x35.google.com with SMTP id\n 586e51a60fabf-36ce5686d75so1634669fac.3\n for <u-boot@lists.denx.de>; Fri, 10 Oct 2025 10:36:37 -0700 (PDT)", "from bill-the-cat.. (fixed-189-203-106-235.totalplay.net.\n [189.203.106.235]) by smtp.gmail.com with ESMTPSA id\n 586e51a60fabf-3c8c8b6984bsm1045885fac.8.2025.10.10.10.36.34\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 10 Oct 2025 10:36:35 -0700 (PDT)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,\n SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=konsulko.com; s=google; t=1760117796; x=1760722596; darn=lists.denx.de;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=gGfJzVFAJl6H2cXzoORLx+qj3glMcBJcsxJbDfr1kp0=;\n b=TnVtX+YnB5nQB/q0C/XB2C0ZEXIujGj2Z/gxjW0t1UrFVlDSjiozwocc8Z5cgkqixu\n Tt2yL2NkyOcfnXqo+t8AolJBpUa/eRpDdnL0/HppEGRDFBp7BG93eUHVQ4UmYy1jpFHQ\n 5D9Gw4D80bD+/1JpnscavTa6SOvw4sduSH9sM=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1760117796; x=1760722596;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=gGfJzVFAJl6H2cXzoORLx+qj3glMcBJcsxJbDfr1kp0=;\n b=sihVm6nylw7PHLF3xXdRfTpeFA4Iwd/oodp2HIOiSre02lxdY6Hlj5zUI8NEG5yWB6\n I38JUmOIBkRVwmucGOv13dlMSGrQmO06iRpPeEtvgHyI0nFE/fja4YXtfVWy0Z9GvDmu\n DB08TFjNbIu+xMCGxshREU3QVUUDorEmef6dOQthr6+7HPg6OsQpzkga/J1ZvDbQXKff\n lhJhd9ui82oHLMRk29k1TQ1GDkIRtKjhuBewFe/bEf6ttC2T8OnS8X0gok7gDyt0MDKx\n angzrhZwXrW/x0HtatmQbGg9qy5PxMtcPe53pBBwzjqyPBX4zfwD2neOaiWg05+Ig/e8\n U8jw==", "X-Gm-Message-State": "AOJu0YyBrb/xZSzvr/VP6mkFkPmJ0uwfVuD4/SX7LFQy5psG2lPf17Xm\n Q7QXDAf9bXvwVEru+k0Li9sEVUDOCuuKl+H0gdZr0Nk0jrpg0tpNCGKVSjRypJV24Z0QHdWXfqc\n G7t/TQns=", "X-Gm-Gg": "ASbGncsL2GfehdIS/Yk5eKPG+EFIm4a40e2L7S1zbwjgBylS7qeDP112ksEGS2Z1dP3\n /WV4pR8IikYvrY7ZAH6ou4joiyzaG/PDQ/4YJQNrCGfXuWpxH1xMwhlPkV49bgP31Rjdwyy+OXY\n m+m0sRNGhSG789N8xzmluyntTQbLkzMipZck8g6m+bff3hu/hB8Jf2D88ISW8rUM5huodlCbmKr\n JS7V1y90Qf9HNWgwv7eHn76+W+O6d9OXQSx8HAx8Mw1oCallYWKZXhWFMCyO9Z2+j+Faont0slu\n ho8pL1FvFZG0SLxXzlS2KSO5BCfFnAsmjM0ewkcTDbeTrV1adx6RuTmgqvIhLHj6PEgUudrTo5C\n DScrmYFc2W6NOoqEmD2n15Oy9Qw6RlVd9Ij3078abkPAlVPXjygsBZGRBQYoGcy8XfrFEMihlIt\n SmCjD+pAY=", "X-Google-Smtp-Source": "\n AGHT+IGw7Ckq9XIGg1y73TuPmJSWK0jWtyfnSvfaJWBLuZqGkLL2rWgkdZyoTdQ6h8SDta0fNlrFHg==", "X-Received": "by 2002:a05:6870:46a9:b0:332:2463:8c88 with SMTP id\n 586e51a60fabf-3c0f9e7240amr6328378fac.37.1760117795704;\n Fri, 10 Oct 2025 10:36:35 -0700 (PDT)", "From": "Tom Rini <trini@konsulko.com>", "To": "u-boot@lists.denx.de", "Cc": "Jerome Forissier <jerome.forissier@linaro.org>", "Subject": "[PATCH] net: phy: Make driver overloading get_phy_id depend on\n !COMPILE_TEST", "Date": "Fri, 10 Oct 2025 11:36:33 -0600", "Message-ID": "<20251010173633.1170642-1-trini@konsulko.com>", "X-Mailer": "git-send-email 2.43.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.8 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "With commit 597fe041a85f (\"net/phy: enable get_phy_id redefinable\") we\nmade get_phy_id a public but weak function, so that PHY drivers that had\nrequired non-standard ways of getting the PHY ID could be supported.\nHowever, overloading a weak function multiple times is (rightly) a link\nerror. At this point, we have two PHYs which make use of this feature,\nso make both of them only available when COMPILE_TEST is unset, as part\nof being able to support \"allyesconfig\" in the future.\n\nSigned-off-by: Tom Rini <trini@konsulko.com>\n---\nI thought about this a bit, and looking around very quickly in the linux\nkernel, I don't see how this is abstracted there. Given some of the\ncomments in the two phy drivers that use this, I'm also not sure we\ncould use some other abstraction here as this function is called during\nprobe to figure out what we have.\n\nCc: Jerome Forissier <jerome.forissier@linaro.org>\n---\n drivers/net/phy/Kconfig | 2 ++\n 1 file changed, 2 insertions(+)", "diff": "diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig\nindex 185c6a3156e2..018be98705a2 100644\n--- a/drivers/net/phy/Kconfig\n+++ b/drivers/net/phy/Kconfig\n@@ -56,6 +56,7 @@ endif # B53_SWITCH\n \n config MV88E61XX_SWITCH\n \tbool \"Marvell MV88E61xx Ethernet switch PHY support.\"\n+\tdepends on !COMPILE_TEST\n \n if MV88E61XX_SWITCH\n \n@@ -119,6 +120,7 @@ config PHY_BROADCOM\n \n config PHY_CORTINA\n \tbool \"Cortina Ethernet PHYs support\"\n+\tdepends on !COMPILE_TEST\n \n config SYS_CORTINA_NO_FW_UPLOAD\n \tbool \"Cortina firmware loading support\"\n", "prefixes": [] }