Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2146090/?format=api
{ "id": 2146090, "url": "http://patchwork.ozlabs.org/api/patches/2146090/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20251006101057.4172248-8-anshuld@ti.com/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20251006101057.4172248-8-anshuld@ti.com>", "list_archive_url": null, "date": "2025-10-06T10:10:55", "name": "[-next,v3,7/7] spl: falcon: disable fallback to U-Boot on failure", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "840cdb4af523e01240c857526b1f75c0b5526e6e", "submitter": { "id": 90324, "url": "http://patchwork.ozlabs.org/api/people/90324/?format=api", "name": "Anshul Dalal", "email": "anshuld@ti.com" }, "delegate": { "id": 3651, "url": "http://patchwork.ozlabs.org/api/users/3651/?format=api", "username": "trini", "first_name": "Tom", "last_name": "Rini", "email": "trini@ti.com" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20251006101057.4172248-8-anshuld@ti.com/mbox/", "series": [ { "id": 476383, "url": "http://patchwork.ozlabs.org/api/series/476383/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=476383", "date": "2025-10-06T10:10:48", "name": "Add support for secure falcon mode: disable fallback", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/476383/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2146090/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2146090/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=ti.com header.i=@ti.com header.a=rsa-sha256\n header.s=ti-com-17Q1 header.b=hlnMB2Eq;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)", "phobos.denx.de;\n dmarc=pass (p=quarantine dis=none) header.from=ti.com", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=ti.com header.i=@ti.com header.b=\"hlnMB2Eq\";\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=pass (p=quarantine dis=none) header.from=ti.com", "phobos.denx.de; spf=pass smtp.mailfrom=anshuld@ti.com" ], "Received": [ "from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (secp384r1))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4cgFSG1k3Vz1yGb\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 6 Oct 2025 21:12:14 +1100 (AEDT)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 6DA1A834D4;\n\tMon, 6 Oct 2025 12:11:20 +0200 (CEST)", "by phobos.denx.de (Postfix, from userid 109)\n id CBD8E83775; Mon, 6 Oct 2025 12:11:19 +0200 (CEST)", "from fllvem-ot03.ext.ti.com (fllvem-ot03.ext.ti.com [198.47.19.245])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n bits)) (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id A12DA834D4\n for <u-boot@lists.denx.de>; Mon, 6 Oct 2025 12:11:17 +0200 (CEST)", "from fllvem-sh03.itg.ti.com ([10.64.41.86])\n by fllvem-ot03.ext.ti.com (8.15.2/8.15.2) with ESMTP id 596ABEEB3526646;\n Mon, 6 Oct 2025 05:11:14 -0500", "from DFLE203.ent.ti.com (dfle203.ent.ti.com [10.64.6.61])\n by fllvem-sh03.itg.ti.com (8.18.1/8.18.1) with ESMTPS id 596ABEQF3234429\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL);\n Mon, 6 Oct 2025 05:11:14 -0500", "from DFLE206.ent.ti.com (10.64.6.64) by DFLE203.ent.ti.com\n (10.64.6.61) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Mon, 6 Oct\n 2025 05:11:13 -0500", "from lelvem-mr06.itg.ti.com (10.180.75.8) by DFLE206.ent.ti.com\n (10.64.6.64) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20 via Frontend\n Transport; Mon, 6 Oct 2025 05:11:13 -0500", "from localhost (dhcp-172-24-233-105.dhcp.ti.com [172.24.233.105])\n by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 596ABCsr3268803;\n Mon, 6 Oct 2025 05:11:13 -0500" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-2.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,\n RCVD_IN_VALIDITY_RPBL_BLOCKED,SPF_HELO_PASS,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com;\n s=ti-com-17Q1; t=1759745474;\n bh=6wAK9InP+9nlxANpBF6pZKwVWl63ol1gX6mGuv63iPw=;\n h=From:To:CC:Subject:Date:In-Reply-To:References;\n b=hlnMB2EqMVAMD1l/EkXxXAnE9x8m557nxnc96xZEfuscgKKyc4hIRtLwrsWVMSj5e\n AEy6ozVjCPSQrD4xjBFyJfjJfCIkDXxwKoKUQ/ik1XwaqfCW+glAw9BH9PdIHyo2tJ\n kq6BPYrkWwTDIYI/x5zQYsHYUUcHrGIK5FN8Nc5w=", "From": "Anshul Dalal <anshuld@ti.com>", "To": "<u-boot@lists.denx.de>", "CC": "Anshul Dalal <anshuld@ti.com>, <vigneshr@ti.com>, <trini@konsulko.com>,\n <afd@ti.com>, <m-chawdhry@ti.com>, <n-francis@ti.com>, <b-liu@ti.com>,\n <nm@ti.com>, <bb@ti.com>, <kever.yang@rock-chips.com>,\n <hl@rock-chips.com>, <tim@feathertop.org>,\n <marek.vasut+renesas@mailbox.org>", "Subject": "[PATCH -next v3 7/7] spl: falcon: disable fallback to U-Boot on\n failure", "Date": "Mon, 6 Oct 2025 15:40:55 +0530", "Message-ID": "<20251006101057.4172248-8-anshuld@ti.com>", "X-Mailer": "git-send-email 2.51.0", "In-Reply-To": "<20251006101057.4172248-1-anshuld@ti.com>", "References": "<20251006101057.4172248-1-anshuld@ti.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-C2ProcessedOrg": "333ef613-75bf-4e12-a4b1-8e3623f5dcea", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.8 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "Instead of falling back to the standard U-Boot boot flow, we should just\nhalt boot if the expected boot flow in falcon mode fails.\n\nThis prevents a malicious actor from accessing U-Boot proper if they can\ncause a boot failure on falcon mode.\n\nSigned-off-by: Anshul Dalal <anshuld@ti.com>\n---\n common/spl/spl_mmc.c | 4 ++++\n common/spl/spl_nand.c | 6 ++++--\n common/spl/spl_nor.c | 6 ++++--\n common/spl/spl_spi.c | 6 ++++--\n common/spl/spl_ubi.c | 2 ++\n 5 files changed, 18 insertions(+), 6 deletions(-)", "diff": "diff --git a/common/spl/spl_mmc.c b/common/spl/spl_mmc.c\nindex c5585d8e0d2..d0dad6ea8fd 100644\n--- a/common/spl/spl_mmc.c\n+++ b/common/spl/spl_mmc.c\n@@ -272,6 +272,8 @@ static int spl_mmc_do_fs_boot(struct spl_image_info *spl_image,\n \t\t\treturn 0;\n \t\tprintf(\"%s, Failed to load falcon payload: %d\\n\", __func__,\n \t\t ret);\n+\t\tif (CONFIG_IS_ENABLED(OS_BOOT_SECURE))\n+\t\t\treturn ret;\n \t\tprintf(\"Fallback to U-Boot\\n\");\n \t}\n \n@@ -412,6 +414,8 @@ int spl_mmc_load(struct spl_image_info *spl_image,\n \t\t\tret = mmc_load_image_raw_os(spl_image, bootdev, mmc);\n \t\t\tif (!ret)\n \t\t\t\treturn 0;\n+\t\t\tif (CONFIG_IS_ENABLED(OS_BOOT_SECURE))\n+\t\t\t\treturn ret;\n \t\t}\n \n \t\traw_sect = spl_mmc_get_uboot_raw_sector(mmc, raw_sect);\ndiff --git a/common/spl/spl_nand.c b/common/spl/spl_nand.c\nindex f37baefb372..93ef2d1c02c 100644\n--- a/common/spl/spl_nand.c\n+++ b/common/spl/spl_nand.c\n@@ -138,8 +138,10 @@ static int spl_nand_load_image(struct spl_image_info *spl_image,\n \t\terr = spl_nand_load_image_os(spl_image, bootdev);\n \t\tif (!err)\n \t\t\treturn 0;\n-\t\tprintf(\"%s: Failed in falcon boot: %d, fallback to U-Boot\",\n-\t\t __func__, err);\n+\t\tprintf(\"%s: Failed in falcon boot: %d\", __func__, err);\n+\t\tif (CONFIG_IS_ENABLED(OS_BOOT_SECURE))\n+\t\t\treturn err;\n+\t\tprintf(\"Fallback to U-Boot\\n\");\n \t}\n #endif\n \ndiff --git a/common/spl/spl_nor.c b/common/spl/spl_nor.c\nindex 9c037bd62eb..6f9ff91bef7 100644\n--- a/common/spl/spl_nor.c\n+++ b/common/spl/spl_nor.c\n@@ -95,8 +95,10 @@ static int spl_nor_load_image(struct spl_image_info *spl_image,\n \t\tif (!err)\n \t\t\treturn 0;\n \n-\t\tprintf(\"%s: Failed in falcon boot: %d, fallback to U-Boot\",\n-\t\t __func__, err);\n+\t\tprintf(\"%s: Failed in falcon boot: %d\", __func__, err);\n+\t\tif (CONFIG_IS_ENABLED(OS_BOOT_SECURE))\n+\t\t\treturn err;\n+\t\tprintf(\"Fallback to U-Boot\\n\");\n \t}\n #endif\n \ndiff --git a/common/spl/spl_spi.c b/common/spl/spl_spi.c\nindex 2a6098a4dc3..cbc864809fe 100644\n--- a/common/spl/spl_spi.c\n+++ b/common/spl/spl_spi.c\n@@ -105,8 +105,10 @@ static int spl_spi_load_image(struct spl_image_info *spl_image,\n \t\tif (!err)\n \t\t\treturn 0;\n \n-\t\tprintf(\"%s: Failed in falcon boot: %d, fallback to U-Boot\",\n-\t\t __func__, err);\n+\t\tprintf(\"%s: Failed in falcon boot: %d\", __func__, err);\n+\t\tif (CONFIG_IS_ENABLED(OS_BOOT_SECURE))\n+\t\t\treturn err;\n+\t\tprintf(\"Fallback to U-Boot\\n\");\n \t}\n #endif\n \ndiff --git a/common/spl/spl_ubi.c b/common/spl/spl_ubi.c\nindex 09b9bbc5c47..3c6f80de7d9 100644\n--- a/common/spl/spl_ubi.c\n+++ b/common/spl/spl_ubi.c\n@@ -77,6 +77,8 @@ int spl_ubi_load_image(struct spl_image_info *spl_image,\n \t\t\treturn 0;\n \n \t\tprintf(\"%s: Failed in falcon boot: %d\", __func__, ret);\n+\t\tif (CONFIG_IS_ENABLED(OS_BOOT_SECURE))\n+\t\t\treturn ret;\n \t\tprintf(\"Fallback to U-Boot\\n\");\n \t}\n #endif\n", "prefixes": [ "-next", "v3", "7/7" ] }