Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/2146087/?format=api
{ "id": 2146087, "url": "http://patchwork.ozlabs.org/api/patches/2146087/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/patch/20251006101057.4172248-5-anshuld@ti.com/", "project": { "id": 18, "url": "http://patchwork.ozlabs.org/api/projects/18/?format=api", "name": "U-Boot", "link_name": "uboot", "list_id": "u-boot.lists.denx.de", "list_email": "u-boot@lists.denx.de", "web_url": null, "scm_url": null, "webscm_url": null, "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20251006101057.4172248-5-anshuld@ti.com>", "list_archive_url": null, "date": "2025-10-06T10:10:52", "name": "[-next,v3,4/7] spl: spi: refactor spl_spi_load_image for falcon mode", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "8d4fab740b0fd41efe8d287efaf7c5e1fbe822f4", "submitter": { "id": 90324, "url": "http://patchwork.ozlabs.org/api/people/90324/?format=api", "name": "Anshul Dalal", "email": "anshuld@ti.com" }, "delegate": { "id": 3651, "url": "http://patchwork.ozlabs.org/api/users/3651/?format=api", "username": "trini", "first_name": "Tom", "last_name": "Rini", "email": "trini@ti.com" }, "mbox": "http://patchwork.ozlabs.org/project/uboot/patch/20251006101057.4172248-5-anshuld@ti.com/mbox/", "series": [ { "id": 476383, "url": "http://patchwork.ozlabs.org/api/series/476383/?format=api", "web_url": "http://patchwork.ozlabs.org/project/uboot/list/?series=476383", "date": "2025-10-06T10:10:48", "name": "Add support for secure falcon mode: disable fallback", "version": 3, "mbox": "http://patchwork.ozlabs.org/series/476383/mbox/" } ], "comments": "http://patchwork.ozlabs.org/api/patches/2146087/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/2146087/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<u-boot-bounces@lists.denx.de>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@legolas.ozlabs.org", "Authentication-Results": [ "legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=ti.com header.i=@ti.com header.a=rsa-sha256\n header.s=ti-com-17Q1 header.b=OH6g6qLD;\n\tdkim-atps=neutral", "legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)", "phobos.denx.de;\n dmarc=pass (p=quarantine dis=none) header.from=ti.com", "phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de", "phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=ti.com header.i=@ti.com header.b=\"OH6g6qLD\";\n\tdkim-atps=neutral", "phobos.denx.de;\n dmarc=pass (p=quarantine dis=none) header.from=ti.com", "phobos.denx.de; spf=pass smtp.mailfrom=anshuld@ti.com" ], "Received": [ "from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature ECDSA (secp384r1))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4cgFRj6Nswz1yGb\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 6 Oct 2025 21:11:45 +1100 (AEDT)", "from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id EA736836EE;\n\tMon, 6 Oct 2025 12:11:15 +0200 (CEST)", "by phobos.denx.de (Postfix, from userid 109)\n id 68D40836C8; Mon, 6 Oct 2025 12:11:14 +0200 (CEST)", "from fllvem-ot04.ext.ti.com (fllvem-ot04.ext.ti.com [198.47.19.246])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n bits)) (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 54E23834D4\n for <u-boot@lists.denx.de>; Mon, 6 Oct 2025 12:11:12 +0200 (CEST)", "from lelvem-sh01.itg.ti.com ([10.180.77.71])\n by fllvem-ot04.ext.ti.com (8.15.2/8.15.2) with ESMTP id 596AB8b23977159;\n Mon, 6 Oct 2025 05:11:08 -0500", "from DLEE103.ent.ti.com (dlee103.ent.ti.com [157.170.170.33])\n by lelvem-sh01.itg.ti.com (8.18.1/8.18.1) with ESMTPS id 596AB8db2158512\n (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA256 bits=128 verify=FAIL);\n Mon, 6 Oct 2025 05:11:08 -0500", "from DLEE211.ent.ti.com (157.170.170.113) by DLEE103.ent.ti.com\n (157.170.170.33) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.55; Mon, 6\n Oct 2025 05:11:08 -0500", "from lelvem-mr06.itg.ti.com (10.180.75.8) by DLEE211.ent.ti.com\n (157.170.170.113) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20 via Frontend\n Transport; Mon, 6 Oct 2025 05:11:08 -0500", "from localhost (dhcp-172-24-233-105.dhcp.ti.com [172.24.233.105])\n by lelvem-mr06.itg.ti.com (8.18.1/8.18.1) with ESMTP id 596AB6Ot3268727;\n Mon, 6 Oct 2025 05:11:07 -0500" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de", "X-Spam-Level": "", "X-Spam-Status": "No, score=-2.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,\n RCVD_IN_VALIDITY_RPBL_BLOCKED,SPF_HELO_PASS,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com;\n s=ti-com-17Q1; t=1759745468;\n bh=XJAjOy96kgOeKxc8MDpMeeiJy4GnUQ1hUtzb1w6XBIQ=;\n h=From:To:CC:Subject:Date:In-Reply-To:References;\n b=OH6g6qLD3L9XPNtrE2zZg/cckKT3AKc90s51zD+rCXinu3pGFYGYgSbFbfHvepAKM\n lCCJ0/ORFm1AIV8q7PbCBK9I65h5nfhLvYHdbW0jTd08gEmL1c1gh06/IsIaHIQZgo\n cVQP0UIZpTTYetpR1qdMztJGreLPVebDYa8kCM2k=", "From": "Anshul Dalal <anshuld@ti.com>", "To": "<u-boot@lists.denx.de>", "CC": "Anshul Dalal <anshuld@ti.com>, <vigneshr@ti.com>, <trini@konsulko.com>,\n <afd@ti.com>, <m-chawdhry@ti.com>, <n-francis@ti.com>, <b-liu@ti.com>,\n <nm@ti.com>, <bb@ti.com>, <kever.yang@rock-chips.com>,\n <hl@rock-chips.com>, <tim@feathertop.org>,\n <marek.vasut+renesas@mailbox.org>", "Subject": "[PATCH -next v3 4/7] spl: spi: refactor spl_spi_load_image for falcon\n mode", "Date": "Mon, 6 Oct 2025 15:40:52 +0530", "Message-ID": "<20251006101057.4172248-5-anshuld@ti.com>", "X-Mailer": "git-send-email 2.51.0", "In-Reply-To": "<20251006101057.4172248-1-anshuld@ti.com>", "References": "<20251006101057.4172248-1-anshuld@ti.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-C2ProcessedOrg": "333ef613-75bf-4e12-a4b1-8e3623f5dcea", "X-BeenThere": "u-boot@lists.denx.de", "X-Mailman-Version": "2.1.39", "Precedence": "list", "List-Id": "U-Boot discussion <u-boot.lists.denx.de>", "List-Unsubscribe": "<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>", "List-Archive": "<https://lists.denx.de/pipermail/u-boot/>", "List-Post": "<mailto:u-boot@lists.denx.de>", "List-Help": "<mailto:u-boot-request@lists.denx.de?subject=help>", "List-Subscribe": "<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>", "Errors-To": "u-boot-bounces@lists.denx.de", "Sender": "\"U-Boot\" <u-boot-bounces@lists.denx.de>", "X-Virus-Scanned": "clamav-milter 0.103.8 at phobos.denx.de", "X-Virus-Status": "Clean" }, "content": "This patch moves the falcon mode handling logic out of\nspl_spi_load_image to spl_spi_load_image_os, this allows for cleaner\nhandling for fallback to U-Boot in case falcon mode fails.\n\nSigned-off-by: Anshul Dalal <anshuld@ti.com>\n---\n common/spl/spl_spi.c | 31 ++++++++++++++++++++++++-------\n 1 file changed, 24 insertions(+), 7 deletions(-)", "diff": "diff --git a/common/spl/spl_spi.c b/common/spl/spl_spi.c\nindex c2b188371c2..2a6098a4dc3 100644\n--- a/common/spl/spl_spi.c\n+++ b/common/spl/spl_spi.c\n@@ -49,6 +49,25 @@ u32 __weak spl_spi_boot_cs(void)\n \treturn CONFIG_SF_DEFAULT_CS;\n }\n \n+#if CONFIG_IS_ENABLED(OS_BOOT)\n+static int spl_spi_load_image_os(struct spl_image_info *spl_image,\n+\t\t\t\t struct spl_boot_device *bootdev,\n+\t\t\t\t struct spi_flash *flash,\n+\t\t\t\t struct spl_load_info *load)\n+{\n+\tint err = spl_load(spl_image, bootdev, load, 0,\n+\t\t\t CONFIG_SYS_SPI_KERNEL_OFFS);\n+\n+\tif (err)\n+\t\treturn err;\n+\n+\t/* Read device tree. */\n+\treturn spi_flash_read(flash, CONFIG_SYS_SPI_ARGS_OFFS,\n+\t\t\t CONFIG_SYS_SPI_ARGS_SIZE,\n+\t\t\t (void *)CONFIG_SPL_PAYLOAD_ARGS_ADDR);\n+}\n+#endif\n+\n /*\n * The main entry for SPI booting. It's necessary that SDRAM is already\n * configured and available since this code loads the main U-Boot image\n@@ -81,15 +100,13 @@ static int spl_spi_load_image(struct spl_image_info *spl_image,\n \n #if CONFIG_IS_ENABLED(OS_BOOT)\n \tif (!spl_start_uboot()) {\n-\t\tint err = spl_load(spl_image, bootdev, &load, 0,\n-\t\t\t\t CONFIG_SYS_SPI_KERNEL_OFFS);\n+\t\terr = spl_spi_load_image_os(spl_image, bootdev, flash, &load);\n \n \t\tif (!err)\n-\t\t\t/* Read device tree. */\n-\t\t\treturn spi_flash_read(\n-\t\t\t\tflash, CONFIG_SYS_SPI_ARGS_OFFS,\n-\t\t\t\tCONFIG_SYS_SPI_ARGS_SIZE,\n-\t\t\t\t(void *)CONFIG_SPL_PAYLOAD_ARGS_ADDR);\n+\t\t\treturn 0;\n+\n+\t\tprintf(\"%s: Failed in falcon boot: %d, fallback to U-Boot\",\n+\t\t __func__, err);\n \t}\n #endif\n \n", "prefixes": [ "-next", "v3", "4/7" ] }